├── gradle.properties ├── settings.gradle.kts ├── gradle └── wrapper │ ├── gradle-wrapper.jar │ └── gradle-wrapper.properties ├── .gitignore ├── .idea └── codeStyles │ ├── codeStyleConfig.xml │ └── Project.xml ├── README.md ├── LICENSE ├── gradlew.bat ├── gradlew └── src └── main └── kotlin └── NonStop.kt /gradle.properties: -------------------------------------------------------------------------------- 1 | kotlin.code.style=official -------------------------------------------------------------------------------- /settings.gradle.kts: -------------------------------------------------------------------------------- 1 | rootProject.name = "svg-non-stop" 2 | 3 | -------------------------------------------------------------------------------- /gradle/wrapper/gradle-wrapper.jar: -------------------------------------------------------------------------------- https://raw.githubusercontent.com/14v/svg-non-stop/HEAD/gradle/wrapper/gradle-wrapper.jar -------------------------------------------------------------------------------- /.gitignore: -------------------------------------------------------------------------------- 1 | *.iml 2 | .gradle 3 | /local.properties 4 | /.idea/* 5 | !/.idea/codeStyles/ 6 | !/.idea/codeStyles/* 7 | .DS_Store 8 | /build 9 | /captures 10 | .externalNativeBuild 11 | -------------------------------------------------------------------------------- /.idea/codeStyles/codeStyleConfig.xml: -------------------------------------------------------------------------------- 1 | 2 | 3 | 5 | -------------------------------------------------------------------------------- /gradle/wrapper/gradle-wrapper.properties: -------------------------------------------------------------------------------- 1 | distributionBase=GRADLE_USER_HOME 2 | distributionPath=wrapper/dists 3 | distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-bin.zip 4 | zipStoreBase=GRADLE_USER_HOME 5 | zipStorePath=wrapper/dists 6 | -------------------------------------------------------------------------------- /.idea/codeStyles/Project.xml: -------------------------------------------------------------------------------- 1 | 2 | 3 | 4 | 6 | 7 | 9 | 10 | -------------------------------------------------------------------------------- /README.md: -------------------------------------------------------------------------------- 1 | # SVG non-stop 2 | ## What is this 3 | 4 | Java utility fixes `Gradient has no stop info` error when importing SVG files as vector assets in Android studio. This error results in corrupt drawable with empty gradient fills. 5 | 6 | ## How to use 7 | 8 | 1. Download binary from [releases/latest](https://github.com/14v/svg-non-stop/releases/latest) 9 | 10 | 2. Pass target SVG file name as parameter: 11 | 12 | ``` 13 | ./bin/svg-non-stop my_vector_drawable.svg 14 | ``` 15 | 16 | 3. Result will be saved in `my_vector_drawable_nonstop.svg`. Use this file to import in IDE. 17 | 18 | Optional parameters: 19 | * `-f` to force overwrite target `_nonstop.svg` file, 20 | * `-v` to have verbose output. 21 | 22 | ## Technical notes 23 | Utility copies stops definitions into target gradients in SVG file. Then IDE can process file correctly. Utility is _not_ for use in android code. 24 | 25 | For build use gradle `assemble` task and you will get `build/distributions/svg-non-stop-x.y.z.zip` archive. 26 | -------------------------------------------------------------------------------- /LICENSE: -------------------------------------------------------------------------------- 1 | MIT License 2 | 3 | Copyright (c) 2022 github.com/14v 4 | 5 | Permission is hereby granted, free of charge, to any person obtaining a copy 6 | of this software and associated documentation files (the "Software"), to deal 7 | in the Software without restriction, including without limitation the rights 8 | to use, copy, modify, merge, publish, distribute, sublicense, and/or sell 9 | copies of the Software, and to permit persons to whom the Software is 10 | furnished to do so, subject to the following conditions: 11 | 12 | The above copyright notice and this permission notice shall be included in all 13 | copies or substantial portions of the Software. 14 | 15 | THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 16 | IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 17 | FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE 18 | AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER 19 | LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, 20 | OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE 21 | SOFTWARE. 22 | -------------------------------------------------------------------------------- /gradlew.bat: -------------------------------------------------------------------------------- 1 | @if "%DEBUG%" == "" @echo off 2 | @rem ########################################################################## 3 | @rem 4 | @rem Gradle startup script for Windows 5 | @rem 6 | @rem ########################################################################## 7 | 8 | @rem Set local scope for the variables with windows NT shell 9 | if "%OS%"=="Windows_NT" setlocal 10 | 11 | set DIRNAME=%~dp0 12 | if "%DIRNAME%" == "" set DIRNAME=. 13 | set APP_BASE_NAME=%~n0 14 | set APP_HOME=%DIRNAME% 15 | 16 | @rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. 17 | set DEFAULT_JVM_OPTS="-Xmx64m" 18 | 19 | @rem Find java.exe 20 | if defined JAVA_HOME goto findJavaFromJavaHome 21 | 22 | set JAVA_EXE=java.exe 23 | %JAVA_EXE% -version >NUL 2>&1 24 | if "%ERRORLEVEL%" == "0" goto init 25 | 26 | echo. 27 | echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 28 | echo. 29 | echo Please set the JAVA_HOME variable in your environment to match the 30 | echo location of your Java installation. 31 | 32 | goto fail 33 | 34 | :findJavaFromJavaHome 35 | set JAVA_HOME=%JAVA_HOME:"=% 36 | set JAVA_EXE=%JAVA_HOME%/bin/java.exe 37 | 38 | if exist "%JAVA_EXE%" goto init 39 | 40 | echo. 41 | echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 42 | echo. 43 | echo Please set the JAVA_HOME variable in your environment to match the 44 | echo location of your Java installation. 45 | 46 | goto fail 47 | 48 | :init 49 | @rem Get command-line arguments, handling Windows variants 50 | 51 | if not "%OS%" == "Windows_NT" goto win9xME_args 52 | 53 | :win9xME_args 54 | @rem Slurp the command line arguments. 55 | set CMD_LINE_ARGS= 56 | set _SKIP=2 57 | 58 | :win9xME_args_slurp 59 | if "x%~1" == "x" goto execute 60 | 61 | set CMD_LINE_ARGS=%* 62 | 63 | :execute 64 | @rem Setup the command line 65 | 66 | set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar 67 | 68 | @rem Execute Gradle 69 | "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS% 70 | 71 | :end 72 | @rem End local scope for the variables with windows NT shell 73 | if "%ERRORLEVEL%"=="0" goto mainEnd 74 | 75 | :fail 76 | rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of 77 | rem the _cmd.exe /c_ return code! 78 | if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1 79 | exit /b 1 80 | 81 | :mainEnd 82 | if "%OS%"=="Windows_NT" endlocal 83 | 84 | :omega 85 | -------------------------------------------------------------------------------- /gradlew: -------------------------------------------------------------------------------- 1 | #!/usr/bin/env sh 2 | 3 | ############################################################################## 4 | ## 5 | ## Gradle start up script for UN*X 6 | ## 7 | ############################################################################## 8 | 9 | # Attempt to set APP_HOME 10 | # Resolve links: $0 may be a link 11 | PRG="$0" 12 | # Need this for relative symlinks. 13 | while [ -h "$PRG" ] ; do 14 | ls=`ls -ld "$PRG"` 15 | link=`expr "$ls" : '.*-> \(.*\)$'` 16 | if expr "$link" : '/.*' > /dev/null; then 17 | PRG="$link" 18 | else 19 | PRG=`dirname "$PRG"`"/$link" 20 | fi 21 | done 22 | SAVED="`pwd`" 23 | cd "`dirname \"$PRG\"`/" >/dev/null 24 | APP_HOME="`pwd -P`" 25 | cd "$SAVED" >/dev/null 26 | 27 | APP_NAME="Gradle" 28 | APP_BASE_NAME=`basename "$0"` 29 | 30 | # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. 31 | DEFAULT_JVM_OPTS='"-Xmx64m"' 32 | 33 | # Use the maximum available, or set MAX_FD != -1 to use that value. 34 | MAX_FD="maximum" 35 | 36 | warn () { 37 | echo "$*" 38 | } 39 | 40 | die () { 41 | echo 42 | echo "$*" 43 | echo 44 | exit 1 45 | } 46 | 47 | # OS specific support (must be 'true' or 'false'). 48 | cygwin=false 49 | msys=false 50 | darwin=false 51 | nonstop=false 52 | case "`uname`" in 53 | CYGWIN* ) 54 | cygwin=true 55 | ;; 56 | Darwin* ) 57 | darwin=true 58 | ;; 59 | MINGW* ) 60 | msys=true 61 | ;; 62 | NONSTOP* ) 63 | nonstop=true 64 | ;; 65 | esac 66 | 67 | CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar 68 | 69 | # Determine the Java command to use to start the JVM. 70 | if [ -n "$JAVA_HOME" ] ; then 71 | if [ -x "$JAVA_HOME/jre/sh/java" ] ; then 72 | # IBM's JDK on AIX uses strange locations for the executables 73 | JAVACMD="$JAVA_HOME/jre/sh/java" 74 | else 75 | JAVACMD="$JAVA_HOME/bin/java" 76 | fi 77 | if [ ! -x "$JAVACMD" ] ; then 78 | die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME 79 | 80 | Please set the JAVA_HOME variable in your environment to match the 81 | location of your Java installation." 82 | fi 83 | else 84 | JAVACMD="java" 85 | which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 86 | 87 | Please set the JAVA_HOME variable in your environment to match the 88 | location of your Java installation." 89 | fi 90 | 91 | # Increase the maximum file descriptors if we can. 92 | if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then 93 | MAX_FD_LIMIT=`ulimit -H -n` 94 | if [ $? -eq 0 ] ; then 95 | if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then 96 | MAX_FD="$MAX_FD_LIMIT" 97 | fi 98 | ulimit -n $MAX_FD 99 | if [ $? -ne 0 ] ; then 100 | warn "Could not set maximum file descriptor limit: $MAX_FD" 101 | fi 102 | else 103 | warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" 104 | fi 105 | fi 106 | 107 | # For Darwin, add options to specify how the application appears in the dock 108 | if $darwin; then 109 | GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" 110 | fi 111 | 112 | # For Cygwin, switch paths to Windows format before running java 113 | if $cygwin ; then 114 | APP_HOME=`cygpath --path --mixed "$APP_HOME"` 115 | CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` 116 | JAVACMD=`cygpath --unix "$JAVACMD"` 117 | 118 | # We build the pattern for arguments to be converted via cygpath 119 | ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` 120 | SEP="" 121 | for dir in $ROOTDIRSRAW ; do 122 | ROOTDIRS="$ROOTDIRS$SEP$dir" 123 | SEP="|" 124 | done 125 | OURCYGPATTERN="(^($ROOTDIRS))" 126 | # Add a user-defined pattern to the cygpath arguments 127 | if [ "$GRADLE_CYGPATTERN" != "" ] ; then 128 | OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" 129 | fi 130 | # Now convert the arguments - kludge to limit ourselves to /bin/sh 131 | i=0 132 | for arg in "$@" ; do 133 | CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` 134 | CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option 135 | 136 | if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition 137 | eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` 138 | else 139 | eval `echo args$i`="\"$arg\"" 140 | fi 141 | i=$((i+1)) 142 | done 143 | case $i in 144 | (0) set -- ;; 145 | (1) set -- "$args0" ;; 146 | (2) set -- "$args0" "$args1" ;; 147 | (3) set -- "$args0" "$args1" "$args2" ;; 148 | (4) set -- "$args0" "$args1" "$args2" "$args3" ;; 149 | (5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; 150 | (6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; 151 | (7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; 152 | (8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; 153 | (9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; 154 | esac 155 | fi 156 | 157 | # Escape application args 158 | save () { 159 | for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done 160 | echo " " 161 | } 162 | APP_ARGS=$(save "$@") 163 | 164 | # Collect all arguments for the java command, following the shell quoting and substitution rules 165 | eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" 166 | 167 | # by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong 168 | if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then 169 | cd "$(dirname "$0")" 170 | fi 171 | 172 | exec "$JAVACMD" "$@" 173 | -------------------------------------------------------------------------------- /src/main/kotlin/NonStop.kt: -------------------------------------------------------------------------------- 1 | import org.w3c.dom.NamedNodeMap 2 | import org.w3c.dom.Node 3 | import org.w3c.dom.NodeList 4 | import java.io.File 5 | import java.net.URI 6 | import javax.xml.parsers.DocumentBuilderFactory 7 | import javax.xml.transform.TransformerFactory 8 | import javax.xml.transform.dom.DOMSource 9 | import javax.xml.transform.stream.StreamResult 10 | 11 | object NonStop { 12 | 13 | var optionVerbose = false 14 | 15 | fun processSvg(rootNodes: NodeList): Boolean { 16 | val defsNode = rootNodes.findNode("defs") 17 | if (defsNode == null) { 18 | println("No 'defs' node found, possibly this file does not contain gradients.") 19 | return false 20 | } 21 | 22 | val gradientNodes = defsNode.childNodes 23 | val gradientStopsMap = mutableMapOf>() 24 | val targetGradientsMap = mutableMapOf>() 25 | 26 | gradientNodes.forEach { 27 | // Skipping whitespace nodes 28 | if (it.nodeName == "#text") return@forEach 29 | 30 | logv("Processing gradient node ${it.nodeName}") 31 | 32 | val xlinkedId = it.getAttribute("xlink:href")?.removePrefix("#") 33 | if (xlinkedId != null) { 34 | // Links to gradients 35 | if (targetGradientsMap[xlinkedId] == null) targetGradientsMap[xlinkedId] = mutableListOf() 36 | targetGradientsMap[xlinkedId]!!.add(it) 37 | logv("Found linked gradient, id $xlinkedId") 38 | } else if (it.isGradient()) { 39 | extractStops(it, gradientStopsMap) 40 | } 41 | } 42 | 43 | if (gradientStopsMap.isEmpty()) { 44 | println("Gradient stops not found in defs, searching in g(roups)...") 45 | val gNode = rootNodes.findNode("g") 46 | if (gNode == null) { 47 | println("No 'g' nodes - stops not found.") 48 | return false 49 | } 50 | 51 | logv("Found 'g' node...") 52 | gNode.childNodes.forEachSearchGradients { 53 | extractStops(it, gradientStopsMap) 54 | } 55 | 56 | } 57 | 58 | if (gradientStopsMap.isEmpty()) { 59 | println("Gradient stops not found in gs.") 60 | return false 61 | } 62 | 63 | println("Inserting stops into target gradients.") 64 | targetGradientsMap.forEach { targetGradientsMapEntry -> 65 | val targetGradientId = targetGradientsMapEntry.key 66 | val stops = gradientStopsMap[targetGradientId] ?: return@forEach 67 | val targetGradients = targetGradientsMapEntry.value 68 | logv("Inserting stops for id $targetGradientId, ${targetGradients.count()} gradient(s) count") 69 | targetGradients.forEach { targetGradient -> 70 | stops.forEachIndexed { stopNum, stop -> 71 | logv("Inserting stop #$stopNum for target gradient ${targetGradient.getId()}") 72 | // appendChild will move node if attached to document already, cloning then 73 | targetGradient.appendChild(stop.cloneNode(false)) 74 | } 75 | } 76 | } 77 | 78 | return true 79 | } 80 | 81 | /** 82 | * Process linear gradients with tags 83 | */ 84 | private fun extractStops(linearGradient: Node, gradientStopsMap: MutableMap>) { 85 | val stopNodes = mutableListOf() 86 | linearGradient.childNodes.forEach { stopNode -> if (stopNode.nodeName == "stop") stopNodes.add(stopNode) } 87 | val id = linearGradient.getId() 88 | logv("Found linear gradient, id $id, has ${stopNodes.count()} stops") 89 | 90 | if (stopNodes.isEmpty()) return 91 | gradientStopsMap[id] = stopNodes 92 | } 93 | 94 | private fun NodeList.forEach(action: (Node) -> Unit) { 95 | for (i in 0 until this.length) action.invoke(this.item(i)) 96 | } 97 | 98 | // Dumb recursive, may need performance update on big files 99 | private fun NodeList.forEachSearchGradients(action: (Node) -> Unit) { 100 | for (i in 0 until this.length) { 101 | val node = this.item(i) 102 | val childNodes = node.childNodes 103 | 104 | if (childNodes.length > 0 && !node.isGradient()) { 105 | logv("Node contains nested groups, g id " + node.getId()) 106 | childNodes.forEachSearchGradients(action) 107 | } else if (node.isGradient()) { 108 | action.invoke(node) 109 | } 110 | } 111 | } 112 | 113 | private fun NodeList.findNode(name: String): Node? { 114 | for (i in 0 until this.length) { 115 | val node = this.item(i) 116 | if (node.nodeName == name) return node 117 | } 118 | return null 119 | } 120 | 121 | private fun NamedNodeMap.hasNode(name: String): Boolean { 122 | for (i in 0 until this.length) { 123 | val node = this.item(i) 124 | if (node.nodeName == name) return true 125 | } 126 | return false 127 | } 128 | 129 | private fun Node.getId(): String = getAttribute("id")!! 130 | 131 | private fun Node.getAttribute(attrName: String): String? { 132 | return this.attributes.getNamedItem(attrName)?.nodeValue 133 | } 134 | 135 | private fun Node.isGradient(): Boolean = nodeName == "linearGradient" || nodeName == "radialGradient" 136 | 137 | private fun logv(message: String) { 138 | if (optionVerbose) println(message) 139 | } 140 | } 141 | 142 | 143 | fun main(args: Array) { 144 | var filename: String? = null 145 | var optionForceOverwrite = false 146 | args.forEach { 147 | when (it) { 148 | "-f" -> { 149 | optionForceOverwrite = true 150 | println("Option Force overwrite is on.") 151 | } 152 | "-v" -> { 153 | NonStop.optionVerbose = true 154 | println("Option Verbose is on.") 155 | } 156 | else -> filename = it 157 | } 158 | } 159 | if (filename == null) { 160 | println("Pass target SVG file name as parameter.\n" + 161 | "Add -f to force overwrite target _nonstop.svg file, -v to have verbose output.") 162 | return 163 | } 164 | 165 | val documentBuilder = DocumentBuilderFactory.newInstance().newDocumentBuilder() 166 | val document = documentBuilder.parse(filename) 167 | val documentURI = document.documentURI 168 | 169 | val nonstopDocumentURI = documentURI.replace(".svg", "_nonstop.svg") 170 | val nonstopFile = File(URI.create(nonstopDocumentURI)) 171 | if (nonstopFile.exists() && !optionForceOverwrite) { 172 | println("Target file ${nonstopFile.name} already exists, exiting. Use -f option to force overwrite.") 173 | return 174 | } 175 | 176 | println("Parsed file $documentURI") 177 | val nodes = document.documentElement.childNodes 178 | println("Document contains ${nodes.length} nodes.") 179 | 180 | val resultOk = NonStop.processSvg(nodes) 181 | 182 | if (!resultOk) { 183 | println("Errors occurred, exiting.") 184 | return 185 | } 186 | 187 | println("Processed document.") 188 | val domSource = DOMSource(document) 189 | val streamResult = StreamResult(nonstopFile) 190 | TransformerFactory.newInstance().newTransformer().transform(domSource, streamResult) 191 | println("Saved new file $nonstopDocumentURI successfully.") 192 | } --------------------------------------------------------------------------------