├── quality
    ├── checkstyle
    │   ├── suppressions.xml
    │   └── checkstyle.xml
    ├── findbugs
    │   └── findbugs-filter.xml
    ├── pmd
    │   └── pmd-ruleset.xml
    └── lint
    │   └── lint.xml
├── .gitignore
├── LICENSE
├── jacoco.gradle
├── README.md
└── quality.gradle


/quality/checkstyle/suppressions.xml:
--------------------------------------------------------------------------------
1 | <?xml version="1.0"?>
2 | <!DOCTYPE suppressions PUBLIC
3 |     "-//Puppy Crawl//DTD Suppressions 1.1//EN"
4 |     "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
5 | 
6 | <suppressions>
7 | </suppressions>


--------------------------------------------------------------------------------
/.gitignore:
--------------------------------------------------------------------------------
 1 | # IDE config
 2 | .idea/
 3 | 
 4 | # Built application files
 5 | *.apk
 6 | *.ap_
 7 | 
 8 | # Files for the Dalvik VM
 9 | *.dex
10 | 
11 | # Java class files
12 | *.class
13 | 
14 | # Generated files
15 | bin/
16 | gen/
17 | 
18 | # Gradle files
19 | .gradle/
20 | build/
21 | /*/build/
22 | 
23 | # Local configuration file (sdk path, etc)
24 | local.properties
25 | 
26 | # Proguard folder generated by Eclipse
27 | proguard/
28 | 
29 | # Log Files
30 | *.log
31 | 


--------------------------------------------------------------------------------
/quality/findbugs/findbugs-filter.xml:
--------------------------------------------------------------------------------
 1 | <?xml version="1.0" encoding="UTF-8"?>
 2 | <FindBugsFilter>
 3 |     <!-- http://stackoverflow.com/questions/7568579/eclipsefindbugs-exclude-filter-files-doesnt-work -->
 4 |     <Match>
 5 |         <Class name="~.*\.R\$.*"/>
 6 |     </Match>
 7 |     <Match>
 8 |         <Class name="~.*\.Manifest\$.*"/>
 9 |     </Match>
10 |     <!-- All bugs in test classes, except for JUnit-specific bugs -->
11 |     <Match>
12 |         <Class name="~.*\.*Test" />
13 |         <Not>
14 |             <Bug code="IJU" />
15 |         </Not>
16 |     </Match>
17 | 
18 | 
19 | </FindBugsFilter>


--------------------------------------------------------------------------------
/LICENSE:
--------------------------------------------------------------------------------
 1 | The MIT License (MIT)
 2 | 
 3 | Copyright (c) 2015 Piasy
 4 | 
 5 | Permission is hereby granted, free of charge, to any person obtaining a copy
 6 | of this software and associated documentation files (the "Software"), to deal
 7 | in the Software without restriction, including without limitation the rights
 8 | to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 9 | copies of the Software, and to permit persons to whom the Software is
10 | furnished to do so, subject to the following conditions:
11 | 
12 | The above copyright notice and this permission notice shall be included in all
13 | copies or substantial portions of the Software.
14 | 
15 | THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 | IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 | FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18 | AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 | LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20 | OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21 | SOFTWARE.
22 | 
23 | 


--------------------------------------------------------------------------------
/jacoco.gradle:
--------------------------------------------------------------------------------
 1 | /**
 2 |  *  Apply additional build steps to sub-projects*/
 3 | def jacocoToolVersion = rootProject.ext.has('jacocoVersion') ? rootProject.ext.jacocoVersion : '0.7.7.201606060606'
 4 | def moduleExcludes = rootProject.ext.has('moduleExcludes') ? rootProject.ext.moduleExcludes : [:]
 5 | def ignoredByJacoco = rootProject.ext.has('ignoredByJacoco') ? rootProject.ext.ignoredByJacoco : []
 6 | 
 7 | if (shouldApplyJacoco(project, ignoredByJacoco)) {
 8 |     apply plugin: 'jacoco'
 9 | 
10 |     jacoco {
11 |         version jacocoToolVersion
12 |     }
13 | 
14 |     task jacocoReport(type: JacocoReport, dependsOn: 'test') {
15 |         group = 'Reporting'
16 |         description = 'Generate Jacoco coverage reports after running tests.'
17 | 
18 |         reports {
19 |             html {
20 |                 enabled true
21 |                 destination file('build/reports/jacoco/full')
22 |             }
23 |             xml {
24 |                 enabled true
25 |                 destination file('build/reports/jacoco/full/jacocoFullReport.xml')
26 |             }
27 |         }
28 | 
29 |         sourceDirectories = project.files('src/main/java')
30 |         classDirectories = project.fileTree(dir: 'build/intermediates/classes/debug',
31 |                 excludes: moduleExcludes[project.name] ?: [])
32 | 
33 |         executionData = project.files('build/jacoco/testDebugUnitTest.exec')
34 | 
35 |         doFirst {
36 |             renameClasses(project.name + '/build/intermediates/classes/debug')
37 |         }
38 |     }
39 | }
40 | 
41 | List<File> listDirRecursive(File rootPath) {
42 |     List<File> result = new ArrayList<>()
43 |     List<File> children = rootPath.listFiles()
44 |     children.each { file ->
45 |         if (file.isFile()) {
46 |             result.add(file)
47 |         } else if (file.isDirectory()) {
48 |             result.addAll(listDirRecursive(file))
49 |         }
50 |     }
51 |     return result
52 | }
53 | 
54 | void renameClasses(String rootPath) {
55 |     List<File> classes = listDirRecursive(file(rootPath))
56 |     classes.each { file ->
57 |         if (file.name.contains('$$')) {
58 |             file.renameTo(file.path.replace('$$', '$'))
59 |         }
60 |     }
61 | }
62 | 
63 | boolean shouldApplyJacoco(Project project, List<String> ignoredByJacoco) {
64 |     def ignored = ignoredByJacoco.contains(project.name)
65 |     def isJava = project.plugins.hasPlugin("java")
66 |     def isAndroid = project.plugins.hasPlugin("com.android.library") || plugins.hasPlugin(
67 |             "com.android.application")
68 |     return !ignored && (isJava || isAndroid)
69 | }
70 | 


--------------------------------------------------------------------------------
/README.md:
--------------------------------------------------------------------------------
 1 | # AndroidCodeQualityConfig
 2 | 
 3 | Code quality config for android project, including lint, pmd, findbugs, checkstyle, jacoco code coverage. Serve as a submodule for repo: https://github.com/Piasy/AndroidTDDBootStrap
 4 | 
 5 | +  Usage
 6 |   +  step 1. fork me
 7 |   +  step 2. import the forked repo as git submodule, or just put the folder under your project root.
 8 |   +  step 3. `apply from: '../AndroidCodeQualityConfig/quality.gradle'` for android module then run `gradle check`
 9 |   +  step 4. no more step 4 :).
10 | 
11 | If you have many modules, you have another option:
12 | 
13 | + step 3. add below code into your root project's `build.gradle`:
14 | 
15 | ``` gradle
16 | subprojects {
17 |     apply from: "$rootProject.projectDir/AndroidCodeQualityConfig/quality.gradle"
18 | 
19 |     afterEvaluate {
20 |         check.dependsOn 'checkstyle', 'findbugs', 'pmd', 'lint'
21 |    }
22 | }
23 | ```
24 | 
25 | + step 4. remove `check.dependsOn 'checkstyle', 'findbugs', 'pmd', 'lint'` in quality.gradle.
26 | + step 5. change the last paragraph of quality.gradle into this:
27 | 
28 | ``` gradle
29 | afterEvaluate {
30 |     android {
31 |         lintOptions {
32 |             abortOnError true
33 |             xmlReport true
34 |             htmlReport true
35 |             lintConfig file("${project.rootDir}/AndroidCodeQualityConfig/quality/lint/lint.xml")
36 |         }
37 |     }
38 | }
39 | ```
40 | 
41 | ## CheckStyle
42 | +  [CheckStyle](https://github.com/checkstyle/checkstyle)
43 | +  [CheckStyle-IDEA plugin](https://github.com/jshiell/checkstyle-idea)
44 | 
45 | ## FindBugs
46 | +  [Findbugs](https://github.com/findbugsproject/findbugs)
47 | 
48 | ## PMD
49 | +  [PMD](https://github.com/pmd/pmd)
50 | 
51 | ## Lint
52 | +  [Android Lint](http://tools.android.com/tips/lint)
53 | 
54 | ## Jacoco
55 | 
56 | In your root project `build.gradle`:
57 | 
58 | ``` gradle
59 | apply from: 'AndroidCodeQualityConfig/jacoco.gradle'
60 | ```
61 | 
62 | then define `ignoredByJacoco` array in your root project ext part to define ignoring module, and `moduleExcludes` for each not ignoring module.
63 | 
64 | ## License
65 | 
66 |     The MIT License (MIT)
67 | 
68 |     Copyright (c) 2015 Piasy
69 | 
70 |     Permission is hereby granted, free of charge, to any person obtaining a copy
71 |     of this software and associated documentation files (the "Software"), to deal
72 |     in the Software without restriction, including without limitation the rights
73 |     to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
74 |     copies of the Software, and to permit persons to whom the Software is
75 |     furnished to do so, subject to the following conditions:
76 | 
77 |     The above copyright notice and this permission notice shall be included in all
78 |     copies or substantial portions of the Software.
79 | 
80 |     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
81 |     IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
82 |     FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
83 |     AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
84 |     LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
85 |     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
86 |     SOFTWARE.
87 | 


--------------------------------------------------------------------------------
/quality/pmd/pmd-ruleset.xml:
--------------------------------------------------------------------------------
 1 | <?xml version="1.0"?>
 2 | <ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" name="Android Application Rules"
 3 |          xmlns="http://pmd.sf.net/ruleset/1.0.0"
 4 |          xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd"
 5 |          xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd">
 6 | 
 7 |     <description>Custom ruleset for Android application</description>
 8 | 
 9 |     <exclude-pattern>.*/R.java</exclude-pattern>
10 |     <exclude-pattern>.*/gen/.*</exclude-pattern>
11 |     <exclude-pattern>.*/test/.*</exclude-pattern>
12 |     <exclude-pattern>.*/androidTest/.*</exclude-pattern>
13 | 
14 |     <rule ref="rulesets/java/android.xml"/>
15 | 
16 |     <rule ref="rulesets/java/basic.xml"/>
17 |     <rule ref="rulesets/java/braces.xml"/>
18 |     <rule ref="rulesets/java/clone.xml"/>
19 |     <rule ref="rulesets/java/codesize.xml">
20 |         <exclude name="TooManyMethods"/>
21 |     </rule>
22 |     <rule ref="rulesets/java/codesize.xml/TooManyMethods">
23 |         <properties>
24 |             <property name="maxmethods" value="20"/>
25 |         </properties>
26 |     </rule>
27 |     <rule ref="rulesets/java/comments.xml">
28 |         <exclude name="CommentSize"/>
29 |         <!-- javadoc is checked by checkstyle -->
30 |         <exclude name="CommentRequired"/>
31 |         <exclude name="CommentDefaultAccessModifier"/>
32 |     </rule>
33 |     <rule ref="rulesets/java/controversial.xml">
34 |         <exclude name="AtLeastOneConstructor"/>
35 | 
36 |         <!-- better to keep dagger module class provide methods as package private -->
37 |         <exclude name="DefaultPackage"/>
38 | 
39 |         <!-- annoying -->
40 |         <exclude name="AvoidFinalLocalVariable"/>
41 | 
42 |         <!-- Singleton usage -->
43 |         <exclude name="AvoidUsingVolatile"/>
44 | 
45 |         <exclude name="AvoidPrefixingMethodParameters"/>
46 | 
47 |         <exclude name="OnlyOneReturn"/>
48 |     </rule>
49 |     <rule ref="rulesets/java/coupling.xml">
50 |         <!-- this is too strictly -->
51 |         <exclude name="LawOfDemeter"/>
52 |         <exclude name="ExcessiveImports"/>
53 |     </rule>
54 |     <rule ref="rulesets/java/design.xml">
55 |         <exclude name="UncommentedEmptyMethodBody"/>
56 |     </rule>
57 |     <rule ref="rulesets/java/empty.xml"/>
58 |     <rule ref="rulesets/java/finalizers.xml"/>
59 |     <rule ref="rulesets/java/imports.xml">
60 |         <!-- Espresso is designed this way !-->
61 |         <exclude name="TooManyStaticImports"/>
62 |     </rule>
63 | 
64 |     <rule ref="rulesets/java/junit.xml">
65 |         <!-- mockito assert -->
66 |         <exclude name="JUnitTestsShouldIncludeAssert"/>
67 |         <exclude name="JUnitTestContainsTooManyAsserts"/>
68 |         <exclude name="JUnitAssertionsShouldIncludeMessage"/>
69 |     </rule>
70 |     <rule ref="rulesets/java/logging-java.xml"/>
71 | 
72 |     <rule ref="rulesets/java/naming.xml">
73 |         <exclude name="AbstractNaming"/>
74 |         <exclude name="LongVariable"/>
75 |         <!--<exclude name="LongMethodName" />-->
76 |         <exclude name="ShortMethodName"/>
77 |         <exclude name="ShortVariable"/>
78 |         <exclude name="VariableNamingConventions"/>
79 |     </rule>
80 |     <rule ref="rulesets/java/optimizations.xml"/>
81 |     <rule ref="rulesets/java/strictexception.xml"/>
82 |     <rule ref="rulesets/java/strings.xml">
83 |         <exclude name="AvoidDuplicateLiterals"/>
84 |     </rule>
85 |     <rule ref="rulesets/java/strings.xml/AvoidDuplicateLiterals">
86 |         <properties>
87 |             <property name="skipAnnotations" value="true"/>
88 |         </properties>
89 |     </rule>
90 |     <!--<rule ref="rulesets/java/typeresolutoin.xml"/>-->
91 |     <rule ref="rulesets/java/unnecessary.xml"/>
92 |     <rule ref="rulesets/java/unusedcode.xml"/>
93 | </ruleset>


--------------------------------------------------------------------------------
/quality.gradle:
--------------------------------------------------------------------------------
  1 | apply plugin: 'checkstyle'
  2 | apply plugin: 'findbugs'
  3 | apply plugin: 'pmd'
  4 | 
  5 | def isJava = plugins.hasPlugin('java')
  6 | // Add checkstyle, findbugs, pmd and lint to the check task.
  7 | // Comment it if already set in root project's build.gradle.
  8 | check.dependsOn 'checkstyle', 'findbugs', 'pmd'
  9 | if (!isJava) {
 10 |     check.dependsOn 'lint'
 11 | }
 12 | 
 13 | checkstyle {
 14 |     toolVersion '7.4'
 15 | 
 16 |     configFile file("${project.rootDir}/AndroidCodeQualityConfig/quality/checkstyle/checkstyle.xml")
 17 |     configProperties.checkstyleSuppressionFilterPath = file(
 18 |             "${project.rootDir}/AndroidCodeQualityConfig/quality/checkstyle/suppressions.xml")
 19 |             .absolutePath
 20 | }
 21 | 
 22 | task checkstyle(type: Checkstyle, group: 'verification') {
 23 |     source 'src'
 24 |     include '**/*.java'
 25 |     exclude '**/gen/**'
 26 |     exclude '**/test/**'
 27 |     exclude '**/androidTest/**'
 28 |     exclude '**/R.java'
 29 |     exclude '**/BuildConfig.java'
 30 |     classpath = files()
 31 | }
 32 | 
 33 | 
 34 | findbugs {
 35 |     toolVersion = "3.0.1"
 36 |     ignoreFailures = false
 37 |     effort = "max"
 38 |     reportLevel = "high"
 39 |     excludeFilter = new File("${project.rootDir}/AndroidCodeQualityConfig/quality/findbugs/findbugs-filter.xml")
 40 | }
 41 | 
 42 | task findbugs(type: FindBugs, dependsOn: "assemble", group: 'verification') {
 43 |     if (isJava) {
 44 |         classes = files("$projectDir.absolutePath/build/classes")
 45 |     } else {
 46 |         classes = files("$projectDir.absolutePath/build/intermediates/classes")
 47 |     }
 48 |     source 'src'
 49 |     include '**/*.java'
 50 |     exclude '**/gen/**'
 51 | 
 52 |     reports {
 53 |         // FindBugs tasks can only have one report enabled
 54 |         xml.enabled = false
 55 |         html.enabled = !xml.enabled
 56 |         xml {
 57 |             destination file("$projectDir.absolutePath/build/reports/findbugs/findbugs.xml")
 58 |         }
 59 |         html {
 60 |             destination file("$projectDir.absolutePath/build/reports/findbugs/findbugs.html")
 61 |         }
 62 |     }
 63 | 
 64 |     classpath = files()
 65 | }
 66 | 
 67 | 
 68 | pmd {
 69 |     toolVersion = '5.5.2'
 70 |     ignoreFailures = false
 71 |     ruleSetFiles = files("${project.rootDir}/AndroidCodeQualityConfig/quality/pmd/pmd-ruleset.xml")
 72 |     ruleSets = []
 73 | }
 74 | 
 75 | task pmd(type: Pmd, group: 'verification') {
 76 |     source 'src'
 77 |     include '**/*.java'
 78 |     exclude('**/gen/**', '**/debug/**')
 79 | 
 80 |     reports {
 81 |         xml.enabled = true
 82 |         html.enabled = true
 83 |         xml {
 84 |             destination file("$projectDir.absolutePath/build/reports/pmd/pmd.xml")
 85 |         }
 86 |         html {
 87 |             destination file("$projectDir.absolutePath/build/reports/pmd/pmd.html")
 88 |         }
 89 |     }
 90 | }
 91 | 
 92 | if (!isJava) {
 93 |     android {
 94 |         lintOptions {
 95 |             disable 'NewApi' // gradle build will compile code use `Objects.requireNonNull()` for lambda
 96 |             abortOnError true
 97 |             xmlReport true
 98 |             xmlOutput project.file('build/reports/lint/lint-report.xml')
 99 |             htmlReport true
100 |             htmlOutput project.file('build/reports/lint/lint-report.html')
101 |             lintConfig file("${project.rootDir}/AndroidCodeQualityConfig/quality/lint/lint.xml")
102 |         }
103 | 
104 |         testOptions.unitTests.all {
105 |             testLogging {
106 |                 events 'passed', 'skipped', 'failed', 'standardOut', 'standardError'
107 |                 outputs.upToDateWhen { false }
108 |                 showStandardStreams = true
109 |             }
110 |             jvmArgs '-noverify'
111 |         }
112 |     }
113 | }
114 | 
115 | apply from: rootProject.file('AndroidCodeQualityConfig/jacoco.gradle')
116 | 


--------------------------------------------------------------------------------
/quality/lint/lint.xml:
--------------------------------------------------------------------------------
  1 | <?xml version="1.0" encoding="UTF-8"?>
  2 | <lint>
  3 |     <issue id="AdapterViewChildren" severity="ignore" />
  4 |     <issue id="AllowBackup" severity="ignore" />
  5 |     <issue id="AlwaysShowAction" severity="ignore" />
  6 |     <issue id="ButtonCase" severity="ignore" />
  7 |     <issue id="ButtonOrder" severity="ignore" />
  8 |     <issue id="ButtonStyle" severity="ignore" />
  9 |     <issue id="CommitPrefEdits" severity="error" />
 10 |     <issue id="CommitTransaction" severity="ignore" />
 11 |     <issue id="ContentDescription" severity="ignore" />
 12 |     <issue id="CutPasteId" severity="ignore" />
 13 |     <issue id="DalvikOverride" severity="ignore" />
 14 |     <issue id="DefaultLocale" severity="ignore" />
 15 |     <issue id="Deprecated" severity="ignore" />
 16 |     <issue id="DeviceAdmin" severity="ignore" />
 17 |     <issue id="DisableBaselineAlignment" severity="error" />
 18 |     <issue id="DrawAllocation" severity="error" />
 19 |     <issue id="DuplicateActivity" severity="error" />
 20 |     <issue id="DuplicateDefinition" severity="error" />
 21 |     <issue id="DuplicateIds" severity="error" />
 22 |     <issue id="DuplicateIncludedIds" severity="error" />
 23 |     <issue id="DuplicateUsesFeature" severity="error" />
 24 |     <issue id="EnforceUTF8" severity="error" />
 25 |     <issue id="ExportedContentProvider" severity="ignore" />
 26 |     <issue id="ExportedReceiver" severity="ignore" />
 27 |     <issue id="ExportedService" severity="ignore" />
 28 |     <issue id="ExtraText" severity="ignore" />
 29 |     <issue id="ExtraTranslation" severity="ignore" />
 30 |     <issue id="FloatMath" severity="error" />
 31 |     <issue id="GifUsage" severity="ignore" />
 32 |     <issue id="GradleOverrides" severity="ignore" />
 33 |     <issue id="GrantAllUris" severity="ignore" />
 34 |     <issue id="GridLayout" severity="error" />
 35 |     <issue id="HandlerLeak" severity="error" />
 36 |     <issue id="HardcodedDebugMode" severity="error" />
 37 |     <issue id="HardcodedText" severity="ignore" />
 38 |     <issue id="IconColors" severity="ignore" />
 39 |     <issue id="IconDensities" severity="error" />
 40 |     <issue id="IconDipSize" severity="error" />
 41 |     <issue id="IconDuplicates" severity="ignore" />
 42 |     <issue id="IconDuplicatesConfig" severity="ignore" />
 43 |     <issue id="IconExtension" severity="ignore" />
 44 |     <issue id="IconLauncherShape" severity="ignore" />
 45 |     <issue id="IconLocation" severity="ignore" />
 46 |     <issue id="IconMissingDensityFolder" severity="ignore" />
 47 |     <issue id="IconMixedNinePatch" severity="ignore" />
 48 |     <issue id="IconNoDpi" severity="ignore" />
 49 |     <issue id="IconXmlAndPng" severity="ignore" />
 50 |     <issue id="IllegalResourceRef" severity="ignore" />
 51 |     <issue id="InOrMmUsage" severity="ignore" />
 52 |     <issue id="InconsistentArrays" severity="ignore" />
 53 |     <issue id="InconsistentLayout" severity="ignore" />
 54 |     <issue id="InefficientWeight" severity="ignore" />
 55 |     <issue id="InlinedApi" severity="ignore" />
 56 |     <issue id="InnerclassSeparator" severity="ignore" />
 57 |     <issue id="Instantiatable" severity="ignore" />
 58 |     <issue id="InvalidId" severity="error" />
 59 |     <issue id="InvalidPackage" severity="ignore" />
 60 |     <issue id="JavascriptInterface" severity="ignore" />
 61 |     <issue id="LabelFor" severity="ignore" />
 62 |     <issue id="LibraryCustomView" severity="ignore" />
 63 |     <issue id="LocalSuppress" severity="ignore" />
 64 |     <issue id="MangledCRLF" severity="ignore" />
 65 |     <issue id="ManifestOrder" severity="ignore" />
 66 |     <issue id="ManifestTypo" severity="error" />
 67 |     <issue id="MenuTitle" severity="ignore" />
 68 |     <issue id="MergeRootFrame" severity="ignore" />
 69 |     <issue id="MissingApplicationIcon" severity="ignore" />
 70 |     <issue id="MissingId" severity="error" />
 71 |     <issue id="MissingPrefix" severity="ignore" />
 72 |     <issue id="MissingQuantity" severity="ignore" />
 73 |     <issue id="MissingRegistered" severity="ignore" />
 74 |     <issue id="MissingSuperCall" severity="ignore" />
 75 |     <issue id="MissingTranslation" severity="ignore" />
 76 |     <issue id="MissingVersion" severity="ignore" />
 77 |     <issue id="MockLocation" severity="ignore" />
 78 |     <issue id="MultipleUsesSdk" severity="ignore" />
 79 |     <issue id="NamespaceTypo" severity="ignore" />
 80 |     <issue id="NestedScrolling" severity="ignore" />
 81 |     <issue id="NestedWeights" severity="error" />
 82 |     <issue id="NewApi">
 83 |         <ignore regexp="Try-with-resources requires API level 19"/>
 84 |     </issue>
 85 |     <issue id="NotSibling" severity="ignore" />
 86 |     <issue id="ObsoleteLayoutParam" severity="ignore" />
 87 |     <issue id="OldTargetApi" severity="ignore" />
 88 |     <issue id="OnClick" severity="error" />
 89 |     <issue id="Orientation" severity="ignore" />
 90 |     <issue id="Overdraw" severity="warning" />
 91 |     <issue id="Override" severity="error" />
 92 |     <issue id="PackagedPrivateKey" severity="ignore" />
 93 |     <issue id="ParcelCreator" severity="ignore" />
 94 |     <issue id="PrivateResource" severity="ignore" />
 95 |     <issue id="Proguard" severity="ignore" />
 96 |     <issue id="ProguardSplit" severity="ignore" />
 97 |     <issue id="ProtectedPermissions" severity="ignore" />
 98 |     <issue id="PxUsage" severity="ignore" />
 99 |     <issue id="Recycle" severity="ignore" />
100 |     <issue id="Registered" severity="ignore" />
101 |     <issue id="RequiredSize" severity="ignore" />
102 |     <issue id="ResAuto" severity="ignore" />
103 |     <issue id="ResourceAsColor" severity="ignore" />
104 |     <issue id="ScrollViewCount" severity="ignore" />
105 |     <issue id="ScrollViewSize" severity="ignore" />
106 |     <issue id="SdCardPath" severity="error" />
107 |     <issue id="SecureRandom" severity="ignore" />
108 |     <issue id="ServiceCast" severity="ignore" />
109 |     <issue id="SetJavaScriptEnabled" severity="ignore" />
110 |     <issue id="ShowToast" severity="error" />
111 |     <issue id="SimpleDateFormat" severity="ignore" />
112 |     <issue id="SmallSp" severity="ignore" />
113 |     <issue id="SpUsage" severity="ignore" />
114 |     <issue id="StateListReachable" severity="ignore" />
115 |     <issue id="StringFormatCount" severity="ignore" />
116 |     <issue id="StringFormatInvalid" severity="ignore" />
117 |     <issue id="StringFormatMatches" severity="ignore" />
118 |     <issue id="StyleCycle" severity="ignore" />
119 |     <issue id="Suspicious0dp" severity="error" />
120 |     <issue id="SuspiciousImport" severity="error" />
121 |     <issue id="TextFields" severity="ignore" />
122 |     <issue id="TextViewEdits" severity="ignore" />
123 |     <issue id="TooDeepLayout" severity="error" />
124 |     <issue id="TooManyViews" severity="error" />
125 |     <issue id="TrulyRandom" severity="ignore" />
126 |     <issue id="TypographyDashes" severity="ignore" />
127 |     <issue id="TypographyEllipsis" severity="ignore" />
128 |     <issue id="TypographyFractions" severity="ignore" />
129 |     <issue id="TypographyOther" severity="ignore" />
130 |     <issue id="Typos" severity="ignore" />
131 |     <issue id="UniquePermission" severity="error" />
132 |     <issue id="UnknownId" severity="error" />
133 |     <issue id="UnknownIdInLayout" severity="error" />
134 |     <issue id="UnlocalizedSms" severity="ignore" />
135 |     <issue id="UnusedNamespace" severity="ignore" />
136 |     <issue id="UnusedQuantity" severity="ignore" />
137 |     <issue id="UnusedResources" severity="ignore" />
138 |     <issue id="UseCheckPermission" severity="ignore" />
139 |     <issue id="UseCompoundDrawables" severity="ignore" />
140 |     <issue id="UseSparseArrays" severity="ignore" />
141 |     <issue id="UseValueOf" severity="ignore" />
142 |     <issue id="UselessLeaf" severity="ignore" />
143 |     <issue id="UselessParent" severity="ignore" />
144 |     <issue id="UsesMinSdkAttributes" severity="ignore" />
145 |     <issue id="ValidFragment" severity="ignore" />
146 |     <issue id="ViewConstructor" severity="ignore" />
147 |     <issue id="ViewTag" severity="ignore" />
148 |     <issue id="Wakelock" severity="ignore" />
149 |     <issue id="WorldReadableFiles" severity="ignore" />
150 |     <issue id="WorldWriteableFiles" severity="ignore" />
151 |     <issue id="WrongCall" severity="ignore" />
152 |     <issue id="WrongCase" severity="ignore" />
153 |     <issue id="WrongFolder" severity="ignore" />
154 |     <issue id="WrongManifestParent" severity="ignore" />
155 |     <issue id="WrongViewCast" severity="error" />
156 |     <issue id="GoogleAppIndexingWarning" severity="ignore" />
157 | </lint>


--------------------------------------------------------------------------------
/quality/checkstyle/checkstyle.xml:
--------------------------------------------------------------------------------
  1 | <?xml version="1.0"?>
  2 | <!DOCTYPE module PUBLIC
  3 |         "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
  4 |         "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
  5 | 
  6 | <module name="Checker">
  7 |     <module name="FileLength">
  8 |         <property name="max" value="500"/>
  9 |         <property name="fileExtensions" value="java"/>
 10 |     </module>
 11 | 
 12 |     <module name="SuppressionCommentFilter"/>
 13 | 
 14 |     <module name="SuppressionFilter">
 15 |         <property name="file" value="${checkstyleSuppressionFilterPath}"/>
 16 |     </module>
 17 | 
 18 |     <module name="TreeWalker">
 19 | 
 20 |         <module name="FileContentsHolder"/>
 21 | 
 22 |         <!-- See http://checkstyle.sf.net/config_sizes.html !-->
 23 |         <!-- Checks for long lines. !-->
 24 |         <module name="LineLength">
 25 |             <property name="ignorePattern" value="^$"/>
 26 |             <property name="max" value="120"/>
 27 |         </module>
 28 | 
 29 |         <!-- Checks the number of methods declared in each type. This includes the number of each scope !-->
 30 |         <!-- (private, package, protected and public) as well as an overall total. !-->
 31 |         <!-- See http://checkstyle.sourceforge.net/config_sizes.html#MethodCount !-->
 32 |         <module name="MethodCount">
 33 |             <property name="maxTotal" value="100"/>
 34 |             <property name="maxPrivate" value="100"/>
 35 |             <property name="maxPackage" value="100"/>
 36 |             <property name="maxProtected" value="100"/>
 37 |             <property name="maxPublic" value="100"/>
 38 |         </module>
 39 | 
 40 |         <!-- Checks for long methods and constructors. !-->
 41 |         <!-- See http://checkstyle.sf.net/config_sizes.html !-->
 42 |         <module name="MethodLength">
 43 |             <property name="max" value="80"/>
 44 |             <property name="countEmpty" value="true"/>
 45 |             <property name="tokens" value="METHOD_DEF, CTOR_DEF"/>
 46 |         </module>
 47 | 
 48 |         <!-- Checks for the number of types declared at the outer (or root) level in a file. !-->
 49 |         <!-- See http://checkstyle.sourceforge.net/config_sizes.html#OuterTypeNumber !-->
 50 |         <module name="OuterTypeNumber">
 51 |             <property name="max" value="1"/>
 52 |         </module>
 53 | 
 54 |         <!-- Checks the number of parameters of a method or constructor. !-->
 55 |         <!-- See http://checkstyle.sf.net/config_sizes.html !-->
 56 |         <module name="ParameterNumber">
 57 |             <property name="max" value="7"/>
 58 |             <property name="tokens" value="METHOD_DEF, CTOR_DEF"/>
 59 |         </module>
 60 | 
 61 |     </module>
 62 |     <module name="TreeWalker">
 63 | 
 64 |         <module name="FileContentsHolder"/>
 65 | 
 66 |         <!-- Checks the padding of an empty for initializer. !-->
 67 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
 68 |         <module name="EmptyForInitializerPad">
 69 |             <property name="option" value="nospace"/>
 70 |         </module>
 71 | 
 72 |         <!-- Checks the padding of an empty for iterator. !-->
 73 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
 74 |         <module name="EmptyForIteratorPad">
 75 |             <property name="option" value="nospace"/>
 76 |         </module>
 77 | 
 78 |         <!-- Checks that the whitespace around the Generic tokens < and > is correct to the typical convention. !-->
 79 |         <!-- See http://checkstyle.sourceforge.net/config_whitespace.html#GenericWhitespace !-->
 80 |         <module name="GenericWhitespace"/>
 81 | 
 82 |         <!-- Checks the padding between the identifier of a method definition, !-->
 83 |         <!-- constructor definition, method call, or constructor invocation; and the left parenthesis of the parameter list. !-->
 84 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
 85 |         <module name="MethodParamPad">
 86 |             <property name="allowLineBreaks" value="false"/>
 87 |             <property name="option" value="nospace"/>
 88 |             <property name="tokens"
 89 |                       value="CTOR_DEF, LITERAL_NEW, METHOD_CALL, METHOD_DEF, SUPER_CTOR_CALL "/>
 90 |         </module>
 91 | 
 92 |         <!-- Checks that there is no whitespace after a token. !-->
 93 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
 94 |         <module name="NoWhitespaceAfter">
 95 |             <property name="allowLineBreaks" value="true"/>
 96 |             <property name="tokens"
 97 |                       value="ARRAY_INIT, BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS, UNARY_PLUS"/>
 98 |         </module>
 99 | 
100 |         <!-- Checks that there is no whitespace before a token. !-->
101 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
102 |         <module name="NoWhitespaceBefore">
103 |             <property name="allowLineBreaks" value="false"/>
104 |             <property name="tokens" value="SEMI, POST_DEC, POST_INC"/>
105 |         </module>
106 | 
107 |         <!-- Checks the policy on how to wrap lines on operators. !-->
108 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
109 |         <module name="OperatorWrap">
110 |             <property name="option" value="nl"/>
111 |             <property name="tokens" value="ASSIGN, BAND, BOR, BSR, BXOR, COLON, DIV,
112 |                                            EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF,
113 |                                            LOR, LT, MINUS, MOD, NOT_EQUAL,
114 |                                            PLUS, QUESTION, SL, SR, STAR"/>
115 |         </module>
116 | 
117 |         <!-- Checks the policy on the padding of parentheses. !-->
118 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
119 |         <module name="ParenPad">
120 |             <property name="option" value="nospace"/>
121 |             <property name="tokens"
122 |                       value="CTOR_CALL, METHOD_CALL, SUPER_CTOR_CALL"/>
123 |         </module>
124 | 
125 |         <!-- Checks the policy on the padding of parentheses for typecasts. !-->
126 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
127 |         <module name="TypecastParenPad">
128 |             <property name="option" value="nospace"/>
129 |             <property name="tokens" value="TYPECAST, RPAREN"/>
130 |         </module>
131 | 
132 |         <!-- Checks that a token is followed by whitespace. !-->
133 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
134 |         <module name="WhitespaceAfter">
135 |             <property name="tokens" value="COMMA, SEMI, TYPECAST"/>
136 |         </module>
137 | 
138 |         <!-- Checks that a token is surrounded by whitespace. !-->
139 |         <!-- See http://checkstyle.sf.net/config_whitespace.html !-->
140 |         <module name="WhitespaceAround">
141 |             <property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN,
142 |                                            BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND,
143 |                                            LCURLY, LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE,
144 |                                            LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN,
145 |                                            LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT,
146 |                                            MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN,
147 |                                            QUESTION, RCURLY, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN"/>
148 |             <property name="allowEmptyConstructors" value="true"/>
149 |             <property name="allowEmptyMethods" value="true"/>
150 |             <property name="allowEmptyTypes" value="true"/>
151 |         </module>
152 | 
153 |         <!-- The following checks are actually not whitespace checks, but still fit here quite well. !-->
154 | 
155 |         <!-- Checks that there is only one statement per line. !-->
156 |         <!-- See http://checkstyle.sourceforge.net/config_coding.html#OneStatementPerLine !-->
157 |         <module name="OneStatementPerLine"/>
158 | 
159 |         <!-- Checks that each variable declaration is in its own statement and on its own line. !-->
160 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
161 |         <module name="MultipleVariableDeclarations"/>
162 | 
163 |     </module>
164 | 
165 |     <!-- Checks that there are no tabs in the source file !-->
166 |     <!-- http://checkstyle.sourceforge.net/config_whitespace.html#FileTabCharacter !-->
167 |     <module name="FileTabCharacter"/>
168 |     <module name="TreeWalker">
169 |         <module name="FileContentsHolder"/>
170 | 
171 |         <!-- Checks that the outer type name and the file name match. !-->
172 |         <!-- See http://checkstyle.sourceforge.net/config_misc.html#OuterTypeFilename !-->
173 |         <module name="OuterTypeFilename"/>
174 | 
175 |         <!-- Checks for class type parameter name naming conventions. !-->
176 |         <!-- See http://checkstyle.sourceforge.net/config_naming.html#ClassTypeParameterName !-->
177 |         <module name="ClassTypeParameterName">
178 |             <property name="format" value="^[A-Z]$"/>
179 |         </module>
180 | 
181 |         <!-- Checks for constant name naming conventions. !-->
182 |         <!-- See http://checkstyle.sf.net/config_naming.html !-->
183 |         <module name="ConstantName">
184 |             <property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/>
185 |             <property name="applyToPublic" value="true"/>
186 |             <property name="applyToProtected" value="true"/>
187 |             <property name="applyToPackage" value="true"/>
188 |             <property name="applyToPrivate" value="true"/>
189 |         </module>
190 | 
191 |         <!-- Checks for local final variable name naming conventions. !-->
192 |         <!-- See http://checkstyle.sf.net/config_naming.html !-->
193 |         <module name="LocalFinalVariableName">
194 |             <property name="format" value="^[a-z][a-zA-Z0-9]*$"/>
195 |             <property name="tokens" value="VARIABLE_DEF"/>
196 |         </module>
197 | 
198 |         <!-- Checks for local variable name naming conventions. !-->
199 |         <!-- See http://checkstyle.sf.net/config_naming.html !-->
200 |         <module name="LocalVariableName">
201 |             <property name="format" value="^[a-z][a-zA-Z0-9]*$"/>
202 |             <property name="tokens" value="VARIABLE_DEF"/>
203 |         </module>
204 | 
205 |         <!-- Checks for member variable name naming conventions. !-->
206 |         <!-- See http://checkstyle.sf.net/config_naming.html !-->
207 |         <module name="MemberName">
208 |             <property name="format" value="^m[A-Z][a-zA-Z0-9]*$"/>
209 |             <property name="applyToPublic" value="true"/>
210 |             <property name="applyToProtected" value="true"/>
211 |             <property name="applyToPackage" value="true"/>
212 |             <property name="applyToPrivate" value="true"/>
213 |         </module>
214 | 
215 |         <!-- Checks for method name naming conventions. !-->
216 |         <!-- See http://checkstyle.sf.net/config_naming.html !-->
217 |         <module name="MethodName">
218 |             <property name="format" value="^[a-z][a-zA-Z0-9_]*$"/>
219 |         </module>
220 | 
221 |         <!-- Checks for method type parameter name naming conventions. !-->
222 |         <!-- See http://checkstyle.sourceforge.net/config_naming.html#MethodTypeParameterName !-->
223 |         <module name="MethodTypeParameterName">
224 |             <property name="format" value="^[A-Z]$"/>
225 |         </module>
226 | 
227 |         <!-- Checks for package name naming conventions. !-->
228 |         <!-- See http://checkstyle.sf.net/config_naming.html !-->
229 |         <module name="PackageName">
230 |             <property name="format" value="^[a-z][a-z0-9]*(\.[a-zA-Z_][a-zA-Z0-9_]*)*$"/>
231 |         </module>
232 | 
233 |         <!-- Checks for parameter name naming conventions. !-->
234 |         <!-- See http://checkstyle.sf.net/config_naming.html !-->
235 |         <module name="ParameterName">
236 |             <property name="format" value="^[a-z][a-zA-Z0-9]*$"/>
237 |         </module>
238 | 
239 |         <!-- Checks for static variable name naming conventions. !-->
240 |         <!-- See http://checkstyle.sf.net/config_naming.html !-->
241 |         <module name="StaticVariableName">
242 |             <property name="format" value="^s[A-Z][a-zA-Z0-9]*$"/>
243 |             <property name="applyToPublic" value="true"/>
244 |             <property name="applyToProtected" value="true"/>
245 |             <property name="applyToPackage" value="true"/>
246 |             <property name="applyToPrivate" value="true"/>
247 |         </module>
248 | 
249 |         <!-- Checks for type name naming conventions. !-->
250 |         <!-- See http://checkstyle.sf.net/config_naming.html !-->
251 |         <module name="TypeName">
252 |             <property name="format" value="^[A-Z][a-zA-Z0-9]*$"/>
253 |             <property name="tokens" value="CLASS_DEF, INTERFACE_DEF"/>
254 |             <property name="applyToPublic" value="true"/>
255 |             <property name="applyToProtected" value="true"/>
256 |             <property name="applyToPackage" value="true"/>
257 |             <property name="applyToPrivate" value="true"/>
258 |         </module>
259 | 
260 |     </module>
261 | 
262 |     <module name="TreeWalker">
263 | 
264 |         <module name="FileContentsHolder"/>
265 | 
266 |         <!-- Ensure a class has a package declaration. !-->
267 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
268 |         <module name="PackageDeclaration"/>
269 | 
270 |     </module>
271 |     <module name="TreeWalker">
272 | 
273 |         <module name="FileContentsHolder"/>
274 | 
275 |         <!-- Checks visibility of class members. !-->
276 |         <!-- See http://checkstyle.sf.net/config_design.html !-->
277 |         <module name="VisibilityModifier">
278 |             <property name="packageAllowed" value="false"/>
279 |             <property name="protectedAllowed" value="true"/>
280 |             <property name="publicMemberPattern" value="^serialVersionUID$"/>
281 | 
282 |             <!-- ignore fields annotated with @Inject, @BindView, @BindViews, @AutoBundleField, @VisibleForTesting-->
283 |             <property name="ignoreAnnotationCanonicalNames" value="Inject"/>
284 |             <property name="ignoreAnnotationCanonicalNames" value="BindView"/>
285 |             <property name="ignoreAnnotationCanonicalNames" value="BindViews"/>
286 |             <property name="ignoreAnnotationCanonicalNames" value="AutoBundleField"/>
287 |             <property name="ignoreAnnotationCanonicalNames" value="VisibleForTesting"/>
288 |         </module>
289 | 
290 |         <!-- Checks that classes (except abtract one) define a ctor and don't rely on the default one. !-->
291 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
292 |         <!--<module name="MissingCtor"/>!-->
293 | 
294 |         <!-- Make sure that utility classes (classes that contain only static methods) do not have a public constructor. !-->
295 |         <!-- See http://checkstyle.sf.net/config_design.html !-->
296 |         <module name="HideUtilityClassConstructor"/>
297 | 
298 |     </module>
299 |     <module name="TreeWalker">
300 | 
301 |         <module name="FileContentsHolder"/>
302 | 
303 |         <!-- Checks that the order of modifiers conforms to the suggestions in the Java Language specification, !-->
304 |         <!-- sections 8.1.1, 8.3.1 and 8.4.3. !-->
305 |         <!-- See http://checkstyle.sf.net/config_modifiers.html !-->
306 |         <module name="ModifierOrder"/>
307 | 
308 |         <!-- Checks that there are no redundant modifiers. !-->
309 |         <!-- See http://checkstyle.sf.net/config_modifiers.html
310 |         <module name="RedundantModifier">
311 |             <property name="tokens" value="METHOD_DEF, VARIABLE_DEF, ANNOTATION_FIELD_DEF"/>
312 |         </module>
313 |          !-->
314 | 
315 |         <!-- Checks that a class which has only private constructors is declared as final. !-->
316 |         <!-- See http://checkstyle.sf.net/config_design.html !-->
317 |         <module name="FinalClass"/>
318 | 
319 |         <!-- Check nested (internal) classes/interfaces are declared at the bottom of the class after all method and field declarations. !-->
320 |         <!-- See http://checkstyle.sourceforge.net/config_design.html#InnerTypeLast !-->
321 |         <module name="InnerTypeLast"/>
322 | 
323 |         <!-- Implements Bloch, Effective Java, Item 17 - Use Interfaces only to define types. !-->
324 |         <!-- See http://checkstyle.sf.net/config_design.html !-->
325 |         <module name="InterfaceIsType">
326 |             <property name="allowMarkerInterfaces" value="true"/>
327 |         </module>
328 | 
329 |         <!-- Restricts throws statements to a specified count. !-->
330 |         <!-- See http://checkstyle.sf.net/config_design.html !-->
331 |         <module name="ThrowsCount">
332 |             <property name="max" value="2"/>
333 |         </module>
334 | 
335 |         <!-- Checks that classes that define a covariant equals() method also override method equals(java.lang.Object). !-->
336 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
337 |         <module name="CovariantEquals"/>
338 | 
339 |         <!-- Checks declaration order according to Code Conventions for the Java Programming Language. !-->
340 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
341 |         <module name="DeclarationOrder">
342 |             <property name="ignoreConstructors" value="false"/>
343 |             <property name="ignoreModifiers" value="false"/>
344 |         </module>
345 | 
346 |         <!-- Check that the default is after all the cases in a switch statement. !-->
347 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
348 |         <module name="DefaultComesLast"/>
349 | 
350 |         <!-- Detects empty statements (standalone ;). !-->
351 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
352 |         <module name="EmptyStatement"/>
353 | 
354 |         <!-- Catching java.lang.Exception, java.lang.Error or java.lang.RuntimeException is almost never acceptable. !-->
355 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
356 |         <module name="IllegalCatch">
357 |             <property name="illegalClassNames"
358 |                       value="java.lang.Throwable, java.lang.RuntimeException"/>
359 |         </module>
360 | 
361 |         <!-- This check can be used to ensure that types are not declared to be thrown. !-->
362 |         <!-- Declaring to throw java.lang.Error or java.lang.RuntimeException is almost never acceptable. !-->
363 |         <!-- See http://checkstyle.sourceforge.net/config_coding.html#IllegalThrows !-->
364 |         <module name="IllegalThrows">
365 |             <property name="illegalClassNames"
366 |                       value="java.lang.Throwable, java.lang.Error, java.lang.RuntimeException"/>
367 |         </module>
368 | 
369 |         <!-- Checks for assignments in subexpressions, such as in String s = Integer.toString(i = 2);. !-->
370 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
371 |         <module name="InnerAssignment">
372 |             <property name="tokens" value="ASSIGN, BAND_ASSIGN, BOR_ASSIGN, BSR_ASSIGN, BXOR_ASSIGN,
373 |                                            DIV_ASSIGN, MINUS_ASSIGN, MOD_ASSIGN, PLUS_ASSIGN, SL_ASSIGN,
374 |                                            SR_ASSIGN, STAR_ASSIGN"/>
375 |         </module>
376 | 
377 |         <!-- Checks that switch statement has "default" clause. !-->
378 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
379 |         <module name="MissingSwitchDefault"/>
380 | 
381 |         <!-- Check for ensuring that for loop control variables are not modified inside the for block. !-->
382 |         <!-- See http://checkstyle.sourceforge.net/config_coding.html#ModifiedControlVariable !-->
383 |         <module name="ModifiedControlVariable"/>
384 | 
385 |         <!-- Disallow assignment of parameters. !-->
386 |         <!-- See http://checkstyle.sf.net/config_coding.html !-->
387 |         <module name="ParameterAssignment"/>
388 | 
389 |         <!-- this got moved here from the import checks !-->
390 |         <!-- Checks for unused import statements. !-->
391 |         <!-- See http://checkstyle.sf.net/config_import.html !-->
392 |         <module name="UnusedImports"/>
393 | 
394 |     </module>
395 | 
396 | 
397 | </module>
398 | 


--------------------------------------------------------------------------------