├── README.md ├── rxjs-docs ├── 2017 │ ├── 2017-10 │ │ ├── .DS_Store │ │ └── october-16.md │ ├── 2017-11 │ │ ├── november-15.md │ │ └── november-29.md │ └── 2017-12 │ │ └── december-13.md ├── 2018 │ ├── 2018-01 │ │ ├── january-10.md │ │ └── january-31.md │ ├── 2018-02 │ │ ├── february-14.md │ │ └── february-28.md │ ├── 2018-03 │ │ ├── march-14.md │ │ └── march-28.md │ ├── 2018-04 │ │ └── april-25.md │ ├── 2018-06 │ │ └── june-6.md │ ├── 2018-07 │ │ └── july-18.md │ └── 2018-08 │ │ └── august-15.md └── .DS_Store └── rxjs ├── 2016 ├── 2016-10 │ ├── october-10.md │ └── october-24.md ├── 2016-11 │ └── november-08.md └── 2016-12 │ ├── december-05.md │ └── december-20.md ├── 2017 ├── 2017-01 │ └── january-30.md ├── 2017-03 │ └── march-27.md ├── 2017-05 │ └── may-08.md ├── 2017-06 │ └── June-21.md ├── 2017-08 │ └── August-28.md ├── 2017-09 │ └── September-11.md ├── 2017-10 │ ├── october-11.md │ └── october-25.md ├── 2017-11 │ └── november-08.md └── 2017-12 │ └── december-6.md └── 2018 ├── 2018-01 └── january-31.md ├── 2018-02 ├── february-14.md └── february-28.md ├── 2018-04 └── april-25.md ├── 2018-06 └── june-6.md ├── 2018-07 └── july-18.md └── 2018-08 └── august-1.md /README.md: -------------------------------------------------------------------------------- 1 | # RxJS Core Meeting Notes 2 | 3 | RxJS Core team meets once every two weeks to discuss the development of RxJS, future plans, and priorities. 4 | 5 | New notes will be added as pull requests so you will be notified of them if you watch the repo. You can comment on the pull requests to discuss the notes, or raise issues if you would like to ask for a clarification. Please direct other support and "how do I?" questions to [StackOverflow](https://www.stackoverflow.com/questions/tagged/rxjs). 6 | 7 | The repo format is inspired by [Ember](https://github.com/emberjs/core-notes) and [React's](https://github.com/reactjs/core-notes) Core Notes. 8 | 9 | :shipit: 10 | -------------------------------------------------------------------------------- /rxjs-docs/.DS_Store: -------------------------------------------------------------------------------- https://raw.githubusercontent.com/ReactiveX/rxjs-core-notes/cefc054d3e26ce6db09252ef425c59dd549eebc3/rxjs-docs/.DS_Store -------------------------------------------------------------------------------- /rxjs-docs/2017/2017-10/.DS_Store: -------------------------------------------------------------------------------- https://raw.githubusercontent.com/ReactiveX/rxjs-core-notes/cefc054d3e26ce6db09252ef425c59dd549eebc3/rxjs-docs/2017/2017-10/.DS_Store -------------------------------------------------------------------------------- /rxjs-docs/2017/2017-10/october-16.md: -------------------------------------------------------------------------------- 1 | # October 16, 2017 Docs Kickoff Meeting 2 | 3 | ### Attendees 4 | 5 | * [@ladyleet](http://github.com/ladyleet) 6 | * [@benlesh](http://github.com/benlesh) 7 | * [@kwonoj](http://github.com/kwonoj) 8 | * [@staltz](http://github.com/staltz) 9 | * [@btroncone](http://github.com/btroncone) 10 | * ~ 18 other community members looking to get involved 11 | 12 | ### Welcome & Ongoing Meetings 13 | 14 | * Discuss ongoing / how to contribute 15 | * Contribute by looking at the issues and submitting PRs! Super easy. 16 | * Create new issues that you feel like will improve the docs. 17 | * Tracy is also available if you need ideas on how to contribute. 18 | * For the first few months - Every other Wednesday at 930am PST. After that, we will move to a monthly meeting. We are very active in github in the issues so feel free to chat. 19 | 20 | ### How Much Do I Have to Commit? 21 | 22 | * As much as you like! Absolutely no obligation to do anything, just do what you can, when you can and we greatly appreciate the help. 23 | 24 | 25 | ### How Are Docs Structured? 26 | 27 | * They are currently a basic Angular CLI app! Latest version of Angular is maintained. 28 | 29 | ### Recent Contributions 30 | 31 | *Brian Troncone 32 | *Descriptions for operators 33 | *made PWA 34 | *John RHGeek 35 | *creating issues for individual operators 36 | *Jen Luker 37 | *Added a11y! 38 | *Philippe Martin 39 | *Travis updates and angular updates 40 | *Andrew Anderson 41 | *Lazy loaded components 42 | *Ashwin 43 | *updated Angular Material for us 44 | 45 | ### Translations 46 | 47 | * How do we create a build process for this. 48 | * What tool should we use? Ngx/Gitlocalize/Pontoon. 49 | * What is the best way to keep things updated. 50 | * During the next meeting, we will bikeshed on this further. 51 | * We *are* looking for a lead to help us figure this out. 52 | 53 | ### Operators 54 | 55 | * Brian Troncone's work so far on operators 56 | * Discuss what else we need 57 | * Real world examples 58 | * Examples in other frameworks 59 | * Visual example 60 | * Architectural use case 61 | * Descriptions 62 | * Use cases 63 | * Edit here interface to allow people to contribute easily. 64 | * Check out this list https://github.com/ReactiveX/rxjs/blob/master/doc/operator-creation.md#submitting-a-pr-for-an-operator 65 | * Another short list of things for each operator: https://github.com/ReactiveX/rxjs/pull/2208#issuecomment-274623556 66 | 67 | 68 | ### Getting Started Guide 69 | * for node users 70 | * for angular users 71 | * for react users 72 | * pre-requisite page? 73 | 74 | ### Visualization 75 | 76 | * RxViz 77 | * RxMarbles 78 | * Rxfiddle.net 79 | 80 | ### Other Things 81 | 82 | * Pages we would like to see 83 | * links to awesome rxjs content 84 | * Real world implementations in different libraries 85 | * Integrating community projects 86 | * Pages on site 87 | * People you can work with - check out interested people and what https://github.com/ReactiveX/rxjs-docs/issues/24 88 | * Slack channel - if you want to be added email me tracy@thisdot.co (unfortunately it's a manual process and will always stay that way) 89 | 90 | 91 | 92 | 93 | -------------------------------------------------------------------------------- /rxjs-docs/2017/2017-11/november-15.md: -------------------------------------------------------------------------------- 1 | # November 15, 2017 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [@ladyleet](http://github.com/ladyleet) 6 | * [@omfgnuts](http://github.com/omfgnuts) 7 | * [@getdanarias](http://github.com/getdanarias) 8 | * [@xlozinguez](http://github.com/xlozinguez) 9 | * [@jasonaden](http://github.com/jasonaden) 10 | 11 | ### Items Discussed 12 | 13 | * Open PRs 14 | * Anyone is able to review PRs without having write access to the repo - and we are greatly looking for folks to contribute more in this area. 15 | 16 | * Translations 17 | * Translations seem to be what people are very excited about with the docs. 18 | * Nik's company Valor has a PR open for using ngx-translate - [#144](https://github.com/ReactiveX/rxjs-docs/pull/144) it's in progress. 19 | * In discussions in with Ben Lesh, agreed that we should just go with the majority from the next meeting, which no one had opinions against ngx-translate. 20 | * Currently proto is only for russian & english - but can add more. 21 | * Stored in TS files - but can move to JSON files if applicable. 22 | * Xavier Lozinguez mentioned he was interested in helping French. 23 | * Dan Arias mentioned he was interested in helping Spanish. 24 | 25 | * Helping with framework content 26 | * Dan Arias is interested in helping create examples around React, Angular, Node 27 | * He is mainly interestd in helping create real world examples with Angular 28 | * Will start creating a getting started guide for Angular 29 | * Jason Aden is working on a getting started with Observables for the RxJS docs too which we may be able to point to. 30 | * Xavier pointed out the stencil docs as great docs to reference. https://stenciljs.com/docs/intro/ & https://stenciljs.com/docs/getting-started 31 | 32 | * Beta launch of site 33 | * Need to discuss with others on beta launch of site 34 | 35 | * Action Items 36 | * Tracy to discuss beta launch of site with others 37 | * Getting ngx-translate to a place of launch -------------------------------------------------------------------------------- /rxjs-docs/2017/2017-11/november-29.md: -------------------------------------------------------------------------------- 1 | # November 29, 2017 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [@ladyleet](http://github.com/ladyleet) 6 | * [@benlesh](http://github.com/benlesh) 7 | * [@kwonoj](http://github.com/kwonoj) 8 | * [@btroncone](http://github.com/btroncone) 9 | * [@only1mranderson](http://github.com/only1mranderson) 10 | * [@ashwin-sureshkumar](http://github.com/ashwin-sureshkumar) 11 | * [@necoline](http://github.com/necoline) 12 | * [@knittingcodemonkey](http://github.com/knittingcodemonkey) 13 | * [@mustafamg](http://github.com/mustafamg) 14 | * [@valorkin](http://github.com/valorkin) 15 | 16 | ### Items Discussed 17 | 18 | * Open PRs 19 | * Everyone has been really active in code reviews and merging PRs, so there are no outstanding ones that need attention! 20 | 21 | * Companies Page 22 | * Andrew Anderson's PR on the company page is just about complete. Discussion on best way to host data and what to do about firebase credentials 23 | * Decision - ad hoc for now until it grows and we decide we need to figure something new out. 24 | 25 | * Translations 26 | * Dmitriy Shekhovtsov spent a bit of time talking through what he feels like we need to do to optimize translations. 27 | * Conclusion: No objections to use ngx-translate and continue down the pending PR with translations. 28 | 29 | * Documentation issues - current docs vs new docs - how to handle? 30 | * Decision: Ad-hoc for now since the # of requests is low. As people create issues on the rxjs repo, Tracy Lee will triage and create issues on rxjs docs or help redirect. 31 | 32 | * Beta launch of site 33 | * Goal is to launch so people feel like they are able to contribute easier and can see the fruits of their labor. 34 | * Brian mentioned there are only about 20% of operators currently documented. 35 | * Decision is that we should not wait until mobile optimization before launch, though it is something we need to address. 36 | * 2 items before launch 37 | * Create a header that explicitly says these docs are beta. 38 | * Have Jen Luker go over the site once again and make sure it is a11y friendly. 39 | * What beta domain do we put it on? 40 | * Can be stand alone for now 41 | * Can either be github pages or firebase 42 | 43 | * Versioning 44 | * Ashwin Sureshkumar brought this up as it is being discussed on github. 45 | * Ashwin to come up with a proposal by next meeting and work with Dmitriy since he has experience doing versioning with ngx-bootstrap. 46 | 47 | * Before final launch of site 48 | * All operators need to be documented 49 | * Jay Phelps's PR related to getting docs out of source code needs to be worked on and merged somehow 50 | * Link to source code needs and docs in source code 51 | * Reconciliation of documentation 52 | * Review and approval of all descriptions, etc from core team 53 | * Getting started guide 54 | 55 | * Mobile Issues 56 | * JSBin not loading properly on mobile 57 | * RxMarbles graphs not pretty on mobile 58 | 59 | * Other Notes 60 | * Please promote the RxJS docs site on social channels so we can get more people contributing to the docs! 61 | * Andrew Anderson said he would work on the companies page. 62 | 63 | * Action Items 64 | * Tracy to discuss beta launch of site with others 65 | * Getting ngx-translate to a place of launch 66 | -------------------------------------------------------------------------------- /rxjs-docs/2017/2017-12/december-13.md: -------------------------------------------------------------------------------- 1 | # December 13, 2017 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Jen Luker](http://github.com/knittingcodemonkey) 7 | * [Ashwin Sureshkumar](http://github.com/ashwin-sureshkumar) 8 | * [Sumit Arora](http://github.com/sumitarora) 9 | 10 | ### Items Discussed 11 | 12 | * Launching of site 13 | * Ready to launch - Ashwin and Sumit to coordinate and hopefully get that beta launch by 12/18/17! (Crossing fingers) 14 | * URL determined: rxjs-beta-docs.firebaseapp.com 15 | * Jen is going through final review today. 16 | 17 | * Open PRs 18 | * We have been asking a lot of people to rebase - but approver/merger can do this with simple one page files so we don't hold up the merge. 19 | 20 | * Master firebase account? 21 | * Tracy to create and provide logins for team. 22 | 23 | * New contributors 24 | * Tracy doing a push once the beta site is launched for new contributors. 25 | * Mentioned that we could use a designer on our team. 26 | 27 | * A11y findings 28 | * Jen is pretty happy she has mainly found a few form fields missing labels & images missing alt tags. 29 | * Main concern was jsbin - getting out of escape key 30 | 31 | * jsdoc integration 32 | * Dmitriy from Valor is working on it 33 | 34 | * Translation PR 35 | * PR still waiting to be completed -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-01/january-10.md: -------------------------------------------------------------------------------- 1 | # January 10, 2018 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ashwin Sureshkumar](http://github.com/ashwin-sureshkumar) 7 | * [Jen Luker](http://github.com/knittingcodemonkey) 8 | * [Brian Troncone](http://github.com/btroncone) 9 | 10 | ### Items Discussed 11 | 12 | * Including Angular & React & other framework examples in docs 13 | * Brian gave update on PR for to include samples for Angular and React 14 | * Agree it is a good thing and will bring in more contributors in different frameworks 15 | 16 | * Misc items & action items 17 | * Followup OJ on Travis 18 | * Firebase unable to deploy - need to figure out firebase apps 19 | * Ping Dmitriy about translate PR and jsdoc PR 20 | * Create your own operator adventure should be kept 21 | * Expand navigation to include intros 22 | * Write contribs should help people rebase if we can to get PRs merged in faster 23 | * We need a UX designer! Ask Dmitriy 24 | * Jen can help with coming from a none rxjs perspective to review some of the docs 25 | * Tracy to add to Companies page 26 | * Some light discuss around versioning 27 | 28 | * Contributors to note - 29 | * Hardik 30 | * Jan Niklas 31 | 32 | * Tracy shard some of the goals for RxJS docs project 2018 and how RxJS learning team could help RxJS in general 33 | * Get the beta version and launch to get more OSS support 34 | * Get more contributors for RxJS docs 35 | * Getting translations done 36 | * JSDOC done 37 | * Monorepo for RxJS - this will happen in 2018 sometime 38 | * Get more contributors for RxJS core 39 | -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-01/january-31.md: -------------------------------------------------------------------------------- 1 | # January 31, 2018 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ben Lesh](http://github.com/benlesh) 7 | * [OJ Kwon](http://github.com/kwonoj) 8 | * [Sumit Arora](http://github.com/arorasumit) 9 | * [Ashwin Sureshkumar](http://github.com/ashwin-sureshkumar) 10 | 11 | ### Items Discussed 12 | 13 | * Tracy to set up the domain for github.io 14 | * Still need to add companies page 15 | 16 | * Ashwin and Sumit have been the most active in approving and reviewing the PRs 17 | * Reviewers should - embedded links in the PR need to have the expected output of the JSBin 18 | 19 | * Discussion about moving all the examples to Stackblitz 20 | * 21 | 22 | * PR from Brian for examples to include Angular, React, etc #210 23 | * Ashwin and Sumit to review and merge 24 | 25 | * Notable contributors 26 | * DiedrikDM 27 | * Jan Niklas has been reviewing PRs - great detail and really helpful 28 | 29 | * PR approvals 30 | * Being a little more lax right now on conventions with RxJS core team process, but 31 | 32 | * Bottlenecks 33 | * 2 PR approval process 34 | 35 | * Hosting website 36 | * Igor Minar from Angular team will facilitate this. Ben will talk to Igor about this. 37 | 38 | * Items 39 | * Ping Jen about adding intros to navigation. 40 | * Create your own operator adventure - move over directly from current docs (this can on the main page). 41 | 42 | * Docs team contributing to RxJS core 43 | * Could be helpful to have PR reviews. 44 | 45 | * Monorepo for RxJS - this will happen in 2018 sometime 46 | * Get more contributors for RxJS core 47 | 48 | * Getting stackblitz to have an Rx playground with no Angular and no React. 49 | 50 | -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-02/february-14.md: -------------------------------------------------------------------------------- 1 | # February 14, 2018 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ben Lesh](http://github.com/benlesh) 7 | * [Sumit Arora](http://github.com/arorasumit) 8 | * [Jen Luker](http://github.com/knittingcodemonkey) 9 | * [Jan-Niklas Wortmann](http://github.com/JWO719) 10 | 11 | ### Items Discussed 12 | 13 | * All examples now done in Stackblitz 14 | * Initial translate PR 15 | * Love to see progress in the next few weeks 16 | * Sumit - asking Brian about github pages 17 | * Jen - homepage - what do we want to bring over to the homepage? 18 | * What else about the docs 19 | * Bring over everything current docs page 20 | * Intro that all examples are on Stackblitz 21 | * Create your own operator adventure - move over directly from current docs (this can on the main page). 22 | * Think Ashwin was working on this? 23 | * Will comment this out until we get it integrated and work with Ashwin on it. 24 | * Getting started guide - someone should start working on it. 25 | * http://reactivex.io/rxjs/manual/overview.html - some of the code is outdated. 26 | * Jen will work on this 27 | * Still need to add companies page 28 | * PR from Brian for examples to include Angular, React, etc #210 29 | * Hold off til Stackblitz implementation 30 | * Jan-Niklas brought up generating docs from source code 31 | * Most problematic currently 32 | * Talk to Jay and Dmitriy about generaing docs from source code 33 | * Jen would like to talk them about it - she has some ideas 34 | * Tracy to talk to Jay about TestScheduler and documentation 35 | * Mikhail design suggestions 36 | * Jan-Niklas created in issues and implemented changes in search bar 37 | * Jen to review the search bar PR 38 | 39 | ### Goals 40 | * Launching the site 41 | * Progress on translate PR 42 | * Deciding on a path for generating docs from source code 43 | -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-02/february-28.md: -------------------------------------------------------------------------------- 1 | # February 28, 2018 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ben Lesh](http://github.com/benlesh) 7 | * [Ashwin Sureshkumar](http://github.com/ashwin-sureshkumar) 8 | * [Mustafa Gamal](http://github.com/mustafamg) 9 | * [Jen Luker](http://github.com/knittingcodemonkey) 10 | * [Jan-Niklas Wortmann](http://github.com/JWO719) 11 | 12 | ### Items Discussed 13 | * Site release! Now can be found at rxjsdocs.com 14 | 15 | * Can we get it stood up really easily? 16 | * Our docs problem is more of a content thing. 17 | * Worth exploring with the Angular team. 18 | * Learning curve and back and forth with Angular team may take more time from what we are doing. 19 | * We could think about forking it. 20 | * Benefits - docs generated from source code & versioning already avail. 21 | * Going through Angular.io docs to go through with Angular team to discuss this with Ben Lesh, Jay Phelps, OJ Kwon. 22 | 23 | * Help - Ben would like help with inline documentation updates with new docs. 24 | 25 | * Real world documentation and other things updating RxJS Docs. 26 | 27 | * Docs focus - generating content. 28 | 29 | * Followup with Dmitriy for initial translate PR 30 | * Followup with Dmitriy on source code generating docs PR 31 | -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-03/march-14.md: -------------------------------------------------------------------------------- 1 | # March 14, 2018 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ben Lesh](http://github.com/benlesh) 7 | * [Ashwin Sureshkumar](http://github.com/ashwin-sureshkumar) 8 | * [Pete Bacon Darwin](http://github.com/petebacondarwin) 9 | * [Brian Troncone](http://github.com/btroncone) 10 | * [Jan-Niklas Wortmann](http://github.com/JWO719) 11 | 12 | ### Items Discussed 13 | 14 | * How big will the updates for the RxJS 6 documentation and what are current efforts around it? 15 | * Need documenation on how to migrate to RxJS6 - Jason Aiden from Angular team is working on it. 16 | * Need to update examples to not use the old global. 17 | 18 | * What is the timeline for the POC for Angular.io? 19 | * Pete pulled all the documentation out of the code files and we need to go through and update it. 20 | * We can release the POC on the internet now. 21 | * Fix the POC - take all the static content and change the branding from it. 22 | * We should integrate Stackblitz with Pete's stuff. 23 | * Think about how to integrate real world examples or other examples we would like to have. 24 | * For Angular they create full fledged examples in the source code and they automatically turn them into stackblitz links. 25 | * Current POC is on the Angular repo. 26 | * We're going to need to migrate all the infrastructure from the Angular repo POC to a new repo. 27 | 28 | ### Action Items for New RxJS Docs 29 | 1. Migrate all the infrastructure from the Angular repo POC to a new repo. 30 | 2. Fix all the Angular branding from POC to remove. 31 | 3. Updating all examples for current RxJS docs with the new documentation we have in the beta RxJS docs. 32 | 4. Move introduction items or static content over. 33 | 5. Contributing to the documentation application & contributing documentation. 34 | 6. Release the new docs. 35 | 36 | ### Other Items 37 | * Need to update examples to not use the old global. 38 | * Let's not hinder any PRs coming in from the RxJS beta docs. 39 | -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-03/march-28.md: -------------------------------------------------------------------------------- 1 | # March 28, 2018 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ashwin Sureshkumar](http://github.com/ashwin-sureshkumar) 7 | * [Jen Luker](http://github.com/knittingcodemonkey) 8 | * [Diedrik De Mits](http://github.com/diedrikdm) 9 | 10 | ### Items Discussed 11 | 12 | Ashwin got POC done on local - Ashwin writing up a proposal - spoke with Pete to change a few things - then sent it over to Ben. Trying to get approval to proceed. 13 | -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-04/april-25.md: -------------------------------------------------------------------------------- 1 | # April 25, 2018 Docs Meeting 2 | 3 | ### Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ben Lesh](http://github.com/benlesh) 7 | * [Jan Niklass-Wortmann](http://github.com/JWO719) 8 | 9 | ### Items Discussed 10 | 11 | * 23 PRs outstanding - Jan will look at them and we will ask team to look at them too. 12 | 13 | * Need to port everything from rxjsdocs.com over to the new dgeni site. 14 | 15 | * How do we handle Ng references in code? Naming conventions for variables and things - does it really matter for our first draft? 16 | 17 | * Ben mentioned the most important thing is ng references on site - references in code is okay. 18 | 19 | * Reviewing new dgeni docs site - Sumit is currently working on something but we could probably releasing it as a beta soon. We should get an update from Sumit. 20 | 21 | * Jan-Niklas and Ben discussed footer and licensing for dgeni docs. 22 | 23 | ### Left To Launch New Dgeni First Release 24 | 25 | * Remove everything Angular related on the site 26 | 27 | * Remove feature site (needs to be rewritten) 28 | 29 | * Figure out where we are going to host it 30 | 31 | ### To Do For Site 32 | 33 | * Port over everything from rxjsdocs.com currently 34 | 35 | * Improve resources page for new dgeni site - or remove for now and improve it later on. 36 | -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-06/june-6.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes June 6, 2018 2 | 3 | ## Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ben Lesh](https://github.com/benlesh) 7 | * [Jan Niklass-Wortmann](http://github.com/JWO719) 8 | * [Ashwin Sureshkumar](http://github.com/ashwin-sureshkumar) 9 | 10 | ## Discussed 11 | 12 | * PRIORITY: Code of conduct on docs 13 | 14 | * PRIORITY: Get docs automatically publishing whenever we publish the releases 15 | 16 | * Merge core team and this group into one group to combine conversations since the docs are now a part of the core repository. 17 | 18 | * Content migration needs to happen 19 | * API docs need to be updated - we need to make sure they are short and sweet and have the code examples 20 | * Getting started guides and code examples or fundamentals we also need to migrate over and start adding new content. 21 | 22 | -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-07/july-18.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes July 18, 2018 2 | 3 | ## Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Jan Niklass-Wortmann](http://github.com/JWO719) 7 | 8 | ## Discussed 9 | 10 | * Acknowledgements 11 | * Jan-Niklas has been leading most of the docs initiative - thank you!! 12 | * Matt Yao has been helping out a lot! Thank you Matt! 13 | * Martin Sikora made a really great PR - thank you Martin! 14 | 15 | * Docs reconciliation 16 | * We should close the old RxJS docs repo soon or make it read only after reconciliation 17 | * Need the "choose your operator" functionality back 18 | * Still need to reconcile from all other docs - Jan-Niklas and Tracy will create a screencast so folks can help contribute to this. 19 | 20 | * Travis builds have been failing - speak to OJ about this during core meeting 21 | 22 | * Google Analytics issue from Stephen Fluin - we should fix that for the docs firebase app. 23 | 24 | * Taking off beta 25 | * Jan-Niklas brought up that we should take URL changes very seriously and SEO implications before we think about removing the beta. 26 | * After speaking with Ben about this he just wants to remove and doesn't think any of this will be affected. 27 | -------------------------------------------------------------------------------- /rxjs-docs/2018/2018-08/august-15.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes August 15, 2018 2 | 3 | ## Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Jan Niklass-Wortmann](http://github.com/JWO719) 7 | * [Matt Yao](http://github.com/mattyao1984) 8 | * [Rob Simpson](http://github.com/pertrai1) 9 | 10 | ## Discussed 11 | 12 | * Docs reconciliation 13 | * Jan-Niklas and Tracy just recorded a video on how to do the docs migration from rxjs-docs to rxjs 14 | 15 | * Improvements to docs 16 | * Adding stackblitz examples intead of markdown 17 | * Need the "choose your operator" functionality back - we want to make it dynamic but right now we will make it static html - Matt said he would be able to help 18 | * RxJS tutorials or advice? What do we want to cover in some of these static tutorials? 19 | * Maybe a tour of heroes tutorial on how to deal with RxJS? 20 | * Migrate and update this? http://reactivex.io/learnrx/ 21 | * Static content for advice like 22 | * testing 23 | * multicasting 24 | 25 | * How to proceed with old docs 26 | * Remove old docs from rxjs repo - chat with Ben about it 27 | -------------------------------------------------------------------------------- /rxjs/2016/2016-10/october-10.md: -------------------------------------------------------------------------------- 1 | # October 10 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/1)) 2 | 3 | ## v5 RC1 4 | 5 | * Are we ready? 6 | * What's blocking? 7 | 8 | #### Decisions 9 | 10 | Need to remove `.cache()` operator because it tried to solve everyone's usecases without solving any of them. Need to stop publishing `rxjs-es` and not include ES6 builds in `@reactivex/rxjs`. 11 | 12 | Update: v5.0.0-rc1 was released! 13 | 14 | 15 | ## Official stance/process on adding new operators [#1950](https://github.com/ReactiveX/rxjs/pull/1950) [#1928](https://github.com/ReactiveX/rxjs/pull/1928) 16 | 17 | * Should we make a "kitchen sink" addon? 18 | * Should we slim down existing operators even further? 19 | * Is this a filesize problem, a documentation presentation problem, both? 20 | 21 | #### Decisions 22 | 23 | A large chunk of our users don't use operator patching; some for technical reasons and others out of convenience. We want to have the core RxJS you `import Rx from 'rxjs';` be small--smaller than it is today even. That means removing some operators like possibly `.every()`, `.reduce()`, etc. Keep the core limited to operators which are very common (like `.map()`) or fairly common and non-trivial to implement for Rx beginners. 24 | 25 | However, there are many operators that people would like, even if their usage isn't as common. We want to have some answer to this, likely involving some form of addons. One way is to put them all into "kitchen-sink" addon. There are concerns around bloating node_modules file size for Electron users who commonly don't do operator patching or even bundling. 26 | 27 | For now, the status quo will be that we'll not be accepting any new operators for v5, at least as a general rule. Before v5.0.0-final, we may remove some operators we feel do not belong in core and bring them back in some future addon. If we do remove any, we will now try to include a code snippet in the CHANGELOG showing how you can easily recreate the same behavior. 28 | 29 | We want to focus as much as possible on shipping a stable v5.0.0-final ASAP, which means keeping our limited resources as undivided as possible. If you're interested in spearheading the kitchen-sink/addon effort now, please reach out. 30 | 31 | ## Productizing the TestScheduler [#1775](https://github.com/ReactiveX/rxjs/issues/1775) 32 | 33 | * reducing boilerplate for creating TestScheduler instance w/ helpers like `createHotObservable()` because verbose vs just `hot()` 34 | * Automatically injecting the TestScheduler into pre-existing observable chains. e.g. `delay(1000)` ideally shouldn't require the user to write injection logic. 35 | * How we do we let users provide their equality checking logic from their test runner? 36 | * Is this worth blocking a v5 release? 37 | 38 | #### Decisions 39 | 40 | Mocking `AsapScheduler` with `TestScheduler` would produce different behavior in some cases. Very few people use schedulers other than when the `AsyncScheduler` is implicitly added by default for time-based operators. We need to do more experimenting and discussing if it's feasible to have a test scheduler that keeps the behavior of the scheduler it's mocking, except controlling virtual time. e.g. `AsapScheduler`, `AnimationFrameScheduler`, `QueueScheduler`. 41 | 42 | Still create `TestScheduler.run(({ cold, hot }) => {})` helper which creates instance, injects scheduler to mock `AsyncScheduler` and additional boilerplate. 43 | 44 | This work will likely collide with work @blesh is doing with refactoring some error handling out of operators and into the schedulers. 45 | 46 | Assigned: @jayphelps 47 | 48 | ## Stop publishing rxjs-es. Move ES6 build to output .mjs files alongside the CJS .js files. [#1671](https://github.com/ReactiveX/rxjs/issues/1671) 49 | # ES5 code w/ ES Modules [#1925](https://github.com/ReactiveX/rxjs/issues/1925) 50 | 51 | I don't believe we're still planning to do .mjs files, not sure what the .mjs status is in the node community. 52 | 53 | Side note, if we stop building pure ES6, there has been some community concern we won't be publishing ES6 code on the documentation website http://reactivex.io/rxjs/source.html which is easier to read cause it doesn't have all the TypeScript generics and such. 54 | 55 | #### Decisions 56 | 57 | Stop publishing rxjs-es and any ES6 or ES Module builds at all. Focus efforts on shipping 5.0.0-final and then we can add ES Module builds later, since additive things are not breaking changes. 58 | 59 | Continue building ES6 code for ESDocs generation only--that means users will not ever be able to depend on this, it's simply because there is no good TypeScript equivalent for ESDoc at the moment. 60 | 61 | Assigned: @blesh 62 | 63 | ## Adopting TypeScript 2.0 [#1968](https://github.com/ReactiveX/rxjs/pull/1968) [#1978](https://github.com/ReactiveX/rxjs/pull/1978) 64 | 65 | * When should we adopt? 66 | * Expected backlash? 67 | * Would allow us to do ES5 code w/ ES Modules [#1925](https://github.com/ReactiveX/rxjs/issues/1925) [#1671](https://github.com/ReactiveX/rxjs/issues/1671) in the future 68 | 69 | #### Decisions 70 | 71 | Confirmed, we have upgrade to TypeScript 2.0. Angular2 users by far make up a majority of our TypeScript userbase and the trend is a quick migration to 2.0. 72 | 73 | 74 | ## Operators that are reserved words requiring _underscore convention [#1958](https://github.com/ReactiveX/rxjs/issues/1958) 75 | 76 | Some operator names are reserved words, which require us to prefix them with an _underscore so that they can be imported directly. Should we rename them or is the _underscore pattern acceptable? How are we currently documenting these exceptional uses? 77 | 78 | * catch 79 | * switch 80 | * do 81 | * finally 82 | * let 83 | * throw 84 | 85 | #### Decisions 86 | 87 | Leave unchanged for v5, revisit for in the future v6, etc. based on more user feedback. 88 | 89 | ## Publishing meeting notes 90 | 91 | * Is this something we should do? 92 | * Who will record and publish them? 93 | * What process to add agenda items? 94 | 95 | #### Decisions 96 | 97 | Let's do it! (obviously, you're reading this) 98 | 99 | If you have something to add for the agenda, for now, just bug @jayphelps. We're going to shake out this process for a couple iterations to figure out what works. 100 | 101 | Assigned: @jayphelps 102 | 103 | :shipit: 104 | -------------------------------------------------------------------------------- /rxjs/2016/2016-10/october-24.md: -------------------------------------------------------------------------------- 1 | # October 24 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/2)) 2 | 3 | ## Attendees 4 | 5 | * @kwonoj 6 | * @blesh 7 | * @jayphelps 8 | 9 | ## Outstanding PRs 10 | 11 | * [#2025](https://github.com/ReactiveX/rxjs/pull/2025), [#2039](https://github.com/ReactiveX/rxjs/pull/2039), [#2042](https://github.com/ReactiveX/rxjs/pull/2042), [#2046](https://github.com/ReactiveX/rxjs/pull/2046), [#2050](https://github.com/ReactiveX/rxjs/pull/2050) 12 | * Merge them. Assigned @jayphelps 13 | * [#2049](https://github.com/ReactiveX/rxjs/pull/2049) 14 | * Needs updated jsdocs to no longer reference `compare` argument. Assigned @blesh 15 | * [#1950](https://github.com/ReactiveX/rxjs/pull/1950), [#2051](https://github.com/ReactiveX/rxjs/pull/2051) 16 | * `.some()` and `.toSet()` operators. We don't believe these belong in core at this time. We will continue to consider removing `.every()`, `.reduce()`, and maybe others from core--possibly move them into an addon at a later date. More info about our thoughts on adding new operators [found here](https://github.com/ReactiveX/rxjs-core-notes/blob/32ea3f8e3488c38b4498492ba442efaf93667c7a/2016-10/october-10.md#official-stanceprocess-on-adding-new-operators-1950-1928). We want to focus on shipping v5.0.0-final ASAP for now. Will investigate how common these other similar operators are used in real world code to inform our decision on whether to remove them or not. 17 | * Discuss with PR owners if they'd like to keep the PRs open until then and/or help with the efforts to support some form of kitchen-sink addon--possibly still included in the `rxjs` npm module, but not imported by default. Assigned: @jayphelps 18 | * [#2057](https://github.com/ReactiveX/rxjs/pull/2057) 19 | * We absolutely need a more clear MIGRATION guide that also provides solutions to operators that existed in v4 but not v5. Assigned: @jayphelps, help wanted too. 20 | * [#2024](https://github.com/ReactiveX/rxjs/pull/2024) 21 | * We don't have consensus on the linting preferences this PR imposes. We agreed to keep the status quo for now. There are also possible concerns about this actually increasing inconsistency between public and private function parameters. 22 | * [#1852](https://github.com/ReactiveX/rxjs/pull/1852) 23 | * We think adding a `removeEventListener()` mock to [.markdown-doctest-setup.js](https://github.com/ReactiveX/rxjs/blob/fee7585b4d2ed786065a40e580b862bfd9211281/.markdown-doctest-setup.js#L26) will let the testing of the markdown examples correctly pass. Need to sync up with PR owner to suggest solution. Assigned @jayphelps 24 | 25 | :shipit: 26 | -------------------------------------------------------------------------------- /rxjs/2016/2016-11/november-08.md: -------------------------------------------------------------------------------- 1 | # November 8 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/4)) 2 | 3 | ### Attendees 4 | 5 | * [@kwonoj](https://github.com/kwonoj) 6 | * [@blesh](https://github.com/blesh) 7 | * [@mattpodwysocki](https://github.com/mattpodwysocki) 8 | * [@jayphelps](https://github.com/jayphelps]) 9 | 10 | ## TypeScript is forcing users to install types for chai, etc [#2112](https://github.com/ReactiveX/rxjs/issues/2112) 11 | 12 | A TypeScript compiler bug is forcing RxJS TS users to install `chai` and any other dev dependency we use internally, when using the `@types` definitions. This is a known bug and fixed in [#11849](https://github.com/Microsoft/TypeScript/issues/11849) which should land in v2.1 of tsc. 13 | 14 | #### Decisions 15 | 16 | There is [a PR that solves this](https://github.com/ReactiveX/rxjs/pull/2113) by using the latest dev build of tsc, but we do not feel comfortable building an RxJS release with an unstable version of tsc. 17 | 18 | We will try to get more insight into when v2.1 will be released with the fix upstream and if not within the next two weeks we will downgrade our type definition usage to use `@typings` instead of `@types`. 19 | 20 | Users who want to work around this today can install the type definition for chai in their app: 21 | 22 | ``` 23 | npm install --save-dev @types/chai 24 | ``` 25 | 26 | ## API docs are broken [#2111](https://github.com/ReactiveX/rxjs/issues/2111) 27 | 28 | Our docs are broken due to two issues: 29 | 30 | * We accidentally didn't build the CJS version during doc generation, which is currently used for esdocs 31 | * Many of the JSDoc signatures were not placed next to the signatures themselves, which prevents ESDoc from picking them up correctly 32 | 33 | #### Decisions 34 | 35 | Andre's PR [#2118](https://github.com/ReactiveX/rxjs/pull/2118) looks good, needs final review, merge and republishing of docs. 36 | 37 | ## Dynamic operator invoking helper aka .operate() [#2036](https://github.com/ReactiveX/rxjs/pull/2036) 38 | 39 | #### Decisions 40 | 41 | Lack of type safety to any currently feasible solution makes this unattractive, even though existing solutions library authors use like `source.call(operator)` are unsafe as well. 42 | 43 | No solid consensus yet, need more input from library authors whether this is truly desired or not. Punting for now. 44 | 45 | ## Internal: lint changes [#2104](https://github.com/ReactiveX/rxjs/pull/2104) [#2103](https://github.com/ReactiveX/rxjs/pull/2103) 46 | 47 | Add several linting options to TSC compiler, instead of doing them at commit-time with tslint. 48 | 49 | #### Decisions 50 | 51 | * [#2104](https://github.com/ReactiveX/rxjs/pull/2104) `--noUnusedLocals` is not desirable for us currently, because it can disrupt debugging when sometimes you're commenting out things or temporarily have used code while you fix things. If we made it a warning only, we'd still need to use tslint to prevent it from being committed. We may reconsider later, but for now we'd like to keep the status quo. 52 | * [#2103](https://github.com/ReactiveX/rxjs/pull/2103) `--noImplicitThis` adds value to certain places where it is indeed confusing what `this` currently is because of dynamic invocations, mostly around schedulers. We think this adds notable value while not significantly impeding debugging. Merge. 53 | 54 | ## Internal: random Yarn lockfile updates 55 | 56 | Since switching to yarn for internal RxJS usage, we haven't yet experienced any performance wins and appear to have random lockfile changes when contributors `yarn install`. 57 | 58 | Initial investigation into this suggests our travis config isn't correct to provide caching, which is likely fixable, but the lockfile random changes eludes us and so yarn is currently causing more problems than it's providing. tl;dr even though our package.json has `"typescript": "^2.0.6"` and our lockfile has `typescript@2.0.6`, doing a `yarn install` is bumping us up to `2.0.7` and updating the lockfile with this change. This seems counter to our understanding and initial discussions with James Kyle of yarn team suggests this isn't expected. 59 | 60 | #### Decisions 61 | 62 | Since we're very focused on shipping v5-final, and none of us are very confident in their understanding of how we're supposed to reliably use yarn, it was decided to switch back to using npm until a later date. 63 | 64 | :shipit: 65 | -------------------------------------------------------------------------------- /rxjs/2016/2016-12/december-05.md: -------------------------------------------------------------------------------- 1 | # December 5th, 2016 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/5)) 2 | 3 | ### Attendees 4 | 5 | * [@blesh](https://github.com/blesh) 6 | * [@jayphelps](https://github.com/jayphelps]) 7 | * [@kwonoj](https://github.com/kwonoj) 8 | * [@mattpodwysocki](https://github.com/mattpodwysocki) 9 | * [@staltz](https://github.com/staltz]) 10 | * [@trxcllnt](https://github.com/trxcllnt]) 11 | 12 | ## v5.0.0-final Timeline 13 | 14 | Are we ready for v5.0.0-final? What are the blockers? 15 | 16 | #### Decisions 17 | 18 | We realize v5 has been in alpha/beta/rc for an unusually long amount of time. There are many reasons for this: v5 was a complete rewrite and as such we needed to shake out regressions, we changed the API in certain ways that we needed real-world feedback on to commit to, and in general there was a fear of locking into a major version would prevent us from releasing breaking changes that were necessary. In fact, v5 from a runtime stability prospective has been very _stable_ for almost a year. We have taken the learnings from this experience and unanimously agreed to start shipping major versions at a much more frequent interval to better signal true stability of both the code and the API surface. 19 | 20 | We decided to ship v5.0.0-final one week from today, December 12th. We are in a code freeze, except for critical fixes that we all agree should ship for v5. The known list of those are these: 21 | 22 | ###### Blockers 23 | 24 | * Typings for filter, find, first, last are incorrect, need to choose one of these: [#2170](https://github.com/ReactiveX/rxjs/pull/2170), [#2164](https://github.com/ReactiveX/rxjs/pull/2164) 25 | * Customizing TimeoutError for `.timeout()` operator [is confusing](https://github.com/ReactiveX/rxjs/pull/2141), remove ability to customize the timeout message at all. Can revisit for v6 and beyond. Assigned: @blesh 26 | * [Better error messages](https://github.com/ReactiveX/rxjs/pull/2152) for returning non-consumable objects/undefined/null in things like `mergeMap` projection. We all agree to merge. Assigned: @blesh 27 | * Extending Observable still doesn't lift correctly in all cases, mostly static operators. Paul would like an opportunity to fix this before we ship, but we're on a tight schedule so it will depend on what he comes up with. Related: [#1876](https://github.com/ReactiveX/rxjs/issues/1876), [#1829](https://github.com/ReactiveX/rxjs/issues/1829). Assigned: @trxcllnt 28 | 29 | ## takeUntil does not stop taking when notifier complete()s [#2160](https://github.com/ReactiveX/rxjs/issues/2160) 30 | 31 | 32 | ```js 33 | const onDestroy$: Subject = new Subject(); 34 | 35 | Rx.Observable.interval() 36 | .takeUntil(onDestroy$) 37 | .subscribe(console.log, undefined, () => console.log("complete")); 38 | 39 | setTimeout(() => { 40 | onDestroy$.complete(); 41 | // doesn't cause the interval to stop. takeUntil only stops for `.next()`, not `.complete()` 42 | }, 5000); 43 | ``` 44 | 45 | #### Decisions 46 | 47 | This is as designed, and mirrors what Rx.NET and RxJS v4 did. Some believe it _should_ terminate when notifier complete()s (RxJava does), but we want to keep the status quo for now. 48 | 49 | ## Subscribing to multicast streams without an error handler can prevent subsequent subscribers from receiving errors [#2145](https://github.com/ReactiveX/rxjs/issues/2145) 50 | 51 | ```js 52 | 53 | var observable = Rx.Observable.interval(200).do(function(i) { 54 | if (i === 2) { 55 | throw 'some error'; 56 | } 57 | }).share(); 58 | 59 | // This subscriber cares about errors and gets them 60 | observable.subscribe(function(res) { 61 | console.log("first subscriber, next " + res); 62 | }, function(err) { 63 | console.log("first subscriber, error " + err); 64 | }); 65 | 66 | // This subscriber does not care about errors 67 | observable.subscribe(function(res) { 68 | console.log("second subscriber, next " + res); 69 | }); 70 | 71 | // This subscriber cares about errors, but never gets them 72 | // because the second subscriber did not handle them 73 | observable.subscribe(function(res) { 74 | console.log("third subscriber, next " + res); 75 | }, function(err) { 76 | console.log("third subscriber, error " + err); 77 | }); 78 | ``` 79 | 80 | #### Decisions 81 | 82 | This is the same behavior as v4. This exact topic is already being considered by TC39 for the [Observable spec](https://github.com/tc39/proposal-observable) because of DOM event handler streams are multicast. 83 | 84 | Instead of guessing what TC39 might decide, we're going to keep the status quo because v4 handles it this way as well and the solutions are rather involved and highly likely we'll not align with the TC39. We should have a better idea of what TC39 wants to do soon. 85 | 86 | :shipit: 87 | -------------------------------------------------------------------------------- /rxjs/2016/2016-12/december-20.md: -------------------------------------------------------------------------------- 1 | # December 20th, 2016 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/6)) 2 | 3 | ### Attendees 4 | 5 | * [@blesh](https://github.com/blesh) 6 | * [@jayphelps](https://github.com/jayphelps]) 7 | * [@mattpodwysocki](https://github.com/mattpodwysocki) 8 | 9 | ## Branching Strategy 10 | 11 | We originally were thinking of having three branches: **master**, **minor**, **patch**, but after discussing decided on two branches: **master** and **next** 12 | 13 | - **master**: anything that can be released in a minor/patch bump, but no breaking changes. Most PRs will be merged into here. 14 | - **next**: everything from **master** (except incompatible changes) and breaking changes or major rewrites. This branch tracks the next major release, e.g. 6.0. We will manually rebase **master** into here, before every breaking change PR merge. 15 | 16 | ## VirtualTimeScheduler API additions 17 | 18 | @mattpodwysocki would like to add the ability to manually control the passing of relative time with the VirtualTimeScheduler, similar to RxJS v4 was able to do. e.g. `scheduler.advanceBy(2000)` 19 | 20 | #### Decisions 21 | 22 | @mattpodwysocki will champion a proposal in collaboration with @trxcllnt. 23 | 24 | ## Error trapping 25 | 26 | In cases of multicast, lack of error trapping can cause very undesired behavior for users when a synchronous observer fails. Error trapping is the proposed solution, and the [same behavior that Promises have](https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Promise.jsm/Examples#The_case_of_unhandled_rejections)--exceptions in one observer do not prevent other observers from receiving synchronous values. This is being discussed in TC39 Observable spec and the word on the street is that native Observables will likely ship _with_ error trapping. For Observables, it becomes even more important that Promises because of the plans for browsers to support observable event listeners--similar to `Observable.fromEvent(el, 'name')` is multicast, so errors in one subscribers should not prevent any others from receiving them! 27 | 28 | Just like with Promises, this is a hot topic of debate because using error trapping means that the exception is "silently swallowed" from the normal propagation of JS exceptions--however, the HTML spec added an `unhandledrejection` event on the `window` object that can be used to listen for and report swallowed errors. Google Chrome still reports these errors in the console, to aid in debugging. 29 | 30 | This is a rather confusing problem, so don't be surprised if it seems unclear (or even stupid why we would want this). For a better understanding, see existing discussions on Promise unhandled rejections in the community at large aka Google. 31 | 32 | #### Decisions 33 | 34 | We will continue to receive guidance from TC39, but we feel strongly they will move to adopt error trapping (like Promises) so we may look to changing this for v6 or v7. We would still provide a similar mechanism to `unhandledrejection` events as well as still still having the error show up in the console for debugging. 35 | 36 | ## Failure handling operators 37 | 38 | Unrelated to the error trapping behavior described above, we discussed the potential for supporting other error handling strategies. The [failsafe](https://github.com/jhalterman/failsafe) library for Java has a lot of inspiration for us to look towards. 39 | 40 | There are many policies, max retries, jitter, circuit breakers, etc. Many of them are very non-trivial for most people to correctly implement on their own, like exponential backoff. 41 | 42 | #### Decisions 43 | 44 | @mattpodwysocki will continue researching this. We might consider supporting a generic "retry policy" API (like failsafe) but not including the policies themselves in core, instead in an companion library. We're not yet ready to commit to anything. 45 | 46 | ## Documentation 47 | 48 | Anyone have suggested strategies to bring it all up to date and keep it that way? 49 | 50 | #### Decisions 51 | 52 | We will commit to enforcing that any new features must be documented. To entice contributors to document existing APIs will be considering some rewards. 53 | 54 | ## Review PRs/Issues 55 | 56 | * We're looking into adding static versions of mergeAll/concatAll/etc operators 57 | * Fix groupBy to dispose of outer subscription [#2201](https://github.com/ReactiveX/rxjs/pull/2201) 58 | * We're not confident to merge this without a test. Assigned: @blesh 59 | * Join pattern operators like join/groupJoin/when/etc [#2194](https://github.com/ReactiveX/rxjs/pull/2194) 60 | * Aren't frequently used, but are hard to implement for users. Growing number of node.js users of RxJS means we'll consider including them but want to release them together. 61 | * Cancel scheduled timeout work, if no longer needed [#2135](https://github.com/ReactiveX/rxjs/pull/2135) 62 | * Needs comments on why we're using lift this way, also remove npm script changes. Assigned: @jayphelps 63 | 64 | :shipit: 65 | -------------------------------------------------------------------------------- /rxjs/2017/2017-01/january-30.md: -------------------------------------------------------------------------------- 1 | # January 30th, 2017 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/8)) 2 | 3 | ### Attendees 4 | 5 | * [@blesh](https://github.com/blesh) 6 | * [@david-driscoll](https://github.com/david-driscoll) 7 | * [@jayphelps](https://github.com/jayphelps) 8 | * [@kwonoj](https://github.com/kwonoj) 9 | * [@mattpodwysocki](https://github.com/mattpodwysocki) 10 | * [@staltz](https://github.com/staltz) 11 | 12 | ## TS 2.1 custom Error objects [#2190](https://github.com/ReactiveX/rxjs/pull/2190) 13 | 14 | TypeScript 2.1 changed transpiled output in way that makes extending the native `Error` object no longer work. We have a proposed solution, but mostly untested. 15 | 16 | #### Decisions 17 | 18 | Punt and work with ng2 team towards the same solution, since they have the problem too. 19 | 20 | ## Inject tslib functions [#2121](https://github.com/ReactiveX/rxjs/pull/2121) 21 | 22 | We don't currently have anything that outright tests that our global UMD build works as expected--this is actually mostly the normal in OSS, very few projects that publish global builds actually test those builds themselves in an automated fashion, they usually run their tests against their CJS or ES modules. 23 | 24 | That said, merging this wouldn't change that fact and we can try the build by hand before we publish. 25 | 26 | #### Decisions 27 | 28 | Merge. 29 | 30 | ## fix(buffer): Emit last buffer if source completes [#2174](https://github.com/ReactiveX/rxjs/pull/2174) 31 | 32 | #### Decisions 33 | 34 | Looks good, but even though we didn't intend for the existing behavior, since we shipped it people could be relying on it. 35 | 36 | Merge into next major release, not minor because it is a BREAKING CHANGE. 37 | 38 | ## feat(windowTime): maxWindowSize parameter in windowTime operator [#2187](https://github.com/ReactiveX/rxjs/pull/2187) 39 | 40 | #### Decisions 41 | 42 | @jayphelps will fix reentry issues, then we can merge into master. 43 | 44 | ## fix(buffer): subscribe to source and closingNotifier in proper order [#2195](https://github.com/ReactiveX/rxjs/pull/2195) 45 | 46 | #### Decisions 47 | 48 | Needs another review, is BREAKING ChANGE, so would be major version 49 | 50 | 51 | ## feat(takeUntil): change behavior of takeUntil to not subscribe to source if notifier is synchronous [#2189](https://github.com/ReactiveX/rxjs/pull/2189) 52 | 53 | This one is hotly debated. It's one of those that could go either way depending on your use case. This would be a breaking change, so major version. All of the arguments discussed were rehashes of the discussion in the PR thread. 54 | 55 | #### Decisions 56 | 57 | If most of us don't agree on it, we don't want to make the change. @trxcllnt, the PR author and core team member, was not in attendance so we want to give him an opportunity to champion the argument further at a future meeting. 58 | 59 | ## test(filter): enable type inference to marble diagram [#2202](https://github.com/ReactiveX/rxjs/pull/2202) 60 | 61 | While the solution itself isn't ideal, we're mostly OK with it since no other viable solution is known. There is concern that we will forget about it and remove/reformat the lines later and unknowingly break it. 62 | 63 | #### Decisions 64 | 65 | OJ will look into some way to detect/prevent us from later accidentally removing/reformatting these import lines. 66 | 67 | ## .op() helper [#2034](https://github.com/ReactiveX/rxjs/pull/2034) 68 | 69 | Generally everyone agreed we need something like this. There was a debate about whether or not we could have the `.let()` operator imported by default and just have people use that: 70 | 71 | ```js 72 | source 73 | .let(s => filter.call(s, x => x > 1)) 74 | .let(s => map.call(s, x => x + 10)) 75 | 76 | // vs. 77 | 78 | source 79 | .op(filter, x => x > 1) 80 | .op(map, x => x + 10) 81 | ``` 82 | 83 | `.let()` does not have operator type safety, whereas we _can_ add safety for `.op()` (thought the PR doesn't currently have the overload signatures yet) 84 | 85 | #### Decisions 86 | 87 | We think the terseness of `.op()` combined with the planned type safety additions are enough to justify adding. 88 | 89 | @jayphelps will add type signature overloads for all operator patching files, so that `.op()` is type-safe. When that's ready, we'll merge. 90 | 91 | ## feat(Zone): add support for Zone.js [#2266](https://github.com/ReactiveX/rxjs/pull/2266) 92 | 93 | This isn't really _support_ for Zones, it's more adding a different behavior about what zone you subscribe in vs. declare your observable chain in. The problem and justifications are quite complex, see the ticket for full details. 94 | 95 | All of us would prefer it if we could provide a patching module, e.g. `rxjs/add/zones` that would monkey patch the necessary changes instead of baking them in by default. 96 | 97 | #### Decisions 98 | 99 | We need to test the performance difference between the three: 100 | 101 | * Current (no extra zones stuff) 102 | * Using monkey patching (`rxjs/add/zones`) 103 | * Merged into core itself 104 | 105 | Need to continue working closely with the Angular team. 106 | 107 | ## Template for creating new operators [#2299](https://github.com/ReactiveX/rxjs/issues/2299) 108 | 109 | Adding new operators to core is not a trivial process. There's a ton of bikeshedding that needs to go on, and for good reasons. We want to make that process more clear and have the discussions early on before wasted code is written. 110 | 111 | #### Decisions 112 | 113 | @mattpodwysocki will create the initial document 114 | 115 | :shipit: 116 | -------------------------------------------------------------------------------- /rxjs/2017/2017-03/march-27.md: -------------------------------------------------------------------------------- 1 | # March 29th, 2017 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/8)) 2 | 3 | ### Attendees 4 | 5 | * [@blesh](https://github.com/blesh) 6 | * [@kwonoj](https://github.com/kwonoj) 7 | 8 | 9 | ## Splitting DOM Observables off 10 | 11 | - @benlesh discussed possibly splitting the Http/AJAX observable stuff out of Angular/http 12 | and using it as the official HTTP/AJAX implementation for RxJS and Angular as well. 13 | Needs follow up with @robwormald and @igorminar 14 | 15 | ## Zones PR (#2266)[https://github.com/ReactiveX/rxjs/pull/2266] 16 | 17 | - Still need benchmarks around each approach. Once we have the numbers, we can merge one of the methods of adding Zones 18 | 19 | ## Pipe PR (#2486)[https://github.com/ReactiveX/rxjs/pull/2489] 20 | 21 | - No real opinion. Lose type inference 22 | 23 | ## Next major release 24 | 25 | - Want to only introduce one or two small breaking changes at a time, possibly on a two month cadence. 26 | - Need to align with major customers like Angular. 27 | 28 | ## Publishing ES6 Module 29 | 30 | - Angular team needs this. 31 | - Can we reuse the ES6 build that exists for the doc gen? 32 | - Can we ship both inside of CJS modules directories: @benlesh and @kwonoj are opposed to this idea. 33 | - This will hurt Electron users. 34 | - the `@reactivex/rxjs` build has all possible builds in it, so we don't really need to ship this with `rxjs` 35 | - Some people don't want to change to `@reactivex/rxjs` to use the ES6 modules, tho. 36 | 37 | ## Removal of Error rethrowing 38 | 39 | - To align with TC39 proposal 40 | - To prevent producer interference 41 | - Pass the error to some global handler of some sort. (Similar to promise unhandled error) 42 | 43 | ## PR Merging strategy 44 | 45 | - If 2 approvals from core team, and it's a "next patch" version, merge it. 46 | - If it's minor or major do not merge it right away. 47 | - Docs changes can be merged right away. 48 | -------------------------------------------------------------------------------- /rxjs/2017/2017-05/may-08.md: -------------------------------------------------------------------------------- 1 | # May 8th, 2017 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/9)) 2 | 3 | ### Attendees 4 | 5 | * [@benlesh](https://github.com/benlesh) 6 | * [@kwonoj](https://github.com/kwonoj) 7 | * [@david-driscoll](https://github.com/david-driscoll) 8 | 9 | 10 | ## Moving Toward Lettable Operators 11 | 12 | The idea here is to update RxJS 5 to include all operators as higher-order functions that return a lettable function. For example: `const map = (fn) => (source$) => currentMapFn.call(source$, fn)` (this is the most primitive implementation) 13 | 14 | ### Pros 15 | 16 | - Much more flexible overall 17 | - No more prototype augmentation for those that opt to use this method 18 | - Better tree shaking 19 | 20 | ### Cons 21 | 22 | - TypeScript does not infer types through this sort of chaining. 23 | - Yet another way for people to use RxJS 24 | 25 | [@david-driscoll](https://github.com/david-driscoll) has a counter-proposal involving a more "pipeable" design to accommodate TypeScript type inference. In this design operators would be implemented with the source observable as the first argument. 26 | 27 | It was agreed that the ideal solution would be to use the higher-order lettable functions, and just have TypeScript work with smarter type inference for arguments provided via higher-order functions. 28 | 29 | @benlesh will talk to folks at Google (who really want this) and reach out to the TypeScript team to see if we can't get this resolved on the TypeScript side. 30 | 31 | ### Unifying AJAX: Both Angular and RxJS have an Observable-based implementation of AJAX, we should unify those into one framework-agnostic implementation 32 | 33 | Ideally this will reduce confusion for Angular users. Also it should result in a better maintained AJAX implementation. Currently, not many people use the Rx implementation because of poor documentation. 34 | 35 | Perhaps we can also move the `WebSocketSubject` to a nuetral space and make it easier to use with Angular. 36 | 37 | [@benlesh](https://github.com/benlesh) will work with the Angular team to see what we can work out. 38 | 39 | ### Outstanding Bugs/Issues 40 | 41 | Due to low headcount/availabilty we're getting backed up on issues and PRs in the repo. This is also in part due to not having a solid unified direction for where we want to go with certain parts of the library. 42 | 43 | We need to come up with a solid direction, and that will help guide whether or not we need to close certain issues or PRs that are currently in limbo because we're undecided. 44 | 45 | Current direction is that we want to aim for reducing the size of Rx's footprint, move to lettable operators, and refactor the `TestScheduler` to make it easier for users to consume. 46 | 47 | ### T-Rx 48 | 49 | [@benlesh](https://github.com/benlesh) showed off work on a private prototype of RxJS that weighs in at around 3k minified and gzipped. It has most if not all updates in it that we want to introduce to RxJS over the long term. This will remain in a private repository for now, as it's far too alpha for anyone to be using. 50 | 51 | One thought is that once it's ready to be alpha'd properly (we have current tests passing on it) we can move it over to a branch on the RxJS main repository, and start some concurrent development between it and current Rx. Another approach would be to try to steer the current repository in that direction, however that would involve a few moments of extremely difficult refactors, mostly around schedulers and the like. Final strategy TBD. 52 | 53 | -------------------------------------------------------------------------------- /rxjs/2017/2017-06/June-21.md: -------------------------------------------------------------------------------- 1 | # June 21st, 2017 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/10)) 2 | 3 | ### Attendees 4 | 5 | * [@blesh](https://github.com/blesh) 6 | * [@kwonoj](https://github.com/kwonoj) 7 | * [@david-driscoll](https://github.com/david-driscoll) 8 | 9 | ### Discussed 10 | 11 | - Work is ongoing on lettable operators. We want to land that in 5.5 or 5.6 ahead of 6.0. 12 | - Work is ongoing on reducing size of non-hotpath observables, again we want to land that in 5.5 or 5.6 ahead of 6.0 13 | - OJ or David is going to drive an effort to clean up types exposed to the public for the 6.0 release. This will be a breaking change. The idea is to clean up the interfaces people see ahead of refactors around error handling, scheduling and other important efforts that likely will not land until version 7 or 8. 14 | - Documentation is still an issue. Discussed trying to move documentation out of code files and into something more simplistic, like Markdown, in hopes of getting more contributions from the community. 15 | -------------------------------------------------------------------------------- /rxjs/2017/2017-08/August-28.md: -------------------------------------------------------------------------------- 1 | # August 28nd, 2017 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/11)) 2 | 3 | ### Attendees 4 | 5 | * [@benlesh](https://github.com/benlesh) 6 | * [@ladyleet](https://github.com/ladyleet) 7 | * [@kwonoj](https://github.com/kwonoj) 8 | * [@david-driscoll](https://github.com/david-driscoll) 9 | 10 | ### Discussed 11 | 12 | * @ladyleet and @david-driscoll discovered that they are neighbors. 13 | * @ladyleet has whiskey at her house 14 | * @benlesh should stop goofing around 15 | 16 | 17 | * How can we help people publish their own operators and features? 18 | * Should we have a userland GitHub organization? 19 | - Maybe use @reactivex 20 | - for user-land projects related to RxJS 21 | - mostly for custom operators and features 22 | - also for tooling 23 | - For custom operators and features we should provide a custom repository people can fork 24 | - Must have a clear code-of-conduct 25 | - What is the criteria to even get a repository in this org? 26 | - Electron does something like this (Electron-Userland) 27 | - examples 28 | - https://github.com/cake-contrib 29 | - https://github.com/electron-userland/ 30 | - Governence would be hard: Consistency, Code quality, Code of Conduct, etc. 31 | 32 | * Mono-repo - many packages: @david-driscoll foolishly throws himself on the sword. This could be the real solution to the userland packages 33 | 34 | 35 | * Lettables - Jason Aden from Google's Angular Team is helping port operators to lettable operators... should be out in 5.5.0 36 | 37 | * ES Module publish - Jason Aden https://github.com/ReactiveX/rxjs/pull/2804 38 | 39 | The idea is to publish .esm files in an adjacent tree along with appropriate package.json files. This is "in addition to" the current `rxjs` publish, not along-side or instead-of. 40 | 41 | 42 | * Documentation effort 43 | - Tracy has a list of ~27 people that want to contribute. 44 | - Documentation 45 | - API docs 46 | - Examples 47 | - Tutorials 48 | - General information 49 | - Build/bundling basics 50 | - working with frameworks 51 | - Number one complaint has been lack of solid examples. 52 | - Brian Truncone's project. He's willing to contribute the content from his site to our documentation. (https://github.com/btroncone/learn-rxjs) 53 | 54 | 1. General Information Site 55 | 2. Form the Learning Team 56 | 3. Create Issues so people can start contributing 57 | - Add a label for issues 58 | 4. Link beta docs from current docs until current docs are more complete 59 | 5. Find example docs we think are useful (Angular docs, React?, LoDash docs, MDN) 60 | 61 | 62 | -------------------------------------------------------------------------------- /rxjs/2017/2017-09/September-11.md: -------------------------------------------------------------------------------- 1 | # September 11th, 2017 ([discuss](https://github.com/ReactiveX/rxjs-core-notes/pull/12)) 2 | 3 | ### Attendees 4 | 5 | * [@benlesh](https://github.com/benlesh) 6 | * [@ladyleet](https://github.com/ladyleet) 7 | * [@kwonoj](https://github.com/kwonoj) 8 | * [@mattpodwysocki](https://github.com/mattpodwysocki) 9 | 10 | ### Discussed 11 | 12 | - Lettable operators done and sitting in PRs 13 | - 5.5 beta release incoming before 5.5. 14 | - Might punt on deprecation messages before 6.0. 15 | - Master should be 6.0+ after 5.5 release, move 5.5 stuff to a legacy branch 16 | - Docs 17 | - need to meet with Pete Bacon Darwin 18 | - @ladyleet needs a little help 19 | - need to create issues for docs team 20 | - need to meet with LearnRx.io 21 | - @benlesh to schedule meeting with RxJS Learning Team for October 16th. 22 | - Contributors are waiting too long to get PRs merged 23 | - 24 | 25 | 26 | -------------------------------------------------------------------------------- /rxjs/2017/2017-10/october-11.md: -------------------------------------------------------------------------------- 1 | # October 11th, 2017 2 | 3 | ### Attendees 4 | 5 | * [@benlesh](https://github.com/benlesh) 6 | * [@ladyleet](https://github.com/ladyleet) 7 | * [@kwonoj](https://github.com/kwonoj) 8 | * [@david-driscoll](https://github.com/david-driscoll) 9 | 10 | ### Discussed 11 | 12 | - Build Process needs simplification 13 | - Move lettable operators to next branch 14 | - Simplify build 15 | - CD and monorepo 16 | - Issues labeled discussion 17 | - Please bikeshed on these issues 18 | - Cleaning up PRs and issues 19 | - Needs to happen 20 | - Docs Translation 21 | - Need to think about tooling 22 | - Getting started guide for translations probably best first step 23 | - How do we incrementally roll out translations? 24 | - Docs 25 | - Initial meeting scheduled 10/16 with 46 tentative attendees 26 | - Need to add issue - take TS files and convert them to ASTs, then traverse ASTs to extract out documentation. 27 | - Ongoing meetings 28 | - CORE - Moved to Wednesday at 1030am every other week for 60 minutes 29 | - DOCS - Starting kickoff for every other week Wednesday at 930am for 60 minutes 30 | 31 | -------------------------------------------------------------------------------- /rxjs/2017/2017-10/october-25.md: -------------------------------------------------------------------------------- 1 | # October 25th, 2017 2 | 3 | ### Attendees 4 | 5 | * [@benlesh](https://github.com/benlesh) 6 | * [@ladyleet](https://github.com/ladyleet) 7 | * [@kwonoj](https://github.com/kwonoj) 8 | 9 | ### Discussed 10 | 11 | - SystemJS folks still having issues, but have always had issues. 12 | - Can we continue to support them? 13 | - Mono Repo discussion: What we want to do is have a top level lerna (or something) that can build/publish more than one package under a modules directory. One of the things we'd like is to move the patching operators (`rxjs/add/*` to a separate package like `rxjs-dotchaining` or the like) 14 | - Talk Nightlies: @kwonoj is going to work on getting Nightlies going. No changelogs will be generated for nightlies, because there would be too much flux in them. 15 | - Open Collective: @benlesh signed us up for OC, however, we need to figure out more about how it works and more importantly, what we would do with the money. Both @benlesh and @kwonoj expressed concern that the introduction of money could bring politics and feelings into play in the repo/community. 16 | - Discussion around inviting non-core team members to core team meetings: The core team meetings are for private discussion of RxJS issues/direction/concerns, and while we may invite non-core team members for specific reasons from time to time, it should really be for core team members only unless otherwise needed. 17 | - Remove secondary map: Discussed removing secondary mapping selector from operators like `mergeMap`, `switchMap`, `concatMap`: @kwonoj and @benlesh generally in favor, but @kwonoj is worried about introducing too many breaking changes in v6. So we want to do it, but whether or not it's in v6 is TBD. 18 | - deprecate `@reactivex/rxjs` and `rxjs-es6` and only publish `rxjs` :+1: - This is definitely happening before v6. 19 | - move add/ operators to a separate package in monorepo - This is something we'd like for v6. So we aren't dropping support for the patching operators, rather just moving them to another package: This is for a few reasons: 1) we'd like to encourage people ot use the functional operators. 2) It'll reduce the size of the package for people using Node or Electron. 3) It will reduce confusion when using the library 20 | - Scheduler discussion: Discussion around [The Future Of Schedulers](https://github.com/ReactiveX/rxjs/issues/2935) issue. Both @kwonoj and @benlesh agree we should reduce the size impact of schedulers on the library. @kwonoj is concerned about the number of breaking changes for v6, so we'll need to plan it out, but it can be seen that there is perhaps a little too much code/engineering around scheduling within the library, and we can definitely reduce the size of the library by taking a smarter approach with schedulers. This is to be discussed more in the future, no solid decisions made. 21 | -------------------------------------------------------------------------------- /rxjs/2017/2017-11/november-08.md: -------------------------------------------------------------------------------- 1 | ### Agenda 2 | 3 | - Monorepo: Do we start again from scratch with our build process? 4 | - Organization of code: 5 | - Move everything we don't want people using directly (Subscriber for example) to an `internal` directory? 6 | - Export locations for: 7 | - operators (e.g. `map`, `mergeAll`, etc) 8 | - static functions (e.g. `merge`, `race`, `concat`, `forkJoin`) - name collisions with operators? 9 | - observable creation methods: (e.g. `timer`, `range`, `fromEvent`) - are they much different than the static functions? 10 | - Removal of secondary mappings from operators like `mergeMap` 11 | - Rename `mergeMap` to `flatMap`? 12 | - Progress in docs effort (@ladyleet if she can attend) 13 | - WHATWG Observable effort and alignment 14 | 15 | ## Attendees 16 | 17 | - [Ben Lesh](https://github.com/benlesh) 18 | - [Tracy Lee](https://github.com/ladyleet) 19 | 20 | Brief discussion was had, but nothing important decided due to lack of attendance. 21 | -------------------------------------------------------------------------------- /rxjs/2017/2017-12/december-6.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes December 6, 2017 2 | 3 | [Discussion can be found here](https://github.com/reactivex/rxjs-core-notes/pull/21) 4 | 5 | ## Attendees 6 | 7 | [Ben Lesh](https://github.com/benlesh) 8 | [OJ Kwon](https://github.com/kwonoj) 9 | [Tracy Lee](http://github.com/ladyleet) 10 | 11 | ## Discussed 12 | 13 | - Top-level exports. The vast majority of the community seems to be behind the change and very excited. Igor Minar of the Angular Team has expressed concern. Ben will meet with Igor later today to see what we can do to alleviate those concerns. 14 | - Bazel and Bazel builds. The addition of the Bazel file(s) in 5.5.5 was just to support users who want to build with Bazel (This is primarily Angular users going forward). Ben talked with Alex Eagle who is going to run a Bazel hackathon in late December to try to move RxJS's build to Bazel. This might mesh well with Ward Peter's desire to help move us to a monorepo. Ward has expressed interest in trying to use Bazel for this. 15 | - Jan. 3 Core meeting cancelled because of Holidays. 16 | - When we're back from break in January, we're going to focus on adding some structure to the team and what it means to be a "core team member" participation-wise. 17 | - Tracy Lee is officially on the RxJS Core Team. Both OJ and Ben are extremely happy with how she has led and revitalized the efforts around the RxJS documentation, and we really look forward to future contributions from her. 👏👏👏 18 | -------------------------------------------------------------------------------- /rxjs/2018/2018-01/january-31.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes January 31, 2018 2 | 3 | ## Attendees 4 | 5 | [Ben Lesh](https://github.com/benlesh) 6 | [OJ Kwon](https://github.com/kwonoj) 7 | [David Driscoll](http://github.com/david-driscoll) 8 | [Tracy Lee](http://github.com/ladyleet) 9 | [Ashwin Sureshkumar](http://github.com/ashwin-sureshkumar) 10 | 11 | 12 | ## Discussed 13 | 14 | * Moving RxSandbox into Rx proper - OJ created a proof of concept. Once we agree with it it can be ported over to RxJS core. 15 | * Start an issue of what we want to change about test scheduling. 16 | * Need to go through all the things we can fix in the TestScheduler work and get aligned. 17 | * PR # tracking is #3266. 18 | * Jay had some ideas about fixing the TestScheduler as well that we need to align on. 19 | * Lots of discussion around test scheduler - separate meeting to be scheduled next week to discuss this specifically with Jay, Ben, OJ. 20 | 21 | * Ben has been going through issues and closing them out. 22 | * Could use help from others to even label the issues so we know someone has looked at the issues. 23 | 24 | * David's PR #3265 25 | * Goes through and updates our tests and imports tests instead of having them global & brings in better typing, etc. 26 | * David needs to fix the build! Ben and OJ to review after. 27 | 28 | * Monorepo 29 | * The angular folks may or may not take this over. 30 | * Ben to ping Igor Minar and Jason Aiden about this. 31 | 32 | * Async iterable support 33 | * Ben has been creating able to create observable from async iterable. 34 | * Implementing async iterable on observable - still thinking about whether we should do this or not - lots of bikeshedding needed. 35 | * Should we implement a toAsync iterable first for async iterable support - do this first vs the first two above. 36 | * No PRs have been submitted yet. 37 | 38 | * Conversation around removing all polyfills from RxJS completely PR #3263 39 | * Responsibility should be for the person that needs the polyfill so we reduce bloat of our library - this is in V6 in master. 40 | * Other core team members can work on this - work should be easy. 41 | 42 | * Discussed other PRs 43 | * 44 | 45 | * Learning team meeting update 46 | * Update from Tracy - Jan 31 was the last meeting. 47 | -------------------------------------------------------------------------------- /rxjs/2018/2018-02/february-14.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes February 14, 2018 2 | 3 | ## Attendees 4 | 5 | [Ben Lesh](https://github.com/benlesh) 6 | [OJ Kwon](https://github.com/kwonoj) 7 | [Tracy Lee](http://github.com/ladyleet) 8 | 9 | ## Discussed 10 | 11 | * Jay’s issue 3227 - unable to come up with solution around ESM module imports and tree shaking right now. 12 | 13 | * OJ Migrating new TestScheduler PR into v6 core #3314 14 | * Have Jay review since he is also looking to work on some TestScheduler changes soon. 15 | * Jay and Ben has been bikeshedding on this too. 16 | * Review at next core meeting and discuss on github. 17 | 18 | * Review David Driscoll's PR #3265 19 | * Updating test helpers to be strongly typed. 20 | * Ben and OJ :shipit: and merged. 21 | 22 | * Ben: Operators that have child subscriptions like mergeMap are currently hanging on to the source subscription longer than it should and tests reflect it. 23 | * Need to fix before 6 goes out because it's a breaking change. 24 | 25 | * Change to remove result selectors needs to happen #3304 26 | 27 | * Deprecation strategy 28 | * Need to general strategy to have migration plan for users. 29 | * Will be interesting to see feedback from V5 to V6 to decide on how we handle this in the future. 30 | 31 | * Async subscription comments from fetch polyfill guys about async teardown (issue #2758) 32 | 33 | * Monorepo proposal from Bazel 34 | * Google has been committed to do this but there has been no progress. 35 | * Ben to ping people about this. 36 | * See where progress is on 3/1. 37 | -------------------------------------------------------------------------------- /rxjs/2018/2018-02/february-28.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes February 28, 2018 2 | 3 | ## Attendees 4 | 5 | [Ben Lesh](https://github.com/benlesh) 6 | [OJ Kwon](https://github.com/kwonoj) 7 | [David Driscoll](https://github.com/david-driscoll) 8 | [Tracy Lee](http://github.com/ladyleet) 9 | [Jay Phelps](http://github.com/jayphelps) 10 | 11 | ## Discussed 12 | 13 | * Angular wanting RxJS 6 to be moving from alpha to beta by March 7th with no breaking changes. 14 | 15 | * Jay’s issue 3227 - ESM module imports. Needs to fix for everyone but Angular. This will be a breaking change for many people. Everyone green lighted to have Jay make the PR. 16 | 17 | * TestScheduler - Jay, OJ, Ben have been discussing and quite a bit of bikeshedding today. 18 | 19 | * Monorepo proposal from Bazel 20 | * No updates yet. 21 | 22 | * David's PRs - request for review 23 | * https://github.com/ReactiveX/rxjs/pull/3329 24 | * https://github.com/ReactiveX/rxjs/pull/3332 -------------------------------------------------------------------------------- /rxjs/2018/2018-04/april-25.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes April 25, 2018 2 | 3 | ## Attendees 4 | 5 | [Ben Lesh](https://github.com/benlesh) 6 | [Tracy Lee](http://github.com/ladyleet) 7 | [David Driscoll](https://github.com/david-driscoll) 8 | 9 | ## Discussed 10 | 11 | * RxJS 6 released 12 | 13 | * Need to discuss what we need to do with branches - master vs stable - now branches do not make sense and we need to move branches around. 14 | 15 | * Experimental branch and design doc released last week from Ben - Ben is looking to do these things for RxJS 7 - eventually they need to go into RxJS master - but not yet. Some concerns here that need to be hashed out. Currently will stay in experimental.. but might have to rename stable branch to V5 or something... 16 | 17 | * Need to file issues for tests that have not been updated to use pipeable operators - these are good first contributor issues. Ben would prefer new contributors take these issues - not a rush or high priority - but something that could motivate new people to do. 18 | 19 | * New test runner stuff that Jay Phelps put in! Landed and is out in 6.0 - should probably go through and update our tests to use this instead of the magic globals. 20 | 21 | * RxJS docs update - new dgeni docs are going to be released soon - yay API docs! 22 | 23 | ### Core Contributors 24 | 25 | * Core team members need to continue to have context in RxJS. (Persons who have no context in RxJS core with write access pose a risk to the library.) 26 | 27 | * In order to stay a core team member, members need to be present at pre-scheduled meetings at least once a month. 28 | 29 | * Core team members need to also be actively contributing monthly. 30 | 31 | * Eligibility for core team members and/or write access to the repo will be reviewed at core team meetings and voted based on consensus on a quarterly basis. 32 | 33 | * Discussion around core team member and/or write access to be reviewed at our next meeting. -------------------------------------------------------------------------------- /rxjs/2018/2018-06/june-6.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes June 6, 2018 2 | 3 | ## Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ben Lesh](https://github.com/benlesh) 7 | * [OJ Kwon](https://github.com/kwonoj) 8 | * [Nicholas Jamieson](https://github.com/cartant) 9 | * [Jan Niklass-Wortmann](http://github.com/JWO719) 10 | * [Paul Taylor](http://github.com/trxcllnt) 11 | 12 | ## Discussed 13 | 14 | * RxJS package is bloated. 15 | * Discussed solutions - no resolution yet. 16 | 17 | * Deprecate partition operator. 18 | * Removing partition next major version 19 | * Proposing split as a static operator - Paul will file issue to hear folks comments and issues for suggested changes. 20 | 21 | * Bringing back the concat operator under concatWith 22 | * Undeprecate concat operator 23 | * Rename it to concatWith. 24 | * :thumbsup: 25 | 26 | * Reporting sync errors after complete 27 | * 28 | * :thumbsup: 29 | 30 | * Documentation 31 | * App under directory in Master. RxJS Learning team has been working hard on this. 32 | * Next step: When we publish we automatically publish the docs. 33 | 34 | * Upcoming 35 | * Nightly builds for RxJS 36 | 37 | 38 | * Core team 39 | * [Nicholas](https://github.com/cartant) is now a part of the core team as of 2 weeks ago!! :) 40 | 41 | * Discussed a few folks we'd love to groom for the core team meeting 42 | 43 | * Discussion about core team 44 | * Core team members need to continue to have context in RxJS. (Persons who have no context in RxJS core with write access pose a risk to the library.) 45 | 46 | * In order to stay a core team member, members need to be present at pre-scheduled meetings at least once a month. 47 | 48 | * Core team members need to also be actively contributing monthly. 49 | 50 | * Eligibility for core team members and/or write access to the repo will be reviewed at core team meetings and voted based on consensus on a quarterly basis. 51 | 52 | * Consensus to change some settings members who are currently not actively involved. -------------------------------------------------------------------------------- /rxjs/2018/2018-07/july-18.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes July 18, 2018 2 | 3 | ## Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ben Lesh](http://github.com/benlesh) 7 | * [Nicholas Jamieson](http://github.com/cartant) 8 | * [Matt Podwysocki](http://github.com/mattpodwysocki) 9 | * [Natalie Smith](http://github.com/natmegs) 10 | * [OJ Kwon](http://github.com/kwonoj) 11 | 12 | ## Discussed 13 | 14 | * Google Analytics issue - Ben will resolve it. 15 | 16 | * Travis CI issues discussed - OJ said to tag him on it and he'll check. 17 | 18 | * Discussed taking beta off the docs - Tracy to create an issue. 19 | 20 | * Adding "choose your operator" back to front page of docs - Tracy to create an issue. 21 | 22 | * PSA - if docs PRs look good, anyone who has merge access can just merge it to speed up the process. 23 | 24 | * PSA - anyone who wants to rebase a few pending PRs - please do so so we can merge some of the PRs in. 25 | 26 | * Ben talked about experimental branch 27 | * callback style implementation 28 | * Ben is working on a design doc for a test scheduler (in the experimental branch) that can better deal with actual asynchrony - although native async/await remains a problem. 29 | 30 | * Discussed adding capybara to Travis - would be good as an indicator but not as a blocker in Travis given implications. 31 | -------------------------------------------------------------------------------- /rxjs/2018/2018-08/august-1.md: -------------------------------------------------------------------------------- 1 | # Meeting Notes August 1, 2018 2 | 3 | ## Attendees 4 | 5 | * [Tracy Lee](http://github.com/ladyleet) 6 | * [Ben Lesh](http://github.com/benlesh) 7 | * [Nicholas Jamieson](http://github.com/cartant) 8 | * [Paul Taylor](http://github.com/trxcllnt) 9 | * [David Driscoll](http://github.com/david-driscoll) 10 | 11 | ## Discussed 12 | 13 | - [`forEach` PR](https://github.com/ReactiveX/rxjs/pull/3977): Adding a secondary "Subscription as a cancellation token" argument to `forEach`. Concensus was a "thumbs up". 14 | - Making Observable "awaitable". @david-driscoll brought up the desire to make Observable thennable, and therefor awaitable. Everyone agreed that it's problematic to do so, because people will not be expecting multiple side effects when awaiting the observable twice (in comparision to promises) 15 | - [Splitting publish, multicast etc](https://github.com/reactivex/rxjs/issues/3833). Thumbs up from everyone. The idea here is to split the publish operator into a static `publish`/`multicast` that returns `ConnectableObservable`, and an operator like `publishWith` or `publishAs` that must have the `selector`/`projection` argument and returns `Observable`. 16 | - [xWith operators](https://github.com/reactivex/rxjs/issues/3927): Thumbs up from everyone. The idea here is instead of just deprecating the `concat`, `zip`, et al _operators_, we rename them (alias them but still deprecate the old names) to `concatWith`, `zipWith`, et al. 17 | - [Possibly removing instanceof checks from the library](https://github.com/reactivex/rxjs/issues/3828): Thumbs down. Status quo maintained. Given the performance impact of removing `instanceof` checks in favor of property assertions in potentially hot path areas like inner subscriptions, it was decided to leave the `instanceof` checks in place. 18 | - Interop with Node Streams - @trxcllnt brought up the desire to convert an Observable to a Node Stream. This has a lot of implications around needing to provide various buffering strategies. It was decided that it might be better to provide conversion to **Async Iterator**, which is more easily converted to a Node Stream, and is likely more desireable. Still, the buffering strategy is an issue to be resolved. @trxcllnt said he may look into coming out with a design document for this in the future. 19 | --------------------------------------------------------------------------------