├── .gitignore ├── .npmignore ├── LICENSE ├── compile.sh ├── contracts ├── Dispatcher.sol ├── Migrations.sol └── Upgradeable.sol ├── migrations ├── 1_initial_migration.js └── 2_deploy_contracts.js ├── package-lock.json ├── package.json ├── readme.md ├── test.sh ├── test ├── contracts │ ├── ErrorTarget.sol │ ├── NotVerifyingTarget.sol │ ├── StateErrorTarget.sol │ ├── Target.sol │ ├── TargetCommon.sol │ └── TargetV2.sol ├── dispatcher.js └── upgradeable.js ├── testrpc.sh └── truffle.js /.gitignore: -------------------------------------------------------------------------------- 1 | **/*.iml 2 | .idea 3 | flat 4 | node_modules 5 | -------------------------------------------------------------------------------- /.npmignore: -------------------------------------------------------------------------------- 1 | **/*.iml 2 | .idea 3 | flat 4 | node_modules 5 | *.sh 6 | tests 7 | build -------------------------------------------------------------------------------- /LICENSE: -------------------------------------------------------------------------------- 1 | Apache License 2 | Version 2.0, January 2004 3 | http://www.apache.org/licenses/ 4 | 5 | TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION 6 | 7 | 1. Definitions. 8 | 9 | "License" shall mean the terms and conditions for use, reproduction, 10 | and distribution as defined by Sections 1 through 9 of this document. 11 | 12 | "Licensor" shall mean the copyright owner or entity authorized by 13 | the copyright owner that is granting the License. 14 | 15 | "Legal Entity" shall mean the union of the acting entity and all 16 | other entities that control, are controlled by, or are under common 17 | control with that entity. For the purposes of this definition, 18 | "control" means (i) the power, direct or indirect, to cause the 19 | direction or management of such entity, whether by contract or 20 | otherwise, or (ii) ownership of fifty percent (50%) or more of the 21 | outstanding shares, or (iii) beneficial ownership of such entity. 22 | 23 | "You" (or "Your") shall mean an individual or Legal Entity 24 | exercising permissions granted by this License. 25 | 26 | "Source" form shall mean the preferred form for making modifications, 27 | including but not limited to software source code, documentation 28 | source, and configuration files. 29 | 30 | "Object" form shall mean any form resulting from mechanical 31 | transformation or translation of a Source form, including but 32 | not limited to compiled object code, generated documentation, 33 | and conversions to other media types. 34 | 35 | "Work" shall mean the work of authorship, whether in Source or 36 | Object form, made available under the License, as indicated by a 37 | copyright notice that is included in or attached to the work 38 | (an example is provided in the Appendix below). 39 | 40 | "Derivative Works" shall mean any work, whether in Source or Object 41 | form, that is based on (or derived from) the Work and for which the 42 | editorial revisions, annotations, elaborations, or other modifications 43 | represent, as a whole, an original work of authorship. For the purposes 44 | of this License, Derivative Works shall not include works that remain 45 | separable from, or merely link (or bind by name) to the interfaces of, 46 | the Work and Derivative Works thereof. 47 | 48 | "Contribution" shall mean any work of authorship, including 49 | the original version of the Work and any modifications or additions 50 | to that Work or Derivative Works thereof, that is intentionally 51 | submitted to Licensor for inclusion in the Work by the copyright owner 52 | or by an individual or Legal Entity authorized to submit on behalf of 53 | the copyright owner. For the purposes of this definition, "submitted" 54 | means any form of electronic, verbal, or written communication sent 55 | to the Licensor or its representatives, including but not limited to 56 | communication on electronic mailing lists, source code control systems, 57 | and issue tracking systems that are managed by, or on behalf of, the 58 | Licensor for the purpose of discussing and improving the Work, but 59 | excluding communication that is conspicuously marked or otherwise 60 | designated in writing by the copyright owner as "Not a Contribution." 61 | 62 | "Contributor" shall mean Licensor and any individual or Legal Entity 63 | on behalf of whom a Contribution has been received by Licensor and 64 | subsequently incorporated within the Work. 65 | 66 | 2. Grant of Copyright License. Subject to the terms and conditions of 67 | this License, each Contributor hereby grants to You a perpetual, 68 | worldwide, non-exclusive, no-charge, royalty-free, irrevocable 69 | copyright license to reproduce, prepare Derivative Works of, 70 | publicly display, publicly perform, sublicense, and distribute the 71 | Work and such Derivative Works in Source or Object form. 72 | 73 | 3. Grant of Patent License. Subject to the terms and conditions of 74 | this License, each Contributor hereby grants to You a perpetual, 75 | worldwide, non-exclusive, no-charge, royalty-free, irrevocable 76 | (except as stated in this section) patent license to make, have made, 77 | use, offer to sell, sell, import, and otherwise transfer the Work, 78 | where such license applies only to those patent claims licensable 79 | by such Contributor that are necessarily infringed by their 80 | Contribution(s) alone or by combination of their Contribution(s) 81 | with the Work to which such Contribution(s) was submitted. If You 82 | institute patent litigation against any entity (including a 83 | cross-claim or counterclaim in a lawsuit) alleging that the Work 84 | or a Contribution incorporated within the Work constitutes direct 85 | or contributory patent infringement, then any patent licenses 86 | granted to You under this License for that Work shall terminate 87 | as of the date such litigation is filed. 88 | 89 | 4. Redistribution. You may reproduce and distribute copies of the 90 | Work or Derivative Works thereof in any medium, with or without 91 | modifications, and in Source or Object form, provided that You 92 | meet the following conditions: 93 | 94 | (a) You must give any other recipients of the Work or 95 | Derivative Works a copy of this License; and 96 | 97 | (b) You must cause any modified files to carry prominent notices 98 | stating that You changed the files; and 99 | 100 | (c) You must retain, in the Source form of any Derivative Works 101 | that You distribute, all copyright, patent, trademark, and 102 | attribution notices from the Source form of the Work, 103 | excluding those notices that do not pertain to any part of 104 | the Derivative Works; and 105 | 106 | (d) If the Work includes a "NOTICE" text file as part of its 107 | distribution, then any Derivative Works that You distribute must 108 | include a readable copy of the attribution notices contained 109 | within such NOTICE file, excluding those notices that do not 110 | pertain to any part of the Derivative Works, in at least one 111 | of the following places: within a NOTICE text file distributed 112 | as part of the Derivative Works; within the Source form or 113 | documentation, if provided along with the Derivative Works; or, 114 | within a display generated by the Derivative Works, if and 115 | wherever such third-party notices normally appear. The contents 116 | of the NOTICE file are for informational purposes only and 117 | do not modify the License. You may add Your own attribution 118 | notices within Derivative Works that You distribute, alongside 119 | or as an addendum to the NOTICE text from the Work, provided 120 | that such additional attribution notices cannot be construed 121 | as modifying the License. 122 | 123 | You may add Your own copyright statement to Your modifications and 124 | may provide additional or different license terms and conditions 125 | for use, reproduction, or distribution of Your modifications, or 126 | for any such Derivative Works as a whole, provided Your use, 127 | reproduction, and distribution of the Work otherwise complies with 128 | the conditions stated in this License. 129 | 130 | 5. Submission of Contributions. Unless You explicitly state otherwise, 131 | any Contribution intentionally submitted for inclusion in the Work 132 | by You to the Licensor shall be under the terms and conditions of 133 | this License, without any additional terms or conditions. 134 | Notwithstanding the above, nothing herein shall supersede or modify 135 | the terms of any separate license agreement you may have executed 136 | with Licensor regarding such Contributions. 137 | 138 | 6. Trademarks. This License does not grant permission to use the trade 139 | names, trademarks, service marks, or product names of the Licensor, 140 | except as required for reasonable and customary use in describing the 141 | origin of the Work and reproducing the content of the NOTICE file. 142 | 143 | 7. Disclaimer of Warranty. Unless required by applicable law or 144 | agreed to in writing, Licensor provides the Work (and each 145 | Contributor provides its Contributions) on an "AS IS" BASIS, 146 | WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 147 | implied, including, without limitation, any warranties or conditions 148 | of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A 149 | PARTICULAR PURPOSE. You are solely responsible for determining the 150 | appropriateness of using or redistributing the Work and assume any 151 | risks associated with Your exercise of permissions under this License. 152 | 153 | 8. Limitation of Liability. In no event and under no legal theory, 154 | whether in tort (including negligence), contract, or otherwise, 155 | unless required by applicable law (such as deliberate and grossly 156 | negligent acts) or agreed to in writing, shall any Contributor be 157 | liable to You for damages, including any direct, indirect, special, 158 | incidental, or consequential damages of any character arising as a 159 | result of this License or out of the use or inability to use the 160 | Work (including but not limited to damages for loss of goodwill, 161 | work stoppage, computer failure or malfunction, or any and all 162 | other commercial damages or losses), even if such Contributor 163 | has been advised of the possibility of such damages. 164 | 165 | 9. Accepting Warranty or Additional Liability. While redistributing 166 | the Work or Derivative Works thereof, You may choose to offer, 167 | and charge a fee for, acceptance of support, warranty, indemnity, 168 | or other liability obligations and/or rights consistent with this 169 | License. However, in accepting such obligations, You may act only 170 | on Your own behalf and on Your sole responsibility, not on behalf 171 | of any other Contributor, and only if You agree to indemnify, 172 | defend, and hold each Contributor harmless for any liability 173 | incurred by, or claims asserted against, such Contributor by reason 174 | of your accepting any such warranty or additional liability. 175 | 176 | END OF TERMS AND CONDITIONS 177 | 178 | APPENDIX: How to apply the Apache License to your work. 179 | 180 | To apply the Apache License to your work, attach the following 181 | boilerplate notice, with the fields enclosed by brackets "{}" 182 | replaced with your own identifying information. (Don't include 183 | the brackets!) The text should be enclosed in the appropriate 184 | comment syntax for the file format. We also recommend that a 185 | file or class name and description of purpose be included on the 186 | same "printed page" as the copyright notice for easier 187 | identification within third-party archives. 188 | 189 | Copyright {yyyy} {name of copyright owner} 190 | 191 | Licensed under the Apache License, Version 2.0 (the "License"); 192 | you may not use this file except in compliance with the License. 193 | You may obtain a copy of the License at 194 | 195 | http://www.apache.org/licenses/LICENSE-2.0 196 | 197 | Unless required by applicable law or agreed to in writing, software 198 | distributed under the License is distributed on an "AS IS" BASIS, 199 | WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 200 | See the License for the specific language governing permissions and 201 | limitations under the License. 202 | -------------------------------------------------------------------------------- /compile.sh: -------------------------------------------------------------------------------- 1 | #!/usr/bin/env bash 2 | rm -Rf build 3 | truffle compile -------------------------------------------------------------------------------- /contracts/Dispatcher.sol: -------------------------------------------------------------------------------- 1 | pragma solidity ^0.4.21; 2 | 3 | 4 | contract Dispatcher { 5 | address target; 6 | 7 | function Dispatcher(address _target) public { 8 | target = _target; 9 | } 10 | 11 | function() public { 12 | assembly { 13 | let _target := sload(0) 14 | calldatacopy(0x0, 0x0, calldatasize) 15 | let retval := delegatecall(gas, _target, 0x0, calldatasize, 0x0, 0) 16 | let returnsize := returndatasize 17 | returndatacopy(0x0, 0x0, returnsize) 18 | switch retval case 0 {revert(0, 0)} default {return (0, returnsize)} 19 | } 20 | } 21 | } 22 | -------------------------------------------------------------------------------- /contracts/Migrations.sol: -------------------------------------------------------------------------------- 1 | pragma solidity ^0.4.21; 2 | 3 | contract Migrations { 4 | address public owner; 5 | uint public last_completed_migration; 6 | 7 | modifier restricted() { 8 | if (msg.sender == owner) _; 9 | } 10 | 11 | function Migrations() public { 12 | owner = msg.sender; 13 | } 14 | 15 | function setCompleted(uint completed) restricted public { 16 | last_completed_migration = completed; 17 | } 18 | 19 | function upgrade(address new_address) restricted public { 20 | Migrations upgraded = Migrations(new_address); 21 | upgraded.setCompleted(last_completed_migration); 22 | } 23 | } 24 | -------------------------------------------------------------------------------- /contracts/Upgradeable.sol: -------------------------------------------------------------------------------- 1 | pragma solidity ^0.4.21; 2 | 3 | 4 | contract Upgradeable { 5 | address public target; 6 | event EventUpgrade(address target, address admin); 7 | 8 | modifier onlyAdmin() { 9 | checkAdmin(); 10 | _; 11 | } 12 | 13 | function checkAdmin() internal; 14 | 15 | function upgrade(address _target) onlyAdmin public { 16 | verifyTargetState(_target); 17 | verifyState(_target); 18 | target = _target; 19 | emit EventUpgrade(_target, msg.sender); 20 | } 21 | 22 | function verifyTargetState(address testTarget) private { 23 | require(address(delegateGet(testTarget, "target()")) == target); 24 | } 25 | 26 | function verifyState(address testTarget) internal { 27 | 28 | } 29 | 30 | function delegateGet(address testTarget, string signature) internal returns (bytes32 result) { 31 | bytes4 targetCall = bytes4(keccak256(signature)); 32 | assembly { 33 | let free := mload(0x40) 34 | mstore(free, targetCall) 35 | let retVal := delegatecall(gas, testTarget, free, 4, free, 32) 36 | result := mload(free) 37 | } 38 | } 39 | } 40 | -------------------------------------------------------------------------------- /migrations/1_initial_migration.js: -------------------------------------------------------------------------------- 1 | var Migrations = artifacts.require("./Migrations.sol"); 2 | 3 | module.exports = function(deployer) { 4 | deployer.deploy(Migrations); 5 | }; 6 | -------------------------------------------------------------------------------- /migrations/2_deploy_contracts.js: -------------------------------------------------------------------------------- 1 | var Target = artifacts.require("./contracts/Target.sol"); 2 | var TargetV2 = artifacts.require("./contracts/TargetV2.sol"); 3 | var ErrorTarget = artifacts.require("./contracts/ErrorTarget.sol"); 4 | var StateErrorTarget = artifacts.require("./contracts/StateErrorTarget.sol"); 5 | var NotVerifyingTarget = artifacts.require("./contracts/NotVerifyingTarget.sol"); 6 | var Dispatcher = artifacts.require("./upgradeable/Dispatcher.sol"); 7 | 8 | module.exports = function(deployer) { 9 | deployer.deploy(TargetV2); 10 | deployer.deploy(ErrorTarget); 11 | deployer.deploy(StateErrorTarget); 12 | deployer.deploy(NotVerifyingTarget); 13 | deployer.deploy(Target) 14 | .then(() => deployer.deploy(Dispatcher, Target.address)); 15 | }; 16 | -------------------------------------------------------------------------------- /package-lock.json: -------------------------------------------------------------------------------- 1 | { 2 | "name": "daonomic-upgradeable", 3 | "version": "0.0.2", 4 | "lockfileVersion": 1, 5 | "requires": true, 6 | "dependencies": { 7 | "daonomic-tests": { 8 | "version": "0.0.2", 9 | "resolved": "https://registry.npmjs.org/daonomic-tests/-/daonomic-tests-0.0.2.tgz", 10 | "integrity": "sha512-KssicJbMweXecDIpkPJ5uEQ/mjZipaYG7i6pWkhjCzKAuIVKT2O6wlEB3Qed4XtjT0PrcYDt956rF76ivpRzUQ==", 11 | "dev": true 12 | } 13 | } 14 | } 15 | -------------------------------------------------------------------------------- /package.json: -------------------------------------------------------------------------------- 1 | { 2 | "name": "daonomic-upgradeable", 3 | "version": "0.0.2", 4 | "description": "Base for upgradeable smart contracts", 5 | "main": "truffle.js", 6 | "directories": { 7 | "test": "test" 8 | }, 9 | "scripts": { 10 | "test": "truffle test" 11 | }, 12 | "repository": { 13 | "type": "git", 14 | "url": "git+https://github.com/0v1se/contracts-upgradeable.git" 15 | }, 16 | "keywords": [ 17 | "ethereum" 18 | ], 19 | "license": "MIT", 20 | "bugs": { 21 | "url": "https://github.com/0v1se/contracts-upgradeable/issues" 22 | }, 23 | "homepage": "https://github.com/0v1se/contracts-upgradeable", 24 | "devDependencies": { 25 | "daonomic-tests": "0.0.2" 26 | } 27 | } 28 | -------------------------------------------------------------------------------- /readme.md: -------------------------------------------------------------------------------- 1 | ## Upgradeable contracts 2 | 3 | Small library providing upgradeable smart contracts. You can have upgradeable contracts for reasonable price (about 1100 gas per call. it depends on data size). [Dispatcher](contracts/Dispatcher.sol) uses new returndatasize and returndatacopy opcodes. So it won't work in pre-byzantium network. 4 | 5 | ### Disclaimer 6 | 7 | Library has not been heavily tested. Use it on your own risk. Do it only if you understand how data is stored. 8 | 9 | ### Basic Usage 10 | 11 | 1. Deploy target contract (You can use Upgradeable as base contract, it has some useful functions) 12 | 2. Deploy Dispatcher contract with address of the target as constructor argument. 13 | 3. You can use dispatcher's address as static address even if you want to switch to other implementation in future. 14 | 15 | ### Writing compatible contracts 16 | 17 | - The first storage slot in the contract will be used to store the address of the target contract 18 | - Additionally, when you upgrade a contract that has already stored data on the blockchain, you will need to be sure not to change the organization of your contract's storage. You can safely add new storage variables, but do not delete or re-order existing ones. It may also be risky to change the version of the Solidity compiler used, as there is no guarantee the storage layout will remain the same 19 | - Take a look at [upgradeable.js](test/upgradeable.js) to see some examples 20 | 21 | ### Upgradeable overview 22 | 23 | - Upgradeable has some checks to ensure next version is compatible with previous. 24 | - See [Upgradeable](contracts/Upgradeable.sol).verifyTargetState. It uses delegatecall to check if next contract version stores "target" storage variable in the same slot 25 | - Also, you'd better implement your own version of "verifyState" function. It can check if other storage variables are in the same slots. See [Target](test/contracts/Target.sol) for example. [NotVerifyingTarget](test/contracts/NotVerifyingTarget.sol) doesn't have this check. This leads to data corruption. See [upgradeable.js](test/upgradeable.js) "but it'll let upgrade if no check present" test 26 | - Implement checkAdmin function. Usually you can check if msg.sender is some address responsible for upgrading contracts -------------------------------------------------------------------------------- /test.sh: -------------------------------------------------------------------------------- 1 | #!/usr/bin/env bash 2 | truffle test -------------------------------------------------------------------------------- /test/contracts/ErrorTarget.sol: -------------------------------------------------------------------------------- 1 | pragma solidity ^0.4.15; 2 | 3 | 4 | import "./TargetCommon.sol"; 5 | import "../../contracts/Upgradeable.sol"; 6 | 7 | 8 | contract ErrorTarget is TargetCommon, Upgradeable { 9 | function checkAdmin() internal { 10 | 11 | } 12 | } 13 | -------------------------------------------------------------------------------- /test/contracts/NotVerifyingTarget.sol: -------------------------------------------------------------------------------- 1 | pragma solidity ^0.4.15; 2 | 3 | 4 | import "./TargetCommon.sol"; 5 | import "../../contracts/Upgradeable.sol"; 6 | 7 | 8 | contract NotVerifyingTarget is Upgradeable, TargetCommon { 9 | function checkAdmin() internal { 10 | 11 | } 12 | 13 | function verifyState(address testTarget) internal { 14 | 15 | } 16 | } 17 | -------------------------------------------------------------------------------- /test/contracts/StateErrorTarget.sol: -------------------------------------------------------------------------------- 1 | pragma solidity ^0.4.15; 2 | 3 | 4 | import "../../contracts/Upgradeable.sol"; 5 | 6 | 7 | contract StateErrorTarget is Upgradeable { 8 | uint256 public intState; 9 | string public stringState; 10 | 11 | function setStringState(string value) public { 12 | stringState = value; 13 | } 14 | 15 | function setIntState(uint256 value) public { 16 | intState = value; 17 | } 18 | 19 | function checkAdmin() internal { 20 | 21 | } 22 | } 23 | -------------------------------------------------------------------------------- /test/contracts/Target.sol: -------------------------------------------------------------------------------- 1 | pragma solidity ^0.4.15; 2 | 3 | 4 | import "./TargetCommon.sol"; 5 | import "../../contracts/Upgradeable.sol"; 6 | 7 | 8 | contract Target is Upgradeable, TargetCommon { 9 | function checkAdmin() internal { 10 | 11 | } 12 | 13 | function verifyState(address testTarget) internal { 14 | require(uint256(delegateGet(testTarget, "intState()")) == intState); 15 | } 16 | } 17 | -------------------------------------------------------------------------------- /test/contracts/TargetCommon.sol: -------------------------------------------------------------------------------- 1 | pragma solidity ^0.4.15; 2 | 3 | 4 | contract TargetCommon { 5 | string public stringState; 6 | uint256 public intState; 7 | 8 | function setStringState(string value) public { 9 | stringState = value; 10 | } 11 | 12 | function setIntState(uint256 value) public { 13 | intState = value; 14 | } 15 | } 16 | -------------------------------------------------------------------------------- /test/contracts/TargetV2.sol: -------------------------------------------------------------------------------- 1 | pragma solidity ^0.4.15; 2 | 3 | 4 | import "./TargetCommon.sol"; 5 | import "../../contracts/Upgradeable.sol"; 6 | 7 | 8 | contract TargetV2 is Upgradeable, TargetCommon { 9 | address public admin; 10 | 11 | function setAdmin(address _admin) public { 12 | admin = _admin; 13 | } 14 | 15 | function checkAdmin() internal { 16 | require(msg.sender == admin); 17 | } 18 | 19 | function increaseIntState() public { 20 | intState = intState + 1; 21 | } 22 | 23 | function verifyState(address testTarget) internal { 24 | require(uint256(delegateGet(testTarget, "intState()")) == intState); 25 | } 26 | } 27 | -------------------------------------------------------------------------------- /test/dispatcher.js: -------------------------------------------------------------------------------- 1 | var Dispatcher = artifacts.require("./upgradeable/Dispatcher.sol"); 2 | var Target = artifacts.require("./contracts/Target.sol"); 3 | 4 | function randomString(length, chars) { 5 | var result = ''; 6 | for (var i = length; i > 0; --i) result += chars[Math.floor(Math.random() * chars.length)]; 7 | return result; 8 | } 9 | 10 | function randomAlphanumeric(length) { 11 | return randomString(length, '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'); 12 | } 13 | 14 | var target; 15 | var dispatcher; 16 | var dispatcherAsTarget; 17 | var size = Math.floor(Math.random() * 100); 18 | var state = randomAlphanumeric(size); 19 | 20 | contract('Dispatcher', function(accounts) { 21 | 22 | it("should dispatch requests", async () => { 23 | target = await Target.new(); 24 | dispatcher = await Dispatcher.new(target.address); 25 | dispatcherAsTarget = Target.at(dispatcher.address); 26 | 27 | await dispatcherAsTarget.setStringState(state) 28 | assert.equal(await dispatcherAsTarget.stringState.call(), state); 29 | }); 30 | 31 | it("should use storage from Dispatcher, not from target", async () => { 32 | var size2 = Math.floor(Math.random() * 100); 33 | var state2 = randomAlphanumeric(size2); 34 | 35 | assert.equal(await target.stringState.call(), ""); 36 | await target.setStringState(state2) 37 | assert.equal(await target.stringState.call(), state2); 38 | assert.equal(await dispatcherAsTarget.stringState.call(), state); 39 | }); 40 | 41 | it("should consume not more than 1100 gas", async () => { 42 | var testValue = Math.floor(Math.random() * 1000); 43 | 44 | var dispatchedGas = (await dispatcherAsTarget.setIntState(testValue)).receipt.gasUsed; 45 | var directGas = (await target.setIntState(testValue)).receipt.gasUsed; 46 | 47 | console.log("gasUsage: direct=" + directGas + " dispatched=" + dispatchedGas + " diff=" + (dispatchedGas - directGas) + " (" + 100 * (dispatchedGas - directGas) / directGas + "%)"); 48 | assert.isBelow(dispatchedGas - directGas, 1100); 49 | }); 50 | }); 51 | -------------------------------------------------------------------------------- /test/upgradeable.js: -------------------------------------------------------------------------------- 1 | var Dispatcher = artifacts.require("./upgradeable/Dispatcher.sol"); 2 | var Target = artifacts.require("./contracts/Target.sol"); 3 | var TargetV2 = artifacts.require("./contracts/TargetV2.sol"); 4 | var ErrorTarget = artifacts.require("./contracts/ErrorTarget.sol"); 5 | var StateErrorTarget = artifacts.require("./contracts/StateErrorTarget.sol"); 6 | var NotVerifyingTarget = artifacts.require("./contracts/NotVerifyingTarget.sol"); 7 | 8 | const expectThrow = require('daonomic-tests').expectThrow; 9 | 10 | contract('Upgradeable', function(accounts) { 11 | 12 | it("should let upgrade to v2", async () => { 13 | var target = await Target.deployed(); 14 | var targetV2 = await TargetV2.deployed(); 15 | var dispatcher = await Dispatcher.deployed(); 16 | var dispatcherAsTarget = Target.at(dispatcher.address); 17 | var dispatcherAsTargetV2 = TargetV2.at(dispatcher.address); 18 | 19 | await dispatcherAsTarget.upgrade(targetV2.address, {from: accounts[2]}) 20 | await dispatcherAsTargetV2.increaseIntState(); 21 | await dispatcherAsTargetV2.setAdmin(accounts[1]); 22 | assert.equal(await dispatcherAsTargetV2.intState.call(), 1); 23 | }); 24 | 25 | it("should not let upgrade if checkAdmin fails", async () => { 26 | var target = await Target.deployed(); 27 | var dispatcher = await Dispatcher.deployed(); 28 | var dispatcherAsTargetV2 = TargetV2.at(dispatcher.address); 29 | 30 | await expectThrow(dispatcherAsTargetV2.upgrade(target.address)); 31 | }); 32 | 33 | it("should let upgrade if checkAdmin succeeds", async () => { 34 | var target = await Target.deployed(); 35 | var dispatcher = await Dispatcher.deployed(); 36 | var dispatcherAsTargetV2 = TargetV2.at(dispatcher.address); 37 | 38 | await dispatcherAsTargetV2.upgrade(target.address, {from: accounts[1]}) 39 | }); 40 | 41 | it("should not let upgrade if target can't be verified", async () => { 42 | var dispatcher = await Dispatcher.deployed(); 43 | var dispatcherAsTarget = Target.at(dispatcher.address); 44 | var errorTarget = await ErrorTarget.deployed(); 45 | 46 | await expectThrow(dispatcherAsTarget.upgrade(errorTarget.address)); 47 | }); 48 | 49 | it("should not not let upgrade if intState can't be verified", async () => { 50 | var dispatcher = await Dispatcher.deployed(); 51 | var dispatcherAsTarget = Target.at(dispatcher.address); 52 | var stateErrorTarget = await StateErrorTarget.deployed(); 53 | 54 | await expectThrow(dispatcherAsTarget.upgrade(stateErrorTarget.address)); 55 | }); 56 | 57 | it("but it'll let upgrade if no check present", async () => { 58 | var dispatcher = await Dispatcher.deployed(); 59 | var dispatcherAsTarget = Target.at(dispatcher.address); 60 | var stateErrorTarget = await StateErrorTarget.deployed(); 61 | var notVerifyingTarget = await NotVerifyingTarget.deployed(); 62 | 63 | await dispatcherAsTarget.setStringState("test state"); 64 | await dispatcherAsTarget.upgrade(notVerifyingTarget.address); 65 | await dispatcherAsTarget.upgrade(stateErrorTarget.address); 66 | assert.notEqual(await dispatcherAsTarget.stringState.call(), "test state"); 67 | 68 | await dispatcherAsTarget.upgrade(notVerifyingTarget.address); 69 | assert.equal(await dispatcherAsTarget.stringState.call(), "test state"); 70 | }); 71 | }); 72 | -------------------------------------------------------------------------------- /testrpc.sh: -------------------------------------------------------------------------------- 1 | #!/usr/bin/env bash 2 | testrpc -------------------------------------------------------------------------------- /truffle.js: -------------------------------------------------------------------------------- 1 | module.exports = { 2 | networks: { 3 | }, 4 | solc: { 5 | optimizer: { 6 | enabled: true, 7 | runs: 200 8 | } 9 | } 10 | }; 11 | --------------------------------------------------------------------------------