73 | );
74 | }
75 | }
76 |
77 | const TodoApp = connect(mapStateToProps, mapDispatchToProps)(Todo);
78 |
79 | // const mapStateToProps = state => {
80 | // return {
81 | // todos: state.todos
82 | // };
83 | // };
84 | //
85 | // const TodoApp = connect(mapStateToProps, mapDispatchToProps)(TodoList);
86 |
87 | export default TodoApp;
88 |
--------------------------------------------------------------------------------
/packages/home/src/logo.svg:
--------------------------------------------------------------------------------
1 |
8 |
--------------------------------------------------------------------------------
/README.md:
--------------------------------------------------------------------------------
1 | # Delivery Console Prototype v0
2 |
3 | This is an experimental implementation of
4 | [`create-react-app`](https://github.com/facebookincubator/create-react-app) with
5 | `react-router-dom`, `react-loadable` and `yarn workspaces`.
6 |
7 | ## To run
8 |
9 | For this to work you first need to enable workspaces in `yarn`. Simply run:
10 |
11 | ```sh
12 | $ yarn config set workspaces-experimental true
13 | ```
14 |
15 | That should update your `~/.yarnrc`.
16 |
17 | ```sh
18 | $ git clone https://github.com/peterbe/devcons.git
19 | $ yarn
20 | $ yarn start
21 | $ open http://localhost:3000
22 | ```
23 |
24 | ## To build and serve
25 |
26 | Globally install [`serve`](https://www.npmjs.com/package/serve)
27 |
28 | ```sh
29 | $ yarn serve
30 | $ open http://localhost:5000
31 | ```
32 |
33 | ## To run tests
34 |
35 | ```sh
36 | $ yarn test
37 | ```
38 |
39 | Note that `jest` only runs tests based on the files since the last commit.
40 | The interactive test running should mention this and you can press `a` to
41 | run all tests.
42 |
43 | ## Source map exploration
44 |
45 | The whole point of using async loading is to avoid the cost of having to
46 | download a monster .js bundle for the union of all packages in all
47 | different workspaces. To prove that the lazy loaded chunks "self-contain"
48 | the packages only they need. To see this in action, globally install
49 | [`source-map-explorer`](https://www.npmjs.com/package/source-map-explorer).
50 |
51 | ```sh
52 | $ yarn global add source-map-explorer
53 | $ yarn build
54 | $ ls packages/home/build/static/js
55 | 0.0c747db6.chunk.js 0.0c747db6.chunk.js.map main.6d9855f0.js main.6d9855f0.js.map
56 | $ source-map-explorer packages/home/build/static/js/0.0c747db6.chunk.js
57 | $ source-map-explorer packages/home/build/static/js/main.6d9855f0.js
58 | ```
59 |
60 | ## How it works
61 |
62 | The core React app is the `packages/home` one. It's the one that imports
63 | the other components from the other workspace packages.
64 |
65 | It uses `react-router-dom` to redirect traffic to components in other
66 | packages and when it does so it uses `react-loadable` which
67 | asynchronously loads them.
68 |
69 | ### Rational
70 |
71 | The goal is that each app is a contained folder containing a bunch of
72 | React components and it's own `package.json` where it can maintain a list
73 | of vendor packages these app components need. This makes for better
74 | organization of files. Each app feels more self-contained even though
75 | it's only imports for the `home` app.
76 |
77 | The user experience is ideal in that minimal build JS is downloaded
78 | if the user only uses some few apps, for example, only using the `home`
79 | app (to sign in and as landing page) and the Normandy app. Then xhe
80 | shouldn't have to download all the resources that `someotherapp` requires.
81 |
82 | ## Caveats
83 |
84 | * When working on an app/component that isn't imported you don't get
85 | those `create-react-app` `eslint` warnings immediately.
86 | That's because the code you might be working on isn't imported yet.
87 | Perhaps this can be solved by some hack that depends on
88 | `process.env.NODE_ENV` so that it imports all files during development.
89 |
90 | * Perhaps it's not convenient to load the `home` and have the app you're
91 | strongly interested in being async loaded. See point above.
92 | Perhaps it's possible to write a, for example, `packages/normandy/index.js`
93 | that you can start with `yarn start` specifically in that directory. Then
94 | it could have a mock of the `home` app's top bar and nav etc.
95 |
--------------------------------------------------------------------------------
/packages/home/src/App.js:
--------------------------------------------------------------------------------
1 | import React from 'react';
2 | import {
3 | BrowserRouter as Router,
4 | Route,
5 | NavLink,
6 | Link,
7 | Switch
8 | } from 'react-router-dom';
9 | import Loadable from 'react-loadable';
10 | import './App.css';
11 |
12 | import {
13 | Home,
14 | About,
15 | SignIn,
16 | PageNotFound,
17 | LoadingWrapper
18 | } from './Components';
19 | // import { PageNotFound } from 'common/src/PageNotFound';
20 | // import { PageNotFound } from 'common/src/Loading';
21 | // import { App as NormandyApp } from "normandy/src/App";
22 | // import { App as NormandyApp } from 'normandy/src/App';
23 | // console.log("TEST", NormandyApp);
24 |
25 | // const LoadableNormandyApp = Loadable({
26 | // loader: () => import('normandy/src/App'),
27 | // loading() {
28 | // return
Loading...
;
29 | // }
30 | // });
31 |
32 | // XXX Make this more generic and not hardcoded.
33 | const Normandy = Loadable({
34 | loader: () => import('normandy/src/App'),
35 | loading: LoadingWrapper('Normandy')
36 | });
37 |
38 | class App extends React.Component {
39 | setCameFrom = event => {
40 | let camefrom = window.location.pathname;
41 | if (window.location.search) {
42 | camefrom += window.location.search;
43 | }
44 | window.sessionStorage.setItem('camefrom', camefrom);
45 | };
46 |
47 | componentDidMount() {
48 | // XXX There's a cool thing we could do.
49 | // Now that the home app has loaded, we could ask our localStorage
50 | // or something for the users preferred app(s). Suppose we
51 | // can figure out that this user often loads Normandy, we could
52 | // trigger `Normandy.preload()`
53 | // this._preloadApp('normandy');
54 | }
55 |
56 | onNavLinkHover = app => {
57 | this._preloadApp(app);
58 | };
59 |
60 | // Memory of which apps have been preloaded.
61 | preloadedApps = new Set();
62 |
63 | _preloadApp = app => {
64 | if (!this.preloadedApps.has(app)) {
65 | this.preloadedApps.add(app);
66 | switch (app) {
67 | case 'normandy':
68 | Normandy.preload();
69 | break;
70 | default:
71 | console.warn(`Not sure how to reload: ${app}`);
72 | }
73 | }
74 | };
75 |
76 | render() {
77 | return (
78 |
79 |
138 |
139 | );
140 | }
141 | }
142 |
143 | export default App;
144 |
--------------------------------------------------------------------------------
/packages/home/src/registerServiceWorker.js:
--------------------------------------------------------------------------------
1 | // In production, we register a service worker to serve assets from local cache.
2 |
3 | // This lets the app load faster on subsequent visits in production, and gives
4 | // it offline capabilities. However, it also means that developers (and users)
5 | // will only see deployed updates on the "N+1" visit to a page, since previously
6 | // cached resources are updated in the background.
7 |
8 | // To learn more about the benefits of this model, read https://goo.gl/KwvDNy.
9 | // This link also includes instructions on opting out of this behavior.
10 |
11 | const isLocalhost = Boolean(
12 | window.location.hostname === 'localhost' ||
13 | // [::1] is the IPv6 localhost address.
14 | window.location.hostname === '[::1]' ||
15 | // 127.0.0.1/8 is considered localhost for IPv4.
16 | window.location.hostname.match(
17 | /^127(?:\.(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)){3}$/
18 | )
19 | );
20 |
21 | export default function register() {
22 | if (process.env.NODE_ENV === 'production' && 'serviceWorker' in navigator) {
23 | // The URL constructor is available in all browsers that support SW.
24 | const publicUrl = new URL(process.env.PUBLIC_URL, window.location);
25 | if (publicUrl.origin !== window.location.origin) {
26 | // Our service worker won't work if PUBLIC_URL is on a different origin
27 | // from what our page is served on. This might happen if a CDN is used to
28 | // serve assets; see https://github.com/facebookincubator/create-react-app/issues/2374
29 | return;
30 | }
31 |
32 | window.addEventListener('load', () => {
33 | const swUrl = `${process.env.PUBLIC_URL}/service-worker.js`;
34 |
35 | if (isLocalhost) {
36 | // This is running on localhost. Lets check if a service worker still exists or not.
37 | checkValidServiceWorker(swUrl);
38 |
39 | // Add some additional logging to localhost, pointing developers to the
40 | // service worker/PWA documentation.
41 | navigator.serviceWorker.ready.then(() => {
42 | console.log(
43 | 'This web app is being served cache-first by a service ' +
44 | 'worker. To learn more, visit https://goo.gl/SC7cgQ'
45 | );
46 | });
47 | } else {
48 | // Is not local host. Just register service worker
49 | registerValidSW(swUrl);
50 | }
51 | });
52 | }
53 | }
54 |
55 | function registerValidSW(swUrl) {
56 | navigator.serviceWorker
57 | .register(swUrl)
58 | .then(registration => {
59 | registration.onupdatefound = () => {
60 | const installingWorker = registration.installing;
61 | installingWorker.onstatechange = () => {
62 | if (installingWorker.state === 'installed') {
63 | if (navigator.serviceWorker.controller) {
64 | // At this point, the old content will have been purged and
65 | // the fresh content will have been added to the cache.
66 | // It's the perfect time to display a "New content is
67 | // available; please refresh." message in your web app.
68 | console.log('New content is available; please refresh.');
69 | } else {
70 | // At this point, everything has been precached.
71 | // It's the perfect time to display a
72 | // "Content is cached for offline use." message.
73 | console.log('Content is cached for offline use.');
74 | }
75 | }
76 | };
77 | };
78 | })
79 | .catch(error => {
80 | console.error('Error during service worker registration:', error);
81 | });
82 | }
83 |
84 | function checkValidServiceWorker(swUrl) {
85 | // Check if the service worker can be found. If it can't reload the page.
86 | fetch(swUrl)
87 | .then(response => {
88 | // Ensure service worker exists, and that we really are getting a JS file.
89 | if (
90 | response.status === 404 ||
91 | response.headers.get('content-type').indexOf('javascript') === -1
92 | ) {
93 | // No service worker found. Probably a different app. Reload the page.
94 | navigator.serviceWorker.ready.then(registration => {
95 | registration.unregister().then(() => {
96 | window.location.reload();
97 | });
98 | });
99 | } else {
100 | // Service worker found. Proceed as normal.
101 | registerValidSW(swUrl);
102 | }
103 | })
104 | .catch(() => {
105 | console.log(
106 | 'No internet connection found. App is running in offline mode.'
107 | );
108 | });
109 | }
110 |
111 | export function unregister() {
112 | if ('serviceWorker' in navigator) {
113 | navigator.serviceWorker.ready.then(registration => {
114 | registration.unregister();
115 | });
116 | }
117 | }
118 |
--------------------------------------------------------------------------------