├── .gitignore ├── README.md ├── build.gradle ├── chromedriver ├── chromedriver.exe ├── chromedriver_linux ├── gradle └── wrapper │ ├── gradle-wrapper.jar │ └── gradle-wrapper.properties ├── gradlew ├── gradlew.bat ├── pom.xml ├── settings.gradle └── src └── main └── java ├── FlightBookingTest.java ├── HotelBookingTest.java └── SignInTest.java /.gitignore: -------------------------------------------------------------------------------- 1 | build 2 | .idea 3 | .gradle -------------------------------------------------------------------------------- /README.md: -------------------------------------------------------------------------------- 1 | # TestVagrant hiring challenge for applicants 2 | 3 | About the codebase: 4 | --------------------------------- 5 | *This is a simple test project for testing a few scenarios on a sample flight/hotel booking website. There are **3 tests** in total spread over 3 test classes. Following tech stack has been used to develop the same.* 6 | 7 | **Tech Stack:** *Java* *Selenium* *TestNG* *Gradle/Maven* 8 | 9 | **The parameters of evaluation** 10 | ---------------------------------- 11 | 1. Naming Conventions & readability of code 12 | 2. Modularization & Abstraction 13 | 3. Demonstration of OO concepts & Design Patterns 14 | 4. Etiquette of Version control 15 | 16 | Problem Statement 17 | ---------------------------------- 18 | **Tasks:** 19 | 20 | 1. Test are failing which needs your expertise to fix it. 21 | 2. Review and point out design issues with the current codebase/framework, if any. 22 | 3. Improve/refactor the code to implement your suggestions. 23 | 24 | **Expectation:** 25 | 1. Create a GitHub account if not existing already. 26 | 2. Fork this repo (DO NOT CLONE). 27 | 3. Fix the errors and refactor the code, consider **abstractions, reusability and maintenance.** 28 | 4. Make sure you make multiple check-ins in the process, we would love to see your progress bit by bit. 29 | 5. Also check-in a separate file where you should list all your code review comments. 30 | 6. Send us the link of your GitHub repo to **careers@testvagrant.com**. Also attach your **resume**. 31 | -------------------------------------------------------------------------------- /build.gradle: -------------------------------------------------------------------------------- 1 | group 'com.testvagrant.codingRound' 2 | version '1.0-SNAPSHOT' 3 | 4 | apply plugin: 'java' 5 | apply plugin: 'maven' 6 | 7 | sourceCompatibility = 1.8 8 | 9 | repositories { 10 | mavenCentral() 11 | } 12 | 13 | dependencies { 14 | compile group: 'junit', name: 'junit', version: '4.11' 15 | compile group: 'org.seleniumhq.selenium', name: 'selenium-java', version: '3.6.0' 16 | compile group: 'org.testng', name: 'testng', version: '6.11' 17 | } 18 | -------------------------------------------------------------------------------- /chromedriver: -------------------------------------------------------------------------------- https://raw.githubusercontent.com/tvarchive/codingRound/50f70d50db7a76e9a89357c7ff77378f5df9bffe/chromedriver -------------------------------------------------------------------------------- /chromedriver.exe: -------------------------------------------------------------------------------- https://raw.githubusercontent.com/tvarchive/codingRound/50f70d50db7a76e9a89357c7ff77378f5df9bffe/chromedriver.exe -------------------------------------------------------------------------------- /chromedriver_linux: -------------------------------------------------------------------------------- https://raw.githubusercontent.com/tvarchive/codingRound/50f70d50db7a76e9a89357c7ff77378f5df9bffe/chromedriver_linux -------------------------------------------------------------------------------- /gradle/wrapper/gradle-wrapper.jar: -------------------------------------------------------------------------------- https://raw.githubusercontent.com/tvarchive/codingRound/50f70d50db7a76e9a89357c7ff77378f5df9bffe/gradle/wrapper/gradle-wrapper.jar -------------------------------------------------------------------------------- /gradle/wrapper/gradle-wrapper.properties: -------------------------------------------------------------------------------- 1 | #Sat Oct 14 18:55:29 IST 2017 2 | distributionBase=GRADLE_USER_HOME 3 | distributionPath=wrapper/dists 4 | zipStoreBase=GRADLE_USER_HOME 5 | zipStorePath=wrapper/dists 6 | distributionUrl=https\://services.gradle.org/distributions/gradle-2.9-all.zip 7 | -------------------------------------------------------------------------------- /gradlew: -------------------------------------------------------------------------------- 1 | #!/usr/bin/env bash 2 | 3 | ############################################################################## 4 | ## 5 | ## Gradle start up script for UN*X 6 | ## 7 | ############################################################################## 8 | 9 | # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. 10 | DEFAULT_JVM_OPTS="" 11 | 12 | APP_NAME="Gradle" 13 | APP_BASE_NAME=`basename "$0"` 14 | 15 | # Use the maximum available, or set MAX_FD != -1 to use that value. 16 | MAX_FD="maximum" 17 | 18 | warn ( ) { 19 | echo "$*" 20 | } 21 | 22 | die ( ) { 23 | echo 24 | echo "$*" 25 | echo 26 | exit 1 27 | } 28 | 29 | # OS specific support (must be 'true' or 'false'). 30 | cygwin=false 31 | msys=false 32 | darwin=false 33 | case "`uname`" in 34 | CYGWIN* ) 35 | cygwin=true 36 | ;; 37 | Darwin* ) 38 | darwin=true 39 | ;; 40 | MINGW* ) 41 | msys=true 42 | ;; 43 | esac 44 | 45 | # Attempt to set APP_HOME 46 | # Resolve links: $0 may be a link 47 | PRG="$0" 48 | # Need this for relative symlinks. 49 | while [ -h "$PRG" ] ; do 50 | ls=`ls -ld "$PRG"` 51 | link=`expr "$ls" : '.*-> \(.*\)$'` 52 | if expr "$link" : '/.*' > /dev/null; then 53 | PRG="$link" 54 | else 55 | PRG=`dirname "$PRG"`"/$link" 56 | fi 57 | done 58 | SAVED="`pwd`" 59 | cd "`dirname \"$PRG\"`/" >/dev/null 60 | APP_HOME="`pwd -P`" 61 | cd "$SAVED" >/dev/null 62 | 63 | CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar 64 | 65 | # Determine the Java command to use to start the JVM. 66 | if [ -n "$JAVA_HOME" ] ; then 67 | if [ -x "$JAVA_HOME/jre/sh/java" ] ; then 68 | # IBM's JDK on AIX uses strange locations for the executables 69 | JAVACMD="$JAVA_HOME/jre/sh/java" 70 | else 71 | JAVACMD="$JAVA_HOME/bin/java" 72 | fi 73 | if [ ! -x "$JAVACMD" ] ; then 74 | die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME 75 | 76 | Please set the JAVA_HOME variable in your environment to match the 77 | location of your Java installation." 78 | fi 79 | else 80 | JAVACMD="java" 81 | which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 82 | 83 | Please set the JAVA_HOME variable in your environment to match the 84 | location of your Java installation." 85 | fi 86 | 87 | # Increase the maximum file descriptors if we can. 88 | if [ "$cygwin" = "false" -a "$darwin" = "false" ] ; then 89 | MAX_FD_LIMIT=`ulimit -H -n` 90 | if [ $? -eq 0 ] ; then 91 | if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then 92 | MAX_FD="$MAX_FD_LIMIT" 93 | fi 94 | ulimit -n $MAX_FD 95 | if [ $? -ne 0 ] ; then 96 | warn "Could not set maximum file descriptor limit: $MAX_FD" 97 | fi 98 | else 99 | warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" 100 | fi 101 | fi 102 | 103 | # For Darwin, add options to specify how the application appears in the dock 104 | if $darwin; then 105 | GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" 106 | fi 107 | 108 | # For Cygwin, switch paths to Windows format before running java 109 | if $cygwin ; then 110 | APP_HOME=`cygpath --path --mixed "$APP_HOME"` 111 | CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` 112 | JAVACMD=`cygpath --unix "$JAVACMD"` 113 | 114 | # We build the pattern for arguments to be converted via cygpath 115 | ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` 116 | SEP="" 117 | for dir in $ROOTDIRSRAW ; do 118 | ROOTDIRS="$ROOTDIRS$SEP$dir" 119 | SEP="|" 120 | done 121 | OURCYGPATTERN="(^($ROOTDIRS))" 122 | # Add a user-defined pattern to the cygpath arguments 123 | if [ "$GRADLE_CYGPATTERN" != "" ] ; then 124 | OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" 125 | fi 126 | # Now convert the arguments - kludge to limit ourselves to /bin/sh 127 | i=0 128 | for arg in "$@" ; do 129 | CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` 130 | CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option 131 | 132 | if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition 133 | eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` 134 | else 135 | eval `echo args$i`="\"$arg\"" 136 | fi 137 | i=$((i+1)) 138 | done 139 | case $i in 140 | (0) set -- ;; 141 | (1) set -- "$args0" ;; 142 | (2) set -- "$args0" "$args1" ;; 143 | (3) set -- "$args0" "$args1" "$args2" ;; 144 | (4) set -- "$args0" "$args1" "$args2" "$args3" ;; 145 | (5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; 146 | (6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; 147 | (7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; 148 | (8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; 149 | (9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; 150 | esac 151 | fi 152 | 153 | # Split up the JVM_OPTS And GRADLE_OPTS values into an array, following the shell quoting and substitution rules 154 | function splitJvmOpts() { 155 | JVM_OPTS=("$@") 156 | } 157 | eval splitJvmOpts $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS 158 | JVM_OPTS[${#JVM_OPTS[*]}]="-Dorg.gradle.appname=$APP_BASE_NAME" 159 | 160 | exec "$JAVACMD" "${JVM_OPTS[@]}" -classpath "$CLASSPATH" org.gradle.wrapper.GradleWrapperMain "$@" 161 | -------------------------------------------------------------------------------- /gradlew.bat: -------------------------------------------------------------------------------- 1 | @if "%DEBUG%" == "" @echo off 2 | @rem ########################################################################## 3 | @rem 4 | @rem Gradle startup script for Windows 5 | @rem 6 | @rem ########################################################################## 7 | 8 | @rem Set local scope for the variables with windows NT shell 9 | if "%OS%"=="Windows_NT" setlocal 10 | 11 | @rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. 12 | set DEFAULT_JVM_OPTS= 13 | 14 | set DIRNAME=%~dp0 15 | if "%DIRNAME%" == "" set DIRNAME=. 16 | set APP_BASE_NAME=%~n0 17 | set APP_HOME=%DIRNAME% 18 | 19 | @rem Find java.exe 20 | if defined JAVA_HOME goto findJavaFromJavaHome 21 | 22 | set JAVA_EXE=java.exe 23 | %JAVA_EXE% -version >NUL 2>&1 24 | if "%ERRORLEVEL%" == "0" goto init 25 | 26 | echo. 27 | echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 28 | echo. 29 | echo Please set the JAVA_HOME variable in your environment to match the 30 | echo location of your Java installation. 31 | 32 | goto fail 33 | 34 | :findJavaFromJavaHome 35 | set JAVA_HOME=%JAVA_HOME:"=% 36 | set JAVA_EXE=%JAVA_HOME%/bin/java.exe 37 | 38 | if exist "%JAVA_EXE%" goto init 39 | 40 | echo. 41 | echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 42 | echo. 43 | echo Please set the JAVA_HOME variable in your environment to match the 44 | echo location of your Java installation. 45 | 46 | goto fail 47 | 48 | :init 49 | @rem Get command-line arguments, handling Windowz variants 50 | 51 | if not "%OS%" == "Windows_NT" goto win9xME_args 52 | if "%@eval[2+2]" == "4" goto 4NT_args 53 | 54 | :win9xME_args 55 | @rem Slurp the command line arguments. 56 | set CMD_LINE_ARGS= 57 | set _SKIP=2 58 | 59 | :win9xME_args_slurp 60 | if "x%~1" == "x" goto execute 61 | 62 | set CMD_LINE_ARGS=%* 63 | goto execute 64 | 65 | :4NT_args 66 | @rem Get arguments from the 4NT Shell from JP Software 67 | set CMD_LINE_ARGS=%$ 68 | 69 | :execute 70 | @rem Setup the command line 71 | 72 | set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar 73 | 74 | @rem Execute Gradle 75 | "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS% 76 | 77 | :end 78 | @rem End local scope for the variables with windows NT shell 79 | if "%ERRORLEVEL%"=="0" goto mainEnd 80 | 81 | :fail 82 | rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of 83 | rem the _cmd.exe /c_ return code! 84 | if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1 85 | exit /b 1 86 | 87 | :mainEnd 88 | if "%OS%"=="Windows_NT" endlocal 89 | 90 | :omega 91 | -------------------------------------------------------------------------------- /pom.xml: -------------------------------------------------------------------------------- 1 | 2 | 4 | 4.0.0 5 | com.testvagrant.codingRound 6 | codoingRound 7 | 1.0-SNAPSHOT 8 | 9 | 10 | junit 11 | junit 12 | 4.11 13 | compile 14 | 15 | 16 | org.seleniumhq.selenium 17 | selenium-java 18 | 3.6.0 19 | compile 20 | 21 | 22 | org.testng 23 | testng 24 | 6.11 25 | compile 26 | 27 | 28 | 29 | -------------------------------------------------------------------------------- /settings.gradle: -------------------------------------------------------------------------------- 1 | rootProject.name = 'codoingRound' 2 | 3 | -------------------------------------------------------------------------------- /src/main/java/FlightBookingTest.java: -------------------------------------------------------------------------------- 1 | import com.sun.javafx.PlatformUtil; 2 | import org.openqa.selenium.By; 3 | import org.openqa.selenium.NoSuchElementException; 4 | import org.openqa.selenium.WebDriver; 5 | import org.openqa.selenium.WebElement; 6 | import org.openqa.selenium.chrome.ChromeDriver; 7 | import org.openqa.selenium.support.ui.Select; 8 | import org.testng.Assert; 9 | import org.testng.annotations.Test; 10 | 11 | import java.util.List; 12 | 13 | public class FlightBookingTest { 14 | 15 | WebDriver driver = new ChromeDriver(); 16 | 17 | 18 | @Test 19 | public void testThatResultsAppearForAOneWayJourney() { 20 | 21 | setDriverPath(); 22 | driver.get("https://www.cleartrip.com/"); 23 | waitFor(2000); 24 | driver.findElement(By.id("OneWay")).click(); 25 | 26 | driver.findElement(By.id("FromTag")).clear(); 27 | driver.findElement(By.id("FromTag")).sendKeys("Bangalore"); 28 | 29 | //wait for the auto complete options to appear for the origin 30 | 31 | waitFor(2000); 32 | List originOptions = driver.findElement(By.id("ui-id-1")).findElements(By.tagName("li")); 33 | originOptions.get(0).click(); 34 | 35 | driver.findElement(By.id("toTag")).clear(); 36 | driver.findElement(By.id("toTag")).sendKeys("Delhi"); 37 | 38 | //wait for the auto complete options to appear for the destination 39 | 40 | waitFor(2000); 41 | //select the first item from the destination auto complete list 42 | List destinationOptions = driver.findElement(By.id("ui-id-2")).findElements(By.tagName("li")); 43 | destinationOptions.get(0).click(); 44 | 45 | driver.findElement(By.xpath("//*[@id='ui-datepicker-div']/div[1]/table/tbody/tr[3]/td[7]/a")).click(); 46 | 47 | //all fields filled in. Now click on search 48 | driver.findElement(By.id("SearchBtn")).click(); 49 | 50 | waitFor(5000); 51 | //verify that result appears for the provided journey search 52 | Assert.assertTrue(isElementPresent(By.className("searchSummary"))); 53 | 54 | //close the browser 55 | driver.quit(); 56 | 57 | } 58 | 59 | 60 | private void waitFor(int durationInMilliSeconds) { 61 | try { 62 | Thread.sleep(durationInMilliSeconds); 63 | } catch (InterruptedException e) { 64 | e.printStackTrace(); //To change body of catch statement use File | Settings | File Templates. 65 | } 66 | } 67 | 68 | 69 | private boolean isElementPresent(By by) { 70 | try { 71 | driver.findElement(by); 72 | return true; 73 | } catch (NoSuchElementException e) { 74 | return false; 75 | } 76 | } 77 | 78 | private void setDriverPath() { 79 | if (PlatformUtil.isMac()) { 80 | System.setProperty("webdriver.chrome.driver", "chromedriver"); 81 | } 82 | if (PlatformUtil.isWindows()) { 83 | System.setProperty("webdriver.chrome.driver", "chromedriver.exe"); 84 | } 85 | if (PlatformUtil.isLinux()) { 86 | System.setProperty("webdriver.chrome.driver", "chromedriver_linux"); 87 | } 88 | } 89 | } 90 | -------------------------------------------------------------------------------- /src/main/java/HotelBookingTest.java: -------------------------------------------------------------------------------- 1 | import com.sun.javafx.PlatformUtil; 2 | import org.openqa.selenium.WebDriver; 3 | import org.openqa.selenium.WebElement; 4 | import org.openqa.selenium.chrome.ChromeDriver; 5 | import org.openqa.selenium.support.FindBy; 6 | import org.openqa.selenium.support.ui.Select; 7 | import org.testng.annotations.Test; 8 | 9 | public class HotelBookingTest { 10 | 11 | WebDriver driver = new ChromeDriver(); 12 | 13 | @FindBy(linkText = "Hotels") 14 | private WebElement hotelLink; 15 | 16 | @FindBy(id = "Tags") 17 | private WebElement localityTextBox; 18 | 19 | @FindBy(id = "SearchHotelsButton") 20 | private WebElement searchButton; 21 | 22 | @FindBy(id = "travellersOnhome") 23 | private WebElement travellerSelection; 24 | 25 | @Test 26 | public void shouldBeAbleToSearchForHotels() { 27 | setDriverPath(); 28 | 29 | driver.get("https://www.cleartrip.com/"); 30 | hotelLink.click(); 31 | 32 | localityTextBox.sendKeys("Indiranagar, Bangalore"); 33 | 34 | new Select(travellerSelection).selectByVisibleText("1 room, 2 adults"); 35 | searchButton.click(); 36 | 37 | driver.quit(); 38 | 39 | } 40 | 41 | private void setDriverPath() { 42 | if (PlatformUtil.isMac()) { 43 | System.setProperty("webdriver.chrome.driver", "chromedriver"); 44 | } 45 | if (PlatformUtil.isWindows()) { 46 | System.setProperty("webdriver.chrome.driver", "chromedriver.exe"); 47 | } 48 | if (PlatformUtil.isLinux()) { 49 | System.setProperty("webdriver.chrome.driver", "chromedriver_linux"); 50 | } 51 | } 52 | 53 | } 54 | -------------------------------------------------------------------------------- /src/main/java/SignInTest.java: -------------------------------------------------------------------------------- 1 | import com.sun.javafx.PlatformUtil; 2 | import org.openqa.selenium.By; 3 | import org.openqa.selenium.WebDriver; 4 | import org.openqa.selenium.chrome.ChromeDriver; 5 | import org.testng.Assert; 6 | import org.testng.annotations.Test; 7 | 8 | public class SignInTest { 9 | 10 | WebDriver driver = new ChromeDriver(); 11 | 12 | @Test 13 | public void shouldThrowAnErrorIfSignInDetailsAreMissing() { 14 | 15 | setDriverPath(); 16 | 17 | driver.get("https://www.cleartrip.com/"); 18 | waitFor(2000); 19 | 20 | driver.findElement(By.linkText("Your trips")).click(); 21 | driver.findElement(By.id("SignIn")).click(); 22 | 23 | driver.findElement(By.id("signInButton")).click(); 24 | 25 | String errors1 = driver.findElement(By.id("errors1")).getText(); 26 | Assert.assertTrue(errors1.contains("There were errors in your submission")); 27 | driver.quit(); 28 | } 29 | 30 | private void waitFor(int durationInMilliSeconds) { 31 | try { 32 | Thread.sleep(durationInMilliSeconds); 33 | } catch (InterruptedException e) { 34 | e.printStackTrace(); //To change body of catch statement use File | Settings | File Templates. 35 | } 36 | } 37 | 38 | private void setDriverPath() { 39 | if (PlatformUtil.isMac()) { 40 | System.setProperty("webdriver.chrome.driver", "chromedriver"); 41 | } 42 | if (PlatformUtil.isWindows()) { 43 | System.setProperty("webdriver.chrome.driver", "chromedriver.exe"); 44 | } 45 | if (PlatformUtil.isLinux()) { 46 | System.setProperty("webdriver.chrome.driver", "chromedriver_linux"); 47 | } 48 | } 49 | 50 | 51 | } 52 | --------------------------------------------------------------------------------