├── core ├── ReadMe.md └── notes │ ├── _template.md │ ├── 2014-12-17.md │ ├── 2014-12-03.md │ ├── 2015-01-14.md │ ├── 2014-11-26.md │ ├── 2016-03-08.md │ ├── 2015-01-21.md │ ├── 2016-02-23.md │ ├── 2016-03-01.md │ ├── 2015-09-08.md │ ├── 2015-09-01.md │ └── 2016-03-15.md ├── community └── ReadMe.md ├── .gitignore ├── modules ├── notes │ ├── 2015-03-19.md │ ├── 2015-07-02.md │ ├── 2015-05-21.md │ ├── 2015-04-02.md │ ├── 2015-07-23.md │ ├── 2016-01-21.md │ ├── 2015-07-09.md │ ├── 2015-04-09.md │ ├── 2015-10-22.md │ ├── 2015-02-26.md │ ├── 2015-04-16.md │ ├── 2015-04-23.md │ ├── 2015-04-30.md │ ├── 2016-03-03.md │ ├── 2015-09-17.md │ ├── 2015-08-06.md │ ├── 2016-07-07.md │ ├── 2015-06-25.md │ ├── 2015-11-05.md │ ├── 2015-08-13.md │ ├── 2016-03-10.md │ ├── 2016-02-04.md │ ├── 2015-05-07.md │ ├── 2015-09-03.md │ ├── 2016-01-28.md │ ├── 2015-09-10.md │ ├── 2016-02-25.md │ ├── 2015-08-27.md │ ├── 2016-05-05.md │ ├── 2016-02-11.md │ ├── 2016-03-31.md │ ├── 2015-08-20.md │ ├── 2015-11-19.md │ ├── 2015-03-24.md │ ├── 2016-06-30.md │ ├── 2016-07-28.md │ ├── 2015-12-03.md │ ├── 2015-05-28.md │ ├── 2015-12-10.md │ ├── 2016-04-14.md │ ├── 2016-04-28.md │ ├── 2016-04-21.md │ ├── 2015-06-04.md │ ├── 2016-07-21.md │ ├── 2016-04-07.md │ ├── 2016-08-04.md │ ├── 2015-03-5.md │ ├── 2015-10-01.md │ ├── 2015-03-12.md │ ├── 2016-05-12.md │ ├── 2016-08-25.md │ ├── 2015-02-19.md │ ├── 2016-06-09.md │ ├── 2016-01-07.md │ ├── 2015-05-14.md │ ├── 2017-12-21.md │ ├── 2015-12-17.md │ ├── 2016-09-01.md │ ├── 2016-05-19.md │ ├── 2016-06-02.md │ ├── 2016-05-26.md │ ├── 2017-12-07.md │ ├── 2016-06-16.md │ ├── 2016-06-23.md │ ├── 2015-11-12.md │ ├── 2016-10-20.md │ ├── 2018-01-18.md │ ├── 2016-09-29.md │ ├── 2018-01-25.md │ ├── 2016-09-15.md │ ├── 2016-08-11.md │ ├── 2016-10-06.md │ ├── 2016-09-08.md │ ├── 2016-10-13.md │ ├── 2016-11-03.md │ ├── 2017-10-26.md │ ├── 2017-02-23.md │ ├── 2018-03-08.md │ ├── 2016-12-15.md │ ├── 2016-12-01.md │ ├── 2016-11-10.md │ ├── 2016-12-08.md │ ├── 2016-11-17.md │ ├── 2017-05-04.md │ ├── 2017-05-11.md │ ├── 2017-03-23.md │ └── 2017-03-09.md └── README.md ├── README.md ├── puppet-lint ├── README.md ├── notes │ ├── 2017-06-15.md │ ├── 2016-12-21.md │ └── 2017-02-23.md └── invite.ics ├── .github └── ISSUE_TEMPLATE │ ├── bounty-program-proposal.yml │ └── role-application.yml └── 2015-08-18.md /core/ReadMe.md: -------------------------------------------------------------------------------- 1 | -------------------------------------------------------------------------------- /community/ReadMe.md: -------------------------------------------------------------------------------- 1 | -------------------------------------------------------------------------------- /.gitignore: -------------------------------------------------------------------------------- 1 | *~ 2 | *.swp 3 | *.bak 4 | .DS_Store 5 | *.db 6 | -------------------------------------------------------------------------------- /modules/notes/2015-03-19.md: -------------------------------------------------------------------------------- 1 | # 2015-03-19 2 | 3 | I had great notes, but they were in my emacs' scratch buffer and lost when I quit without saving :( 4 | 5 | Postgresql was gone through, and had merges, closes, and comments. 6 | 7 | puppetlabs-mcollective will be moving to puppet-community. 8 | -------------------------------------------------------------------------------- /modules/README.md: -------------------------------------------------------------------------------- 1 | # Modules 2 | 3 | The Puppetlabs Module Team meets in a video chat every Thursday at 18:00:00 UTC to discuss PR's against the different modules. 4 | 5 | The URL to join the conference is posted to IRC shortly before we begin. 6 | 7 | Module Team members and community contributors are encouraged to regularly participate. Minutes of the meetings will be kept in the `notes/` directory going forward. 8 | -------------------------------------------------------------------------------- /modules/notes/2015-07-02.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-07-02 2 | 3 | ## Participants: 4 | * _morgan 5 | * cyberious 6 | * bmjen 7 | * DavidS 8 | * tphoney 9 | * jonnytpuppet 10 | 11 | ### puppetlabs-postgresql 12 | * 665: merged, squashes #620 13 | * 656: commented, needs work/squash/backwards-incompatible 14 | * 637: commented, needs docs/squash 15 | * 636: closed, moved to #656 16 | * 625: merged 17 | * 621: commented, still needs work 18 | * 620: squashed by #665 and closed. 19 | * 615: commented, needs work 20 | * 607: commented, needs work 21 | -------------------------------------------------------------------------------- /README.md: -------------------------------------------------------------------------------- 1 | community-triage 2 | ================ 3 | 4 | 5 | Notes and docs for the Puppet community triage events. 6 | 7 | These are weekly google hangouts where PRs are discussed between Puppet core team and community contributors. 8 | 9 | There are two hangouts, one for modules and one for Puppet core. The link to the google hangouts is provided in #puppet-dev shortly before they start. 10 | 11 | 12 | Soon, we hope to host a PR triage for the puppet-community modules. 13 | 14 | 15 | License 16 | ======= 17 | 18 | 19 | Everything in this repository is Apache 2. 20 | -------------------------------------------------------------------------------- /modules/notes/2015-05-21.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-05-21 2 | 3 | ## Participants: 4 | * bmjen 5 | * nibalizer 6 | * _morgan 7 | 8 | ## Discussion: 9 | * Actions from last meeting: 10 | ** Nodejs and Corosync moved to puppet community 11 | ** Decision was made to not track nodejs and corosync issues in jira, use github issues 12 | ** https://github.com/puppet-community/puppet-healthcheck \o/ 13 | 14 | ## Reviewed 15 | ### puppetlabs-stdlib 16 | * 459: closed, functionality already provided by puppet. 17 | * 458: merged 18 | * 457: discussed, questions about the usecase, concerns about the need and maintainability. 19 | * 455: merged 20 | * 454: merged 21 | -------------------------------------------------------------------------------- /modules/notes/2015-04-02.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage Notes 2015-04-02 2 | 3 | ## Participants: 4 | * tphoney 5 | * jt 6 | * Hunner 7 | * cyberious 8 | * crinkle 9 | * igalic 10 | 11 | ## Discussion: 12 | * We should sync the labels across the modules again 13 | * We should create a label for PRs that need to be reviewed again next meeting 14 | 15 | ### puppetlabs-dhcp 60 16 | 17 | * 60 18 | - Merged 19 | * 59 20 | - Merged 21 | * 58 22 | - Merged 23 | 24 | ### puppetlabs-tomcat 25 | 26 | * 76 27 | - [ACTION] igalic will review 28 | - [ACTION] morgan to review 29 | 30 | ### puppetlabs-haproxy 31 | 32 | * 166 33 | - Multiple instances of haproxy on a single node is of debatable worth to the community at large. Closed. -------------------------------------------------------------------------------- /modules/notes/2015-07-23.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-07-23 2 | 3 | ## Participants: 4 | * DavidS 5 | * Hunner 6 | * bmjen 7 | * raymondmaika 8 | * TPHoney 9 | * JT 10 | 11 | ## Discussion 12 | - We still need to talk to Meg about last weeks puppethack questions 13 | 14 | ## Reviews 15 | ### puppet-corosync 16 | * 155: Needs squash 17 | * 153: Still WIP 18 | 19 | ### puppetlabs-lvm 20 | * 119: Commented 21 | * 106: Closed 22 | * 103: Closed 23 | * 98: Needs rebase 24 | * 95: Merged 25 | 26 | ### puppetlabs-git 27 | * 67: Closed 28 | * 65: Merged 29 | * 64: Merged 30 | 31 | ### puppetlabs-ruby 32 | * 58: Merged 33 | * 57: Comment 34 | 35 | ### puppetlabs-stdlib 36 | * 442: [ACTION] Hunter to ticket in code management 37 | -------------------------------------------------------------------------------- /modules/notes/2016-01-21.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-01-21 2 | ## Participants: 3 | * bmjen 4 | * Hunner 5 | * tphoney 6 | * Dee Austin 7 | * jt_puppet 8 | 9 | ## Discussion 10 | * pcci is still not running on apache. Ping nibz? 11 | 12 | ## Reviews 13 | ### puppetlabs-tomcat 14 | * 118: merged 15 | 16 | ### puppetlabs-rabbitmq 17 | * 423: backwards incompatible change, requires bump of apt dependency to >=2.0 18 | * 421: commented. 19 | * 418: Closed. 20 | * 407: merged. 21 | * 405: Closed. 22 | * 403: Commented. Need more information about the use case. 23 | * 382: Closed 24 | * 380: Commented. Needs docs/validation/rebase 25 | * 379: Needs info 26 | * 376: Closed 27 | * 375: Closed. Backwards incompatible. Suggestions provided. 28 | -------------------------------------------------------------------------------- /modules/notes/2015-07-09.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-07-09 2 | 3 | ## Participants: 4 | * _morgan 5 | * nibz 6 | * DavidS 7 | * tphoney 8 | * igalic 9 | * raymondmaika 10 | * crinkle 11 | 12 | ## Discussion 13 | - Module plugins that require need relative requires or they will break. Example also vsphere 14 | 15 | ## Reviews 16 | ### puppetlabs-stdlib 17 | * 480: squashed to #482; merged there. 18 | * 479: merged 19 | * 476: closed 20 | * 475: merged 21 | * 473: closed; nibz may or may not come back later to fix it 22 | * 457: closed 23 | * 453: closed 24 | * 452: closed 25 | * 451: commented 26 | * 442: [ACTION] Hunter to ticket in code management 27 | 28 | ### puppetlabs-inifile 29 | * 176: David to comment about alternate form of selectors; closed 30 | -------------------------------------------------------------------------------- /puppet-lint/README.md: -------------------------------------------------------------------------------- 1 | puppet-lint triage 2 | ================== 3 | BlueJeans: https://bluejeans.com/280736660 4 | 5 | Notes and docs for the puppet-lint triage events. 6 | 7 | These are regularly scheduled Blue Jeans meetings where PRs are discussed between puppet-lint core team and community contributors. The scheduled time is the 3rd Thursday of every even numbered month, at 1PM Pacific time. You can add the [invite](https://www.google.com/url?q=https%3A%2F%2Fraw.githubusercontent.com%2Fvoxpupuli%2Fcommunity-triage%2Fmaster%2Fpuppet-lint%2Finvite.ics&sa=D&sntz=1&usg=AFQjCNGreEY7d4VkZUZuVtAIaXIf3THJkA) to your calendars. 8 | 9 | Team members and community contributors are encouraged to regularly participate. Minutes of the meetings will be kept in the `notes/` directory. 10 | -------------------------------------------------------------------------------- /modules/notes/2015-04-09.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage Notes 2015-04-09 2 | 3 | ## Participants: 4 | * tphoney 5 | * jt 6 | * Hunner 7 | * cyberious 8 | * crinkle 9 | * nibz 10 | * DavidS 11 | * bmjen 12 | * _morgan 13 | 14 | ## Discussion: 15 | * [ACTION] Hunner to sync the labels across the modules again 16 | 17 | ### puppetlabs-stdlib 18 | 19 | * 429 merged 20 | * 427 [ACTION] Similar to 327 & 317. Travis fixing before merge 21 | * 425 [ACTION] Needs augeas gem. Commented 22 | * 424 [ACTION] DavidS taking this for cleanup work 23 | * 408 merged 24 | * 405 merged 25 | * 341 closed 26 | * 338 [ACTION] morgan to resubmit 27 | 28 | ### puppetlabs-tomcat 29 | 30 | * 76 [ACTION] waiting for response. Morgan to comment 31 | 32 | ### puppetlabs-haproxy 33 | 34 | * 166 [ACTION] Hunner to review -------------------------------------------------------------------------------- /modules/notes/2015-10-22.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-10-22 2 | ## Participants: 3 | * Hunner 4 | * HelenCampbell 5 | * mentat 6 | * karmix 7 | * DavidSchmitt 8 | * TPHoney 9 | * JTpuppet 10 | * bmjen 11 | 12 | ## Discussion 13 | 14 | ## Requested Reviews 15 | 16 | ## Reviews 17 | ### puppetlabs-vcsrepo 18 | * 270: commented 19 | 20 | ### puppetlabs-apache 21 | * 1150: closed 22 | * 1201: commented (check next meeting) 23 | * 1203: closed 24 | 25 | ### puppetlabs-postgresql 26 | * 696: closed 27 | 28 | ### puppetlabs-mongodb 29 | * 194: [ACTION] mentat to run acceptance tests and merge if pass 30 | 31 | ### puppetlabs-mysql 32 | * 704: closed 33 | 34 | ### puppet-corosync 35 | * 153: passed to igalic 36 | 37 | ### puppetlabs-lvm 38 | * 126: commented 39 | * 122: commented 40 | 41 | ## Past Reviews 42 | -------------------------------------------------------------------------------- /core/notes/_template.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes __DATE__ 2 | 3 | Recording: __INSERT_LINK__ 4 | 5 | ### Attending 6 | 7 | __REPLACE__ 8 | 9 | ## New 10 | ### Facter 11 | 12 | ### Hiera 13 | 14 | ### Puppet 15 | 16 | [__REPLACE__](https://github.com/puppetlabs/puppet/pull/__REPLACE__): __DESCRIPTION__ 17 | - __DISCUSSION__ 18 | - **Action**: __ADD__ 19 | 20 | ## Held Over 21 | ### Facter 22 | 23 | ### Hiera 24 | 25 | ### Puppet 26 | 27 | [__REPLACE__](https://github.com/puppetlabs/puppet/pull/__REPLACE__): __DESCRIPTION__ 28 | - __DISCUSSION__ 29 | - **Action**: __UPDATE__ 30 | 31 | ## Merged or Closed Prior to Triage 32 | ### Facter 33 | 34 | ### Hiera 35 | 36 | ### Puppet 37 | 38 | [__REPLACE__](https://github.com/puppetlabs/puppet/pull/__REPLACE__): __DESCRIPTION__ 39 | - **Action**: Merged/Closed __DATE__ 40 | 41 | 42 | -------------------------------------------------------------------------------- /modules/notes/2015-02-26.md: -------------------------------------------------------------------------------- 1 | # 2015-02-26 2 | 3 | (The format for this week is not the usual format due to lack of note taking.) 4 | 5 | Mostly reviewed nodejs, with some postgresql/stdlib/gcc/java/rabbitmq thrown in for good measure. Towards the end, we talked about nibalizer's puppet-community-ci bot that he is working on (http://planck.nibalizer.com/buildlogs/). 6 | 7 | PRs reviewed and their outcome: 8 | 9 | puppetlabs-postgresql 543 commented 10 | puppetlabs-stdlib 418 merged 11 | puppetlabs-gcc 12 merged 12 | puppetlabs-java 111 commented 13 | puppetlabs-nodejs 77 commented 14 | puppetlabs-nodejs 78 commented 15 | puppetlabs-nodejs 108 closed 16 | puppetlabs-nodejs 110 closed 17 | puppetlabs-nodejs 111 merged 18 | puppetlabs-nodejs 112 merged 19 | puppetlabs-nodejs 113 merged 20 | puppetlabs-nodejs 114 merged 21 | puppetlabs-rabbitmq 299 closed 22 | -------------------------------------------------------------------------------- /modules/notes/2015-04-16.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage Notes 2015-04-16 2 | 3 | ## Participants: 4 | * Hunner 5 | * cyberious 6 | * crinkle 7 | * nibz 8 | * DavidS 9 | * bmjen 10 | * _morgan 11 | * igalic 12 | 13 | ## Discussion: 14 | * [ACTION] Hunner to sync the labels across the modules 15 | * puppet 4.0.0 and puppet-agent 1.0.0 released 16 | * rspec-puppet does not support puppet 4 yet 17 | * concat master branch has 2.0.0 changes (unreleased) 18 | 19 | ### puppetlabs-tomcat 20 | * 76 [ACTION] waiting for response. 21 | 22 | ### puppetlabs-haproxy 23 | * 166 [ACTION] waiting for response. 24 | 25 | ### puppetlabs-rabbitmq 26 | * 338 merged 27 | * 337 [ACTION] waiting for response. 28 | * 336 [ACTION] waiting for response. 29 | * 327 [ACTION] waiting for response. 30 | * 326 [ACTION] waiting for response. 31 | * 323 merged 32 | 33 | ### puppetlabs-vcsrepo 34 | * 243 merged -------------------------------------------------------------------------------- /modules/notes/2015-04-23.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage Notes 2015-04-23 2 | 3 | ## Participants: 4 | * Hunner 5 | * crinkle 6 | * DavidS 7 | * bmjen 8 | * _morgan 9 | * Aurelgadjo 10 | 11 | ## Discussion: 12 | * [ACTION] Hunner to sync the labels across the modules 13 | * rspec-puppet now supports puppet 4 14 | 15 | ### puppetlabs-bacula 16 | * 21 waiting for rebase 17 | 18 | ### puppetlabs-apache 19 | * MODULES-1784 / 1968 Commented; waiting for reply 20 | 21 | ### puppetlabs-nodejs 22 | * 126 merged 23 | * 124 merged 24 | * 121 [ACTION] waiting for green. 25 | * 119 merged 26 | 27 | ### puppetlabs-logentries 28 | * 9 has rspec failures. 29 | * 4 ??? 30 | 31 | ### puppetlabs-tomcat 32 | * 76 [ACTION] morgan to respond 33 | 34 | ### puppetlabs-haproxy 35 | * 166 [ACTION] waiting for readme update. bmjen running tests 36 | 37 | ### puppetlabs-rabbitmq 38 | * 337 merged. 39 | * 336 merged. 40 | * 327 closed. 41 | * 326 closed. -------------------------------------------------------------------------------- /modules/notes/2015-04-30.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage Notes 2015-04-30 2 | 3 | ## Participants: 4 | * Hunner 5 | * bmjen 6 | * _morgan 7 | * igalic 8 | * cyberious 9 | 10 | ## Discussion: 11 | * [ACTION] Hunner to sync the labels across the modules 12 | * Puppet Labs modules release process 13 | * Add these to CONTRIBUTING.md 14 | * Users should be able to submit changelog and version bump PRs to get releases 15 | * Moving nodejs & corosync to puppet-community 16 | 17 | ### puppetlabs-bacula 18 | * 31 waiting for rebase 19 | 20 | ### puppetlabs-apache 21 | * 1036 [ACTION] MODULES-1784 / 1968 Morgan to make a PR to warn instead of fail 22 | 23 | ### puppetlabs-nodejs 24 | * 128 merged 25 | 26 | ### puppetlabs-mysql 27 | * 705 waiting for conditional on TRIGGER privilege 28 | * 703 waiting for flush privs to be removed 29 | 30 | ### puppetlabs-tomcat 31 | * 76 waiting on user 32 | 33 | ### puppetlabs-haproxy 34 | * 166 beaker-rspec tests failing -------------------------------------------------------------------------------- /.github/ISSUE_TEMPLATE/bounty-program-proposal.yml: -------------------------------------------------------------------------------- 1 | --- 2 | name: Bounty Program Proposal 3 | description: Raise a new proposal for the Vox Pupuli Bounty Program 4 | labels: ["bounty"] 5 | projects: ["voxpupuli/12"] 6 | body: 7 | - type: markdown 8 | attributes: 9 | value: | 10 | Take a look at our [documentation](https://github.com/voxpupuli/community-triage/wiki/Vox-Pupuli-Bounty-Program) and the [project board](https://github.com/orgs/voxpupuli/projects/12/views/1). 11 | - type: textarea 12 | attributes: 13 | label: body 14 | value: | 15 | # Explanation 16 | 17 | 18 | # Implementation 19 | 20 | 21 | # Validation 22 | 23 | -------------------------------------------------------------------------------- /modules/notes/2016-03-03.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-03-03 2 | ## Participants: 3 | * bmjen 4 | * Hunner 5 | * dev\_el\_ops 6 | * HelenCampbell 7 | * evidex 8 | * tphoney 9 | 10 | ## Discussion 11 | 12 | ## Reviews 13 | ### puppetlabs-haproxy 14 | * 224: commented 15 | 16 | ### puppetlabs-stdlib 17 | * 571: waiting on author 18 | * 576: commented 19 | 20 | ### puppetlabs-ntp 21 | * 314: commented 22 | 23 | ### puppetlabs-vcsrepo 24 | * 275: closed. 25 | 26 | ### puppet-extlib 27 | * 49: commented. 28 | 29 | ### puppetlabs-splunk 30 | * 26: commented 31 | * 20: closed. squashed and merged in #31. 32 | * 15: ticketed in MODULES-3112 33 | * 14: merged. 34 | 35 | ## Past Reviews 36 | ### puppetlabs-java 37 | * 155: commented 38 | 39 | ### puppetlabs-apache 40 | * 1341: commented 41 | 42 | ### puppetlabs-dism 43 | * 40: commented 44 | 45 | ### puppetlabs-rabbitmq 46 | * 423: commented 47 | * 421: commented. 48 | * 403: Commented. Need more information about the use case. 49 | * 380: commented 50 | -------------------------------------------------------------------------------- /modules/notes/2015-09-17.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-09-17 2 | ## Participants: 3 | * bmjen 4 | * DavidS 5 | * _morgan 6 | * RaymondMaika 7 | * Hunner 8 | * TP 9 | * HelenCampbell 10 | * karmix 11 | 12 | ## Reviews 13 | ### puppetlabs-vcsrepo 14 | * 271: commented 15 | * 270: [ACTION] morgan to comment on it 16 | * 268: closed with 272 17 | * 267: waiting on community member 18 | * 262: merged 19 | 20 | ### puppetlabs-apache 21 | * 1183: merged 22 | * 1150: Needs rebase; no change 23 | * 1152: merged 24 | 25 | ### puppetlabs-mongodb 26 | * 194: still under active development 27 | 28 | ### puppetlabs-stdlib 29 | * 525: closed 30 | * 424: comment and close; superseded with #526 31 | * 304: closed. Suggestion to move work to extlib. 32 | 33 | ### puppetlabs-mysql 34 | * 704: waiting for contributor 35 | 36 | ### puppet-corosync 37 | * 153: Still WIP 38 | 39 | ### puppetlabs-lvm 40 | * 122: commented 41 | 42 | ### puppetlabs-postgresql 43 | * 696: commented 44 | 45 | ### puppetlabs-apt 46 | * 563: commented 47 | 48 | -------------------------------------------------------------------------------- /modules/notes/2015-08-06.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-08-06 2 | 3 | ## Participants: 4 | * DavidS 5 | * Hunner 6 | * bmjen 7 | * raymondmaika 8 | * TPHoney 9 | * JT 10 | * daenney 11 | * _morgan 12 | 13 | ## Discussion 14 | 15 | ## Reviews 16 | ### puppetlabs-stdlib 17 | * 497: Merged 18 | 19 | ### puppetlabs-mysql 20 | * 737: Still active 21 | * 462: Closed 22 | * 704: [ACTION] JT to review 23 | 24 | ### puppetlabs-apache 25 | * 1094: Closed 26 | * 1122: Closed 27 | * 1146: Needs rebase 28 | * 1148: Merged 29 | * 1149: Closed 30 | * 1150: Needs rebase 31 | * 1152: Needs help 32 | * 1153: Needs rebase 33 | * 1154: Merged 34 | * 1155: Commented 35 | * 1159: Needs rebase 36 | * 1172: Merged 37 | * 1175: Merged 38 | * 1177: Needs work 39 | 40 | ## Previous reviews 41 | ### puppet-corosync 42 | * 155: Merged 43 | * 153: Still WIP 44 | 45 | ### puppetlabs-lvm 46 | * 119: Commented 47 | * 98: Needs rebase 48 | 49 | ### puppetlabs-ruby 50 | * 57: Comment 51 | 52 | ### puppetlabs-stdlib 53 | * 442: [ACTION] Hunter to ticket in code management 54 | -------------------------------------------------------------------------------- /modules/notes/2016-07-07.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-07-07 2 | 3 | ## Participants: 4 | * Fraq 5 | * bmjen 6 | * dev_el_ops 7 | * tphoney 8 | * HelenCampbell 9 | 10 | ## Discussion 11 | 12 | ## Reviews 13 | ### puppetlabs-accounts 14 | * 51: commented. Needs docs. Needs tests 15 | 16 | ### puppetlabs-postgresql 17 | * 762: commented. Needs to validate passed in params 18 | * 756: reviewed, 762 looks superior 19 | * 764: commented - test failures need to be looked at 20 | * 768: closed 21 | 22 | ## Past Reviews 23 | ### puppetlabs-apache 24 | * 1423: merged 25 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 26 | * 1467: merge? 27 | * 1471: merged 28 | * 1474: tests fail, dropped in favour of 1486 + 1487 29 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 30 | * 1475: waiting for rekick, tphoney to look tomorrow - green, merged 31 | * 1480: merged 32 | * 1490: logic needs rework 33 | * 1491: moved to 1494 34 | * 1494: to be merged after travis woes subside - green, merged 35 | -------------------------------------------------------------------------------- /modules/notes/2015-06-25.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-06-25 2 | 3 | ## Participants: 4 | * nibalizer 5 | * _morgan 6 | * Hunner 7 | * cyberious 8 | * crinkle 9 | * nibalizer 10 | * igalic 11 | * ffrank 12 | * bmjen 13 | * DavidS is a robot 14 | 15 | ## Discussion: 16 | * metadata.json pe & puppet "requirements": puppet will continue as expected, and pe will be removed, since it is a product not a component 17 | 18 | ## Links 19 | http://sentimentalversioning.org/ 20 | 21 | ## Reviewed: 22 | ### puppetlabs-mysql 23 | * 722: merged! 24 | 25 | ### puppetlabs-postgresql 26 | * 643: merged 27 | * 642: closed 28 | * 637: commented, needs docs/squash 29 | * 636: commented, leave createdb_path in 30 | * 633: merged 31 | * 631: closed 32 | * 630: closed 33 | * 625: commented, needs squash 34 | * 621: commented, needs work 35 | * 620: commented, needs squash 36 | * 615: commented, needs work 37 | * 611: closed 38 | * 607: commented, needs work 39 | 40 | ### puppetlabs-mongodb 41 | * 216: commented; docs needed, but really we just want them to rework it in a way that is understandable. 42 | 43 | -------------------------------------------------------------------------------- /modules/notes/2015-11-05.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-11-05 2 | ## Participants: 3 | * Hunner 4 | * HelenCampbell 5 | * mentat 6 | * TPHoney 7 | * bmjen 8 | 9 | ## Discussion 10 | * The tomcats... how does it work? 11 | 12 | ## Requested Reviews 13 | 14 | ## Reviews 15 | ### puppetlabs-tomcat 16 | * 108: we don't understand tomcat enough to review this. [ACTION] bmjen to educate us on how to tomcat 17 | 18 | ### puppetlabs-mysql 19 | * 773: Failure appears to be caused by 767; 774 to fix it 20 | 21 | ### puppetlabs-java 22 | * 117: commented on PR, asked for more information, why required 23 | 24 | ## Past Reviews 25 | ### puppetlabs-vcsrepo 26 | * 270: commented 27 | 28 | ### puppetlabs-apache 29 | * 1150: closed 30 | * 1201: commented (check next meeting) 31 | * 1203: closed 32 | 33 | ### puppetlabs-postgresql 34 | * 696: closed 35 | 36 | ### puppetlabs-mongodb 37 | * 194: [ACTION] mentat to run acceptance tests and merge if pass 38 | 39 | ### puppetlabs-mysql 40 | * 704: closed 41 | 42 | ### puppet-corosync 43 | * 153: passed to igalic 44 | 45 | ### puppetlabs-lvm 46 | * 126: commented 47 | * 122: commented 48 | -------------------------------------------------------------------------------- /modules/notes/2015-08-13.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-08-13 2 | 3 | ## Participants: 4 | * DavidS 5 | * Hunner 6 | * bmjen 7 | * TPHoney 8 | * Doug Knight 9 | * daenney 10 | * _morgan 11 | * nibz 12 | 13 | ## Discussion 14 | 15 | ## Reviews 16 | ### puppetlabs-stdlib 17 | * 504: needs rebase, being worked on 18 | * 499: merged 19 | * 498: closed 20 | * 486: Unknown use case 21 | * 422: closed 22 | * 436: closed 23 | * 435: comment 24 | * 424: comment 25 | * 330: closed 26 | * 325: comment 27 | * 324: needs rebase 28 | * 304: needs work? 29 | * 272: closed 30 | * 263: closed 31 | * 249: closed 32 | 33 | ### puppetlabs-mysql 34 | * 737: Still active 35 | * 704: [ACTION] JT to review 36 | 37 | ## Previous reviews that need re-review 38 | ### puppetlabs-apache 39 | * 1146: Needs rebase 40 | * 1150: Needs rebase 41 | * 1152: Needs help 42 | * 1153: Needs rebase 43 | * 1155: Commented 44 | * 1159: Needs rebase 45 | * 1177: Needs work 46 | 47 | ### puppet-corosync 48 | * 155: Merged 49 | * 153: Still WIP 50 | 51 | ### puppetlabs-lvm 52 | * 119: Commented 53 | * 98: Needs rebase 54 | 55 | ### puppetlabs-ruby 56 | * 57: Comment 57 | 58 | -------------------------------------------------------------------------------- /modules/notes/2016-03-10.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-03-10 2 | ## Participants: 3 | * bmjen 4 | * Hunner 5 | * flaf 6 | * acidrainfall 7 | * Matthew Gyurgyik 8 | * igalic 9 | 10 | ## Discussion 11 | * If no community members show up, we stick around but work on usual stuff 12 | 13 | ## Reviews 14 | ### puppetlabs-haproxy 15 | * 224: commented 16 | 17 | ### puppetlabs-stdlib 18 | * 571: still waiting on author 19 | * 572: waiting for docs/tests 20 | * 576: commented on docs 21 | 22 | ### puppetlabs-ntp 23 | * 314: merged 24 | 25 | ### puppet-extlib 26 | * 49: no activity since last time 27 | 28 | ### puppetlabs-splunk 29 | * 26: merged 30 | * 29: closes #21 31 | * 15: ticketed in MODULES-3112; needs rebase 32 | 33 | ### puppetlabs-apache 34 | * 1392: merged 35 | * 1393: waiting for ci 36 | 37 | ## Past Reviews 38 | ### puppetlabs-java 39 | * 155: commented 40 | 41 | ### puppetlabs-apache 42 | * 1341: commented 43 | 44 | ### puppetlabs-dism 45 | * 40: commented 46 | 47 | ### puppetlabs-rabbitmq 48 | * 423: commented 49 | * 421: commented. 50 | * 403: Commented. Need more information about the use case. 51 | * 380: commented 52 | -------------------------------------------------------------------------------- /.github/ISSUE_TEMPLATE/role-application.yml: -------------------------------------------------------------------------------- 1 | name: Volunteer Role Application 2 | description: If you're interested in one of the open roles, apply or nominate someone here. 3 | title: '[Volunteer Application]: ' 4 | labels: ["volunteer"] 5 | projects: ["voxpupuli/10"] 6 | body: 7 | - type: markdown 8 | attributes: 9 | value: Thank you for your interest! If you prefer to do this privately, you may email pmc@voxpupuli.org instead. 10 | - type: input 11 | id: role 12 | attributes: 13 | label: Volunteer role 14 | description: Which role are you interested in? 15 | validations: 16 | required: true 17 | - type: dropdown 18 | id: source 19 | attributes: 20 | label: Who is this for? 21 | options: 22 | - Application for myself 23 | - Nomination for someone else 24 | validations: 25 | required: true 26 | - type: textarea 27 | id: about-you 28 | attributes: 29 | label: About 30 | description: Tell us a little about yourself or the person you're nominating and why you want this role. 31 | placeholder: 32 | validations: 33 | required: true 34 | -------------------------------------------------------------------------------- /modules/notes/2016-02-04.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-02-04 2 | ## Participants: 3 | * bmjen 4 | * Hunner 5 | * mentat 6 | * DAustin 7 | * Speedr 8 | * kenaz 9 | 10 | ## Discussion 11 | * Handling backwards incompatiblity 12 | 13 | ## Reviews 14 | ### puppetlabs-stdlib 15 | * 562: closed for now. Waiting for correspondence from enterprise team. 16 | 17 | ### puppetlabs-docker_platform 18 | * 15: merged 19 | 20 | ### puppetlabs-firewall 21 | * 601: test failures not related. re-running tests. 22 | 23 | ### puppetlabs-ntp 24 | * 306: merged. 25 | 26 | ### puppetlabs-java 27 | * 139: closed 28 | * 151: commented 29 | * 155: commented 30 | 31 | ### puppetlabs-apache 32 | * 1233: commented 33 | * 1338: merged 34 | * 1339: merged 35 | * 1340: merged 36 | * 1341: commented. 37 | * 1344: merged 38 | 39 | ### puppetlabs-dism 40 | * 39: Submitted #40 for fixes 41 | 42 | ### puppetlabs-pe_gem 43 | * 13: merged 44 | 45 | ### puppetlabs-rabbitmq 46 | * 423: backwards incompatible change, requires bump of apt dependency to >=2.0 47 | * 421: commented. 48 | * 403: Commented. Need more information about the use case. 49 | * 380: Commented. Needs docs/validation/rebase 50 | * 379: Needs info 51 | -------------------------------------------------------------------------------- /modules/notes/2015-05-07.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage Notes 2015-05-07 2 | 3 | ## Participants: 4 | * Hunner 5 | * bmjen 6 | * _morgan 7 | * ashp 8 | * jtpuppet 9 | * DavidS 10 | * cyberious 11 | * igalic 12 | 13 | ## Discussion: 14 | * stdlib fixes 15 | * f5 partitions 16 | * [ACTION] Hunner to sync the labels across the modules 17 | * Public jenkins https://jenkins-modules.puppetlabs.com should have badges added to readmes 18 | ### From last time 19 | * Puppet Labs modules release process 20 | * Add these to CONTRIBUTING.md 21 | * Users should be able to submit changelog and version bump PRs to get releases 22 | * Moving nodejs & corosync to puppet-community 23 | 24 | ## Merged 25 | ### puppetlabs-apache 26 | * 1036 merged 27 | * MODULES-2011 multiple instances request 28 | * Chef does multiple httpd instances https://github.com/chef-cookbooks/httpd 29 | * Suggestion: Only do it for systemd platforms 30 | 31 | ### puppetlabs-mysql 32 | * 705 merged 33 | * 706 (703 was closed) merged 34 | 35 | ## Waiting for response 36 | ### puppetlabs-bacula 37 | * 31 waiting for rebase 38 | 39 | ### puppetlabs-tomcat 40 | * 76 waiting on user 41 | 42 | ### puppetlabs-haproxy 43 | * 166 beaker-rspec tests failing 44 | -------------------------------------------------------------------------------- /modules/notes/2015-09-03.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-09-03 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * DavidS 6 | * _morgan 7 | * RaymonMaika 8 | * karmix 9 | 10 | ## Discussion 11 | * karmix wants to discuss firewall restructure with JT 12 | 13 | ## Reviews 14 | ### puppetlabs-apache 15 | * 1193: merged 16 | * 1192: closed 17 | * 1191: closed 18 | * 1188: merged 19 | * 1183: commented 20 | * 1180: merged 21 | 22 | ### puppetlabs-mongodb 23 | * 194: [ACTION] morgan to rebase 24 | * 210: merged 25 | * 221: commented 26 | 27 | ### puppetlabs-stdlib 28 | * 504: closed 29 | * 486: Unknown use case 30 | * 435: closed 31 | * 424: comment 32 | * 325: comment 33 | * 324: merged in 514 34 | * 304: needs work 35 | 36 | ### puppetlabs-mysql 37 | * 737: closed 38 | * 704: comment 39 | 40 | ### puppetlabs-apache 41 | * 1146: merged 42 | * 1150: Needs rebase 43 | * 1152: needs squash 44 | * 1153: closed 45 | * 1155: merged 46 | * 1159: merged 47 | * 1177: closed 48 | 49 | ### puppet-corosync 50 | * 153: Still WIP 51 | 52 | ### puppetlabs-lvm 53 | * 119: merged 54 | * 98: closed 55 | * 123: merged 56 | * 122: commented 57 | * 121: merged 58 | * 120: merged 59 | 60 | ### puppetlabs-ruby 61 | * 57: merged 62 | 63 | -------------------------------------------------------------------------------- /modules/notes/2016-01-28.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-01-28 2 | ## Participants: 3 | * bmjen 4 | * Kenaz 5 | * Hunner 6 | * helencampbell 7 | * karmix 8 | * speedr 9 | * Dominic 10 | 11 | ## Discussion 12 | * pcci is still not running on apache. Ping nibz? 13 | * Change the “need-feedback” label to be less ambiguous. To “Needs-Information-Submitter” and “Needs-Information-Reviewer” 14 | * Talked about compatibility vs supported in metadata; passed on to Kenaz 15 | 16 | ## Reviews 17 | ### puppetlabs-docker_platform 18 | * 15: 19 | 20 | ### puppetlabs-firewall 21 | * 601: 22 | 23 | ### puppetlabs-ntp 24 | * 306: 25 | 26 | ### puppetlabs-java 27 | * 151: commented 28 | * 155: commented 29 | 30 | ### puppetlabs-apache 31 | * 1338: 32 | * 1339: 33 | * 1340: 34 | * 1341: 35 | * 1344: 36 | * 1345: merged 37 | 38 | ### puppetlabs-registry 39 | * 100: 40 | 41 | ### puppetlabs-vsphere 42 | * 101: 43 | ### puppetlabs-pe_gem 44 | * 13: merged 45 | 46 | ### puppetlabs-rabbitmq 47 | * 423: backwards incompatible change, requires bump of apt dependency to >=2.0 48 | * 421: commented. 49 | * 403: Commented. Need more information about the use case. 50 | * 380: Commented. Needs docs/validation/rebase 51 | * 379: Needs info 52 | -------------------------------------------------------------------------------- /modules/notes/2015-09-10.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-09-10 2 | ## Participants: 3 | * bmjen 4 | * DavidS 5 | * _morgan 6 | * RaymondMaika 7 | * Daenney 8 | * TP 9 | * cyberious 10 | 11 | ## Re-Reviews 12 | ### puppetlabs-apache 13 | * 1183: commented 14 | 15 | ### puppetlabs-mongodb 16 | * 194: commented, needs review 17 | * 221: merged 18 | 19 | ### puppetlabs-stdlib 20 | * 486: Unknown use case; commented on ticked, closed the PR for now 21 | * 424: [action] DavidS to fold in the change when working on stdlib this sprint 22 | * 325: closed 23 | * 304: needs work; pinged 24 | 25 | ### puppetlabs-mysql 26 | * 704: waiting for contributor 27 | 28 | ### puppetlabs-apache 29 | * 1150: Needs rebase; no change 30 | * 1152: needs squash; no change 31 | 32 | ### puppet-corosync 33 | * 153: Still WIP 34 | 35 | ### puppetlabs-lvm 36 | * 122: commented 37 | 38 | ## Reviews 39 | ### puppetlabs-postgresql 40 | 696: [action] bmjen to run acceptance tests and give feedback to submitter 41 | 42 | ### puppetlabs-apt 43 | 563: ping submitter to address outstanding comments so it can be merged 44 | 45 | ### puppetlabs-stdlib 46 | 520: rejected, but ideas for a less painful implementation; DavidS comments with improvement 47 | 48 | -------------------------------------------------------------------------------- /modules/notes/2016-02-25.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-02-25 2 | ## Participants: 3 | * bmjen 4 | * Hunner 5 | * zounese 6 | 7 | ## Discussion 8 | - making splunk higher quality, and maybe supported 9 | - Community member nickperry has filed a couple tickets for improving the module. 10 | -https://tickets.puppetlabs.com/browse/MODULES-2698 11 | -https://tickets.puppetlabs.com/browse/MODULES-2699 12 | - SysOps (Eric Zounes) has forked nickperry’s module because he’s added a lot of need functionality. They’re working on adding tests and getting it cleaned up to adhere to our module guidelines. 13 | - https://github.com/puppetlabs-operations/puppetlabs-splunk/tree/module_test 14 | 15 | ## Reviews 16 | ### puppetlabs-splunk 17 | * 26: commented 18 | * 25: merged 19 | * 21: maybe merged in #29 20 | * 20: commented 21 | * 15: ticketed in MODULES-3112 22 | * 14: ticketed in MODULES-3113 23 | 24 | ## Past Reviews 25 | ### puppetlabs-stdlib 26 | * 571: waiting on author 27 | 28 | ### puppetlabs-java 29 | * 155: commented 30 | 31 | ### puppetlabs-apache 32 | * 1341: commented 33 | 34 | ### puppetlabs-dism 35 | * 40: commented 36 | 37 | ### puppetlabs-rabbitmq 38 | * 423: commented 39 | * 421: commented. 40 | * 403: Commented. Need more information about the use case. 41 | * 380: commented 42 | -------------------------------------------------------------------------------- /modules/notes/2015-08-27.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-08-27 2 | 3 | ## Participants: 4 | * Hunner 5 | * bmjen 6 | * DavidS 7 | * _morgan 8 | 9 | 10 | ## Discussion 11 | 12 | ## Reviews 13 | ### puppetlabs-apache 14 | * 1193: commented 15 | * 1192: commented 16 | * 1191: [ACTION] hunter to comment 17 | * 1189: merged 18 | * 1188: commented 19 | * 1183: commented 20 | * 1180: commented 21 | 22 | ### puppetlabs-haproxy 23 | * 189: closed for 194 24 | * 194: merged 25 | 26 | ## Previous reviews that need re-review 27 | ### puppetlabs-mongodb 28 | * 194: pinged fatmcgav 29 | * 210: needs squash 30 | * 221: skipped 31 | 32 | ### puppetlabs-stdlib 33 | * 504: needs rebase, being worked on 34 | * 486: Unknown use case 35 | * 435: comment 36 | * 424: comment 37 | * 325: comment 38 | * 324: needs rebase 39 | * 304: needs work? 40 | 41 | ### puppetlabs-mysql 42 | * 737: Still active 43 | * 704: [ACTION] JT to review 44 | 45 | ### puppetlabs-apache 46 | * 1146: Needs rebase 47 | * 1150: Needs rebase 48 | * 1152: Needs help 49 | * 1153: Needs rebase 50 | * 1155: Commented 51 | * 1159: Needs rebase 52 | * 1177: Needs work 53 | 54 | ### puppet-corosync 55 | * 153: Still WIP 56 | 57 | ### puppetlabs-lvm 58 | * 119: Commented 59 | * 98: Needs rebase 60 | 61 | ### puppetlabs-ruby 62 | * 57: Comment 63 | 64 | -------------------------------------------------------------------------------- /modules/notes/2016-05-05.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-05-05 2 | ## Participants: 3 | * bmjen 4 | * Hunner 5 | * nibz 6 | 7 | ## Discussion 8 | PuppetConf RFP has been extended to May 9th. Git yer talks in! 9 | 10 | ## Reviews 11 | ### puppetlabs-stdlib 12 | * 601: merged 13 | * 592: merged 14 | 15 | ### puppetlabs-concat 16 | * 397: commented 17 | 18 | ### puppetlabs-rabbitmq 19 | * 466: merged 20 | * 465: made 467 21 | * 464: commented 22 | * 460: deferred 23 | * 457: needs squash/rebase 24 | 25 | ## Past Reviews 26 | ### puppetlabs-postgresql 27 | * 753: commented 28 | 29 | ### puppetlabs-apache 30 | * 1341: User unsure of hunters last reply. Needs input from us. 31 | * 1423: needs re-review 32 | * 1428: commented 33 | 34 | ### puppetlabs-vcsrepo 35 | * 274: commented pinging user for movement 36 | 37 | ### puppetlabs-mongodb 38 | * 260: commented 39 | * 253: needs rebased 40 | * 251: needs rebase 41 | * 284: commented (it probably needs lots of work) 42 | 43 | ### puppet-extlib - wat 44 | * 49: no activity since last time 45 | 46 | ### puppetlabs-splunk 47 | * 15: ticketed in MODULES-3112; needs rebase 48 | 49 | 50 | ### puppetlabs-dism 51 | * 40: commented 52 | 53 | ### puppetlabs-rabbitmq 54 | * 423: commented 55 | * 403: Commented. Need more information about the use case. 56 | * 380: commented 57 | 58 | -------------------------------------------------------------------------------- /modules/notes/2016-02-11.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-02-11 2 | ## Participants: 3 | * jtpuppet 4 | * TPHoney 5 | * Hunner 6 | * HelenCampbell 7 | * bmjen 8 | * cosman / logicminds 9 | * daenney 10 | 11 | 12 | ## Discussion 13 | * Re-discuss firewall #577; considered fine 14 | 15 | 16 | ## Reviews 17 | ### puppetlabs_spec_helper 18 | * 126: commented 19 | * 127: closed as part of 126 20 | 21 | 22 | ### puppetlabs-firewall 23 | * 601: test failures not related. re-running tests. 24 | 25 | 26 | ### puppetlabs-netdev_stdlib 27 | * 17: Author is working on it. 28 | * 15: Merged 29 | * 13: Contacted the creator, who said to close it. 30 | 31 | 32 | ### puppetlabs-java_ks 33 | * 144: merged 34 | 35 | 36 | ### puppetlabs-stdlib 37 | * 573: commented 38 | * 563: 39 | * 562: closed for now. Waiting for correspondence from enterprise team. 40 | 41 | 42 | ### puppetlabs-java 43 | * 151: commented 44 | * 155: commented 45 | 46 | 47 | ### puppetlabs-apache 48 | * 1233: commented 49 | * 1341: commented. 50 | 51 | 52 | ### puppetlabs-dism 53 | * 40: 54 | 55 | 56 | ### puppetlabs-rabbitmq 57 | * 423: backwards incompatible change, requires bump of apt dependency to >=2.0 58 | * 421: commented. 59 | * 403: Commented. Need more information about the use case. 60 | * 380: Commented. Needs docs/validation/rebase 61 | * 379: Needs info -------------------------------------------------------------------------------- /puppet-lint/notes/2017-06-15.md: -------------------------------------------------------------------------------- 1 | BlueJeans Link (Open all the time except during Modules Community Triage): https://bluejeans.com/280736660 2 | 3 | Attendees: rnelson0, binford2k, glenn.sarti, eputnam 4 | 5 | # Planning 6 | 7 | * Rubocop - needs to meet 1.8.7+. Mike started a spike but it was for 2.3+. We can support 1.9+ instead if it's targeted to the 3.0 branch. 8 | * 3.0.0 milestone deadline set to May 5th! 9 | 10 | # Issues and PRs 11 | * 568 - Disable the check in the 3.0.0 branch (rnelson0) 12 | * 586 - Continue if a single file is unparseable; currently stops on the first one (rnelson0) 13 | * [708](https://github.com/rodjek/puppet-lint/pull/708) - Ben will track down Jean and review (binford2k) 14 | * [696](https://github.com/rodjek/puppet-lint/pull/696) - Review for 2.x or 3.x (needs a reviewer) 15 | * [692](https://github.com/rodjek/puppet-lint/issues/692) - Needs some doc updates, Ben will review (binford2k) 16 | 17 | # Other 18 | Rob Nelson has been running the calls for the past few months, but has other commitments preventing him from giving this project the time it needs currently. He is requesting assistance in running the calls and hoping that someone else can take the reins eventually. 19 | * Ben spoke with Lindsey Smith who will float this idea to the PDK team. 20 | * Glenn will float this idea to the modules team. 21 | -------------------------------------------------------------------------------- /modules/notes/2016-03-31.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-03-31 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * HelenCampbell 6 | * dev_el_ops 7 | * tphoney 8 | 9 | ## Discussion 10 | * Implications of transition being supported vs integrated in core 11 | 12 | ## Reviews 13 | ### puppetlabs-apache 14 | * 1412: commented 15 | 16 | ## Past Reviews 17 | ### puppetlabs-vcsrepo 18 | * 274: commented 19 | 20 | ### puppetlabs-stdlib 21 | * 580: commented 22 | 23 | ### puppetlabs-mongodb 24 | * 260: commented 25 | * 282: waiting for travisci 26 | * 253: commented 27 | * 251: commented 28 | 29 | ## Past Reviews 30 | ### puppetlabs-haproxy 31 | * 224: commented 32 | 33 | ### puppetlabs-stdlib 34 | * 571: still waiting on author 35 | * 572: waiting for docs/tests 36 | * 576: commented on docs 37 | 38 | ### puppet-extlib 39 | * 49: no activity since last time 40 | 41 | ### puppetlabs-splunk 42 | * 29: closes #21 43 | * 15: ticketed in MODULES-3112; needs rebase 44 | 45 | ### puppetlabs-apache 46 | * 1393: waiting for ci 47 | 48 | ## Past Reviews 49 | ### puppetlabs-java 50 | * 155: commented 51 | 52 | ### puppetlabs-apache 53 | * 1341: commented 54 | 55 | ### puppetlabs-dism 56 | * 40: commented 57 | 58 | ### puppetlabs-rabbitmq 59 | * 423: commented 60 | * 421: commented. 61 | * 403: Commented. Need more information about the use case. 62 | * 380: commented 63 | -------------------------------------------------------------------------------- /modules/notes/2015-08-20.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-08-20 2 | 3 | ## Participants: 4 | * Hunner 5 | * bmjen 6 | * TPHoney 7 | * daenney 8 | * _morgan 9 | * nibz 10 | * raymondmaika 11 | 12 | ## Discussion 13 | 14 | ## Reviews 15 | ### puppetlabs-mongodb 16 | * 185: merged in 223 17 | * 186: merged 18 | * 188: merged 19 | * 194: pinged fatmcgav 20 | * 195: closed 21 | * 197: closed 22 | * 204: merged in 224 23 | * 208: merged 24 | * 209: merged in 186 25 | * 210: needs squash 26 | * 216: merged 27 | * 217: merged 28 | * 218: merged in 186 29 | * 219: merged 30 | * 221: skipped 31 | * 222: merged in 186, 208 32 | * 223: merged 33 | * 224: merged 34 | 35 | ## Previous reviews that need re-review 36 | ### puppetlabs-stdlib 37 | * 504: needs rebase, being worked on 38 | * 486: Unknown use case 39 | * 435: comment 40 | * 424: comment 41 | * 325: comment 42 | * 324: needs rebase 43 | * 304: needs work? 44 | 45 | ### puppetlabs-mysql 46 | * 737: Still active 47 | * 704: [ACTION] JT to review 48 | 49 | ### puppetlabs-apache 50 | * 1146: Needs rebase 51 | * 1150: Needs rebase 52 | * 1152: Needs help 53 | * 1153: Needs rebase 54 | * 1155: Commented 55 | * 1159: Needs rebase 56 | * 1177: Needs work 57 | 58 | ### puppet-corosync 59 | * 153: Still WIP 60 | 61 | ### puppetlabs-lvm 62 | * 119: Commented 63 | * 98: Needs rebase 64 | 65 | ### puppetlabs-ruby 66 | * 57: Comment 67 | -------------------------------------------------------------------------------- /modules/notes/2015-11-19.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-11-19 2 | ## Participants: 3 | * Hunner 4 | * mentat 5 | * bmjen 6 | * karmix 7 | 8 | 9 | ## Discussion 10 | * pcci on haproxy 11 | 12 | 13 | ## Reviews 14 | ### puppetlabs-postgresql 15 | * 679: merged 16 | 17 | 18 | ### puppetlabs-concat 19 | * 368: merged 20 | 21 | 22 | ### puppetlabs-apache 23 | * 1259: Closed - yrobla will resubmit PR with implementation of new vhost::custom, to allow to pass raw configuration. 24 | * 1201: waiting on contributor 25 | 26 | 27 | ### puppetlabs-mysql 28 | * 763: Needs work 29 | 30 | 31 | ### puppetlabs-vcsrepo 32 | * 275: commented 33 | 34 | 35 | ## Past Reviews 36 | ### puppetlabs-tomcat 37 | * 108: was closed and now the work has been moved to 109 we don't understand tomcat enough to review this. [ACTION] bmjen to educate us on how to tomcat 38 | * 109: bmjen is still looking into this along with karmix, the PR needs split into smaller PRs or a single PR with commits per functional area 39 | 40 | 41 | ### puppetlabs-java 42 | * 117: more discussion on the changes 43 | 44 | 45 | ### puppetlabs-vcsrepo 46 | * 270: commented 47 | 48 | 49 | ### puppetlabs-mongodb 50 | * 194: [ACTION] mentat to run acceptance tests and merge if pass 51 | 52 | 53 | ### puppet-corosync 54 | * 153: passed to igalic 55 | 56 | 57 | ### puppetlabs-lvm 58 | * 126: commented 59 | * 122: commented -------------------------------------------------------------------------------- /modules/notes/2015-03-24.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-03-24 2 | ## Participants: 3 | * Hunner 4 | * igalic 5 | * HelenCampbell 6 | * jt_puppet 7 | * dev_el_ops 8 | * jyaworski 9 | * tphoney 10 | 11 | ## Discussion 12 | * What are the implications of using VP or unsupported PL modules in supported modules 13 | 14 | ## Reviews 15 | ### puppetlabs-vcsrepo 16 | * 274: commented 17 | * 284: merged 18 | 19 | ### puppetlabs-stdlib 20 | * 580: commented 21 | 22 | ## Past Reviews 23 | ### puppetlabs-mongodb 24 | * 260: commented 25 | * 282: waiting for travisci 26 | * 253: commented 27 | * 251: commented 28 | 29 | ## Past Reviews 30 | ### puppetlabs-haproxy 31 | * 224: commented 32 | 33 | ### puppetlabs-stdlib 34 | * 571: still waiting on author 35 | * 572: waiting for docs/tests 36 | * 576: commented on docs 37 | 38 | ### puppet-extlib 39 | * 49: no activity since last time 40 | 41 | ### puppetlabs-splunk 42 | * 29: closes #21 43 | * 15: ticketed in MODULES-3112; needs rebase 44 | 45 | ### puppetlabs-apache 46 | * 1393: waiting for ci 47 | 48 | ## Past Reviews 49 | ### puppetlabs-java 50 | * 155: commented 51 | 52 | ### puppetlabs-apache 53 | * 1341: commented 54 | 55 | ### puppetlabs-dism 56 | * 40: commented 57 | 58 | ### puppetlabs-rabbitmq 59 | * 423: commented 60 | * 421: commented. 61 | * 403: Commented. Need more information about the use case. 62 | * 380: commented 63 | -------------------------------------------------------------------------------- /modules/notes/2016-06-30.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-06-30 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * dev_el_ops 6 | * tphoney 7 | * HelenCampbell 8 | * Karmix 9 | 10 | ## Discussion 11 | * Jenkins and travis != "ci" because we are not integrating anything 12 | * apache third party modules cause a maintenance burden, where we do not know whether there is enough payoff for customers. (tphoney to ticket and look into) 13 | Steps to improve or at least tackle 14 | * investigate apache next epic, and remove garbage fire 15 | * apache puppet 4 release, remove plugin installation apt or rpm 16 | * bump concat version in apache 17 | * puppetlabs-passenger investigate 18 | * remove apache 2.2 crud 19 | 20 | * travis ci is having trouble to keep up and keeps dropping github notifications. Closing and re-opening PRs causes travis to pick them up 21 | 22 | ## Reviews 23 | ### puppetlabs-apache 24 | * 1423: merged 25 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 26 | * 1467: merge? 27 | * 1471: merged 28 | * 1474: tests fail, dropped in favour of 1486 + 1487 29 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 30 | * 1475: waiting for rekick, tphoney to look tomorrow 31 | * 1480: merged 32 | * 1490: logic needs rework 33 | * 1491: moved to 1494 34 | * 1494: to be merged after travis woes subside 35 | 36 | ## Past Reviews 37 | 38 | -------------------------------------------------------------------------------- /modules/notes/2016-07-28.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-07-28 2 | 3 | ## Participants: 4 | * Hunner 5 | * TP 6 | * dev_el_ops 7 | * igalic 8 | 9 | ## Discussion 10 | * What to do with create_resources patterns that proliferate our modules and hinder adoption of proper profile-level abstraction practices? "What is the problem, and what is a better solution?" This should become ticketed work, investigate how widespread in modules. Is it used by many customers ? Education issues about abstraction of profiles? What possible alternatives are there, a function to parse hashes into resources ? update Hiera to handle multiple keys ? will beginner users ever use this ? Do expert users follow this pattern ? - TP to create epic 11 | 12 | ## Reviews 13 | ### puppetlabs-postgresql 14 | * 775: See discussion above ^^ 15 | 16 | ## Past Reviews 17 | ### puppetlabs-accounts 18 | * 51: commented. Needs docs. Needs tests 19 | 20 | ### puppetlabs-postgresql 21 | * 762: commented. Needs to validate passed in params 22 | * 756: reviewed, 762 looks superior 23 | * 764: commented - test failures need to be looked at 24 | 25 | ### puppetlabs-apache 26 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 27 | * 1467: merge? 28 | * 1474: tests fail, dropped in favour of 1486 + 1487 29 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 30 | * 1490: logic needs rework 31 | * 1491: moved to 1494 32 | 33 | -------------------------------------------------------------------------------- /modules/notes/2015-12-03.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-12-03 2 | ## Participants: 3 | * bmjen 4 | * rnelson0 5 | * karmix 6 | * mentat 7 | 8 | ## Discussion 9 | 10 | * #puppethack on 12/15 11 | 12 | ## Reviews 13 | 14 | ### puppetlabs-rabbitmq 15 | * 415: Tests need fixing. 16 | * 413: Merged. 17 | * 211: Tests failing. Needs rebase. Broken on ruby 1.8.7. May require someone take over dev. 18 | * 375: Commented. Backwards incompatible. Suggestions provided. 19 | 20 | ## Past Reviews 21 | ### puppetlabs-postgresql 22 | 23 | ### puppetlabs-concat 24 | 25 | ### puppetlabs-apache 26 | * 1201: Closed. Re-implemented by karmix in #1270 and merged. 27 | 28 | ### puppetlabs-mysql 29 | * 763: Still needs work and rebase. Pinged submitter 30 | 31 | ### puppetlabs-vcsrepo 32 | * 275: commented. karmix to comment with short term solution. long term solution for `exists?` still needed. 33 | * 270: Closed due to inactivity. Submitter will reopen when able. 34 | 35 | ### puppetlabs-tomcat 36 | * 109: bmjen is still looking into this along with karmix, the PR needs split into smaller PRs or a single PR with commits per functional area. Still investigating. Submitter needs to fix linting errors. 37 | 38 | ### puppetlabs-java 39 | * 117: Merged 40 | 41 | ### puppetlabs-mongodb 42 | * 194: Merged. 43 | 44 | ### puppet-corosync 45 | * 153: Merged 46 | 47 | ### puppetlabs-lvm 48 | * 126: Merged. 49 | * 122: Closed for inactivity. Pinged submitter to reopen when issues addressed. 50 | -------------------------------------------------------------------------------- /modules/notes/2015-05-28.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-05-28 2 | 3 | ## Participants: 4 | * bmjen 5 | * nibalizer 6 | * _morgan 7 | * DavidS 8 | * tphoney 9 | * Hunner 10 | * cyberious 11 | * igalic 12 | 13 | ## Discussion: 14 | * The use of metadata and how it should/should not be coupled with manifest code. 15 | * [ACTION] Hunner: sync the labels across the modules 16 | * branching strategy 17 | * [ACTION] Morgan to draft a proposal then email to puppet-dev 18 | * [ACTION] Add how to write changelog & version bump to CONTRIBUTING.md so that users can request a release. Related: https://github.com/boennemann/semantic-release 19 | * CONTRIBUTING.md has too much not-useful information and should be slimmed down. 20 | * [ACTION] nibz: turn on pcci voting (rabbitmq is failing, so maybe delay? http://planck.nibalizer.com:5000/modules/puppetlabs/puppetlabs-rabbitmq) 21 | 22 | 23 | ## Reviewed: 24 | ### puppetlabs-stdlib 25 | * 457: re-evaluated. proposing a function to return information from metadata.json in a hash. 26 | 27 | ### puppetlabs-postgresql 28 | * 632: Needs update to metadata.json 29 | * 626: Needs to wait for new concat 2.0.x release 30 | 31 | ### puppetlabs-apt 32 | * 525: [ACTION] Morgan to review because of her work. 33 | 34 | ## Waiting for response 35 | ### puppetlabs-bacula 36 | * 31 still waiting for rebase 37 | 38 | ### puppetlabs-tomcat 39 | * 76 still waiting on user 40 | 41 | ### puppetlabs-haproxy 42 | * 166 beaker-rspec tests failing and needs rebase 43 | -------------------------------------------------------------------------------- /modules/notes/2015-12-10.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-12-10 2 | ## Participants: 3 | * bmjen 4 | * karmix 5 | * mentat 6 | * DavidSchmitt 7 | * TP 8 | * Helen 9 | 10 | ## Discussion 11 | 12 | ## Reviews 13 | 14 | ### puppetlabs-firewall 15 | * 579: Merged 16 | 17 | ### puppetlabs-stdlib 18 | * 554: merged 19 | 20 | ### puppetlabs-java 21 | * 149: DavidS commented. This change would cause some breakage and backwards incompatibility. 22 | 23 | ## Past Reviews 24 | 25 | ### puppetlabs-rabbitmq 26 | * 415: Merged 27 | * 211: Tests failing. Needs rebase. Broken on ruby 1.8.7. May require someone take over dev. 28 | * 375: Commented. Backwards incompatible. Suggestions provided. 29 | 30 | ### puppetlabs-postgresql 31 | 32 | ### puppetlabs-concat 33 | 34 | ### puppetlabs-apache 35 | 36 | ### puppetlabs-mysql 37 | * 763: Still needs work and rebase. DavidS to take a look at the conflicts and maybe take over rebase/PR. Pushed to https://github.com/puppetlabs/puppetlabs-mysql/pull/786 38 | 39 | ### puppetlabs-vcsrepo 40 | * 275: [ACTION]. Karmix to take over suggested updates. [ACTION] bmjen to track larger refactor in github issues + jira ticket. 41 | * 270: [ACTION] Still closed due to inactivity. Karmix to comment on pertinence to #275. 42 | 43 | ### puppetlabs-tomcat 44 | * 109: [ACTION] TP to create JIRA ticket to take over the work and determine backwards compatibility. 45 | 46 | 47 | ### puppetlabs-lvm 48 | * 122: Closed for inactivity. Pinged submitter to reopen when issues addressed. 49 | -------------------------------------------------------------------------------- /modules/notes/2016-04-14.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-04-14 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * tphoney 6 | * fraq 7 | * HelenCampbell 8 | 9 | ## Discussion 10 | * hunner-hiera is now a VP module 11 | 12 | ## Reviews 13 | ### puppetlabs-apache 14 | * 1393: merged 15 | * 1341: commented. 16 | * 1334: closed 17 | * 1399: merged 18 | * 1401: merged 19 | * 1405: merged 20 | * 1404: needs rebase 21 | * 1407: merged 22 | * 1408: merged 23 | * 1421: needs rebase 24 | * 1423: commented 25 | * 1426: waiting on user 26 | * 1427: needs rebase 27 | * 1428: needs tests 28 | 29 | ## Past Reviews 30 | ### puppetlabs-vcsrepo 31 | * 274: still waiting on contributor 32 | 33 | ### puppetlabs-mongodb 34 | * 260: commented 35 | * 282: waiting for travisci 36 | * 253: commented 37 | * 251: commented 38 | * 284: commented (it probably needs lots of work) 39 | 40 | ### puppetlabs-haproxy 41 | * 224: commented 42 | 43 | ### puppetlabs-stdlib 44 | * 571: still waiting on author 45 | * 572: waiting for docs/tests 46 | * 576: commented on docs 47 | * 580: commented 48 | 49 | ### puppet-extlib 50 | * 49: no activity since last time 51 | 52 | ### puppetlabs-splunk 53 | * 29: closes #21 54 | * 15: ticketed in MODULES-3112; needs rebase 55 | \ 56 | 57 | ### puppetlabs-java 58 | * 155: commented 59 | 60 | ### puppetlabs-dism 61 | * 40: commented 62 | 63 | ### puppetlabs-rabbitmq 64 | * 423: commented 65 | * 421: commented. 66 | * 403: Commented. Need more information about the use case. 67 | * 380: commented 68 | -------------------------------------------------------------------------------- /modules/notes/2016-04-28.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-04-28 2 | ## Participants: 3 | * tphoney 4 | * helencampbell 5 | 6 | ## Discussion 7 | This week was spent going over past reviews and removing stale PRs. 8 | 9 | ## Reviews 10 | 11 | 12 | ## Past Reviews 13 | ### puppetlabs-stdlib 14 | * 592: Needs review 15 | 16 | ### puppetlabs-postgresql 17 | * 753: commented 18 | 19 | ### puppetlabs-rabbitmq 20 | * 463: merged 21 | 22 | ### puppetlabs-apache 23 | * 1341: User unsure of hunters last reply. Needs input from us. 24 | * 1404: merged 25 | * 1421: merged 26 | * 1423: needs re-review 27 | * 1426: merged 28 | * 1427: merged 29 | * 1428: commented 30 | 31 | ### puppetlabs-vcsrepo 32 | * 274: commented pinging user for movement 33 | 34 | ### puppetlabs-mongodb 35 | * 260: commented 36 | * 282: merged 37 | * 253: needs rebased 38 | * 251: needs rebase 39 | * 284: commented (it probably needs lots of work) 40 | 41 | ### puppetlabs-haproxy 42 | * 224: merged 43 | 44 | ### puppetlabs-stdlib 45 | * 571: closed 46 | * 572: closed 47 | * 576: merged 48 | * 580: merged 49 | 50 | ### puppet-extlib - wat 51 | * 49: no activity since last time 52 | 53 | ### puppetlabs-splunk 54 | * 29: merged 55 | * 15: ticketed in MODULES-3112; needs rebase 56 | 57 | ### puppetlabs-java 58 | * 155: closed 59 | 60 | ### puppetlabs-dism 61 | * 40: commented 62 | 63 | ### puppetlabs-rabbitmq 64 | * 423: commented 65 | * 421: closed 66 | * 403: Commented. Need more information about the use case. 67 | * 380: commented 68 | -------------------------------------------------------------------------------- /modules/notes/2016-04-21.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-04-21 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * nibz 6 | * dev_el_ops 7 | 8 | ## Discussion 9 | 10 | 11 | ## Reviews 12 | ### puppetlabs-stdlib 13 | * 592: DavidS to comment 14 | 15 | ### puppetlabs-postgresql 16 | * 753: commented 17 | 18 | ### puppetlabs-rabbitmq 19 | * 463: commented 20 | 21 | ## Past Reviews 22 | ### puppetlabs-apache 23 | * 1393: merged 24 | * 1341: commented 25 | * 1404: needs rebase 26 | * 1421: needs rebase 27 | * 1423: commented 28 | * 1426: waiting on user 29 | * 1427: needs rebase 30 | * 1428: needs tests 31 | 32 | ### puppetlabs-vcsrepo 33 | * 274: still waiting on contributor 34 | 35 | ### puppetlabs-mongodb 36 | * 260: commented 37 | * 282: waiting for travisci 38 | * 253: commented 39 | * 251: commented 40 | * 284: commented (it probably needs lots of work) 41 | 42 | ### puppetlabs-haproxy 43 | * 224: commented 44 | 45 | ### puppetlabs-stdlib 46 | * 571: still waiting on author 47 | * 572: waiting for docs/tests 48 | * 576: commented on docs 49 | * 580: commented 50 | 51 | ### puppet-extlib 52 | * 49: no activity since last time 53 | 54 | ### puppetlabs-splunk 55 | * 29: closes #21 56 | * 15: ticketed in MODULES-3112; needs rebase 57 | 58 | ### puppetlabs-java 59 | * 155: commented 60 | 61 | ### puppetlabs-dism 62 | * 40: commented 63 | 64 | ### puppetlabs-rabbitmq 65 | * 423: commented 66 | * 421: commented. 67 | * 403: Commented. Need more information about the use case. 68 | * 380: commented 69 | 70 | -------------------------------------------------------------------------------- /modules/notes/2015-06-04.md: -------------------------------------------------------------------------------- 1 | ## Participants: 2 | * bmjen 3 | * nibalizer 4 | * _morgan 5 | * Hunner 6 | * cyberious 7 | * crinkle 8 | * tphoney 9 | 10 | ## Discussion: 11 | * PCCI bot commenting multiple times, no solution yet https://github.com/puppet-community/pcci/issues/4 12 | * [ACTION] Hunner: sync the labels across the modules 13 | * branching strategy 14 | * [ACTION] Morgan to draft a proposal then email to puppet-dev 15 | * [ACTION] Add how to write changelog & version bump to CONTRIBUTING.md so that users can request a release. Related: https://github.com/boennemann/semantic-release 16 | * CONTRIBUTING.md has too much not-useful information and should be slimmed down. 17 | * [ACTION] nibz: turn on pcci voting (rabbitmq is failing, so maybe delay? http://planck.nibalizer.com:5000/modules/puppetlabs/puppetlabs-rabbitmq) 18 | 19 | 20 | ## Reviewed: 21 | ### puppetlabs-openstack 22 | * 192: merged 23 | * 193: closed 24 | * 194: needs work 25 | 26 | ### puppetlabs-stdlib 27 | * 457: Related to #442 28 | * 442: Discussion on dependencies being required. Delaying until later 29 | * 469: merged 30 | 31 | ### puppetlabs-postgresql 32 | * 632: Closed 33 | * 626: Merged 34 | 35 | ### puppetlabs-apt 36 | * 525: [ACTION] Morgan to review because of her work. 37 | * 527: merged 38 | 39 | ## Waiting for response 40 | ### puppetlabs-bacula 41 | * 31 still waiting for rebase 42 | 43 | ### puppetlabs-tomcat 44 | * 76 still waiting on user 45 | 46 | ### puppetlabs-haproxy 47 | * 166 beaker-rspec tests failing and needs rebase 48 | 49 | -------------------------------------------------------------------------------- /modules/notes/2016-07-21.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-07-21 2 | 3 | ## Participants: 4 | * Hunner 5 | * karmix 6 | * igalic 7 | * SeanGriffin 8 | * dev_el_ops 9 | 10 | ## Discussion 11 | * inifile module cannot purge whole sections, only settings. The rhn config file contains sections-per-repo and it would be nice to be able to purge these by name. There is no previous ticket or PR around this idea. 12 | * Should we hardcode in httpoxy blocks in modules? Changing configfiles and restarting services in a bugfix release may be not recommended. Should provide a way to disable in case of edge cases? Or just hardcode and make disableable if someone complains. 13 | * haproxy may drop 1.4 compatibility, as well as older platforms (ubuntu 10/12/14.04, debian 6/7, redhats 5/6, puppet 3.x). TBD 14 | 15 | ## Reviews 16 | ### puppetlabs-stdlib 17 | * 620: commented, closed 18 | 19 | ### puppetlabs-inifile 20 | * 208: merged 21 | 22 | ## Past Reviews 23 | ### puppetlabs-accounts 24 | * 51: commented. Needs docs. Needs tests 25 | 26 | ### puppetlabs-postgresql 27 | * 762: commented. Needs to validate passed in params 28 | * 756: reviewed, 762 looks superior 29 | * 764: commented - test failures need to be looked at 30 | 31 | ### puppetlabs-apache 32 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 33 | * 1467: merge? 34 | * 1474: tests fail, dropped in favour of 1486 + 1487 35 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 36 | * 1490: logic needs rework 37 | * 1491: moved to 1494 38 | 39 | -------------------------------------------------------------------------------- /modules/notes/2016-04-07.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-04-07 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * HelenCampbell 6 | * dev_el_ops 7 | * tphoney 8 | * igalic 9 | * fraq 10 | * acidrainfall 11 | 12 | ## Discussion 13 | * apache overhaul? 14 | 15 | ## Reviews 16 | ### puppetlabs-apt 17 | * 581: yolo merged; hunner to watch CI for failures 18 | 19 | ### puppetlabs-mongodb 20 | * 288: merged 21 | * 287: merged 22 | * 284: commented (it probably needs lots of work) 23 | 24 | ## Past Reviews 25 | ### puppetlabs-apache 26 | * 1412: merged 27 | 28 | ### puppetlabs-vcsrepo 29 | * 274: still waiting on contributor 30 | 31 | ### puppetlabs-stdlib 32 | * 580: commented 33 | 34 | ### puppetlabs-mongodb 35 | * 260: commented 36 | * 282: waiting for travisci 37 | * 253: commented 38 | * 251: commented 39 | 40 | ### puppetlabs-haproxy 41 | * 224: commented 42 | 43 | ### puppetlabs-stdlib 44 | * 571: still waiting on author 45 | * 572: waiting for docs/tests 46 | * 576: commented on docs 47 | 48 | ### puppet-extlib 49 | * 49: no activity since last time 50 | 51 | ### puppetlabs-splunk 52 | * 29: closes #21 53 | * 15: ticketed in MODULES-3112; needs rebase 54 | 55 | ### puppetlabs-apache 56 | * 1393: waiting for ci 57 | 58 | ## Past Reviews 59 | ### puppetlabs-java 60 | * 155: commented 61 | 62 | ### puppetlabs-apache 63 | * 1341: commented 64 | 65 | ### puppetlabs-dism 66 | * 40: commented 67 | 68 | ### puppetlabs-rabbitmq 69 | * 423: commented 70 | * 421: commented. 71 | * 403: Commented. Need more information about the use case. 72 | * 380: commented 73 | -------------------------------------------------------------------------------- /modules/notes/2016-08-04.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-08-04 2 | 3 | ## Participants: 4 | * Hunner 5 | * HelenCampbell 6 | * dev_el_ops 7 | * zleslie 8 | * bmjen 9 | 10 | ## Discussion 11 | * TP to create epic on last weeks create_resources hiera hash pattern 12 | * read_only properties should conditionally be able to warn or fail. On warn, flush should still not be called if there are no other changes. Aws #334 spawned this discussion. Also, for those who have access, see vsphere/lib/puppet_x/puppetlabs/property/read_only.rb (which could use `insync?` instead of `validate`) zleslie to file a MODULES ticket. 13 | 14 | ## Reviews 15 | ### puppetlabs-aws 16 | * 336: merged 17 | * 334: to discuss after the others are reviewed 18 | * 330: david to comment and close and submit another bump pr for awssdk 19 | * 329: merged 20 | * 328: needs work 21 | * 327: merged 22 | * 325: merged 23 | * 324: commented 24 | 25 | 26 | ## Past Reviews 27 | ### puppetlabs-accounts 28 | * 51: commented. Needs docs. Needs tests 29 | 30 | ### puppetlabs-postgresql 31 | * 775: See discussion on 2016-07-28 32 | * 762: commented. Needs to validate passed in params 33 | * 756: reviewed, 762 looks superior 34 | * 764: commented - test failures need to be looked at 35 | 36 | ### puppetlabs-apache 37 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 38 | * 1467: merge? 39 | * 1474: tests fail, dropped in favour of 1486 + 1487 40 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 41 | * 1490: logic needs rework 42 | * 1491: moved to 1494 43 | 44 | -------------------------------------------------------------------------------- /modules/notes/2015-03-5.md: -------------------------------------------------------------------------------- 1 | # 2015-03-05 2 | 3 | Participants: 4 | * Hunner 5 | * \_morgan 6 | * cyberious 7 | * daenney 8 | * crinkle 9 | 10 | ## stdlib 421 11 | 12 | * Making JSON by hand is a bad idea 13 | * Rework it to check if the hash repsonds to `to_json` instead 14 | 15 | ## stdlib 416 16 | 17 | * Respond with how to do this with `has_key` instead 18 | * This is not needed, close it 19 | 20 | ## stdlib 409 21 | 22 | * This will only be reliable in masterless mode 23 | * Closed 24 | 25 | ## stdlib 408 26 | 27 | * This needs to be run through all the acceptance CI 28 | * Why are we only salting on the JVM? 29 | * Still a function masking the password variable 30 | 31 | ## stdlib 405 32 | 33 | * We're still not liking base64 34 | * It's not usable as POSIX password salt as per the contributor's own argument 35 | 36 | Hunter comments about how we'd like to see this done instead. 37 | 38 | ## stdlib 404 39 | 40 | Asked for a rebase. 41 | 42 | ## stdlib 390 43 | 44 | Travis will submit a new PR based on the original. 45 | 46 | ## stdlib 378 47 | 48 | Closed due to inactivity. 49 | 50 | ## stdlib 375 51 | 52 | This is good. Merged. 53 | 54 | ## stdlib 369 55 | 56 | This is good. Merged. 57 | 58 | ## stdlib 332 59 | 60 | This only returns floats on Ruby >2.0. It's `fqdn_rand` but with a minimum. Documentation is completely wrong. Closed. 61 | 62 | ## stdlib 307 63 | 64 | This is a 'deterministic' random function. Closed. 65 | 66 | ## stdlib 305 67 | 68 | Don't use hashes for passwords that you don't know what they are. Has been stale since August. No one likes this. No tests. Closed. 69 | -------------------------------------------------------------------------------- /modules/notes/2015-10-01.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-10-01 2 | ## Participants: 3 | * bmjen 4 | * Hunner 5 | * TP 6 | * HelenCampbell 7 | * Adam S (speedr|asasfu) 8 | * DavidSchmitt 9 | * daenney 10 | * speedr 11 | * nibalizer 12 | * JesseLovelace 13 | 14 | ## Discussion 15 | * pconf! 16 | 17 | ## Reviews 18 | ### Requested 19 | * Oracle support for java https://github.com/puppetlabs/puppetlabs-java/pull/139 20 | * Nope, legal issues 21 | * Disable service restarts on config changes in postgresql https://github.com/puppetlabs/puppetlabs-postgresql/pull/699 22 | * Looks good; needs work; commented 23 | * Package provider fact https://github.com/puppetlabs/puppetlabs-stdlib/pull/534 24 | * merged 25 | * service provider function https://gist.github.com/asasfu/e00eaf76f37141fca083 26 | * complex pattern requires modifying every module to support it; use collector override instead 27 | * Apt supporting https https://github.com/puppetlabs/puppetlabs-apt/pull/563 28 | * This should be solved at profile level, not in the module 29 | 30 | ## Past Reviews 31 | ### puppetlabs-vcsrepo 32 | * 271: commented 33 | * 270: commented 34 | * 267: waiting on community member 35 | 36 | ### puppetlabs-apache 37 | * 1150: Needs rebase; no change 38 | * 1201: commented 39 | * 1203: commented 40 | 41 | ### puppetlabs-mongodb 42 | * 194: still under active development 43 | 44 | ### puppetlabs-mysql 45 | * 704: waiting for contributor 46 | 47 | ### puppet-corosync 48 | * 153: Still WIP 49 | 50 | ### puppetlabs-lvm 51 | * 122: commented 52 | 53 | ### puppetlabs-postgresql 54 | * 696: commented 55 | 56 | ### puppetlabs-apt 57 | * 563: commented 58 | 59 | 60 | -------------------------------------------------------------------------------- /modules/notes/2015-03-12.md: -------------------------------------------------------------------------------- 1 | # 2015-03-12 2 | 3 | Participants: 4 | * Hunner 5 | * \_morgan 6 | * cyberious 7 | * daenney 8 | * crinkle 9 | * brian 10 | 11 | ## postgresql 580 12 | 13 | Missing docs, should at least have a docstring. 14 | 15 | ## postgresql 579 16 | 17 | Merged. 18 | 19 | ## postgresql 575 20 | 21 | * This should be a major version bump since we're removing a depedency 22 | * This module does have an explicit need for the apt module 23 | 24 | Rejected. 25 | 26 | ## postgresql 571 27 | 28 | Still needs docs and tests. 29 | 30 | ## postgresql 569 31 | 32 | Needs some style-guide fixage. Spacing around equal signs and hash rocket alignment. 33 | 34 | ## postgresql 564 35 | 36 | The `validate_string` on L78 needs to be `validate_re`. Was broken in the original and we should fix that up in a separate pull request. 37 | 38 | Merged. 39 | 40 | ## postgresql 560 41 | 42 | Needs to be rethought. Parameters that are being used for interpolation can be undef which gives rather weird results. 43 | 44 | ## postgresql 550 45 | 46 | * Variable needs to be renamed 47 | * Needs a rebase 48 | * `local_auth_options` being undeath can be a problem 49 | 50 | ## postgresql 547 51 | 52 | Closed due to inactivity. 53 | 54 | ## postgresql 546 55 | 56 | Hunter will squash and merge. 57 | 58 | ## postgresql 545 59 | 60 | Closed as invalid. The implementation ends up changing the error message but doesn't achieve anything more than that. 61 | 62 | ## postgresql 543 63 | 64 | Closed. 65 | 66 | ## postgresql 536 67 | 68 | Closed. This use case can already be accomplished. 69 | 70 | ## postgresql 530 71 | 72 | Accepted. Hunter will rebase and merge. 73 | -------------------------------------------------------------------------------- /modules/notes/2016-05-12.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-05-12 2 | ## Participants: 3 | * dev_el_ops 4 | * Hunner 5 | * Nirupama 6 | * rnelson0 7 | * twinkiman 8 | 9 | ## Discussion 10 | ### Mongodb 1.0.0 release: 11 | - WORKING TESTS!!! 12 | - drop apt 1.8 13 | - drop stdlib < 4 14 | - drop puppet < 3.8 and 4 <= x < 4.5 15 | - drop mongodb < 3 16 | - scrub readme 17 | - drop ubuntu < 14.04 18 | - drop centos < 6 19 | - drop debian < 7 20 | - update mongodb.conf to official 3.x 21 | - filed as MODULES-3358 22 | 23 | ## Reviews 24 | ### puppetlabs-mongodb 25 | * 297: merged 26 | * 296: merged 27 | * 295: merged 28 | 29 | ### voxpupuli-mcollective 30 | * 282: needs rebase 31 | 32 | ## Past Reviews 33 | ### puppetlabs-concat 34 | * 397: commented 35 | 36 | ### puppetlabs-rabbitmq 37 | * 465: made 467 38 | * 464: commented 39 | * 460: deferred 40 | * 457: needs squash/rebase 41 | 42 | ### puppetlabs-postgresql 43 | * 753: commented 44 | 45 | ### puppetlabs-apache 46 | * 1341: User unsure of hunters last reply. Needs input from us. 47 | * 1423: needs re-review 48 | * 1428: commented 49 | 50 | ### puppetlabs-vcsrepo 51 | * 274: commented pinging user for movement 52 | 53 | ### puppetlabs-mongodb 54 | * 260: commented 55 | * 253: needs rebased 56 | * 251: needs rebase 57 | * 284: commented (it probably needs lots of work) 58 | 59 | ### puppet-extlib - wat 60 | * 49: no activity since last time 61 | 62 | ### puppetlabs-splunk 63 | * 15: ticketed in MODULES-3112; needs rebase 64 | 65 | 66 | ### puppetlabs-dism 67 | * 40: commented 68 | 69 | ### puppetlabs-rabbitmq 70 | * 423: commented 71 | * 403: Commented. Need more information about the use case. 72 | * 380: commented 73 | 74 | -------------------------------------------------------------------------------- /modules/notes/2016-08-25.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-08-25 2 | 3 | ## Participants: 4 | * Hunner 5 | * HelenCampbell 6 | * eputnam 7 | * dev_el_ops 8 | * tphoney 9 | 10 | ## Discussion 11 | * 12 | 13 | ## Reviews 14 | ### puppetlabs-aws 15 | * 334: to discuss after the others are reviewed 16 | * 352: merged 17 | * 350: merged 18 | * 340: Filed QENG-4362 to be able to handle this 19 | * 330: closed 20 | * 328: merged 21 | * 324: merged 22 | 23 | ### puppetlabs-lvm 24 | * 158: skipping for now; will take too long 25 | * 155: merged 26 | * 154: commented 27 | * 153: commented 28 | * 152: closed 29 | * 148: merged 30 | 31 | ## Past Reviews 32 | ### puppetlabs-accounts 33 | * 51: commented. Needs docs. Needs tests 34 | 35 | ### puppetlabs-postgresql 36 | * 775: See discussion on 2016-07-28 37 | * 762: commented. Needs to validate passed in params 38 | * 756: reviewed, 762 looks superior 39 | * 764: commented - test failures need to be looked at 40 | 41 | ### puppetlabs-apache 42 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 43 | * 1467: merge? 44 | * 1474: tests fail, dropped in favour of 1486 + 1487 45 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 46 | * 1490: logic needs rework 47 | * 1491: moved to 1494 48 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 49 | * 1513: commented 50 | * 1497: commented 51 | * 1498: commented 52 | * 1499: commented 53 | 54 | 55 | -------------------------------------------------------------------------------- /puppet-lint/invite.ics: -------------------------------------------------------------------------------- 1 | BEGIN:VCALENDAR 2 | PRODID:-//Google Inc//Google Calendar 70.9054//EN 3 | VERSION:2.0 4 | CALSCALE:GREGORIAN 5 | METHOD:REQUEST 6 | BEGIN:VTIMEZONE 7 | TZID:America/New_York 8 | X-LIC-LOCATION:America/New_York 9 | BEGIN:DAYLIGHT 10 | TZOFFSETFROM:-0500 11 | TZOFFSETTO:-0400 12 | TZNAME:EDT 13 | DTSTART:19700308T020000 14 | RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=2SU 15 | END:DAYLIGHT 16 | BEGIN:STANDARD 17 | TZOFFSETFROM:-0400 18 | TZOFFSETTO:-0500 19 | TZNAME:EST 20 | DTSTART:19701101T020000 21 | RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU 22 | END:STANDARD 23 | END:VTIMEZONE 24 | BEGIN:VEVENT 25 | DTSTART;TZID=America/New_York:20170420T160000 26 | DTEND;TZID=America/New_York:20170420T170000 27 | RRULE:FREQ=MONTHLY;INTERVAL=2;BYDAY=3TH 28 | DTSTAMP:20170224T132940Z 29 | ORGANIZER;CN=Rob Nelson:mailto:rnelson0@gmail.com 30 | UID:fmnd0sfdiqo12kq8b7shqqu2h4@google.com 31 | ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE 32 | ;CN=Rob Nelson;X-NUM-GUESTS=0:mailto:rnelson0@gmail.com 33 | ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= 34 | TRUE;CN=rn7284@att.com;X-NUM-GUESTS=0:mailto:rn7284@att.com 35 | CREATED:20170224T132940Z 36 | DESCRIPTION:https://bluejeans.com/280736660\n\nBi-monthly triage call. See https://github.com/voxpupuli/community-triage/tree/master/puppet-lint for more information and meeting minutes. 37 | LAST-MODIFIED:20170224T132940Z 38 | LOCATION:https://bluejeans.com/280736660 39 | SEQUENCE:0 40 | STATUS:CONFIRMED 41 | SUMMARY:puppet-lint triage 42 | TRANSP:OPAQUE 43 | BEGIN:VALARM 44 | ACTION:DISPLAY 45 | DESCRIPTION:This is an event reminder 46 | TRIGGER:-P0DT0H15M0S 47 | END:VALARM 48 | END:VEVENT 49 | END:VCALENDAR 50 | -------------------------------------------------------------------------------- /modules/notes/2015-02-19.md: -------------------------------------------------------------------------------- 1 | # 2015-02-19 2 | 3 | Participants: 4 | * tphoney 5 | * jt 6 | * Hunner 7 | * \_morgan 8 | * cyberious 9 | * daenney 10 | 11 | ## nodejs 103 12 | 13 | * Major rework. 14 | * Closed all the other associated PR's. 15 | 16 | Merged by Hunner. 17 | 18 | daenney came in late because of browser plugin issues with BlueJeans. Minutes start from 18:18 UTC. 19 | 20 | ## stdlib 408 21 | 22 | * This needs to be updates to work on Windows. 23 | * L37 is weird, password is a variable but masked now by a function 24 | 25 | ## stdlib 405 26 | 27 | Long story about base64 vs. base62 from Hunter. 28 | 29 | * Why do we even have a `base64` version. 30 | * What is it used for? 31 | * We're confused about the seed. 32 | 33 | `base64` doesn't seem useful. Leaving this for now 34 | 35 | ## apt 424 36 | 37 | Lots of cheering. 38 | 39 | Daenney given the honour to merge into next! 40 | 41 | ## mysql 649 42 | 43 | This merge broke Puppetlabs internal CI. Travis is on rotation to fix this. 44 | 45 | ## tomcat 76 46 | 47 | * This needs to be squashed 48 | * Too many different ways of casing variables 49 | * A lot of parameters instead of a hash with optional keys 50 | * Only documentation on some of the classes 51 | 52 | \_morgan will look at this further and respond. Travis will help because he has *zomg* Tomcat experience. Even on Windows. 53 | 54 | ## tomcat 74 55 | 56 | * Needs a README 57 | * Needs tests 58 | * Trailing comma's 59 | 60 | \_morgan comments. 61 | 62 | ## tomcat 70 63 | 64 | `ensure_resource` freaks out people. But this seems to be one of the rare cases where it is correctly being used. 65 | 66 | Merged by \_morgan 67 | 68 | ## mysql 674 69 | 70 | Hunner merged. 71 | -------------------------------------------------------------------------------- /modules/notes/2016-06-09.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-06-09 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * HelenCampbell 6 | * tphoney 7 | * twinkiman 8 | 9 | ## Discussion 10 | * Lets get puppet-archive to 1.0.0 and Puppet Approved! 11 | 12 | ## Reviews 13 | ### puppet-archive 14 | * prep for release and approval! 15 | * 171: 16 | 17 | ### puppetlabs-haproxy 18 | * 218: Needs rebase 19 | * 238: Closed by 243 20 | * 239: Merged 21 | * 242: Merged 22 | 23 | ## Past Reviews 24 | ### puppetlabs-aws 25 | * 307: commenting 26 | * 300: commented 27 | 28 | ## Past Reviews 29 | ### puppetlabs-mysql 30 | * 832: commented 31 | 32 | ### voxpupuli-mcollective 33 | * 282: rebased to https://github.com/voxpupuli/puppet-mcollective/pull/303 34 | 35 | ### puppetlabs-concat 36 | * 397: commented 37 | 38 | ### puppetlabs-rabbitmq 39 | * 465: made 467 40 | * 464: commented 41 | * 460: deferred 42 | * 457: needs squash/rebase 43 | 44 | ### puppetlabs-postgresql 45 | * 753: commented 46 | 47 | ### puppetlabs-apache 48 | * 1341: User unsure of hunters last reply. Needs input from us. 49 | * 1423: needs re-review 50 | * 1428: commented 51 | 52 | ### puppetlabs-vcsrepo 53 | * 274: commented pinging user for movement 54 | 55 | ### puppetlabs-mongodb 56 | * 260: commented 57 | * 253: needs rebased 58 | * 251: needs rebase 59 | * 284: commented (it probably needs lots of work) 60 | 61 | ### puppet-extlib - wat 62 | * 49: no activity since last time 63 | 64 | ### puppetlabs-splunk 65 | * 15: ticketed in MODULES-3112; needs rebase 66 | 67 | 68 | ### puppetlabs-dism 69 | * 40: commented 70 | 71 | ### puppetlabs-rabbitmq 72 | * 423: commented 73 | * 403: Commented. Need more information about the use case. 74 | * 380: commented 75 | -------------------------------------------------------------------------------- /modules/notes/2016-01-07.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-01-07 2 | ## Participants: 3 | * bmjen 4 | * mentat 5 | * DavidS 6 | * HelenCampbell 7 | * Hunner 8 | * karmix 9 | * daenney 10 | * tphoney 11 | 12 | ## Discussion 13 | 14 | * vcsrepo#275: group debugging the git provider; general consensus seems to be that the code is convoluted and jimmied 15 | 16 | ## Reviews 17 | 18 | ### puppetlabs-rabbitmq 19 | * 403: Commented. Need more information about the usecase. 20 | 21 | ## Past Reviews 22 | 23 | ### puppetlabs-rabbitmq 24 | * 418: Needs work. 25 | * 407: Needs work. Fails tests. bmjen fixed unit tests, submitter needs to rebase. 26 | * 405: Commented. Needs work. Submitter pinged. - Submitter closed this himself without comment. 27 | * 211: Tests failing. Needs rebase. Broken on ruby 1.8.7. May require someone take over dev. 28 | * 375: Commented. Backwards incompatible. Suggestions provided. 29 | 30 | ### puppetlabs-haproxy 31 | * 200: merged 32 | * 203: merged 33 | * 204: re-uploaded as 211 34 | 35 | ### puppetlabs-java 36 | * 149: closed 37 | 38 | ### puppetlabs-mysql 39 | * 763: Merged at 786 40 | 41 | ### puppetlabs-vcsrepo 42 | * 275: [ACTION: bmjen to open JIRA tickets for karmix’s action items so that we can address them internally and take over karmix’s work. ([ACTION]. Karmix to take over suggested updates. [ACTION] bmjen to track larger refactor in github issues + jira ticket.) 43 | * 270: [ACTION]: bmjen to open JIRA ticket to take over adding test to this PR to get the fix in. ([ACTION] Still closed due to inactivity. Karmix to comment on pertinence to #275.) 44 | 45 | ### puppetlabs-tomcat 46 | * 109: now tracked in FM-3981. Will need to be reimplemented to more compartmentalized features and fixes. 47 | -------------------------------------------------------------------------------- /modules/notes/2015-05-14.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage Notes 2015-05-14 2 | 3 | ## Participants: 4 | * Hunner 5 | * bmjen 6 | * _morgan 7 | * jtpuppet 8 | * DavidS 9 | * cyberious 10 | * nibz 11 | * tphoney 12 | 13 | ## Discussion: 14 | * [ACTION] Hunner: sync the labels across the modules 15 | * branching strategy 16 | * "stable" is not useful branch name 17 | * One proposal: ditch "master" and use "2.x" and "3.x" etc. and set the latest one as the default branch 18 | * Another: use .y branches + master to track minor releases 19 | * [ACTION] Come up with requirements, then proposal, then email to puppet-dev 20 | * [ACTION] Add module release process to CONTRIBUTING.md 21 | * [ACTION] Hunner: Move nodejs & corosync to puppet-community 22 | * [ACTION] nibz: turn on pcci voting 23 | * [ACTION] Hunner: create openstack group for rabbitmq, mongodb, mysql and add crinkle, nibz, emilienm, sbadia 24 | 25 | ## Reviewed 26 | ### puppetlabs-stdlib 27 | * 445 & 444 conn_validator 28 | * validate_connection rename? 29 | * a single type with providers instead of http_* and tcp_* 30 | * This should go into puppet-community 31 | * [ACTION] nibz: Email to puppet-dev mailing list about it moving to puppet community, pick a name, pick the API, and use cases. 32 | * 329: closed, not reproducible 33 | * 326: soft reject 34 | 35 | ### puppetlabs-apache 36 | * MODULES-2011 multiple instances request 37 | * Chef does multiple httpd instances https://github.com/chef-cookbooks/httpd 38 | * Suggestion: Only do it for systemd platforms 39 | * Would need all classes (mod, configs, etc) converted to defines and take instance names 40 | 41 | ## Waiting for response 42 | ### puppetlabs-bacula 43 | * 31 still waiting for rebase 44 | 45 | ### puppetlabs-tomcat 46 | * 76 still waiting on user 47 | 48 | ### puppetlabs-haproxy 49 | * 166 beaker-rspec tests failing and needs rebase 50 | 51 | 52 | -------------------------------------------------------------------------------- /puppet-lint/notes/2016-12-21.md: -------------------------------------------------------------------------------- 1 | BlueJeans Link (Open all the time except during Modules Community Triage): https://bluejeans.com/280736660 2 | 3 | # Planning 4 | 5 | * How to leverage the puppet parser API? Would require adding the puppet gem and its dependencies. This would affect ability to detect issues with older syntax and possibly affect tools like Atom that leverage the linter. (3.x) 6 | * Validation ([586](https://github.com/rodjek/puppet-lint/pull/586)) - looks good 7 | * Enable app orchestration 8 | * Continue if a single file is unparseable (currently stops) 9 | * Pulling it in for lexing and check logic - up in the air 10 | * New plugins that are non-core ([example](https://github.com/rodjek/puppet-lint/pull/235)) - one community plugins repo, with individual gems in their own directory. Those gems can be one plugin or multiple plugins. (1Q17) 11 | * Existing plugins in core, allow to be applied by groups, and also capture other metada. Example of groups are style guide plugins, site manifest plugins, etc. (3.0.0) 12 | * plugin group, documentation reference, description, enable/disable 13 | * rake spec should flag missing docrefs 14 | * Spike for token getters/setters ([584](https://github.com/rodjek/puppet-lint/pull/584/files)) (3.0.0) 15 | * Set a regular cadence for puppet-lint triage and planning sessions (Rob Nelson) 16 | * Drop Ruby 1.8.7 support in Puppet 3 ([503](https://github.com/rodjek/puppet-lint/issues/503), [606](https://github.com/rodjek/puppet-lint/pull/606)) 17 | 18 | # Issues and PRs 19 | 20 | * Arrow Alignment: 416, 424, 446, 506 - Tim will look into 424 first and then some others. 21 | * Top-scope: 464, 548, 549, 550, 576 22 | * Merged: 589, 590, 591, 545 (was merged, will add a new PR with an additional spec test), Approved with modifications: 586, 517, 605 (replaced by 608) 23 | * Other: 596 provide a workaround and then discuss 24 | 25 | 26 | -------------------------------------------------------------------------------- /modules/notes/2017-12-21.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2017-12-21 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * eputnam 7 | * dhollinger 8 | 9 | ### Discussion: 10 | * Is there anybody out there...? #holidays 11 | 12 | 13 | 14 | Go to https://github.com/voxpupuli/community-triage/tree/master/modules/notes for notes from previous meetings. 15 | 16 | ## Reviews: 17 | ### puppetlabs-postgresql 18 | * 917: commented (yuge!) 19 | 20 | ### puppetlabs-tomcat 21 | * 260: review in progress 22 | 23 | 24 | ## Past Reviews: 25 | 26 | ### puppetlabs-rsync 27 | * 78: closed - inactivity 28 | * 80: commented 29 | * 81: opened #110 to close 30 | 31 | ### puppetlabs-apache 32 | * 1659: again... looking good, comments from ekohl for a few helpful changes. 33 | 34 | 35 | 36 | ### puppet-rabbitmq 37 | - 529: commented 38 | - 556: commented 39 | - 547: commented, merged by accident and reverted. Needs to be resubmitted. 40 | - 598: merged 41 | 42 | 43 | 44 | ### voxpupuli-yum 45 | * 40: commented 46 | 47 | ### puppet-nginx 48 | * #862: [discuss] 49 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 50 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 51 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 52 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 53 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 54 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 55 | * #902: use_default_location 56 | 57 | 58 | -------------------------------------------------------------------------------- /modules/notes/2015-12-17.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-12-17 2 | ## Participants: 3 | * bmjen 4 | * mentat 5 | * nibalizer 6 | 7 | ## Discussion 8 | 9 | ## Reviews 10 | 11 | ### puppetlabs-rabbitmq 12 | * 419: Merged 13 | * 418: Needs work. 14 | * 412: Merged 15 | * 410: Merged 16 | * 407: Fails tests. [ACTION] bmjen will run unit tests locally and comment on failure reasons. 17 | * 406: Merged. [ACTION] nibalizer can fix style nits in separate PR. 18 | * 405: Commented. Needs work. Submitter pinged. 19 | * 404: Merged. 20 | 21 | ### puppetlabs-haproxy 22 | * 200: commented. 23 | * 203: Needs work. Submitter pinged. 24 | * 204: Needs rebase. Submitter pinged. 25 | 26 | ## Past Reviews 27 | 28 | ### puppetlabs-firewall 29 | * 579: Merged 30 | 31 | ### puppetlabs-stdlib 32 | * 554: merged 33 | 34 | ### puppetlabs-java 35 | * 149: DavidS commented. This change would cause some breakage and backwards incompatibility. 36 | 37 | 38 | 39 | ### puppetlabs-rabbitmq 40 | * 415: Merged 41 | * 211: Tests failing. Needs rebase. Broken on ruby 1.8.7. May require someone take over dev. 42 | * 375: Commented. Backwards incompatible. Suggestions provided. 43 | 44 | ### puppetlabs-postgresql 45 | 46 | ### puppetlabs-concat 47 | 48 | ### puppetlabs-apache 49 | 50 | ### puppetlabs-mysql 51 | * 763: Still needs work and rebase. DavidS to take a look at the conflicts and maybe take over rebase/PR. Pushed to https://github.com/puppetlabs/puppetlabs-mysql/pull/786 52 | 53 | ### puppetlabs-vcsrepo 54 | * 275: [ACTION]. Karmix to take over suggested updates. [ACTION] bmjen to track larger refactor in github issues + jira ticket. 55 | * 270: [ACTION] Still closed due to inactivity. Karmix to comment on pertinence to #275. 56 | 57 | ### puppetlabs-tomcat 58 | * 109: [ACTION] TP to create JIRA ticket to take over the work and determine backwards compatibility. 59 | 60 | 61 | ### puppetlabs-lvm 62 | * 122: Closed for inactivity. Pinged submitter to reopen when issues addressed. 63 | -------------------------------------------------------------------------------- /modules/notes/2016-09-01.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-09-01 2 | 3 | ## Participants: 4 | * Hunner 5 | * bmjen 6 | * eputnam 7 | * tphoney 8 | 9 | ## Discussion 10 | * Modules and puppet language as UX and their importance to customers. 11 | * rabbitmq 6.0.0 time? (#497, #440 & #493) 12 | * rubocop 13 | * PMC applications are open until Sep 17! https://github.com/voxpupuli/plumbing/blob/master/share/elections/2016-01.md#dates 14 | 15 | ## Reviews 16 | ### puppetlabs-rabbitmq 17 | * 500: merged 18 | * 498: reckicked failing CI & commented 19 | * 497: see discussion 20 | * 493: see discussion; needs review 21 | * 491: merged 22 | 23 | ### puppetlabs-aws 24 | * 354: merged 25 | * 334: to discuss after the others are reviewed 26 | * 340: Filed QENG-4362 to be able to handle this 27 | 28 | ## Past Reviews 29 | ### puppetlabs-lvm 30 | * 158: skipping for now; will take too long 31 | * 154: commented 32 | * 153: commented 33 | 34 | ### puppetlabs-accounts 35 | * 51: commented. Needs docs. Needs tests 36 | 37 | ### puppetlabs-postgresql 38 | * 775: See discussion on 2016-07-28 39 | * 762: commented. Needs to validate passed in params 40 | * 756: reviewed, 762 looks superior 41 | * 764: commented - test failures need to be looked at 42 | 43 | ### puppetlabs-apache 44 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 45 | * 1467: merge? 46 | * 1474: tests fail, dropped in favour of 1486 + 1487 47 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 48 | * 1490: logic needs rework 49 | * 1491: moved to 1494 50 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 51 | * 1513: commented 52 | * 1497: commented 53 | * 1498: commented 54 | * 1499: commented 55 | 56 | -------------------------------------------------------------------------------- /modules/notes/2016-05-19.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-05-19 2 | ## Participants: 3 | * dev_el_ops 4 | * Hunner 5 | * Nirupama 6 | * Craig 7 | * twinkiman 8 | * bmjen 9 | * daenney 10 | * HelenCampbell 11 | 12 | ## Discussion 13 | * cutting everything over to pl-apt 2.x… gets rid of warnings, but requires major bump 14 | * dropping puppet 4 would be bad, but dropping 10.04 15 | * drop rhelish 5 stuff 16 | * drop puppet 2.7 anywhere (maybe just stdlib?) 17 | * do the above in all the supported modules 18 | * moving time for this meeting to UTC! Is 16:00-17:00 or 17:00-18:00 better? 19 | * keep at 17:00 for at least another week, since that's when it is now 20 | * need to email out to puppet-dev@ about change and okay'ing change (Hunter) 21 | 22 | ## Reviews 23 | ### puppetlabs-mysql 24 | * 838: merged 25 | * 833: squashmerge 26 | * 832: commented 27 | * 829: merged 28 | 29 | ### voxpupuli-mcollective 30 | * 282: rebased to https://github.com/voxpupuli/puppet-mcollective/pull/303 31 | 32 | ## Past Reviews 33 | ### puppetlabs-concat 34 | * 397: commented 35 | 36 | ### puppetlabs-rabbitmq 37 | * 465: made 467 38 | * 464: commented 39 | * 460: deferred 40 | * 457: needs squash/rebase 41 | 42 | ### puppetlabs-postgresql 43 | * 753: commented 44 | 45 | ### puppetlabs-apache 46 | * 1341: User unsure of hunters last reply. Needs input from us. 47 | * 1423: needs re-review 48 | * 1428: commented 49 | 50 | ### puppetlabs-vcsrepo 51 | * 274: commented pinging user for movement 52 | 53 | ### puppetlabs-mongodb 54 | * 260: commented 55 | * 253: needs rebased 56 | * 251: needs rebase 57 | * 284: commented (it probably needs lots of work) 58 | 59 | ### puppet-extlib - wat 60 | * 49: no activity since last time 61 | 62 | ### puppetlabs-splunk 63 | * 15: ticketed in MODULES-3112; needs rebase 64 | 65 | 66 | ### puppetlabs-dism 67 | * 40: commented 68 | 69 | ### puppetlabs-rabbitmq 70 | * 423: commented 71 | * 403: Commented. Need more information about the use case. 72 | * 380: commented 73 | 74 | -------------------------------------------------------------------------------- /modules/notes/2016-06-02.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-06-02 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * HelenCampbell 6 | * tphoney 7 | 8 | ## Discussion 9 | * cutting everything over to pl-apt 2.x… gets rid of warnings, but requires major bump 10 | * dropping puppet 4 would be bad, but dropping 10.04 11 | * drop rhelish 5 stuff 12 | * drop puppet 2.7 anywhere (maybe just stdlib?) 13 | * do the above in all the supported modules 14 | * moving time for this meeting to UTC! Is 16:00-17:00 or 17:00-18:00 better? 15 | * keep at 17:00 for at least another week, since that's when it is now 16 | * need to email out to puppet-dev@ about change and okay'ing change (Hunter) 17 | 18 | ## Reviews 19 | ### puppetlabs-aws 20 | * 307: commenting 21 | * 304: merged 22 | * 300: commented 23 | * 295: merged, closed 147 and 259 24 | 25 | ## Past Reviews 26 | ### puppetlabs-mysql 27 | * 832: commented 28 | 29 | ### voxpupuli-mcollective 30 | * 282: rebased to https://github.com/voxpupuli/puppet-mcollective/pull/303 31 | 32 | ### puppetlabs-concat 33 | * 397: commented 34 | 35 | ### puppetlabs-rabbitmq 36 | * 465: made 467 37 | * 464: commented 38 | * 460: deferred 39 | * 457: needs squash/rebase 40 | 41 | ### puppetlabs-postgresql 42 | * 753: commented 43 | 44 | ### puppetlabs-apache 45 | * 1341: User unsure of hunters last reply. Needs input from us. 46 | * 1423: needs re-review 47 | * 1428: commented 48 | 49 | ### puppetlabs-vcsrepo 50 | * 274: commented pinging user for movement 51 | 52 | ### puppetlabs-mongodb 53 | * 260: commented 54 | * 253: needs rebased 55 | * 251: needs rebase 56 | * 284: commented (it probably needs lots of work) 57 | 58 | ### puppet-extlib - wat 59 | * 49: no activity since last time 60 | 61 | ### puppetlabs-splunk 62 | * 15: ticketed in MODULES-3112; needs rebase 63 | 64 | 65 | ### puppetlabs-dism 66 | * 40: commented 67 | 68 | ### puppetlabs-rabbitmq 69 | * 423: commented 70 | * 403: Commented. Need more information about the use case. 71 | * 380: commented 72 | -------------------------------------------------------------------------------- /modules/notes/2016-05-26.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-05-26 2 | ## Participants: 3 | * dev_el_ops 4 | * Hunner 5 | * Nirupama 6 | * bmjen 7 | * HelenCampbell 8 | 9 | ## Discussion 10 | * cutting everything over to pl-apt 2.x… gets rid of warnings, but requires major bump 11 | * dropping puppet 4 would be bad, but dropping 10.04 12 | * drop rhelish 5 stuff 13 | * drop puppet 2.7 anywhere (maybe just stdlib?) 14 | * do the above in all the supported modules 15 | * moving time for this meeting to UTC! Is 16:00-17:00 or 17:00-18:00 better? 16 | * keep at 17:00 for at least another week, since that's when it is now 17 | * need to email out to puppet-dev@ about change and okay'ing change (Hunter) 18 | 19 | ## Reviews 20 | ### puppetlabs-aws 21 | * 307: commenting 22 | * 304: merged 23 | * 300: commented 24 | * 295: merged, closed 147 and 259 25 | 26 | ## Past Reviews 27 | ### puppetlabs-mysql 28 | * 832: commented 29 | 30 | ### voxpupuli-mcollective 31 | * 282: rebased to https://github.com/voxpupuli/puppet-mcollective/pull/303 32 | 33 | ### puppetlabs-concat 34 | * 397: commented 35 | 36 | ### puppetlabs-rabbitmq 37 | * 465: made 467 38 | * 464: commented 39 | * 460: deferred 40 | * 457: needs squash/rebase 41 | 42 | ### puppetlabs-postgresql 43 | * 753: commented 44 | 45 | ### puppetlabs-apache 46 | * 1341: User unsure of hunters last reply. Needs input from us. 47 | * 1423: needs re-review 48 | * 1428: commented 49 | 50 | ### puppetlabs-vcsrepo 51 | * 274: commented pinging user for movement 52 | 53 | ### puppetlabs-mongodb 54 | * 260: commented 55 | * 253: needs rebased 56 | * 251: needs rebase 57 | * 284: commented (it probably needs lots of work) 58 | 59 | ### puppet-extlib - wat 60 | * 49: no activity since last time 61 | 62 | ### puppetlabs-splunk 63 | * 15: ticketed in MODULES-3112; needs rebase 64 | 65 | 66 | ### puppetlabs-dism 67 | * 40: commented 68 | 69 | ### puppetlabs-rabbitmq 70 | * 423: commented 71 | * 403: Commented. Need more information about the use case. 72 | * 380: commented 73 | -------------------------------------------------------------------------------- /2015-08-18.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-08-18 2 | 3 | ## Participants: 4 | * Hunner 5 | * eputnam 6 | * fraq 7 | * bmjen 8 | * binford2k 9 | * tphoney 10 | 11 | ## Discussion 12 | * You have until Sunday Aug 21 23:59 UTC to vote on our governance documents (no style nits PLEASE!) https://github.com/voxpupuli/plumbing/pull/45 13 | * It appears that consensus has been removed and all voting will be lazy consensus with 72 hours time slots, condorcet for PMC elections. After discussing it, it seems fine. 14 | * see https://voxpupuli.org/docs/ for further VP details 15 | * Migrate puppetlabs-splunk to voxpupuli's namespace 16 | * eputnam is the newest Puppet module engineer, started this week! 17 | * google docs sucs for writing markdown. We're switching to etherpad! 18 | 19 | ## Reviews 20 | ### puppetlabs-apache 21 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 22 | * 1513: commented 23 | * 1490: merged 24 | * 1496: merged 25 | * 1497: commented 26 | * 1498: commented 27 | * 1499: commented 28 | * 1500: merged 29 | * 1503: merged 30 | 31 | ## Past Reviews 32 | ### puppetlabs-aws 33 | * 334: to discuss after the others are reviewed 34 | * 330: david to comment and close and submit another bump pr for awssdk 35 | * 328: needs work 36 | * 324: commented 37 | 38 | ### puppetlabs-accounts 39 | * 51: commented. Needs docs. Needs tests 40 | 41 | ### puppetlabs-postgresql 42 | * 775: See discussion on 2016-07-28 43 | * 762: commented. Needs to validate passed in params 44 | * 756: reviewed, 762 looks superior 45 | * 764: commented - test failures need to be looked at 46 | 47 | ### puppetlabs-apache 48 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 49 | * 1467: merge? 50 | * 1474: tests fail, dropped in favour of 1486 + 1487 51 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 52 | * 1490: logic needs rework 53 | * 1491: moved to 1494 54 | 55 | -------------------------------------------------------------------------------- /puppet-lint/notes/2017-02-23.md: -------------------------------------------------------------------------------- 1 | BlueJeans Link (Open all the time except during Modules Community Triage): https://bluejeans.com/280736660 2 | 3 | Attendees: rnelson0, mterzo, binford2k, hunner, bmjen, dhollinger, rodjek 4 | 5 | # Planning 6 | 7 | * Rubocop - needs to meet 1.8.7+. Mike started a spike but it was for 2.3+. We can support 1.9+ instead if it's targeted to the 3.0 branch. 8 | * Set a regular cadence for puppet-lint triage and planning sessions - 3rd Thursday of every Even numbered month @ 1PM Pacific (send .ics file to puppet-dev?) 9 | * 3.0.0 milestone deadline set to May 5th! 10 | 11 | # Issues and PRs 12 | 13 | * Good news, everybody! 416/424 were fixed! We should investigate if 446/506 were fixed by this as well. 14 | * Top-scope resolutions in 636-638, should check 464/548/549/550/576 to see if they are resolved. 15 | * 606 - rebase 16 | * 235 - binford2k will touch up and submit a new PR 17 | * 634 - The right side of a parameter arrow can be a value or a `lookup()` call. (rodjek) 18 | * 633 - Style Guide 10.6 will need clarification. The current reading means all parameters with an `=` after them should be grouped together, even if the value they are assigned is "mandatory". 19 | * 627 - Is it a problem because they're on the right side following the left side? Even if not doing an on-the-fly calculation (not recommended) this could potentially occur if two parameters are assigned the same value. Write a test to catch it, then figure out the correct fix. 20 | * 626 - Would require a new check. Is this in the style guide? No - 9.3 is the closest but is Resource Attributes only. 21 | * 625 - Bug with the checks. (binford2k) 22 | * 622 - This functionality should already work, if it's not, it's a regression that's missing a test. 23 | * 599 - Some recent fixes adjusted alignment issues. Check to see if this is resolved. 24 | * 568 - Disable the check in the 3.0.0 branch. 25 | * 586 - Continue if a single file is unparseable; currently stops on the first one (rnelson0) 26 | 27 | * New plugins that are non-core ([example](https://github.com/rodjek/puppet-lint/pull/235)) - Continue with one plugin per repo, tracked in the `gh-pages` community plugins list. In the future, the Puppet SDK team can look at a more flexible solution. 28 | -------------------------------------------------------------------------------- /modules/notes/2017-12-07.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2017-12-07 2 | 3 | ## #puppethack! 4 | 5 | Join us in video chat! https://bluejeans.com/726683729 6 | 7 | ## Participants: 8 | * eputnam 9 | * Hunner 10 | * cdenneen 11 | * binford2k 12 | 13 | ### Discussion: 14 | 15 | 16 | Go to https://github.com/voxpupuli/community-triage/tree/master/modules/notes for notes from previous meetings. 17 | 18 | ## Reviews: 19 | 20 | ### puppetlabs-postgresql 21 | * 775: closed (inactivity) 22 | * 834: closed (inactivity) 23 | 24 | ### puppetlabs-mysql 25 | * 884: closed 26 | * 904: Commented. "Hunner will fix. 27 | * 1035: Commented. 28 | 29 | ## Past Reviews: 30 | ### puppetlabs-tomcat 31 | * 260: review in progress 32 | 33 | ### puppetlabs-rsync 34 | * 78: closed - inactivity 35 | * 80: commented 36 | * 81: opened #110 to close 37 | 38 | ### puppetlabs-apache 39 | * 1659: again... looking good, comments from ekohl for a few helpful changes. 40 | 41 | ### puppetlabs-postgresql 42 | * 917: 43 | 44 | - last one please: https://github.com/puppetlabs/puppetlabs-haproxy/pull/278 tests failing 45 | 46 | ### puppet-rabbitmq 47 | - 529: commented 48 | - 556: commented 49 | - 547: commented, merged by accident and reverted. Needs to be resubmitted. 50 | - 598: merged 51 | 52 | 53 | 54 | ### voxpupuli-yum 55 | * 40: commented 56 | 57 | ### puppetlabs-aws 58 | * 394: commented 59 | * 378: commented 60 | * 312: commented 61 | * 300: commented 62 | 63 | ### puppet-nginx 64 | * #862: [discuss] 65 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 66 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 67 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 68 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 69 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 70 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 71 | * #902: use_default_location 72 | 73 | 74 | -------------------------------------------------------------------------------- /modules/notes/2016-06-16.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-06-16 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * nibz 6 | * tphoney 7 | 8 | ## Discussion 9 | * Soft module dependencies! Raised by https://github.com/voxpupuli/puppet-nodejs/pull/233 (related: http://www.slideshare.net/PuppetLabs/garethrushgrove-puppetconf see slides 150-151) 10 | ** optional dependencies are added when branching logic may or may not need the class 11 | ** many optional dependencies should NOT be declared as normal dependencies because it creates more complicated dependency trees and thus makes it harder to get complete trees 12 | ** what about having an optional_dependency('puppetlabs-apt','>=1.8.0 < 3.0.0') kind of function that looks for the metadata of the required module and raises a helpful error message if missing? 13 | ** or having metadata.json with optional_dependency and the compiler doing something similar to above on manifest cache miss 14 | ** nibz will spec something out 15 | - 16 | 17 | 18 | ## Reviews 19 | ### puppet-archive 20 | * prep for release and approval! 21 | * nan needs to make a decision on 22 | 23 | ## Past Reviews 24 | ### puppetlabs-haproxy 25 | * 218: Needs rebase 26 | 27 | ### puppetlabs-aws 28 | * 307: commenting 29 | * 300: commented 30 | 31 | ### puppetlabs-mysql 32 | * 832: commented 33 | 34 | ### voxpupuli-mcollective 35 | * 282: rebased to https://github.com/voxpupuli/puppet-mcollective/pull/303 36 | 37 | ### puppetlabs-concat 38 | * 397: commented 39 | 40 | ### puppetlabs-rabbitmq 41 | * 465: made 467 42 | * 464: commented 43 | * 460: deferred 44 | * 457: needs squash/rebase 45 | 46 | ### puppetlabs-postgresql 47 | * 753: commented 48 | 49 | ### puppetlabs-apache 50 | * 1341: User unsure of hunters last reply. Needs input from us. 51 | * 1423: needs re-review 52 | * 1428: commented 53 | 54 | ### puppetlabs-vcsrepo 55 | * 274: commented pinging user for movement 56 | 57 | ### puppetlabs-mongodb 58 | * 260: commented 59 | * 253: needs rebased 60 | * 251: needs rebase 61 | * 284: commented (it probably needs lots of work) 62 | 63 | ### puppet-extlib - wat 64 | * 49: no activity since last time 65 | 66 | ### puppetlabs-splunk 67 | * 15: ticketed in MODULES-3112; needs rebase 68 | 69 | ### puppetlabs-dism 70 | * 40: commented 71 | 72 | ### puppetlabs-rabbitmq 73 | * 423: commented 74 | * 403: Commented. Need more information about the use case. 75 | * 380: commented 76 | 77 | -------------------------------------------------------------------------------- /modules/notes/2016-06-23.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-06-23 2 | ## Participants: 3 | * Hunner 4 | * bmjen 5 | * dev_el_ops 6 | * tphoney 7 | 8 | ## Discussion 9 | * (via rnelson0) puppetlabs-mysql uses puppet-staging < 2.0.0 but lots of modules are using >= 2.0.0 10 | ** https://github.com/puppetlabs/puppetlabs-mysql/pull/858 was merged to address this, just need a new forge release. 11 | ** so we'll do a release in an upcoming sprint 12 | ** archive is supposed to be the new staging, and staging is deprecated, so why not switch to archive? 13 | * Are module dependencies public or private API? At some point we decided that dependency gems are private api. 14 | 15 | 16 | ## Reviews 17 | ### puppetlabs-tomcat 18 | * 148: commented, and marked on backwards incompatible. 19 | * 149: merged 20 | 21 | ### puppetlabs-stdlib 22 | * 608: commented on. 23 | * 609: guidance was given, changes to the main readme is required to show the new functionality. David will update the PR 24 | 25 | ### puppetlabs-mysql 26 | * 803: wat? 27 | 28 | ## Past Reviews 29 | ### puppet-archive 30 | * prep for release and approval! 31 | * nan needs to make a decision on 32 | 33 | ### puppetlabs-haproxy 34 | * 218: Needs rebase 35 | 36 | ### puppetlabs-aws 37 | * 307: commenting 38 | * 300: commented 39 | 40 | ### puppetlabs-mysql 41 | * 832: commented 42 | 43 | ### voxpupuli-mcollective 44 | * 282: rebased to https://github.com/voxpupuli/puppet-mcollective/pull/303 45 | 46 | ### puppetlabs-concat 47 | * 397: commented 48 | 49 | ### puppetlabs-rabbitmq 50 | * 465: made 467 51 | * 464: commented 52 | * 460: deferred 53 | * 457: needs squash/rebase 54 | 55 | ### puppetlabs-postgresql 56 | * 753: commented 57 | 58 | ### puppetlabs-apache 59 | * 1341: User unsure of hunters last reply. Needs input from us. 60 | * 1423: needs re-review 61 | * 1428: commented 62 | 63 | ### puppetlabs-vcsrepo 64 | * 274: commented pinging user for movement 65 | 66 | ### puppetlabs-mongodb 67 | * 260: commented 68 | * 253: needs rebased 69 | * 251: needs rebase 70 | * 284: commented (it probably needs lots of work) 71 | 72 | ### puppet-extlib - wat 73 | * 49: no activity since last time 74 | 75 | ### puppetlabs-splunk 76 | * 15: ticketed in MODULES-3112; needs rebase 77 | 78 | ### puppetlabs-dism 79 | * 40: commented 80 | 81 | ### puppetlabs-rabbitmq 82 | * 423: commented 83 | * 403: Commented. Need more information about the use case. 84 | * 380: closed 85 | 86 | -------------------------------------------------------------------------------- /modules/notes/2015-11-12.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2015-11-12 2 | ## Participants: 3 | * Hunner 4 | * igalic 5 | * mentat 6 | * nibalizer 7 | * bmjen 8 | * asasfu 9 | * karmix 10 | * TPHoney 11 | * rnelson0 12 | * DavidSchmitt 13 | * pabelanger 14 | * HelenCampbell 15 | 16 | 17 | ## Discussion 18 | * pl-apache passenger is not currently working due to upstream packaging issues. We are waiting for upstream packaging fixes as fixing in the module will cause more issues down the line. Further to this, it was noted that when we drop 2.2 support, it would be a good time to remove passenger and other problem modules. 19 | * pl-apache: adding custom content in an apache vhost conf with concat::fragment is hard, so we should make an apache::vhost::custom_fragment that allows passing a vhost title and order parameter and wraps a concat::fragment resource to put the content in the desired location in the apache vhost .conf file. 20 | 21 | 22 | ## Reviews 23 | ### puppetlabs-concat 24 | * 368: [ACTION] bmjen to comment "show_diff on fragments should be hard-coded to false" 25 | 26 | 27 | ### puppetlabs-apache 28 | * 1259: [ACTION] This ability can be provided by apache::custom_config, though this is not obvious so pabelanger is going to submit a PR to make an apache::vhost::custom_content that simply wraps the custom_config define (and updates the confdir parameter to point to the expected location for a vhost, if needed) 29 | 30 | 31 | ### puppetlabs-mysql 32 | * 763: [ACTION] Hunner to rebase and resubmit 33 | * 773, 774: everything was merged meanwhile 34 | 35 | 36 | ### puppetlabs-tomcat 37 | * 108: was closed and now the work has been moved to 109 we don't understand tomcat enough to review this. [ACTION] bmjen to educate us on how to tomcat 38 | * 109: bmjen is still looking into this along with karmix, the PR needs split into smaller PRs or a single PR with commits per functional area 39 | 40 | 41 | ### puppetlabs-postgresql 42 | * 705: merged, jira ticket closed modules-2810 43 | 44 | 45 | ### puppetlabs-java 46 | * 117: more discussion on the changes 47 | 48 | 49 | ## Past Reviews 50 | ### puppetlabs-vcsrepo 51 | * 270: commented 52 | 53 | 54 | ### puppetlabs-apache 55 | * 1201: commented (check next meeting) 56 | 57 | 58 | ### puppetlabs-mongodb 59 | * 194: [ACTION] mentat to run acceptance tests and merge if pass 60 | 61 | 62 | ### puppet-corosync 63 | * 153: passed to igalic 64 | 65 | 66 | ### puppetlabs-lvm 67 | * 126: commented 68 | * 122: commented 69 | -------------------------------------------------------------------------------- /modules/notes/2016-10-20.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-10-20 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * eputnam 8 | * fraq 9 | 10 | ## Discussion 11 | * Kittens! http://www.bloodrizer.ru/games/kittens/ stragety! 12 | * We should run through the past reviews to look for anything that is closed or merged to delete... DONE 13 | * VP governance discussion: 14 | * lazy consensus is important and should apply widely. The "mailing list" paragraph enumerates a list of like-things to which lazy consensus should apply, one of which is "policy shift" ie governance changes (See issue #83) 15 | * the charter needs the email list linked 16 | * the charter needs number-per-paragraph (rules) similar to http://legacy.earlham.edu/~peters/writing/nomic.htm#initial%20set 17 | * for context, https://www.urbit.org/posts/constitution/ is another governance document that we may be able to take verbiage from 18 | * LC does not distinguish between PMC and non-PMC, so votes are equal: "The PMC has final say over who can become a committer and will use lazy consensus for approval." 19 | * VP has a kanban! https://github.com/voxpupuli/plumbing/projects/1 20 | 21 | ## Reviews 22 | ### puppetlabs-accounts 23 | * 51: pinged 24 | 25 | ## Past Reviews 26 | ### puppetlabs-aws 27 | * 340: Filed QENG-4362 to be able to handle this 28 | 29 | ### puppetlabs-mysql 30 | * 890: Needs more investigation. 31 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 32 | 33 | ### puppetlabs-firewall 34 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 35 | 36 | ### puppetlabs-apt 37 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 38 | 39 | ### puppetlabs-rabbitmq 40 | * 497: see discussion 41 | * 493: see discussion; needs review 42 | 43 | ### puppetlabs-lvm 44 | * 158: skipping for now; will take too long 45 | * 153: commented 46 | 47 | ### puppetlabs-postgresql 48 | * 775: See discussion on 2016-07-28 49 | * 764: commented - test failures need to be looked at 50 | 51 | ### puppetlabs-apache 52 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 53 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 54 | * 1498: commented 55 | 56 | 57 | -------------------------------------------------------------------------------- /modules/notes/2018-01-18.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2018-01-18 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | Go to https://github.com/voxpupuli/community-triage/tree/master/modules/notes for notes from previous meetings. 5 | 6 | 7 | ## Participants: 8 | * Hunner 9 | * eputnam 10 | * WillMeek 11 | 12 | ### Discussion: 13 | * VoxPupuli PMC elections have ended! See results: https://github.com/voxpupuli/plumbing/blob/master/share/elections/2018-01.md#results 14 | 15 | 16 | ## Reviews: 17 | ### puppetlabs-netapp 18 | * 76: merged 19 | * 102: merged 20 | * 103: commented 21 | * 117: merged 22 | * 118: merged 23 | * 119: merged 24 | * 120: merged 25 | * 121: merged 26 | 27 | ## Past Reviews: 28 | ### puppetlabs-mysql 29 | * 1043: 5.2.0 release - merged 30 | 31 | ### puppetlabs-java_ks 32 | * 212: commented 33 | 34 | ### puppet-rabbitmq 35 | * 676: 36 | 37 | ### puppetlabs-postgresql 38 | * 917: commented (yuge!) 39 | 40 | ### puppetlabs-tomcat 41 | * 260: review in progress 42 | If it's possible can you review the puppet-archive dependancy? At the moment it's >1.0.0 <2.0.0. Last usable version is 1.3.0 and there's a version 2.2.0 out from november. 43 | 44 | ### puppetlabs-rsync 45 | * 78: closed - inactivity 46 | * 80: commented 47 | * 81: opened #110 to close 48 | 49 | ### puppetlabs-apache 50 | * 1659: again... looking good, comments from ekohl for a few helpful changes. 51 | 52 | 53 | 54 | ### puppet-rabbitmq 55 | - 529: commented 56 | - 556: commented 57 | - 547: commented, merged by accident and reverted. Needs to be resubmitted. 58 | - 598: merged 59 | 60 | 61 | 62 | ### voxpupuli-yum 63 | * 40: commented 64 | 65 | ### puppet-nginx 66 | * #862: [discuss] 67 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 68 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 69 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 70 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 71 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 72 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 73 | * #902: use_default_location 74 | 75 | 76 | -------------------------------------------------------------------------------- /modules/notes/2016-09-29.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-09-29 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | *bmjen 7 | *HelenCampbell 8 | *tphoney 9 | *wilson 10 | *squarebracket 11 | *rnelson0 12 | *eputnam 13 | *hail9000 14 | *Hunner 15 | 16 | ## Reviews 17 | ### puppetlabs-vcsrepo 18 | * 297: merged 19 | * 298: merged 20 | * 274: will re-review after reboo 21 | 22 | ### puppetlabs-mysql 23 | * 891: merged 24 | * 890: Needs more investigation. 25 | * 889: merged 26 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 27 | 28 | 29 | ## Past Reviews 30 | ### puppetlabs-vcsrepo 31 | * 274: This depends on source being a property, but is +1 otherwise! 32 | 33 | ### puppetlabs-ntp 34 | * 338: irc request: https://github.com/puppetlabs/puppetlabs-ntp/pull/338 closed 35 | * is this 80/20 rule? Is this useful to users generally? "Who has missed this in the last 10 years?" 36 | 37 | ### puppetlabs-firewall 38 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 39 | 40 | ### puppetlabs-apt 41 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 42 | 43 | ### puppetlabs-rabbitmq 44 | * 498: reckicked failing CI & commented 45 | * 497: see discussion 46 | * 493: see discussion; needs review 47 | 48 | ### puppetlabs-aws 49 | * 334: to discuss after the others are reviewed 50 | * 340: Filed QENG-4362 to be able to handle this 51 | 52 | ### puppetlabs-lvm 53 | * 158: skipping for now; will take too long 54 | * 154: commented 55 | * 153: commented 56 | 57 | ### puppetlabs-accounts 58 | * 51: commented. Needs docs. Needs tests 59 | 60 | ### puppetlabs-postgresql 61 | * 775: See discussion on 2016-07-28 62 | * 762: commented. Needs to validate passed in params 63 | * 756: reviewed, 762 looks superior 64 | * 764: commented - test failures need to be looked at 65 | 66 | ### puppetlabs-apache 67 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 68 | * 1467: merge? 69 | * 1474: tests fail, dropped in favour of 1486 + 1487 70 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 71 | * 1490: logic needs rework 72 | * 1491: moved to 1494 73 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 74 | * 1513: commented 75 | * 1497: commented 76 | * 1498: commented 77 | * 1499: commented 78 | -------------------------------------------------------------------------------- /modules/notes/2018-01-25.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2018-01-25 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | Go to https://github.com/voxpupuli/community-triage/tree/master/modules/notes for notes from previous meetings. 5 | 6 | 7 | ## Participants: 8 | * Hunner 9 | * eputnam 10 | 11 | ### Discussion: 12 | * https://github.com/Flipez/faster-than-bastelfreak 13 | * https://eputnam.github.io doesn't work in firefox, the One True Browser 14 | * Today we triaged nothing; just goofed off. 15 | 16 | 17 | ## Reviews: 18 | ### puppetlabs-concat 19 | * https://github.com/puppetlabs/puppetlabs-concat/pull/485/files merged 20 | 21 | ### puppetlabs-mysql 22 | * https://github.com/puppetlabs/puppetlabs-mysql/pull/1019 commented 23 | 24 | ### puppetlabs-apache 25 | * https://github.com/puppetlabs/puppetlabs-apache/pull/1717 closed 26 | 27 | ## Past Reviews: 28 | ### puppetlabs-mysql 29 | * 1043: 5.2.0 release - merged 30 | 31 | ### puppetlabs-java_ks 32 | * 212: commented 33 | 34 | ### puppet-rabbitmq 35 | * 676: 36 | 37 | ### puppetlabs-postgresql 38 | * 917: commented (yuge!) 39 | 40 | ### puppetlabs-tomcat 41 | * 260: review in progress 42 | If it's possible can you review the puppet-archive dependancy? At the moment it's >1.0.0 <2.0.0. Last usable version is 1.3.0 and there's a version 2.2.0 out from november. 43 | 44 | ### puppetlabs-rsync 45 | * 78: closed - inactivity 46 | * 80: commented 47 | * 81: opened #110 to close 48 | 49 | ### puppetlabs-apache 50 | * 1659: again... looking good, comments from ekohl for a few helpful changes. 51 | 52 | 53 | 54 | ### puppet-rabbitmq 55 | - 529: commented 56 | - 556: commented 57 | - 547: commented, merged by accident and reverted. Needs to be resubmitted. 58 | - 598: merged 59 | 60 | 61 | 62 | ### voxpupuli-yum 63 | * 40: commented 64 | 65 | ### puppet-nginx 66 | * #862: [discuss] 67 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 68 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 69 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 70 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 71 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 72 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 73 | * #902: use_default_location 74 | 75 | 76 | -------------------------------------------------------------------------------- /modules/notes/2016-09-15.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-09-15 2 | 3 | ## Participants: 4 | * Hunner 5 | * eputnam 6 | * Hail9000 7 | * bmjen 8 | * dev_el_ops 9 | * tphoney 10 | * "Wilson" (QA at puppet) 11 | * "Sean" (QA at puppet) 12 | * squarebracket 13 | * Daloran 14 | * roidelapluie 15 | 16 | ## Discussion 17 | * PMC applications are open until Sep 17! https://github.com/voxpupuli/plumbing/blob/master/share/elections/2016-01.md#dates 18 | * Puppet has moved https://github.com/puppetlabs/puppetlabs-mrepo/ to VP 19 | 20 | ## Reviews 21 | ### puppetlabs-stdlib 22 | * 644: merged 23 | * 648: merged 24 | * 653: merged 25 | 26 | ### puppetlabs-vcsrepo 27 | * 274: This depends on source being a property, but is +1 otherwise! 28 | 29 | ### puppetlabs-aws 30 | * 334: merged 31 | * 361: merged 32 | 33 | ## Past Reviews 34 | ### puppetlabs-ntp 35 | * 338: irc request: https://github.com/puppetlabs/puppetlabs-ntp/pull/338 closed 36 | * is this 80/20 rule? Is this useful to users generally? "Who has missed this in the last 10 years?" 37 | 38 | ### puppetlabs-firewall 39 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 40 | 41 | ### puppetlabs-apt 42 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 43 | 44 | ### puppetlabs-rabbitmq 45 | * 498: reckicked failing CI & commented 46 | * 497: see discussion 47 | * 493: see discussion; needs review 48 | 49 | ### puppetlabs-aws 50 | * 334: to discuss after the others are reviewed 51 | * 340: Filed QENG-4362 to be able to handle this 52 | 53 | ### puppetlabs-lvm 54 | * 158: skipping for now; will take too long 55 | * 154: commented 56 | * 153: commented 57 | 58 | ### puppetlabs-accounts 59 | * 51: commented. Needs docs. Needs tests 60 | 61 | ### puppetlabs-postgresql 62 | * 775: See discussion on 2016-07-28 63 | * 762: commented. Needs to validate passed in params 64 | * 756: reviewed, 762 looks superior 65 | * 764: commented - test failures need to be looked at 66 | 67 | ### puppetlabs-apache 68 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 69 | * 1467: merge? 70 | * 1474: tests fail, dropped in favour of 1486 + 1487 71 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 72 | * 1490: logic needs rework 73 | * 1491: moved to 1494 74 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 75 | * 1513: commented 76 | * 1497: commented 77 | * 1498: commented 78 | * 1499: commented 79 | 80 | 81 | -------------------------------------------------------------------------------- /modules/notes/2016-08-11.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-08-11 2 | 3 | ## Participants: 4 | * Hunner 5 | * rnelson0 6 | * binford 7 | * bastelfreak 8 | * dev_el_ops 9 | * tphoney 10 | * fraq 11 | * HelenCampbell 12 | * bmjen 13 | 14 | ## Discussion 15 | * Vox Pupuli governance: 16 | https://github.com/voxpupuli/plumbing/issues/25 for discussion and https://github.com/voxpupuli/plumbing/issues/45 for the document. 17 | * What about objections that arrive after the 72 hour window? 18 | * What is the threshold for merging sooner than the 72 hour waiting period? 19 | * Can we prevent people from dog-piling on a ticket or PR to get it merged? Do we need to? 20 | * Do we have contributor removal? Do we need it? 21 | * Do we have pre-existing ideas about who will fill the PMC? 22 | * What to do with objections in lazy consensus? (rnelson0 to comment) 23 | * rnelson0 suggested that handling PRs should be a section, since it's hinted at in two sections but never explicitly defined. 24 | * what is quorum for PMC elections? 25 | * Who will run the initial condorcet for PMC election if there is no elections officer? 26 | * Should the doc designate an initial elections officer as the "pmc bootloader"? Given the spirit of the elections officer position existing to minimize difficulties, this should be done. 27 | * How long does a condorcet run? 28 | * suggestion to use debian’s DPL or tech-ctte election rules. 29 | * suggestion to nominate multi-person election committee for first election. 30 | * suggestion to post PR for review on IRC&slack in topics and over several weeks, to reach all community members. Is there a mailing list? 31 | * how are changes to the governance document governed? Total control by PMC? Passing through the control of the elections officer? Lazy consensus? 32 | 33 | * y u no release mysql? 5.7.0 made backwards-incompatible breaking changes and Puppet needs to get it green in CI before release, but is slated for release asap after that. 34 | 35 | ## Reviews 36 | 37 | 38 | ## Past Reviews 39 | ### puppetlabs-aws 40 | * 334: to discuss after the others are reviewed 41 | * 330: david to comment and close and submit another bump pr for awssdk 42 | * 328: needs work 43 | * 324: commented 44 | 45 | ### puppetlabs-accounts 46 | * 51: commented. Needs docs. Needs tests 47 | 48 | ### puppetlabs-postgresql 49 | * 775: See discussion on 2016-07-28 50 | * 762: commented. Needs to validate passed in params 51 | * 756: reviewed, 762 looks superior 52 | * 764: commented - test failures need to be looked at 53 | 54 | ### puppetlabs-apache 55 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 56 | * 1467: merge? 57 | * 1474: tests fail, dropped in favour of 1486 + 1487 58 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 59 | * 1490: logic needs rework 60 | * 1491: moved to 1494 61 | 62 | -------------------------------------------------------------------------------- /modules/notes/2016-10-06.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-10-06 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | *bmjen 7 | *HelenCampbell 8 | *hail9000 9 | *binford2k 10 | *nibz 11 | *eputnam 12 | *tphoney 13 | 14 | ## Discussion 15 | * Release of rabbitmq requested - Ticket opened. 16 | 17 | ## Reviews 18 | 19 | ### puppetlabs-apache 20 | * 1497: merged 21 | * 1498: commented. tests fail. 22 | * 1499: looks good. waiting for tests to re-run. 23 | * 1508: merged 24 | * 1509: merged 25 | * 1510: merged 26 | * 1512: will run unit tests locally. Will debug acceptance test failure offline. 27 | * 1513: will rerun and rebase 28 | * 1514: merged 29 | * 1532: merged 30 | 31 | ## Past Reviews 32 | ### puppetlabs-vcsrepo 33 | * 297: merged 34 | * 298: merged 35 | * 274: will re-review after reboo 36 | 37 | ### puppetlabs-mysql 38 | * 891: merged 39 | * 890: Needs more investigation. 40 | * 889: merged 41 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 42 | 43 | ### puppetlabs-ntp 44 | * 338: irc request: https://github.com/puppetlabs/puppetlabs-ntp/pull/338 closed 45 | * is this 80/20 rule? Is this useful to users generally? "Who has missed this in the last 10 years?" 46 | 47 | ### puppetlabs-firewall 48 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 49 | 50 | ### puppetlabs-apt 51 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 52 | 53 | ### puppetlabs-rabbitmq 54 | * 498: reckicked failing CI & commented 55 | * 497: see discussion 56 | * 493: see discussion; needs review 57 | 58 | ### puppetlabs-aws 59 | * 334: to discuss after the others are reviewed 60 | * 340: Filed QENG-4362 to be able to handle this 61 | 62 | ### puppetlabs-lvm 63 | * 158: skipping for now; will take too long 64 | * 154: commented 65 | * 153: commented 66 | 67 | ### puppetlabs-accounts 68 | * 51: commented. Needs docs. Needs tests 69 | 70 | ### puppetlabs-postgresql 71 | * 775: See discussion on 2016-07-28 72 | * 762: commented. Needs to validate passed in params 73 | * 756: reviewed, 762 looks superior 74 | * 764: commented - test failures need to be looked at 75 | 76 | ### puppetlabs-apache 77 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 78 | * 1467: merge? 79 | * 1474: tests fail, dropped in favour of 1486 + 1487 80 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 81 | * 1490: logic needs rework 82 | * 1491: moved to 1494 83 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 84 | * 1513: commented 85 | * 1497: commented 86 | * 1498: commented 87 | * 1499: commented 88 | -------------------------------------------------------------------------------- /modules/notes/2016-09-08.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-09-08 2 | 3 | ## Participants: 4 | * Hunner 5 | * eputnam 6 | * Hail9000 7 | * bmjen 8 | * dev_el_ops 9 | * tphoney 10 | * "rob" 11 | 12 | ## Discussion 13 | * PMC applications are open until Sep 17! https://github.com/voxpupuli/plumbing/blob/master/share/elections/2016-01.md#dates 14 | * Puppet to give https://github.com/puppetlabs/puppetlabs-mrepo/ to VP? (asking internal stakeholders) 15 | * in general, who should be contacted for migrating modules at Puppet? TSE? PSE? RE? Product? Ops? 16 | * yes, within reason, but think about the value difference of VP vs Puppet and time spent 17 | * If you have good canned responses, add them here! https://github.com/voxpupuli/plumbing/tree/master/share/canned_responses 18 | * How does windows team do community interfacing? 19 | * Don't get too many PRs from community, so less intensive 20 | * Modules in the wild: ACL, registry, reboot, powershell, chocolatey, dism, dsc, sqlserver, wsus 21 | 22 | ## Reviews 23 | ### puppetlabs-ntp 24 | * 338: irc request: https://github.com/puppetlabs/puppetlabs-ntp/pull/338 closed 25 | * is this 80/20 rule? Is this useful to users generally? "Who has missed this in the last 10 years?" 26 | 27 | ### puppetlabs-firewall 28 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 29 | 30 | ### puppetlabs-apt 31 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 32 | 33 | ## Past Reviews 34 | ### puppetlabs-rabbitmq 35 | * 498: reckicked failing CI & commented 36 | * 497: see discussion 37 | * 493: see discussion; needs review 38 | 39 | ### puppetlabs-aws 40 | * 334: to discuss after the others are reviewed 41 | * 340: Filed QENG-4362 to be able to handle this 42 | 43 | ### puppetlabs-lvm 44 | * 158: skipping for now; will take too long 45 | * 154: commented 46 | * 153: commented 47 | 48 | ### puppetlabs-accounts 49 | * 51: commented. Needs docs. Needs tests 50 | 51 | ### puppetlabs-postgresql 52 | * 775: See discussion on 2016-07-28 53 | * 762: commented. Needs to validate passed in params 54 | * 756: reviewed, 762 looks superior 55 | * 764: commented - test failures need to be looked at 56 | 57 | ### puppetlabs-apache 58 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 59 | * 1467: merge? 60 | * 1474: tests fail, dropped in favour of 1486 + 1487 61 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 62 | * 1490: logic needs rework 63 | * 1491: moved to 1494 64 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 65 | * 1513: commented 66 | * 1497: commented 67 | * 1498: commented 68 | * 1499: commented 69 | 70 | 71 | -------------------------------------------------------------------------------- /core/notes/2014-12-17.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2014-12-17.md 2 | 3 | Recording: https://www.youtube.com/watch?v=CgJt22l9Pg8 4 | 5 | ### Attending 6 | 7 | * **Josh Cooper (joshcooper)** 8 | * **Michael Smith (MikaelSmith)** 9 | * **Geoffrey Gardella (ggardella)** 10 | 11 | ### Summary 12 | 13 | During the previous week, we [closed 9 PRs](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+closed%3A%222014-12-03+..+2014-12-17%22++-label%3APL), of which [6 were merged](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+merged%3A%222014-12-03+..+2014-12-17%22+-label%3APL). 14 | 15 | At the start of the triage: 16 | 17 | * Puppet 18 | - [14 new](https://github.com/puppetlabs/puppet/pulls?q=is%3Apr+created%3A%222014-12-03+..+2014-12-17%22+-label%3APL) from community 19 | - 52 currently open, 23 from community 20 | * Facter 21 | - [6 new](https://github.com/puppetlabs/facter/pulls?q=is%3Apr+created%3A%222014-12-03+..+2014-12-17%22+-label%3APL) from community 22 | - 7 currently open, 6 from community 23 | * Hiera 24 | - [3 new](https://github.com/puppetlabs/hiera/pulls?q=is%3Apr+created%3A%222014-12-03+..+2014-12-17%22+-label%3APL) from community 25 | - 2 currently open, 1 from community 26 | 27 | View each individual pull request for detailed notes. 28 | 29 | ## New 30 | 31 | The following tickets were triaged: 32 | 33 | ### Puppet 34 | * doc (PR 3423) 35 | - Waiting on contributor. 36 | * PUP-3750 37 | - Added comments, waiting on contributor. 38 | - **Action: Michael to do more detailed code review.** 39 | * PUP-3024 40 | - **Action: Michael respond to questions about detecting DeltaRPM support; suggest change to use provider features?** 41 | 42 | ## Held Over 43 | 44 | ### Puppet 45 | * PUP-1072 46 | - **Action: Josh to review and comment on.** 47 | * PUP-3706 48 | - Waiting on contributor for fixes. 49 | - **Action: Michael to review and comment on approach.** 50 | * PUP-3094: 51 | - Waiting on contributor code update. 52 | * PUP-3481: 53 | - Contributor to review Kylo commit. 54 | * PUP-3127 55 | - Pinged contributor. 56 | - **Action: Michael check on selecting Solaris 10 in Puppet, and using ruby-ldap for ldapclient query.** 57 | * PUP-2916 58 | - Pinged contributor. 59 | * PUP-3697, PUP-3698 60 | - Waiting on contributor. 61 | * PUP-1103 62 | - Waiting on contributor. 63 | * PUP-3341 64 | - Waiting on contributor. 65 | * PUP-3168 66 | - **Action: Michael to track down Anderson Mills for comment.** 67 | 68 | ## Closed 69 | 70 | ### Puppet 71 | * GH-3355 72 | - Merged. 73 | * PUP-3549: 74 | - Merged. 75 | * PUP-3605 76 | - Merged. 77 | * PUP-1270 78 | - Merged. 79 | 80 | ## Actions 81 | 82 | ### Michael Smith 83 | * Review 84 | - PUP-3750 85 | - PUP-3024 86 | - PUP-3706 87 | - PUP-3127 88 | 89 | * Escalate 90 | - PUP-3168 91 | 92 | ### Josh Cooper 93 | * Review 94 | - PUP-1072 95 | 96 | -------------------------------------------------------------------------------- /core/notes/2014-12-03.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2014-12-03.md 2 | 3 | Recording: https://www.youtube.com/watch?v=CqCX7q3J09Y 4 | 5 | ### Attending 6 | 7 | * **Felix Frank (ffrank)** 8 | * **Geoffrey Gardella (ggardella)** 9 | * **Josh Cooper (joshcooper)** 10 | * **Peter Huene (peterhuene)** 11 | * **Ryan Senior (senior)** 12 | 13 | ### Summary 14 | 15 | During the previous week, we [closed 7 PRs](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+closed%3A%222014-11-26+..+2014-12-03%22++-label%3APL), of which [6 were merged](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+merged%3A%222014-11-26+..+2014-12-03%22+-label%3APL). 16 | 17 | At the start of the triage: 18 | 19 | * Puppet 20 | - [4 new](https://github.com/puppetlabs/puppet/pulls?q=is%3Apr+created%3A%222014-11-26+..+2014-12-03%22+-label%3APL) from community 21 | - 55 currently open, 23 from community 22 | * Facter 23 | - [0 new](https://github.com/puppetlabs/facter/pulls?q=is%3Apr+created%3A%222014-11-26+..+2014-12-03%22+-label%3APL) from community 24 | - 4 currently open, 2 from community 25 | * Hiera 26 | - [0 new](https://github.com/puppetlabs/hiera/pulls?q=is%3Apr+created%3A%222014-11-26+..+2014-12-03%22+-label%3APL) from community 27 | - 0 currently open, 0 from community 28 | 29 | View each individual pull request for detailed notes. 30 | 31 | ## New 32 | 33 | The following tickets were triaged: 34 | 35 | ### Puppet 36 | 37 | * PUP-1072 38 | - **Action: Josh to review and comment on.** 39 | * GH-3355 40 | - Waiting on contributor for followup. 41 | * PUP-3706 42 | - Waiting on contributor for fixes. 43 | * GH-3347 44 | - Already merged. 45 | 46 | ## Held Over 47 | 48 | ### Puppet 49 | * PUP-3549: 50 | - **Action: Peter to merge.** 51 | * PUP-3094: 52 | - Pinged contributor. 53 | * PUP-3481: 54 | - Pinged contributor. 55 | * PUP-3127 56 | - Pinged contributor. **Action: Geoffrey Gardella to review for Solaris 10 and provide feedback.** 57 | * PUP-2916 58 | - Pinged contributor. 59 | * PUP-3697, PUP-3698 60 | - Waiting on contributor. 61 | * PUP-1270 62 | - **Action: Peter to merge.** 63 | * PUP-1103 64 | - Waiting on contributor 65 | * PUP-3605 66 | - **Action: Peter to merge** 67 | * PUP-3706 68 | - Waiting on contributor 69 | * PUP-3341 70 | - Pinging henrik/jpartlow for review. 71 | * PUP-3168 72 | - Pinged anderson for feedback. 73 | 74 | ## Closed 75 | 76 | ### Puppet 77 | 78 | * PUP-1293 79 | - Merged. 80 | * PUP-1362, PUP-1775 81 | - Merged. 82 | * PUP-3695 83 | - Merged. 84 | * PUP-3700 85 | - Merged. 86 | * GH-3347 87 | - Merged. 88 | 89 | ### Facter 90 | 91 | * FACT-697 92 | - Merged. 93 | 94 | ## Actions 95 | 96 | ### Peter Huene 97 | * Merge 98 | - PUP-3549 99 | - PUP-1270 100 | - PUP-3605 101 | * Review 102 | - PUP-1085 103 | * Escalate 104 | - PUP-1072 105 | 106 | ### Geoffrey Gardella 107 | * Review 108 | - PUP-3127 109 | -------------------------------------------------------------------------------- /modules/notes/2016-10-13.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-10-13 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * Sean 8 | * eputnam 9 | * igalic 10 | * adams 11 | * will 12 | * bmjen 13 | 14 | ## Discussion 15 | * Should VP start its own triage session to handle governance changes? (or just pmc@voxpupuli.org mail discussion) 16 | * Differences or similarities between projects and companies. VP is a non-profit, but the charter of the Modules team ("Build and maintain high value modules that expand the reach of Puppet.") promotes engagement with VP directly 17 | * VP governance wants to avoid anything meritocracy-oriented, because it devolves into non-viable forms of govn't. 18 | * When litugical songs have call and answer, the call is called a "versicle" and is symbolized by ℣ (spawned by igalic's ☭ pasting) 19 | * Fun tricks with self.instances and catalogs in aws #371 20 | 21 | ## Reviews 22 | ### puppetlabs-aws 23 | * 371: reviewed 24 | * 340: Filed QENG-4362 to be able to handle this 25 | 26 | ## Past Reviews 27 | ### puppetlabs-vcsrepo 28 | * 274: will re-review after reboot 29 | 30 | ### puppetlabs-mysql 31 | * 890: Needs more investigation. 32 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 33 | 34 | ### puppetlabs-ntp 35 | * 338: irc request: https://github.com/puppetlabs/puppetlabs-ntp/pull/338 closed 36 | * is this 80/20 rule? Is this useful to users generally? "Who has missed this in the last 10 years?" 37 | 38 | ### puppetlabs-firewall 39 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 40 | 41 | ### puppetlabs-apt 42 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 43 | 44 | ### puppetlabs-rabbitmq 45 | * 498: reckicked failing CI & commented 46 | * 497: see discussion 47 | * 493: see discussion; needs review 48 | 49 | ### puppetlabs-lvm 50 | * 158: skipping for now; will take too long 51 | * 154: commented 52 | * 153: commented 53 | 54 | ### puppetlabs-accounts 55 | * 51: commented. Needs docs. Needs tests 56 | 57 | ### puppetlabs-postgresql 58 | * 775: See discussion on 2016-07-28 59 | * 762: commented. Needs to validate passed in params 60 | * 756: reviewed, 762 looks superior 61 | * 764: commented - test failures need to be looked at 62 | 63 | ### puppetlabs-apache 64 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 65 | * 1467: merge? 66 | * 1474: tests fail, dropped in favour of 1486 + 1487 67 | * 1486: same changes as 1487 and conflicts with 1474. David to rebase 1486 and 1487 68 | * 1490: logic needs rework 69 | * 1491: moved to 1494 70 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 71 | * 1513: commented 72 | * 1497: commented 73 | * 1498: commented 74 | * 1499: commented 75 | * 1498: commented. tests fail. 76 | * 1499: looks good. waiting for tests to re-run. 77 | * 1512: will run unit tests locally. Will debug acceptance test failure offline. 78 | * 1513: will rerun and rebase 79 | 80 | -------------------------------------------------------------------------------- /core/notes/2015-01-14.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2015-01-14.md 2 | 3 | Recording: http://youtu.be/YUHU3F7xvnM 4 | 5 | ### Attending 6 | 7 | * **Michael Smith (MikaelSmith)** 8 | * **Preben Ingvaldsen (fpringvaldsen)** 9 | * **Matthaus Owens (haus)** 10 | * **Josh Cooper (joshcooper)** 11 | * **Peter Huene (peterhuene)** 12 | * **Felix Frank (ffrank)** 13 | * **Kylo Ginsberg (kylog)** 14 | * **Will Hopper (whopper)** 15 | * **Anderson Mills (andersonmills)** 16 | 17 | ### Summary 18 | 19 | During the previous week, we [closed 12 PRs](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+closed%3A%222014-12-17+..+2015-01-14%22++-label%3APL), of which [8 were merged](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+merged%3A%222014-12-17+..+2015-01-14%22+-label%3APL). 20 | 21 | At the start of the triage: 22 | 23 | * Puppet 24 | - [15 new](https://github.com/puppetlabs/puppet/pulls?q=is%3Apr+created%3A%222014-12-17+..+2015-01-14%22+-label%3APL) from community 25 | - 49 currently open, 22 from community 26 | * Facter 27 | - [4 new](https://github.com/puppetlabs/facter/pulls?q=is%3Apr+created%3A%222014-12-17+..+2015-01-14%22+-label%3APL) from community 28 | - 5 currently open, 4 from community 29 | * Hiera 30 | - [1 new](https://github.com/puppetlabs/hiera/pulls?q=is%3Apr+created%3A%222014-12-17+..+2015-01-14%22+-label%3APL) from community 31 | - 3 currently open, 1 from community 32 | 33 | View each individual pull request for detailed notes. 34 | 35 | ## New 36 | 37 | The following tickets were triaged: 38 | 39 | ### Puppet 40 | * PUP-3829 41 | - Provided feedback to contributor, added to discussion on appropriate pip exe for each platform. 42 | * PUP-3082 43 | - Thumbs up from Anderson. 44 | - **Action: Anderson or Michael to merge.** 45 | * PUP-3011, PUP-3012, PUP-3014 46 | - **Action: Anderson and Eric T working on streamlining these tests.** 47 | 48 | ### Facter 49 | * FACT-775 50 | - Closed to target at Facter 3. Discussion will continue on puppet-dev. 51 | 52 | ## Held Over 53 | 54 | ### Puppet 55 | * PUP-1072 56 | - **Action: Preben and server team to review.** 57 | - Discussed some feedback with Felix. 58 | * PUP-3706 59 | - Waiting on contributor for fixes. 60 | - **Action: Michael to review and comment on approach.** 61 | * PUP-3094: 62 | - **Action: Haus and RelEng to review.** 63 | * PUP-3481: 64 | - **Action: Haus and RelEng to review.** 65 | * PUP-3127 66 | - Pinged contributor. 67 | - **Action: Michael summarize feedback.** 68 | * PUP-2916 69 | - Assigned to RelEng. 70 | * PUP-1103 71 | - Pinged contributor. 72 | * PUP-3341 73 | - Waiting on contributor. 74 | * PUP-3168 75 | - Waiting on contributor. 76 | 77 | ## Closed 78 | 79 | ### Puppet 80 | * doc (PR 3423) 81 | - Closed for new PR 3426. 82 | * doc (PR 3426) 83 | - Merged by Kylo. 84 | * PUP-3750 85 | - Closed and reviewed. 86 | * PUP-3024 87 | - Closed and reviewed. 88 | * PUP-3697, PUP-3698 89 | - Closed and reviewed. 90 | 91 | ## Actions 92 | 93 | ### Michael Smith 94 | * Review 95 | - PUP-3706 96 | - PUP-3127 97 | 98 | ### Preben Ingvaldsen 99 | * Review 100 | - PUP-1072 101 | 102 | ### Matthaus Owens 103 | * Review 104 | - PUP-3094 105 | 106 | -------------------------------------------------------------------------------- /core/notes/2014-11-26.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2014-11-26.md 2 | 3 | Recording: https://www.youtube.com/watch?v=nnsFsTK2LhE 4 | 5 | ### Attending 6 | 7 | * **Eric Thompson (er0ck)** 8 | * **Felix Frank (ffrank)** 9 | * **Josh Cooper (joshcooper)** 10 | * **Geoffrey Gardella (ggardella)** 11 | * **Peter Huene (peterhuene)** 12 | * **Will Hopper (whopper)** 13 | 14 | ### Summary 15 | 16 | During the previous week, we [closed 4 PRs](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+closed%3A%222014-11-19+..+2014-11-25%22+), of which [2 were merged](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+merged%3A%222014-11-19+..+2014-11-25%22+). 17 | 18 | At the start of the triage: 19 | 20 | * Puppet 21 | - [7 new](https://github.com/puppetlabs/puppet/pulls?q=is%3Apr+created%3A%222014-11-19+..+2014-11-25%22+-label%3APL) from community 22 | - 51 currently open, 24 from community 23 | * Facter 24 | - [1 new](https://github.com/puppetlabs/facter/pulls?q=is%3Apr+created%3A%222014-11-19+..+2014-11-25%22+-label%3APL) from community 25 | - 5 currently open, 3 from community 26 | * Hiera 27 | - [0 new](https://github.com/puppetlabs/hiera/pulls?q=is%3Apr+created%3A%222014-11-19+..+2014-11-25%22+-label%3APL) from community 28 | - 0 currently open, 0 from community 29 | 30 | View each individual pull request for detailed notes. 31 | 32 | ## New 33 | 34 | The following tickets were triaged: 35 | 36 | ### Puppet 37 | * PUP-3706 38 | - Pinged contributor for change. 39 | * PUP-1103 40 | - Pinged contributor for specs. 41 | * PUP-3700 42 | - **Action: Peter to merge**. 43 | * PUP-3697-3699 44 | - Pinged contributor for change. 45 | * PUP-3695 46 | - **Action: Peter to merge after PR-3335**. 47 | * PUP-1362 48 | - **Action: Josh to merge**. 49 | * PUP-3341 50 | - Contributor (Felix) in hangout; will change. 51 | 52 | ### Facter 53 | * FACT-755 54 | - Pinged contributor for changes and specs. 55 | * FACT-697 56 | - **Action: Peter to merge**. 57 | * FACT-703 58 | - Pinged contributor about spec failures. 59 | 60 | ## Held Over 61 | 62 | ### Puppet 63 | * PUP-1253 64 | - Pinged contributor for changes. 65 | * PUP-1270 66 | - Pinged contributor for specs. 67 | * PUP-3319 68 | - Blocked on PUP-3379. 69 | * PUP-2901 70 | - Pinged @andersonmills. 71 | * PUP-3013 72 | - Pinged @andersonmills. 73 | * PUP-3082 74 | - Pinged @andersonmills. Will escalate with Kylo. 75 | * PUP-1085 76 | - **Action: Peter to review**. 77 | * PUP-3012 78 | - Pinged @andersonmills. 79 | * PUP-778 80 | - Pinged contributor for changes. 81 | * PUP-1293 (peter to merge) 82 | - **Action: Peter to merge**. 83 | * PUP-3168 84 | - Pinged @andersonmills. 85 | * PUP-3166 86 | - Pinged contributor for changes. 87 | * PUp-2402 88 | - Pinged contributor for changes. 89 | * PUP-3116 90 | - Pinged contributor for changes. 91 | * PUP-3332 92 | - Pinged contributor for feedback. 93 | 94 | ## Closed 95 | 96 | ### Puppet 97 | * PUP-3114 (not merged) 98 | 99 | ## Actions 100 | 101 | ### Peter Huene 102 | * Merge 103 | - PUP-3700 104 | - PUP-3695 105 | - FACT-697 106 | - PUP-1293 107 | * Review 108 | - PUP-1085 109 | * Escalate 110 | - PUP-3082 111 | 112 | ### Josh Cooper 113 | * Merge 114 | - PUP-1362 115 | -------------------------------------------------------------------------------- /modules/notes/2016-11-03.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-11-03 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * EricBanks 8 | * HAIL9000 9 | * dev_el_ops 10 | * HelenCampbell 11 | * wyardley (irc: wby) 12 | * wmcc 13 | * Paula 14 | 15 | ## Discussion 16 | * VP has a kanban! https://github.com/voxpupuli/plumbing/projects/1 17 | * Hunter derped git and published voxpupuli splunk 99.99.99 to the forge. It has been deleted but had some downloads. It was supposed to be puppetlabs-splunk but github has the repos mirrored. 18 | * nginx design for uwsgi_params and fastcgi_params: 19 | * Status quo is to maintain known defaults and allow users to override them. 20 | * the configuration files ARE owned by nginx so they are in scope 21 | * the module installs from many sources; perhaps we should trim it down to only official packaging? https://nginx.org/en/linux_packages.html 22 | * or prefer vendor packages? Needs discussion 23 | * defaults should be provider, and maybe vary by osfamily/operatingsystemmajrelease. Should be easily extendable/overridable by users 24 | * maybe break out the parameter settings into defined types similar to postgresql's 25 | 26 | 27 | ## Future reviews for next time: 28 | ### puppet-nginx 29 | * #938: changes to default package source on Linux, seeking structural input 30 | * #932: vhost => server name change 31 | * #902: use_default_location 32 | 33 | ### puppetlabs-rabbitmq 34 | * #504: maybe just switch to multi namevars but not try to maintain backwards compatibility? 35 | 36 | ## Reviews 37 | ### puppet-nginx 38 | * #862: [discuss] (see above) 39 | * #957: from 789 and 820?: should we rename this param? 40 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 41 | * #950: rework namespace: nginx::config should not inherit, instead it should bring base-class variables into the scope: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp and then document template-used variables: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp#L171-L175 . And tests should not test ::config/install/service directly, but should be applied on the base class. 42 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 43 | 44 | ## Past Reviews 45 | ### puppetlabs-accounts 46 | * 51: pinged 47 | 48 | ### puppetlabs-aws 49 | * 340: Filed QENG-4362 to be able to handle this 50 | 51 | ### puppetlabs-mysql 52 | * 890: Needs more investigation. 53 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 54 | 55 | ### puppetlabs-firewall 56 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 57 | 58 | ### puppetlabs-apt 59 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 60 | 61 | ### puppetlabs-rabbitmq 62 | * 497: see discussion 63 | * 493: see discussion; needs review 64 | 65 | ### puppetlabs-lvm 66 | * 158: skipping for now; will take too long 67 | * 153: commented 68 | 69 | ### puppetlabs-postgresql 70 | * 775: See discussion on 2016-07-28 71 | * 764: commented - test failures need to be looked at 72 | 73 | ### puppetlabs-apache 74 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 75 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 76 | * 1498: commented 77 | 78 | -------------------------------------------------------------------------------- /core/notes/2016-03-08.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2016-03-01 2 | 3 | ### Attending 4 | 5 | ## Overview 6 | 7 | ## Pull Requests 8 | 9 | ### Puppet 10 | 11 | ##### For discussion 12 | 13 | ##### For Review / Needs Work 14 | 15 | ##### Merged / Handed Off 16 | 17 | PUP-5992 MERGED 18 | 19 | ##### Closed 20 | 21 | ##### Waiting for updates 22 | 23 | * [(PUP-6000)](https://tickets.puppetlabs.com/browse/PUP-6000) [Add only unique hooks during initialization (PR #4699)](https://github.com/puppetlabs/puppet/pull/4752) 24 | - Requested more detailed commit message 25 | 26 | * [(PUP-2802)](https://tickets.puppetlabs.com/browse/PUP-2802) [Add slot support for portage package provider (PR #4699)](https://github.com/puppetlabs/puppet/pull/4699) 27 | - Pinged a few people who have had past experience with this issue to see if they can weigh in 28 | 29 | ##### Blocked 30 | 31 | * [(PUP-5609)](https://tickets.puppetlabs.com/browse/PUP-5609) [Protect shared state with filesystem lock (PR #4584)](https://github.com/puppetlabs/puppet/pull/4584) 32 | - We need to pull this into a sprint so we can spend some time on it 33 | * [(PUP-4619)](https://tickets.puppetlabs.com/browse/PUP-4619) [sort fstab entries (PR #3953)](https://github.com/puppetlabs/puppet/pull/3953) 34 | - We need to devote some time to spend on this 35 | * [(PUP-4634)](https://tickets.puppetlabs.com/browse/PUP-4634) [Add timing metrics to report (PR #4042)](https://github.com/puppetlabs/puppet/pull/4042) 36 | - Ready for review 37 | - Blocked on our end, haven't had time to bring it into a sprint. 38 | - Would be good to spend a bit of time on our end planning out what we think this should look like. 39 | * [(PUP-598)](https://tickets.puppetlabs.com/browse/PUP-598) [Add gpasswd support to Group provider (PR #3687)](https://github.com/puppetlabs/puppet/pull/3687) 40 | - There is a related PR up for a fix with the same root cause as this one. 41 | - We want to fix both issues with the same PR. 42 | - Haven't had time to bring this into a sprint yet. 43 | * [(PUP-4760)](https://tickets.puppetlabs.com/browse/PUP-4760) [Service type should not retrieve ensure status when not needed (PR #4038)](https://github.com/puppetlabs/puppet/pull/4038) 44 | - Michael is going to spend some time with this post-direct puppet 45 | - Reviewed potential impact to API consumers. Seems like a reasonable improvement, and most consumers would probably behave like `puppet resource` and not see an issue 46 | - Waiting for contributor to retarget at master 47 | - We'll need to move this into a sprint once that happens so we can spend more time on it 48 | * [(PUP-5360)](https://tickets.puppetlabs.com/browse/PUP-5360) [Feature/autorelation defined types (PR #4337)](https://github.com/puppetlabs/puppet/pull/4337) 49 | - Branan to start discussion on JIRA ticket about whether we want this feature and how it should be modelled. 50 | 51 | ### Facter 52 | 53 | ##### Pull Requests 54 | 55 | ##### For discussion 56 | 57 | ##### Merged / Handed Off 58 | 59 | * [(FACT-1339)](https://tickets.puppetlabs.com/browse/FACT-1339) [Prevents OpenBSD swap warnings (#1266)](https://github.com/puppetlabs/facter/pull/1266) 60 | - Branan rebase and merge 61 | 62 | * [(FACT-1024)](https://tickets.puppetlabs.com/browse/FACT-1024) [Fix AWS EC2 Gzip userdata (PR #1272)](https://github.com/puppetlabs/facter/pull/1272) 63 | 64 | ##### Closed 65 | 66 | ##### Waiting for updates 67 | 68 | ##### Blocked 69 | 70 | ### Hiera 71 | 72 | ##### Pull Requests 73 | 74 | ##### For discussion 75 | 76 | ##### Merged / Handed Off 77 | 78 | ##### Closed 79 | 80 | ##### Waiting for updates 81 | 82 | ##### Blocked 83 | 84 | ## Actions 85 | -------------------------------------------------------------------------------- /core/notes/2015-01-21.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2015-01-21.md 2 | 3 | Recording: Missed that the button press didn't register, so no recording this week. 4 | 5 | ### Attending 6 | 7 | * **Michael Smith (MikaelSmith)** 8 | * **Preben Ingvaldsen (fpringvaldsen)** 9 | * **Josh Cooper (joshcooper)** 10 | * **Kylo Ginsberg (kylog)** 11 | * **Melissa (melissaanne)** 12 | * **Anderson Mills (andersonmills)** 13 | 14 | ### Summary 15 | 16 | During the previous week, we [closed 6 PRs](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+closed%3A%222015-01-14+..+2015-01-21%22++-label%3APL), of which [2 were merged](https://github.com/pulls?q=repo%3Apuppetlabs%2Fpuppet+repo%3Apuppetlabs%2Ffacter+repo%3Apuppetlabs%2Fhiera+is%3Apr+label%3ATriaged+merged%3A%222015-01-14+..+2015-01-21%22+-label%3APL); 3 others were updated and then pushed. 17 | 18 | At the start of the triage: 19 | 20 | * Puppet 21 | - [18 new](https://github.com/puppetlabs/puppet/pulls?q=is%3Apr+created%3A%222015-01-14+..+2015-01-21%22+-label%3APL) from community 22 | - 34 currently open, 17 from community 23 | * Facter 24 | - [0 new](https://github.com/puppetlabs/facter/pulls?q=is%3Apr+created%3A%222015-01-14+..+2015-01-21%22+-label%3APL) from community 25 | - 3 currently open, 2 from community 26 | * Hiera 27 | - [0 new](https://github.com/puppetlabs/hiera/pulls?q=is%3Apr+created%3A%222015-01-14+..+2015-01-21%22+-label%3APL) from community 28 | - 2 currently open, 0 from community 29 | 30 | View each individual pull request for detailed notes. 31 | 32 | ## New 33 | 34 | Tickets to triage: 35 | 36 | ### Puppet 37 | 38 | The following tickets were triaged: 39 | 40 | ### Puppet 41 | * PR #3500 42 | - **Action: Anderson to create ticket and merge.** 43 | * PUP-3706 44 | - **Action: Michael to fix and merge.** 45 | * PUP-3094: 46 | - Waiting on contributor. 47 | * PUP-3127 48 | - **Action: Michael test, fixup and merge.** 49 | * PUP-3166 50 | - Pinged contributor. 51 | - **Action: Michael & Melissa to fix and merge.** 52 | * PUP-3168 53 | - **Action: Michael & Anderson to fixup and merge.** 54 | * PUP-3678 55 | - Waiting on PMT team or contributor. 56 | * PUP-1103 57 | - **Action: Michael to add spec and merge.** 58 | * PUP-3332 59 | - **Action: Client team to review and comment.** 60 | * PUP-3341 61 | - Waiting on contributor. 62 | - **Action: Josh to review further.** 63 | * PUP-3319 64 | - **Action: Clean team to review impact of 2.1.5 retry.** 65 | * PUP-3793 66 | - **Action: Michael to review.** 67 | * PUP-1253 68 | - Pinged contributor. 69 | * PUP-3116 70 | - Waiting on contributor. 71 | 72 | ## Held Over 73 | 74 | ### Puppet 75 | * PUP-1072 76 | - Discussed some feedback with Felix. Waiting on update from Chris Price. 77 | * PUP-2916 78 | - No change. 79 | 80 | ## Closed 81 | 82 | ### Puppet 83 | * PUP-3082 84 | - Merged 85 | * PUP-3481: 86 | - Merged 87 | * PUP-3829 88 | - Merged 89 | * PUP-3011, PUP-3012, PUP-3014 90 | - Being addressed by QA. 91 | 92 | ### Facter 93 | * FACT-775 94 | - Closed to target at Facter 3. Discussion will continue on puppet-dev. 95 | 96 | ## Actions 97 | 98 | ### Michael Smith 99 | * Review 100 | - PUP-3706 101 | - PUP-3127 102 | - PUP-3166 103 | - PUP-1103 104 | - PUP-3793 105 | 106 | ### Michael Smith, Josh Cooper, Kylo Ginsberg 107 | * Review 108 | - PUP-3332 109 | - PUP-3319 110 | 111 | ### Josh Cooper 112 | * Review 113 | - PUP-3341 114 | 115 | ### Anderson Mills 116 | * Review 117 | - PUP-3168 118 | - PR 3500 create ticket and merge 119 | 120 | -------------------------------------------------------------------------------- /core/notes/2016-02-23.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2016-02-23 2 | 3 | ### Attending 4 | * **Hailee Kenney (HAIL9000)** 5 | * **Josh Cooper (joshcooper)** 6 | 7 | ## Overview 8 | 9 | ## Pull Requests 10 | 11 | ### Puppet 12 | 13 | ##### For discussion 14 | 15 | ##### For Review / Needs Work 16 | 17 | ##### Merged / Handed Off 18 | * [(PUP-5482)](https://tickets.puppetlabs.com/browse/PUP-5482) [Flag that a type could not be found (PR #4427)](https://github.com/puppetlabs/puppet/pull/4427) 19 | - Handed off to puppet server team 20 | * [(PUP-5616)](https://tickets.puppetlabs.com/browse/PUP-5615) [fixes to improve error display (PR #4507)](https://github.com/puppetlabs/puppet/pull/4507) 21 | - Handed off to QA team 22 | * [(PUP-5545)](https://tickets.puppetlabs.com/browse/PUP-5545) [Rubocop by default](https://github.com/puppetlabs/puppet/pull/4463) 23 | - Handed off to code management 24 | 25 | ##### Closed 26 | 27 | ##### Waiting for updates 28 | * [(PUP-5812)](https://tickets.puppetlabs.com/browse/PUP-5812) [Made the docstring for sshkey more accurate](https://github.com/puppetlabs/puppet/pull/4509) 29 | - Asking for a longer commit message 30 | 31 | ##### Blocked 32 | * [(PUP-5609)](https://tickets.puppetlabs.com/browse/PUP-5609) [Protect shared state with filesystem lock (PR #4584)](https://github.com/puppetlabs/puppet/pull/4584) 33 | - We need to pull this into a sprint so we can spend some time on it 34 | * [(PUP-4619)](https://tickets.puppetlabs.com/browse/PUP-4619) [sort fstab entries (PR #3953)](https://github.com/puppetlabs/puppet/pull/3953) 35 | - We need to devote some time to spend on this 36 | * [(PUP-4634)](https://tickets.puppetlabs.com/browse/PUP-4634) [Add timing metrics to report (PR #4042)](https://github.com/puppetlabs/puppet/pull/4042) 37 | - Ready for review 38 | - Blocked on our end, haven't had time to bring it into a sprint. 39 | - Would be good to spend a bit of time on our end planning out what we think this should look like. 40 | * [(PUP-598)](https://tickets.puppetlabs.com/browse/PUP-598) [Add gpasswd support to Group provider (PR #3687)](https://github.com/puppetlabs/puppet/pull/3687) 41 | - There is a related PR up for a fix with the same root cause as this one. 42 | - We want to fix both issues with the same PR. 43 | - Haven't had time to bring this into a sprint yet. 44 | 45 | ### Facter 46 | 47 | ##### Pull Requests 48 | 49 | ##### For discussion 50 | 51 | ##### Merged / Handed Off 52 | 53 | ##### Closed 54 | 55 | ##### Waiting for updates 56 | 57 | * [(FACT-1339)](https://tickets.puppetlabs.com/browse/FACT-1339) [Prevents OpenBSD swap warnings (#1266)](https://github.com/puppetlabs/facter/pull/1266) 58 | - Asked contributor if they need help rebasing/squashing their pull request 59 | 60 | ##### Blocked 61 | 62 | ### Hiera 63 | 64 | ##### Pull Requests 65 | 66 | ##### For discussion 67 | 68 | ##### Merged / Handed Off 69 | 70 | ##### Closed 71 | 72 | ##### Waiting for updates 73 | 74 | ##### Blocked 75 | 76 | ## Actions 77 | 78 | * Michael: [(PUP-4760)](https://tickets.puppetlabs.com/browse/PUP-4760) [Service type should not retrieve ensure status when not needed (PR #4038)](https://github.com/puppetlabs/puppet/pull/4038) 79 | - Michael is going to spend some time with this post-direct puppet 80 | - Reviewed potential impact to API consumers. Seems like a reasonable improvement, and most consumers would probably behave like `puppet resource` and not see an issue 81 | - Waiting for contributor to retarget at master 82 | - We'll need to move this into a sprint once that happens so we can spend more time on it 83 | 84 | * Branan to review (when we can pull into a sprint): [(PUP-5360)](https://tickets.puppetlabs.com/browse/PUP-5360) [Feature/autorelation defined types (PR #4337)](https://github.com/puppetlabs/puppet/pull/4337) 85 | -------------------------------------------------------------------------------- /modules/notes/2017-10-26.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2017-10-26 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * eputnam 7 | * HAIL9000 8 | * wyardley 9 | 10 | ### Discussion: 11 | - mongodb tickets transfer/removal/something 12 | - Hunter's wife had a baby! (yay) 13 | 14 | ## Reviews: 15 | ### mongodb on JIRA 16 | - https://tickets.puppetlabs.com/browse/MODULES-3749 migrated 17 | - https://tickets.puppetlabs.com/browse/MODULES-3633 closed 18 | - https://tickets.puppetlabs.com/browse/MODULES-534 closed, won't fix, PR possible 19 | - https://tickets.puppetlabs.com/browse/MODULES-936 closed 20 | - a few others, too! 21 | 22 | ## Past Reviews: 23 | 24 | ### puppetlabs-aparAU59: approved, waiting for further testing work 25 | 26 | ### puppet-rabbitmq 27 | - 529: commented 28 | - 556: commented 29 | - 547: commented, merged by accident and reverted. Needs to be resubmitted. 30 | - 598: merged 31 | 32 | ### puppetlabs-mongodb 33 | * 367: commented (points to 369) 34 | * 351: commented, hunner will fixup 35 | 36 | ### puppetlabs-rsync 37 | * 71: commented 38 | * 73: commented 39 | * 85: commented 40 | 41 | ### puppetlabs-mysql 42 | * 884: Needs more research behind impact of #813. 43 | * 904: Commented. "Hunner will fix." 44 | 45 | ### puppetlabs-postgresql 46 | * 805: commented, backwards incompatible 47 | * 775: See discussion on 2016-07-28, and following 48 | - The epic for tracking hashes-as-hiera-bindings is MODULES-3661 49 | - Profiles are generally user-specific and difficult to make abstract, which is why the module's API is generally non-prescriptive in the first place 50 | - How can we teach users to codify their infrastructure in a profile? What does a good profile look like? 51 | - It seems that explicit hiera_*() queries from profiles is better than parameters 52 | - queries can use previously returned answers 53 | - queries can be used in loops 54 | - queries can have different hiera queries, though this could also be viewed as a negative as it could easily make things more confusing 55 | - Would it be *so* bad to block users from this pattern, if they may need to use it as a stepping stone to reach the next level of "profile abstracting define declarations"? 56 | - Con: Progressing beyond this would require a large code and/or data refactor 57 | - Pro: Users new to puppet can write yaml more easily than requiring them to write profiles THEN write yaml 58 | - Alterate idea, create a ::profile::hiera that is a class with parameters of empty hashes to create resources 59 | * 822: needs investigation based on MODULES-4144 60 | * 831: needs lower bound of concat dependency to be >= 2.0.0 (when the force parameter was disabled) and then merge 61 | * 834: postgresql::server::recovery would have conflicts. Hunner to follow up with user 62 | 63 | 64 | ### voxpupuli-yum 65 | * 40: commented 66 | 67 | ### puppetlabs-aws 68 | * 394: commented 69 | * 378: commented 70 | * 312: commented 71 | * 300: commented 72 | 73 | ### puppet-nginx 74 | * #862: [discuss] 75 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 76 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 77 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 78 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 79 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 80 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 81 | * #902: use_default_location 82 | 83 | 84 | -------------------------------------------------------------------------------- /core/notes/2016-03-01.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2016-03-01 2 | 3 | ### Attending 4 | * **Hailee Kenney (HAIL9000)** 5 | * **Josh Cooper (joshcooper)** 6 | * **Branan Riley (branan)** 7 | * **Michael Smith (MikaelSmith)** 8 | 9 | ## Overview 10 | 11 | ## Pull Requests 12 | 13 | ### Puppet 14 | 15 | ##### For discussion 16 | 17 | ##### For Review / Needs Work 18 | 19 | ##### Merged / Handed Off 20 | 21 | * [(PUP-5812)](https://tickets.puppetlabs.com/browse/PUP-5812) [Made the docstring for sshkey more accurate](https://github.com/puppetlabs/puppet/pull/4509) 22 | - Merged 23 | 24 | ##### Closed 25 | 26 | ##### Waiting for updates 27 | 28 | * [(PUP-2802)](https://tickets.puppetlabs.com/browse/PUP-2802) [Add slot support for portage package provider (PR #4699)](https://github.com/puppetlabs/puppet/pull/4699) 29 | - Pinged a few people who have had past experience with this issue to see if they can weigh in 30 | 31 | ##### Blocked 32 | 33 | * [(PUP-5609)](https://tickets.puppetlabs.com/browse/PUP-5609) [Protect shared state with filesystem lock (PR #4584)](https://github.com/puppetlabs/puppet/pull/4584) 34 | - We need to pull this into a sprint so we can spend some time on it 35 | * [(PUP-4619)](https://tickets.puppetlabs.com/browse/PUP-4619) [sort fstab entries (PR #3953)](https://github.com/puppetlabs/puppet/pull/3953) 36 | - We need to devote some time to spend on this 37 | * [(PUP-4634)](https://tickets.puppetlabs.com/browse/PUP-4634) [Add timing metrics to report (PR #4042)](https://github.com/puppetlabs/puppet/pull/4042) 38 | - Ready for review 39 | - Blocked on our end, haven't had time to bring it into a sprint. 40 | - Would be good to spend a bit of time on our end planning out what we think this should look like. 41 | * [(PUP-598)](https://tickets.puppetlabs.com/browse/PUP-598) [Add gpasswd support to Group provider (PR #3687)](https://github.com/puppetlabs/puppet/pull/3687) 42 | - There is a related PR up for a fix with the same root cause as this one. 43 | - We want to fix both issues with the same PR. 44 | - Haven't had time to bring this into a sprint yet. 45 | * [(PUP-4760)](https://tickets.puppetlabs.com/browse/PUP-4760) [Service type should not retrieve ensure status when not needed (PR #4038)](https://github.com/puppetlabs/puppet/pull/4038) 46 | - Michael is going to spend some time with this post-direct puppet 47 | - Reviewed potential impact to API consumers. Seems like a reasonable improvement, and most consumers would probably behave like `puppet resource` and not see an issue 48 | - Waiting for contributor to retarget at master 49 | - We'll need to move this into a sprint once that happens so we can spend more time on it 50 | * [(PUP-5360)](https://tickets.puppetlabs.com/browse/PUP-5360) [Feature/autorelation defined types (PR #4337)](https://github.com/puppetlabs/puppet/pull/4337) 51 | - Branan was looking at this 52 | - Needs to be pulled into a sprint 53 | 54 | ### Facter 55 | 56 | ##### Pull Requests 57 | 58 | ##### For discussion 59 | 60 | ##### Merged / Handed Off 61 | 62 | ##### Closed 63 | 64 | ##### Waiting for updates 65 | 66 | * [(FACT-1339)](https://tickets.puppetlabs.com/browse/FACT-1339) [Prevents OpenBSD swap warnings (#1266)](https://github.com/puppetlabs/facter/pull/1266) 67 | - Asked contributor if they need help rebasing/squashing their pull request 68 | 69 | ##### Blocked 70 | 71 | ### Hiera 72 | 73 | ##### Pull Requests 74 | 75 | ##### For discussion 76 | 77 | ##### Merged / Handed Off 78 | 79 | ##### Closed 80 | 81 | ##### Waiting for updates 82 | 83 | ##### Blocked 84 | 85 | ## Actions 86 | 87 | * Michael: [(FACT-1024)](https://tickets.puppetlabs.com/browse/FACT-1024) [Fix AWS EC2 Gzip userdata (PR #1272)](https://github.com/puppetlabs/facter/pull/1272) 88 | - Spin up AWS instance and see if this may be an issue with an older ruby version 89 | 90 | -------------------------------------------------------------------------------- /modules/notes/2017-02-23.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2017-02-23 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * wmcc 8 | * HelenCampbell 9 | * Paula 10 | * glennsarti 11 | * tphoney 12 | * Guest1 13 | * ErickBanks 14 | 15 | ### Discussion: 16 | - rspec crash-course. Notes: 17 | 18 | # rspec command looks for spec/**/*_spec.rb 19 | RSpec.configure do |c| 20 | c.before :suite do 21 | end 22 | end 23 | 24 | # Pass 1: parsing pass 25 | # - load ruby files 26 | # - parse config 27 | # - create hash of describe/context/it to be run 28 | # Pass 2: run tests 29 | # - before :suite 30 | # - iterate through describe/contexts and run it's as it 31 | # occures 32 | 33 | it { expects(foo).to be_false } 34 | describe 'again' do 35 | before :all do 36 | #hi 37 | end 38 | after :each do 39 | #bye 40 | end 41 | context 'more' do 42 | let(:foo) { "hi" } 43 | before :each do 44 | # set up stuff 45 | end 46 | it "does stuff" do 47 | expect(double).to be_true 48 | end 49 | it { expect { foo }.to_fail } 50 | it { expect { bar }.to_fail } 51 | end 52 | it { allow(foo).to receive(:foo).and_return(:bar) } 53 | end 54 | 55 | 56 | 57 | ## Past Reviews: 58 | 59 | 60 | ## Past Reviews: 61 | ### puppetlabs-rabbitmq 62 | * 504: Big discussion on title_patterns and namevar 63 | * 497: see discussion 64 | * 493: see discussion; needs review 65 | * many, many more... 66 | 67 | ### voxpupuli-yum 68 | * 40: commented 69 | 70 | ### puppetlabs-aws 71 | * 394: commented 72 | * 378: commented 73 | * 312: commented 74 | * 300: commented 75 | 76 | ### puppetlabs-postgresql 77 | * 805: commented, backwards incompatible 78 | * 775: See discussion on 2016-07-28 79 | 80 | ### puppetlabs-lvm 81 | * 158: skipping for now; will take too long 82 | * 153: commented 83 | 84 | ### puppetlabs-xinetd 85 | * 81: Define service_hasstatus/hasrestart for Amazon Linux 86 | 87 | ### puppet-nginx 88 | * #862: [discuss] 89 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 90 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 91 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 92 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 93 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 94 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 95 | * #902: use_default_location 96 | 97 | ### puppetlabs-accounts 98 | * 51: pinged 99 | 100 | ### puppetlabs-mysql 101 | * 890: Needs more investigation. 102 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 103 | * 917: commented. 104 | * 912: commented and closed 105 | * 904 + 900 + 890: Hunner will fix. 106 | 107 | ### puppetlabs-firewall 108 | * 670: commented 109 | 110 | ### puppetlabs-apt 111 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 112 | 113 | ### puppetlabs-apache 114 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 115 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 116 | 117 | ### puppetlabs-mongodb 118 | * can we tag the latest merges? 119 | -------------------------------------------------------------------------------- /modules/notes/2018-03-08.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2018-03-08 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | Go to https://github.com/voxpupuli/community-triage/tree/master/modules/notes for notes from previous meetings. 5 | 6 | 7 | ## Participants: 8 | * eputnam 9 | * Hunner 10 | 11 | ### Discussion: 12 | * Discontinuation of module development/maintenance if a better one exists and what determines that. - dhollinger 13 | - prefer author ask for deprecation/removal 14 | - issue warning to author (unless it's painfully obvious): module seems to be out of regular maintenance 15 | - also need to take downloads into account. is anyone still using it? e.g. Hunner's wordpress module 16 | - deprecate/remove with no response 17 | 18 | - there are some limitations around being able to remove modules from the Forge: modules cannot actually be removed easily but only marked as deleted. even when they are marked, they can still be downloaded. 19 | 20 | 21 | 22 | * bastelfreak needs some releases removed from the forge 23 | 24 | * Data in modules and Hiera 5 25 | - some modules have been switching to data-in-modules scheme, which is good 26 | - however the most up-to-date metadata syntax (hiera.yaml and metadata.json) breaks Puppet 4.9 and earlier 27 | - it's possible to use data-in-modules with metadata that's compatible with both Puppet 5 and Puppet 4.9 28 | - so this raises a policy question of whether Puppet 4.9 is too old to support 29 | - see this PR for an example of compatible data-in-modules setup https://github.com/camptocamp/puppet-systemd/pull/73 30 | 31 | ## Reviews: 32 | 33 | 34 | ## Past Reviews: 35 | ### puppetlabs-stdlib 36 | * 875: merged 37 | 38 | ### puppetlabs-postgresql 39 | * 891: merged 40 | 41 | ### puppetlabs-concat 42 | * https://github.com/puppetlabs/puppetlabs-concat/pull/485/files merged 43 | 44 | ### puppetlabs-mysql 45 | * https://github.com/puppetlabs/puppetlabs-mysql/pull/1019 commented 46 | 47 | ### puppetlabs-apache 48 | * https://github.com/puppetlabs/puppetlabs-apache/pull/1717 closed 49 | 50 | ### puppetlabs-mysql 51 | * 1043: 5.2.0 release - merged 52 | 53 | ### puppetlabs-java_ks 54 | * 212: commented 55 | 56 | ### puppet-rabbitmq 57 | * 676: 58 | 59 | ### puppetlabs-postgresql 60 | * 917: commented (yuge!) 61 | 62 | ### puppetlabs-tomcat 63 | * 260: review in progress 64 | If it's possible can you review the puppet-archive dependancy? At the moment it's >1.0.0 <2.0.0. Last usable version is 1.3.0 and there's a version 2.2.0 out from november. 65 | 66 | ### puppetlabs-rsync 67 | * 78: closed - inactivity 68 | * 80: commented 69 | * 81: opened #110 to close 70 | 71 | ### puppetlabs-apache 72 | * 1659: again... looking good, comments from ekohl for a few helpful changes. 73 | 74 | 75 | 76 | ### puppet-rabbitmq 77 | - 529: commented 78 | - 556: commented 79 | - 547: commented, merged by accident and reverted. Needs to be resubmitted. 80 | - 598: merged 81 | 82 | 83 | 84 | ### voxpupuli-yum 85 | * 40: commented 86 | 87 | ### puppet-nginx 88 | * #862: [discuss] 89 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 90 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 91 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 92 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 93 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 94 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 95 | * #902: use_default_location 96 | 97 | 98 | -------------------------------------------------------------------------------- /modules/notes/2016-12-15.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-12-15 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * bmjen 8 | * eputnam 9 | * hail9000 10 | * HelenCampbell 11 | * ErickBanks 12 | 13 | ## Reviews 14 | 15 | ### puppetlabs-stdlib 16 | * 700: merged 17 | * 640: merged 18 | * 661: closed 19 | 20 | ### puppetlabs-mysql 21 | * 917: commented. 22 | * 915: merged 23 | * 913: merged 24 | * 912: commented and closed 25 | * 904: closed for inactivity 26 | * 904 + 900 + 890: Hunner will fix. 27 | 28 | 29 | ## Past Reviews 30 | 31 | ### puppetlabs-rabbitmq 32 | * #504: Big discussion on title_patterns and namevar 33 | * 497: see discussion 34 | * 493: see discussion; needs review 35 | 36 | ### puppetlabs-postgresql 37 | * 797: picked the remaining functionality into 820, added a little bit of cleanup 38 | * 792: commented 39 | * 810: commented 40 | * 805: commented, backwards incompatible 41 | * 797: from 796. Commented 42 | * 823: commented 43 | * 775: See discussion on 2016-07-28 44 | * 764: commented - test failures need to be looked at 45 | 46 | ### puppetlabs-lvm 47 | * https://github.com/puppetlabs/puppetlabs-lvm/pull/166 48 | * 158: skipping for now; will take too long 49 | * 153: commented 50 | 51 | ### puppetlabs-xinetd 52 | * 81: Define service_hasstatus/hasrestart for Amazon Linux 53 | * 81: commented 54 | 55 | ### puppet-nginx 56 | * 980: Still in progress (vhost -> server rename) 57 | * #862: [discuss] (see above) 58 | * #957: from 789 and 820?: should we rename this param? 59 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 60 | * #950: rework namespace: nginx::config should not inherit, instead it should bring base-class variables into the scope: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp and then document template-used variables: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp#L171-L175 . And tests should not test ::config/install/service directly, but should be applied on the base class. 61 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 62 | * #950: Merged; remaining work is to add nginx::service and nginx::package as per the BGTM (https://docs.puppet.com/guides/module_guides/bgtm.html) 63 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 64 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 65 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 66 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 67 | * #967: Should be ssl like #939 68 | * #902: use_default_location 69 | 70 | ### puppetlabs-accounts 71 | * 51: pinged 72 | 73 | ### puppetlabs-aws 74 | * 340: Filed QENG-4362 to be able to handle this 75 | 76 | ### puppetlabs-mysql 77 | * 890: Needs more investigation. 78 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 79 | 80 | ### puppetlabs-firewall 81 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 82 | 83 | ### puppetlabs-apt 84 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 85 | 86 | ### puppetlabs-apache 87 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 88 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 89 | * 1498: commented 90 | -------------------------------------------------------------------------------- /modules/notes/2016-12-01.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-12-01 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * tphoney 7 | * HAIL9000 8 | * wmcc 9 | * WilsonMcCaubry 10 | * dev_el_ops 11 | * helen 12 | * eputnam 13 | * Hunner 14 | * wby 15 | 16 | ## Discussion 17 | * #PuppetHack! Dec 13th in the Slack room (https://slack.puppet.com/) get together and hack on puppet code. There will be a raffle for participants. It is 12:00-00:00UTC 18 | 19 | ## Reviews 20 | ### puppetlabs-rabbitmq 21 | * #504: Big discussion on title_patterns and namevar 22 | 23 | ### puppet-nginx 24 | * 980: Still in progress (vhost -> server rename) 25 | 26 | ### puppetlabs-postgresql 27 | * 823: commented 28 | 29 | ## Past Reviews: 30 | ### puppetlabs-rabbitmq 31 | * 497: see discussion 32 | * 493: see discussion; needs review 33 | 34 | ### puppetlabs-postgresql 35 | * 797: picked the remaining functionality into 820, added a little bit of cleanup 36 | * 792: commented 37 | * 810: commented 38 | * 805: commented, backwards incompatible 39 | * 797: from 796. Commented 40 | 41 | ### puppetlabs-lvm 42 | * https://github.com/puppetlabs/puppetlabs-lvm/pull/166 43 | * 158: skipping for now; will take too long 44 | * 153: commented 45 | 46 | ### puppetlabs-xinetd 47 | * 81: Define service_hasstatus/hasrestart for Amazon Linux 48 | * 81: commented 49 | 50 | ### puppet-nginx 51 | * #862: [discuss] (see above) 52 | * #957: from 789 and 820?: should we rename this param? 53 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 54 | * #950: rework namespace: nginx::config should not inherit, instead it should bring base-class variables into the scope: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp and then document template-used variables: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp#L171-L175 . And tests should not test ::config/install/service directly, but should be applied on the base class. 55 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 56 | * #950: Merged; remaining work is to add nginx::service and nginx::package as per the BGTM (https://docs.puppet.com/guides/module_guides/bgtm.html) 57 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 58 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 59 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 60 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 61 | * #967: Should be ssl like #939 62 | * #902: use_default_location 63 | 64 | ### puppetlabs-accounts 65 | * 51: pinged 66 | 67 | ### puppetlabs-aws 68 | * 340: Filed QENG-4362 to be able to handle this 69 | 70 | ### puppetlabs-mysql 71 | * 890: Needs more investigation. 72 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 73 | 74 | ### puppetlabs-firewall 75 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 76 | 77 | ### puppetlabs-apt 78 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 79 | 80 | ### puppetlabs-postgresql 81 | * 775: See discussion on 2016-07-28 82 | * 764: commented - test failures need to be looked at 83 | 84 | ### puppetlabs-apache 85 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 86 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 87 | * 1498: commented 88 | 89 | 90 | -------------------------------------------------------------------------------- /modules/notes/2016-11-10.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-11-10 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * Kara 8 | * HAIL9000 9 | * dev_el_ops 10 | * HelenCampbell 11 | * wyardley (irc: wby) 12 | * wmcc 13 | * fraq 14 | * zleslie 15 | * karmix 16 | 17 | ## Discussion 18 | * VP has a kanban! https://github.com/voxpupuli/plumbing/projects/1 19 | * #PuppetHack! Dec 13th in the Slack room (https://slack.puppet.com/) get together and hack on puppet code. There will be a raffle for participants 20 | * US holiday on November 24th, so most likely no US participants. 21 | 22 | ## Reviews: 23 | ### puppetlabs-aws 24 | * #379: merged 25 | 26 | ### puppet-nginx 27 | * #950: Merged; remaining work is to add nginx::service and nginx::package as per the BGTM (https://docs.puppet.com/guides/module_guides/bgtm.html) 28 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 29 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 30 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 31 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 32 | * #932: vhost => server name change 33 | * vhost.pp, mailhost.pp, init.pp, and member.pp all have $server_* variables. Check for what these should be called before running the sed script. 34 | * david is working on it 35 | * #967: Should be ssl like #939 36 | * #902: use_default_location 37 | 38 | ### puppetlabs-rabbitmq 39 | * #504: maybe just switch to multi namevars but not try to maintain backwards compatibility? 40 | 41 | ### puppetlabs-xinetd 42 | * 81: Define service_hasstatus/hasrestart for Amazon Linux 43 | 44 | ## Past Reviews 45 | ### puppet-nginx 46 | * #862: [discuss] (see above) 47 | * #957: from 789 and 820?: should we rename this param? 48 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 49 | * #950: rework namespace: nginx::config should not inherit, instead it should bring base-class variables into the scope: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp and then document template-used variables: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp#L171-L175 . And tests should not test ::config/install/service directly, but should be applied on the base class. 50 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 51 | 52 | ### puppetlabs-accounts 53 | * 51: pinged 54 | 55 | ### puppetlabs-aws 56 | * 340: Filed QENG-4362 to be able to handle this 57 | 58 | ### puppetlabs-mysql 59 | * 890: Needs more investigation. 60 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 61 | 62 | ### puppetlabs-firewall 63 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 64 | 65 | ### puppetlabs-apt 66 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 67 | 68 | ### puppetlabs-rabbitmq 69 | * 497: see discussion 70 | * 493: see discussion; needs review 71 | 72 | ### puppetlabs-lvm 73 | * 158: skipping for now; will take too long 74 | * 153: commented 75 | 76 | ### puppetlabs-postgresql 77 | * 775: See discussion on 2016-07-28 78 | * 764: commented - test failures need to be looked at 79 | 80 | ### puppetlabs-apache 81 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 82 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 83 | * 1498: commented 84 | -------------------------------------------------------------------------------- /core/notes/2015-09-08.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2015-09-01 2 | 3 | Recording: https://www.youtube.com/watch?v=WHMtFF2XeUA 4 | 5 | ### Attending 6 | 7 | * **Josh (joshcooper)** 8 | * **Kylo (kylog)** 9 | * **Branan (branan)** 10 | 11 | ## Pull Requests 12 | 13 | ### Puppet 14 | 15 | ##### For discussion 16 | 17 | 18 | ##### Merged 19 | 20 | ##### Waiting for updates 21 | 22 | * [(PUP-4673)](https://tickets.puppetlabs.com/browse/PUP-4673) [Use proxy when fetching latest for pip packages (PR #3984)](https://github.com/puppetlabs/puppet/pull/3984) 23 | - Pinged nibalizer that we could take this over 24 | * [(PUP-1072)](https://tickets.puppetlabs.com/browse/PUP-1072) [HTTP(S) support for the file type (PR #3748)](https://github.com/puppetlabs/puppet/pull/3748) 25 | - Waiting for Felix to finish updating test coverage. We will take a look at doing the spec test work - it seems pretty close. 26 | 27 | ##### Blocked 28 | 29 | * [(PUP-3116)](https://tickets.puppetlabs.com/browse/PUP-3116) [Optimize the read of system mounts (PR #3043)](https://github.com/puppetlabs/puppet/pull/3043) 30 | - Blocked on someone having time to work on it 31 | - trevor-vaughan is still interested in working on it if he finds the time 32 | 33 | ### Facter 34 | 35 | ##### For discussion 36 | 37 | ##### Merged 38 | 39 | ##### Waiting for updates 40 | 41 | * (MAINT) [cache output of df (PR #1119)](https://github.com/puppetlabs/facter/pull/1119) 42 | - Peter H commented. Waiting on Jasper for response 43 | - PUP ticket needed to take advantage of this: https://tickets.puppetlabs.com/browse/PUP-5125 44 | 45 | ##### Blocked 46 | 47 | ### Hiera 48 | 49 | ##### For discussion 50 | 51 | ##### Waiting for updates 52 | 53 | ##### Blocked 54 | 55 | ## Actions 56 | 57 | Kylo 58 | 59 | * [(PUP-4634)](https://tickets.puppetlabs.com/browse/PUP-4634) [Add agent timing to report (PR #4042)](https://github.com/puppetlabs/puppet/pull/4042) 60 | - Contributor updated based on Josh C comments. Take another pass. 61 | * [Load systemd services from list-units (PR #4092)](https://github.com/puppetlabs/puppet/pull/4092) 62 | - Sort out the two pull requests 63 | - Take a look at failing tests in Travis? 64 | * [(PUP-4997)](https://tickets.puppetlabs.com/browse/PUP-4997) [Fix pip provider for EL6 (PR #4127)](https://github.com/puppetlabs/puppet/pull/4127) 65 | - Looks good to Kylo. Pinged Spencer for additional pip-aware eyes on the fix. 66 | * [(PUP-4619)](https://tickets.puppetlabs.com/browse/PUP-4619) [sort fstab entries (PR #3953)](https://github.com/puppetlabs/puppet/pull/3953) 67 | - Make sure this ticket makes it into a future sprint 68 | * [Updates for rspec 3(PR #288)](https://github.com/puppetlabs/hiera/pull/288) 69 | - Kylo to look at cleaning this up 70 | 71 | Branan 72 | 73 | * [(PUP-598)](https://tickets.puppetlabs.com/browse/PUP-598) [Add gpassword to group provider (PR #3687)](https://github.com/puppetlabs/puppet/pull/3687) 74 | - Work planned in PUP-3774 75 | * [(HI-184)](https://tickets.puppetlabs.com/browse/HI-184) [Inconsistent handling of fully-qualified facts when called from the command line (PR #283)](https://github.com/puppetlabs/hiera/pull/283) 76 | - Talk to Hailee about what needs to happen here 77 | * [Some AIX user attributes should be uppercase (PR #4059)](https://github.com/puppetlabs/puppet/pull/4059) 78 | - Pull into a future sprint so that we can validate on AIX 79 | * [Add clear_paths feature and parameter for package provider](https://github.com/puppetlabs/puppet/pull/4220) 80 | - Figure out what's up with the underlying bug 81 | 82 | Peter H 83 | * (MAINT) [cache output of df (PR #1119)](https://github.com/puppetlabs/facter/pull/1119) 84 | - Examine facter.reset/facter.clear to sort out facter cache clearing from puppet 85 | 86 | Josh C 87 | * [(PUP-5192)](https://tickets.puppetlabs.com/browse/PUP-5192) [Do not assume that an event is a hash in resource/status.rb (PR #4214)](https://github.com/puppetlabs/puppet/pull/4214) 88 | - Figure out why/how status and metric isn't broken the same way as event 89 | -------------------------------------------------------------------------------- /modules/notes/2016-12-08.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-12-08 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * bmjen 8 | * ErickBanks 9 | * sean 10 | * eputnam 11 | 12 | ## Discussion 13 | * #PuppetHack! Dec 13th in the Slack room (https://slack.puppet.com/) get together and hack on puppet code. There will be a raffle for participants. It is 12:00-00:00UTC 14 | * puppet 3 is EOL on Jan 1st 15 | 17:59 Hunner | !puppet3 16 | 17:59 TheVoxFox1337 | Puppet 3 is End of Life in 22 Days 17 | 18 | ## Reviews 19 | ### puppetlabs-stdlib 20 | * 700: Commented 21 | * 640: Rekicked and merge if green 22 | * 661: Commented 23 | 24 | 25 | ## Past Reviews: 26 | ### puppetlabs-rabbitmq 27 | * #504: Big discussion on title_patterns and namevar 28 | * 497: see discussion 29 | * 493: see discussion; needs review 30 | 31 | ### puppetlabs-postgresql 32 | * 797: picked the remaining functionality into 820, added a little bit of cleanup 33 | * 792: commented 34 | * 810: commented 35 | * 805: commented, backwards incompatible 36 | * 797: from 796. Commented 37 | * 823: commented 38 | * 775: See discussion on 2016-07-28 39 | * 764: commented - test failures need to be looked at 40 | 41 | ### puppetlabs-lvm 42 | * https://github.com/puppetlabs/puppetlabs-lvm/pull/166 43 | * 158: skipping for now; will take too long 44 | * 153: commented 45 | 46 | ### puppetlabs-xinetd 47 | * 81: Define service_hasstatus/hasrestart for Amazon Linux 48 | * 81: commented 49 | 50 | ### puppet-nginx 51 | * 980: Still in progress (vhost -> server rename) 52 | * #862: [discuss] (see above) 53 | * #957: from 789 and 820?: should we rename this param? 54 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 55 | * #950: rework namespace: nginx::config should not inherit, instead it should bring base-class variables into the scope: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp and then document template-used variables: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp#L171-L175 . And tests should not test ::config/install/service directly, but should be applied on the base class. 56 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 57 | * #950: Merged; remaining work is to add nginx::service and nginx::package as per the BGTM (https://docs.puppet.com/guides/module_guides/bgtm.html) 58 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 59 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 60 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 61 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 62 | * #967: Should be ssl like #939 63 | * #902: use_default_location 64 | 65 | ### puppetlabs-accounts 66 | * 51: pinged 67 | 68 | ### puppetlabs-aws 69 | * 340: Filed QENG-4362 to be able to handle this 70 | 71 | ### puppetlabs-mysql 72 | * 890: Needs more investigation. 73 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 74 | 75 | ### puppetlabs-firewall 76 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 77 | 78 | ### puppetlabs-apt 79 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 80 | 81 | ### puppetlabs-apache 82 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 83 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 84 | * 1498: commented 85 | 86 | -------------------------------------------------------------------------------- /modules/notes/2016-11-17.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2016-11-17 2 | 3 | https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * HAIL9000 8 | * wmcc 9 | * WilsonMcCaubry 10 | * wby 11 | 12 | ## Discussion 13 | * #PuppetHack! Dec 13th in the Slack room (https://slack.puppet.com/) get together and hack on puppet code. There will be a raffle for participants 14 | * US holiday on November 24th, so most likely no US participants. 15 | 16 | 17 | ## Reviews: 18 | ### puppetlabs-postgresql 19 | * 816: merged 20 | * 813: merged 21 | * 812: merged in #815 22 | * 810: commented 23 | * 808: picked as #817 24 | * 805: commented, backwards incompatible 25 | * 798: merged 26 | * 797: from 796. Commented 27 | 28 | ### puppet-nginx 29 | * #932: vhost => server name change 30 | * vhost.pp, mailhost.pp, init.pp, and member.pp all have $server_* variables. Check for what these should be called before running the sed script. 31 | * david is working on it -> #968 32 | * 968 needs rebase (November 17th) 33 | 34 | 35 | ## Past Reviews: 36 | ### puppetlabs-xinetd 37 | * 81: Define service_hasstatus/hasrestart for Amazon Linux 38 | 39 | ### puppet-nginx 40 | * #862: [discuss] (see above) 41 | * #957: from 789 and 820?: should we rename this param? 42 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 43 | * #950: rework namespace: nginx::config should not inherit, instead it should bring base-class variables into the scope: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp and then document template-used variables: https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/config.pp#L171-L175 . And tests should not test ::config/install/service directly, but should be applied on the base class. 44 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 45 | * #950: Merged; remaining work is to add nginx::service and nginx::package as per the BGTM (https://docs.puppet.com/guides/module_guides/bgtm.html) 46 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 47 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 48 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 49 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 50 | * #967: Should be ssl like #939 51 | * #902: use_default_location 52 | 53 | ### puppetlabs-accounts 54 | * 51: pinged 55 | 56 | ### puppetlabs-aws 57 | * 340: Filed QENG-4362 to be able to handle this 58 | 59 | ### puppetlabs-mysql 60 | * 890: Needs more investigation. 61 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 62 | 63 | ### puppetlabs-firewall 64 | * 641: twitter request https://github.com/puppetlabs/puppetlabs-firewall/pull/641 commented 65 | 66 | ### puppetlabs-apt 67 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 68 | 69 | ### puppetlabs-rabbitmq 70 | * 497: see discussion 71 | * 493: see discussion; needs review 72 | * #504: maybe just switch to multi namevars but not try to maintain backwards compatibility? 73 | 74 | ### puppetlabs-lvm 75 | * 158: skipping for now; will take too long 76 | * 153: commented 77 | 78 | ### puppetlabs-postgresql 79 | * 775: See discussion on 2016-07-28 80 | * 764: commented - test failures need to be looked at 81 | 82 | ### puppetlabs-apache 83 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 84 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 85 | * 1498: commented 86 | -------------------------------------------------------------------------------- /modules/notes/2017-05-04.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2017-05-04 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * eputnam 8 | * rob 9 | * craiggomes 10 | * glennsarti 11 | 12 | ### Discussion: 13 | 14 | ## Reviews: 15 | ### puppetlabs-windows 16 | * 27: merged 17 | * 140: merged 18 | 19 | ### puppetlabs-chocolatey 20 | * MODULES-4678 / 76: merged 21 | 22 | ### puppetlabs-mongodb 23 | * started unsupported release process (create MODULES ticket, task -> Unsupported release template) 24 | 25 | ### puppetlabs-apache 26 | * 1434: merged 27 | 28 | ### puppetlabs-apt 29 | * 623: closed 30 | 31 | ### puppetlabs-firewall 32 | * 670: merged in 684 33 | 34 | ### puppetlabs-postgresql 35 | * 846: commented 36 | * 834: postgresql::server::recovery would have conflicts. Hunner to follow up with user 37 | 38 | ## Past Reviews: 39 | ### puppetlabs-apache 40 | * 1610: commented 41 | 42 | ### puppetlabs-rabbitmq (29 open PRs) 43 | * 533: commented 44 | 45 | ### puppetlabs-mongodb 46 | * 361: commented 47 | * 351: commented, hunner will fixup 48 | 49 | ### puppetlabs-concat 50 | * 428: Commented, put up 433 for first four commits. 51 | 52 | ### puppetlabs-mysql 53 | * 866: closed due to inactivity 54 | * 884: Needs more research behind impact of #813. 55 | * 904: Commented. "Hunner will fix." 56 | * 920: running ad hoc jenkins 57 | * 925: commented - syntax error 58 | 59 | ### puppetlabs-postgresql 60 | * 805: commented, backwards incompatible 61 | * 775: See discussion on 2016-07-28, and following 62 | - The epic for tracking hashes-as-hiera-bindings is MODULES-3661 63 | - Profiles are generally user-specific and difficult to make abstract, which is why the module's API is generally non-prescriptive in the first place 64 | - How can we teach users to codify their infrastructure in a profile? What does a good profile look like? 65 | - It seems that explicit hiera_*() queries from profiles is better than parameters 66 | 67 | - queries can use previously returned answers 68 | 69 | - queries can be used in loops 70 | 71 | - queries can have different hiera queries, though this could also be viewed as a negative as it could easily make things more confusing 72 | 73 | - Would it be *so* bad to block users from this pattern, if they may need to use it as a stepping stone to reach the next level of "profile abstracting define declarations"? 74 | 75 | - Con: Progressing beyond this would require a large code and/or data refactor 76 | 77 | - Pro: Users new to puppet can write yaml more easily than requiring them to write profiles THEN write yaml 78 | 79 | - Alterate idea, create a ::profile::hiera that is a class with parameters of empty hashes to create resources 80 | * 822: needs investigation based on MODULES-4144 81 | * 831: needs lower bound of concat dependency to be >= 2.0.0 (when the force parameter was disabled) and then merge 82 | * 834 83 | 84 | 85 | 86 | ### puppetlabs-rabbitmq 87 | * 504: Big discussion on title_patterns and namevar 88 | * 497: see discussion 89 | * 493: see discussion; needs review 90 | * many, many more... 91 | 92 | ### voxpupuli-yum 93 | * 40: commented 94 | 95 | ### puppetlabs-aws 96 | * 394: commented 97 | * 378: commented 98 | * 312: commented 99 | * 300: commented 100 | 101 | ### puppet-nginx 102 | * #862: [discuss] 103 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 104 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 105 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 106 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 107 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 108 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 109 | * #902: use_default_location 110 | 111 | 112 | 113 | -------------------------------------------------------------------------------- /modules/notes/2017-05-11.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2017-05-11 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * Hunner 7 | * ErickBanks 8 | * craiggomes 9 | * eputnam 10 | * dhollinger 11 | 12 | ### Discussion: 13 | * puppetlabs-rsync review requested in MODULES-4886 14 | 15 | ## Reviews: 16 | ### puppetlabs-firewall 17 | * 699: commented 18 | 19 | ### puppetlabs-rsync 20 | * 84: merged 21 | * 68: closed 22 | * 69: merged 23 | * 78: commented 24 | * 76: merged 25 | * 83: commented 26 | * 71: commented 27 | * 73: commented 28 | * 85: commented 29 | * 86: commented 30 | 31 | ### puppetlabs-mongodb 32 | * 361: commented 33 | 34 | 35 | ## Past Reviews: 36 | ### puppetlabs-mongodb 37 | * started unsupported release process (create MODULES ticket, task -> Unsupported release template) 38 | 39 | ### puppetlabs-postgresql 40 | * 846: commented 41 | * 834: postgresql::server::recovery would have conflicts. Hunner to follow up with user 42 | 43 | ### puppetlabs-apache 44 | * 1610: commented 45 | 46 | ### puppetlabs-rabbitmq (29 open PRs) 47 | * 533: commented 48 | 49 | ### puppetlabs-mongodb 50 | * 361: commented 51 | * 351: commented, hunner will fixup 52 | 53 | ### puppetlabs-concat 54 | * 428: Commented, put up 433 for first four commits. 55 | 56 | ### puppetlabs-mysql 57 | * 866: closed due to inactivity 58 | * 884: Needs more research behind impact of #813. 59 | * 904: Commented. "Hunner will fix." 60 | * 920: running ad hoc jenkins 61 | * 925: commented - syntax error 62 | 63 | ### puppetlabs-postgresql 64 | * 805: commented, backwards incompatible 65 | * 775: See discussion on 2016-07-28, and following 66 | - The epic for tracking hashes-as-hiera-bindings is MODULES-3661 67 | - Profiles are generally user-specific and difficult to make abstract, which is why the module's API is generally non-prescriptive in the first place 68 | - How can we teach users to codify their infrastructure in a profile? What does a good profile look like? 69 | - It seems that explicit hiera_*() queries from profiles is better than parameters 70 | 71 | - queries can use previously returned answers 72 | 73 | - queries can be used in loops 74 | 75 | - queries can have different hiera queries, though this could also be viewed as a negative as it could easily make things more confusing 76 | 77 | - Would it be *so* bad to block users from this pattern, if they may need to use it as a stepping stone to reach the next level of "profile abstracting define declarations"? 78 | 79 | - Con: Progressing beyond this would require a large code and/or data refactor 80 | 81 | - Pro: Users new to puppet can write yaml more easily than requiring them to write profiles THEN write yaml 82 | 83 | - Alterate idea, create a ::profile::hiera that is a class with parameters of empty hashes to create resources 84 | * 822: needs investigation based on MODULES-4144 85 | * 831: needs lower bound of concat dependency to be >= 2.0.0 (when the force parameter was disabled) and then merge 86 | * 834 87 | 88 | 89 | 90 | ### puppetlabs-rabbitmq 91 | * 504: Big discussion on title_patterns and namevar 92 | * 497: see discussion 93 | * 493: see discussion; needs review 94 | * many, many more... 95 | 96 | ### voxpupuli-yum 97 | * 40: commented 98 | 99 | ### puppetlabs-aws 100 | * 394: commented 101 | * 378: commented 102 | * 312: commented 103 | * 300: commented 104 | 105 | ### puppet-nginx 106 | * #862: [discuss] 107 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 108 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 109 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 110 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 111 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 112 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 113 | * #902: use_default_location 114 | 115 | 116 | 117 | -------------------------------------------------------------------------------- /core/notes/2015-09-01.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2015-09-01 2 | 3 | Recording: https://www.youtube.com/watch?v=WHMtFF2XeUA 4 | 5 | ### Attending 6 | 7 | * **Josh (joshcooper)** 8 | * **Kylo (kylog)** 9 | * **Michael (MikaelSmith)** 10 | * **Peter (peterhuene)** 11 | 12 | ## Pull Requests 13 | 14 | ### Puppet 15 | 16 | ##### For discussion 17 | 18 | 19 | ##### Merged 20 | 21 | * [(PUP-5055)](https://tickets.puppetlabs.com/browse/PUP-5055) [parent attributes are set from metadata too early in static_compiler (PR #4184)](https://github.com/puppetlabs/puppet/pull/4184) 22 | * [(PUP-5097)](https://tickets.puppetlabs.com/browse/PUP-5097) [Hostname and Domain as trusted facts (PR #4198)](https://github.com/puppetlabs/puppet/pull/4198) 23 | 24 | ##### Waiting for updates 25 | 26 | * [(PUP-4673)](https://tickets.puppetlabs.com/browse/PUP-4673) [Use proxy when fetching latest for pip packages (PR #3984)](https://github.com/puppetlabs/puppet/pull/3984) 27 | - Branan commenting on the ticket about using internal methods so that we honor the puppet settings for http proxy. PMT code may be an example here. 28 | * [(PUP-3328)](https://tickets.puppetlabs.com/browse/PUP-3328) [tidy should follow symlinks (PR #4084)](https://github.com/puppetlabs/puppet/pull/4084) 29 | - Waiting for contributor to address some concerns/questions which Kylo commented on the ticket. Pinged again. 30 | * [(PUP-1072)](https://tickets.puppetlabs.com/browse/PUP-1072) [HTTP(S) support for the file type (PR #3748)](https://github.com/puppetlabs/puppet/pull/3748) 31 | - Waiting for Felix to finish updating test coverage. We will take a look at doing the spec test work - it seems pretty close. 32 | 33 | ##### Blocked 34 | 35 | * [(PUP-3116)](https://tickets.puppetlabs.com/browse/PUP-3116) [Optimize the read of system mounts (PR #3043)](https://github.com/puppetlabs/puppet/pull/3043) 36 | - Blocked on someone having time to work on it 37 | - trevor-vaughan is still interested in working on it if he finds the time 38 | 39 | ### Facter 40 | 41 | ##### For discussion 42 | 43 | ##### Merged 44 | 45 | ##### Waiting for updates 46 | 47 | * (MAINT) [cache output of df (PR #1119)](https://github.com/puppetlabs/facter/pull/1119) 48 | - Pointed to the solaris resolver as an example of caching 49 | - Jasper updated and Peter H to comment 50 | - PUP ticket needed to take advantage of this: https://tickets.puppetlabs.com/browse/PUP-5125 51 | 52 | ##### Blocked 53 | 54 | ### Hiera 55 | 56 | ##### For discussion 57 | 58 | ##### Waiting for updates 59 | 60 | * [(HI-184)](https://tickets.puppetlabs.com/browse/HI-184) [Inconsistent handling of fully-qualified facts when called from the command line (PR #283)](https://github.com/puppetlabs/hiera/pull/283) 61 | - R.I. pointed out another issues with the fix, waiting for updates from Rob 62 | * [Updates for rspec 3(PR #288)](https://github.com/puppetlabs/hiera/pull/288) 63 | 64 | ##### Blocked 65 | 66 | ## Actions 67 | 68 | Kylo 69 | 70 | * [(PUP-4634)](https://tickets.puppetlabs.com/browse/PUP-4634) [Add agent timing to report (PR #4042)](https://github.com/puppetlabs/puppet/pull/4042) 71 | - Contributor updated based on Josh C comments. Take another pass. 72 | * [Load systemd services from list-units (PR #4092)](https://github.com/puppetlabs/puppet/pull/4092) 73 | - Sort out the two pull requests 74 | - Take a look at failing tests in Travis? 75 | * [(PUP-4997)](https://tickets.puppetlabs.com/browse/PUP-4997) [Fix pip provider for EL6 (PR #4127)](https://github.com/puppetlabs/puppet/pull/4127) 76 | - Looks good to Kylo. Pinged Spencer for additional pip-aware eyes on the fix. 77 | * [(PUP-4619)](https://tickets.puppetlabs.com/browse/PUP-4619) [sort fstab entries (PR #3953)](https://github.com/puppetlabs/puppet/pull/3953) 78 | - Make sure this ticket makes it into a future sprint 79 | * [Some AIX user attributes should be uppercase (PR #4059)](https://github.com/puppetlabs/puppet/pull/4059) 80 | - Pull into a future sprint so that we can validate on AIX 81 | 82 | Branan 83 | 84 | * [(PUP-598)](https://tickets.puppetlabs.com/browse/PUP-598) [Add gpassword to group provider (PR #3687)](https://github.com/puppetlabs/puppet/pull/3687) 85 | - Work planned in PUP-3774 86 | 87 | Peter H 88 | * (MAINT) [cache output of df (PR #1119)](https://github.com/puppetlabs/facter/pull/1119) 89 | - Examine facter.reset/facter.clear to sort out facter cache clearing from puppet 90 | -------------------------------------------------------------------------------- /core/notes/2016-03-15.md: -------------------------------------------------------------------------------- 1 | # Puppet PR Triage Notes 2016-03-15 2 | 3 | ### Attending 4 | - Kylo 5 | - Haus 6 | - Branan 7 | - Peter 8 | 9 | ## Overview 10 | 11 | ## Pull Requests 12 | 13 | ### Puppet 14 | 15 | ##### For discussion 16 | 17 | ##### For Review / Needs Work 18 | 19 | ##### Merged / Handed Off 20 | 21 | * [(PUP-4545)](https://tickets.puppetlabs.com/browse/PUP-4545) [Too many restarts on interface changes (PR #4780)](https://github.com/puppetlabs/puppet/pull/4780) 22 | 23 | ##### Closed 24 | 25 | ##### Waiting for updates 26 | 27 | * [(PUP-6000)](https://tickets.puppetlabs.com/browse/PUP-6000) [Add only unique hooks during initialization (PR #4699)](https://github.com/puppetlabs/puppet/pull/4752) 28 | - Waiting for CLA to be signed by contributor 29 | 30 | * [(PUP-2802)](https://tickets.puppetlabs.com/browse/PUP-2802) [Add slot support for portage package provider (PR #4699)](https://github.com/puppetlabs/puppet/pull/4699) 31 | - Pinged a few people who have had past experience with this issue to see if they can weigh in 32 | 33 | * [(PUP-6048)](https://tickets.puppetlabs.com/browse/PUP-6048) [always create a basic default environment (PR #4788)](https://github.com/puppetlabs/puppet/pull/4788) 34 | - Kylo's following up with contributor about commit message and discussing need for fix 35 | 36 | * [(PUP-5825)](https://tickets.puppetlabs.com/browse/PUP-5825) [use systemctl is-enabled to determine service enable state (PR #4770)](https://github.com/puppetlabs/puppet/pull/4770) 37 | - Waiting on contributor and pinged whopper to see if he can help out testing the systemd change. 38 | 39 | ##### Blocked 40 | 41 | * [(PUP-5609)](https://tickets.puppetlabs.com/browse/PUP-5609) [Protect shared state with filesystem lock (PR #4584)](https://github.com/puppetlabs/puppet/pull/4584) 42 | - We need to pull this into a sprint so we can spend some time on it 43 | * [(PUP-4619)](https://tickets.puppetlabs.com/browse/PUP-4619) [sort fstab entries (PR #3953)](https://github.com/puppetlabs/puppet/pull/3953) 44 | - We need to devote some time to spend on this 45 | * [(PUP-4634)](https://tickets.puppetlabs.com/browse/PUP-4634) [Add timing metrics to report (PR #4042)](https://github.com/puppetlabs/puppet/pull/4042) 46 | - Ready for review 47 | - Blocked on our end, haven't had time to bring it into a sprint. 48 | - Would be good to spend a bit of time on our end planning out what we think this should look like. 49 | * [(PUP-598)](https://tickets.puppetlabs.com/browse/PUP-598) [Add gpasswd support to Group provider (PR #3687)](https://github.com/puppetlabs/puppet/pull/3687) 50 | - There is a related PR up for a fix with the same root cause as this one. 51 | - We want to fix both issues with the same PR. 52 | - Haven't had time to bring this into a sprint yet. 53 | * [(PUP-4760)](https://tickets.puppetlabs.com/browse/PUP-4760) [Service type should not retrieve ensure status when not needed (PR #4038)](https://github.com/puppetlabs/puppet/pull/4038) 54 | - Michael is going to spend some time with this post-direct puppet 55 | - Reviewed potential impact to API consumers. Seems like a reasonable improvement, and most consumers would probably behave like `puppet resource` and not see an issue 56 | - Waiting for contributor to retarget at master 57 | - We'll need to move this into a sprint once that happens so we can spend more time on it 58 | * [(PUP-5360)](https://tickets.puppetlabs.com/browse/PUP-5360) [Feature/autorelation defined types (PR #4337)](https://github.com/puppetlabs/puppet/pull/4337) 59 | - Branan to start discussion on JIRA ticket about whether we want this feature and how it should be modelled. 60 | 61 | ### Facter 62 | 63 | ##### Pull Requests 64 | 65 | ##### For discussion 66 | 67 | ##### Merged / Handed Off 68 | 69 | * [(FACT-1339)](https://tickets.puppetlabs.com/browse/FACT-1339) [Prevents OpenBSD swap warnings (#1287)](https://github.com/puppetlabs/facter/pull/1287) 70 | - Merged. 71 | 72 | ##### Closed 73 | 74 | * [(FACT-1339)](https://tickets.puppetlabs.com/browse/FACT-1339) [Prevents OpenBSD swap warnings (#1266)](https://github.com/puppetlabs/facter/pull/1266) 75 | - Closed in favor of a fixed up PR. 76 | 77 | ##### Waiting for updates 78 | 79 | ##### Blocked 80 | 81 | ### Hiera 82 | 83 | ##### Pull Requests 84 | 85 | ##### For discussion 86 | 87 | ##### Merged / Handed Off 88 | 89 | ##### Closed 90 | 91 | ##### Waiting for updates 92 | 93 | ##### Blocked 94 | 95 | ## Actions -------------------------------------------------------------------------------- /modules/notes/2017-03-23.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2017-03-23 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * eputnam 7 | * wmcc 8 | * HAIL9000 9 | * Paula 10 | * HelenCampbell 11 | * tphoney 12 | 13 | ### Discussion: 14 | * module development should be aware of PUP-6922 for autorequiring types instead of explicitly requiring them. 15 | 16 | ## Reviews: 17 | ### puppetlabs-concat 18 | * 428: Commented, put up 433 for first four commits. 19 | 20 | 21 | ## Past Reviews: 22 | ### puppetlabs-mysql 23 | * 866: closed due to inactivity 24 | * 884: Needs more research behind impact of #813. 25 | * 904: Commented. "Hunner will fix." 26 | * 920: running ad hoc jenkins 27 | * 925: commented - syntax error 28 | 29 | ### puppetlabs-postgresql 30 | * 805: commented, backwards incompatible 31 | * 775: See discussion on 2016-07-28, and following 32 | - The epic for tracking hashes-as-hiera-bindings is MODULES-3661 33 | - Profiles are generally user-specific and difficult to make abstract, which is why the module's API is generally non-prescriptive in the first place 34 | - How can we teach users to codify their infrastructure in a profile? What does a good profile look like? 35 | - It seems that explicit hiera_*() queries from profiles is better than parameters 36 | 37 | - queries can use previously returned answers 38 | 39 | - queries can be used in loops 40 | 41 | - queries can have different hiera queries, though this could also be viewed as a negative as it could easily make things more confusing 42 | 43 | - Would it be *so* bad to block users from this pattern, if they may need to use it as a stepping stone to reach the next level of "profile abstracting define declarations"? 44 | 45 | - Con: Progressing beyond this would require a large code and/or data refactor 46 | 47 | - Pro: Users new to puppet can write yaml more easily than requiring them to write profiles THEN write yaml 48 | 49 | - Alterate idea, create a ::profile::hiera that is a class with parameters of empty hashes to create resources 50 | * 793: merged 51 | * 822: needs investigation based on MODULES-4144 52 | * 831: needs lower bound of concat dependency to be >= 2.0.0 (when the force parameter was disabled) and then merge 53 | * 833: merged 54 | * 834 55 | * 831 vs 843 56 | * 846 57 | 58 | 59 | ### puppetlabs-rabbitmq 60 | * 504: Big discussion on title_patterns and namevar 61 | * 497: see discussion 62 | * 493: see discussion; needs review 63 | * many, many more... 64 | 65 | ### voxpupuli-yum 66 | * 40: commented 67 | 68 | ### puppetlabs-aws 69 | * 394: commented 70 | * 378: commented 71 | * 312: commented 72 | * 300: commented 73 | 74 | ### puppetlabs-xinetd 75 | * 81: Define service_hasstatus/hasrestart for Amazon Linux 76 | 77 | ### puppet-nginx 78 | * #862: [discuss] 79 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 80 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 81 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 82 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 83 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 84 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 85 | * #902: use_default_location 86 | 87 | 88 | 89 | 90 | ### puppetlabs-firewall 91 | * 670: commented 92 | 93 | ### puppetlabs-apt 94 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 95 | 96 | ### puppetlabs-apache 97 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 98 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 99 | 100 | ### puppetlabs-mongodb 101 | * can we tag the latest merges? 102 | 103 | ### puppetlabs-lvm 104 | * 158: skipping for now; will take too long 105 | -------------------------------------------------------------------------------- /modules/notes/2017-03-09.md: -------------------------------------------------------------------------------- 1 | # Module PR Triage 2017-03-09 2 | 3 | Join us in video chat! https://bluejeans.com/280736660 4 | 5 | ## Participants: 6 | * eputnam 7 | * HAIL9000 8 | * HelenCampbell 9 | * wmcc 10 | * tphoney 11 | * pmcmaw 12 | 13 | ### Discussion: 14 | * Hailee's new keyboard is working out well. 15 | 16 | ## Reviews: 17 | ### puppetlabs-lvm 18 | * 158: skipping for now; will take too long 19 | * 153: closed - inactivity 20 | * 181: merged 21 | * 141: closed - inactivity 22 | * 143: merged 23 | 24 | ### puppetlabs-accounts 25 | * 51: closed - inactivity 26 | 27 | 28 | ## Past Reviews: 29 | ### puppetlabs-postgresql 30 | * 805: commented, backwards incompatible 31 | * 775: See discussion on 2016-07-28, and following 32 | - The epic for tracking hashes-as-hiera-bindings is MODULES-3661 33 | - Profiles are generally user-specific and difficult to make abstract, which is why the module's API is generally non-prescriptive in the first place 34 | - How can we teach users to codify their infrastructure in a profile? What does a good profile look like? 35 | - It seems that explicit hiera_*() queries from profiles is better than parameters 36 | 37 | - queries can use previously returned answers 38 | 39 | - queries can be used in loops 40 | 41 | - queries can have different hiera queries, though this could also be viewed as a negative as it could easily make things more confusing 42 | 43 | - Would it be *so* bad to block users from this pattern, if they may need to use it as a stepping stone to reach the next level of "profile abstracting define declarations"? 44 | 45 | - Con: Progressing beyond this would require a large code and/or data refactor 46 | 47 | - Pro: Users new to puppet can write yaml more easily than requiring them to write profiles THEN write yaml 48 | 49 | - Alterate idea, create a ::profile::hiera that is a class with parameters of empty hashes to create resources 50 | * 793: merged 51 | * 822: needs investigation based on MODULES-4144 52 | * 831: needs lower bound of concat dependency to be >= 2.0.0 (when the force parameter was disabled) and then merge 53 | * 833: merged 54 | * 834 55 | * 831 vs 843 56 | * 846 57 | 58 | 59 | ### puppetlabs-rabbitmq 60 | * 504: Big discussion on title_patterns and namevar 61 | * 497: see discussion 62 | * 493: see discussion; needs review 63 | * many, many more... 64 | 65 | ### voxpupuli-yum 66 | * 40: commented 67 | 68 | ### puppetlabs-aws 69 | * 394: commented 70 | * 378: commented 71 | * 312: commented 72 | * 300: commented 73 | 74 | ### puppetlabs-xinetd 75 | * 81: Define service_hasstatus/hasrestart for Amazon Linux 76 | 77 | ### puppet-nginx 78 | * #862: [discuss] 79 | * #929: GPG -- apt_key looks fine, so yumrepo in puppet core should be investigated 80 | * #941: puppet-strings: strings is nearing 1.0.0, file tickets at http://tickets.puppet.com/browse/PDOC 81 | * #938: changes to default package source on Linux, seeking input on whether to use upstream or distro packaging. 82 | * https://nginx.org/en/docs/install.html officially documents using upstream packaging and does not mention distro packaging 83 | * use manage_repo true/false or package_source? Only a single location to configure is best. Sounds like have manage_package => true/false, allow package_source => "nginx"/"nginx-mainline", and remove `manage_repo` 84 | * zleslie: one example is to have various package_name values, and if undef on a platform then skip the package resource 85 | * #902: use_default_location 86 | 87 | 88 | ### puppetlabs-mysql 89 | * 890: Needs more investigation. 90 | * 884: commented 23 days ago. No response. Needs more research behind impact of #813. 91 | * 917: commented. 92 | * 912: commented and closed 93 | * 904 + 900 + 890: Hunner will fix. 94 | 95 | ### puppetlabs-firewall 96 | * 670: commented 97 | 98 | ### puppetlabs-apt 99 | * 623: https://github.com/puppetlabs/puppetlabs-apt/pull/623 100 | 101 | ### puppetlabs-apache 102 | * 1434: low priority, because backwards incompatible and 1434 provides a knob to fix that 103 | * what to do with milestone'd backwards incompatible PRs? Apache defaults have changed while module defaults have stayed the same, but any major rewrite of the module will not be using PRs directly as it will be a full rewrite. Should we close the milestone ones? No, we are leaving them alone. 104 | 105 | ### puppetlabs-mongodb 106 | * can we tag the latest merges? 107 | --------------------------------------------------------------------------------